)]}'
{"tempest/api/volume/admin/test_volume_types.py":[{"author":{"_account_id":7179,"name":"Brad Pokorny","email":"brad_pokorny@symantec.com","username":"bpokorny"},"change_message_id":"89276daf4f37c26d59e938520b534462a5287a55","unresolved":false,"context_lines":[{"line_number":154,"context_line":"        self.assertEmpty(deleted_encryption_type)"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"class VolumeTypesV1TestV1Test(VolumeTypesV2Test):"},{"line_number":158,"context_line":"    _api_version \u003d 1"}],"source_content_type":"text/x-python","patch_set":3,"id":"baa201ad_c71659a7","line":157,"updated":"2014-10-10 18:45:39.000000000","message":"Looks like \"V1Test\" is repeated here.","commit_id":"36dc2c66ea9b4da8a155f913c2166760c6b8d530"},{"author":{"_account_id":1192,"name":"David Kranz","email":"dkranz@redhat.com","username":"david-kranz"},"change_message_id":"210dfedbf15d11043fcca1bdf0cb376d80180bd7","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    _interface \u003d \"json\""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    def _delete_volume(self, volume_id):"},{"line_number":28,"context_line":"        self.volume_client.delete_volume(volume_id)"},{"line_number":29,"context_line":"        self.volume_client.wait_for_resource_deletion(volume_id)"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    def _delete_volume_type(self, volume_type_id):"}],"source_content_type":"text/x-python","patch_set":7,"id":"9aa7fdbe_d868bd89","line":28,"updated":"2014-10-22 13:55:34.000000000","message":"This needs to be explained in the commit message, at a minimum. It looks like the difference here is that volume_client is taken from cls.os_adm and volumes_client is taken from cls.os. This is a naming disaster. Can you explain why this test does not fail without this change? Are there other tests that should also be changed?","commit_id":"5cb8b3856eca841c0aa87229e0b3b373d4159d55"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"858f1e350033894250283c749a593ccd33af5185","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    _interface \u003d \"json\""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    def _delete_volume(self, volume_id):"},{"line_number":28,"context_line":"        self.volume_client.delete_volume(volume_id)"},{"line_number":29,"context_line":"        self.volume_client.wait_for_resource_deletion(volume_id)"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    def _delete_volume_type(self, volume_type_id):"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a8c0949_160de790","line":28,"in_reply_to":"9aa7fdbe_69fda96e","updated":"2014-11-03 08:24:34.000000000","message":"Name disaster of volume client is fixed in this review: https://review.openstack.org/#/c/131693/","commit_id":"5cb8b3856eca841c0aa87229e0b3b373d4159d55"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"6eb5a0ac8854c2c79786d6b49da52772d13514ca","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    _interface \u003d \"json\""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    def _delete_volume(self, volume_id):"},{"line_number":28,"context_line":"        self.volume_client.delete_volume(volume_id)"},{"line_number":29,"context_line":"        self.volume_client.wait_for_resource_deletion(volume_id)"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    def _delete_volume_type(self, volume_type_id):"}],"source_content_type":"text/x-python","patch_set":7,"id":"9aa7fdbe_69fda96e","line":28,"in_reply_to":"9aa7fdbe_d868bd89","updated":"2014-10-29 06:11:23.000000000","message":"I will fix the naming disaster in another patch set. There are tests admin folder which requires admin volume client credentials to run and the volume client should be in modified in the other tests also.","commit_id":"5cb8b3856eca841c0aa87229e0b3b373d4159d55"}],"tempest/services/volume/v2/xml/admin/volume_types_client.py":[{"author":{"_account_id":7179,"name":"Brad Pokorny","email":"brad_pokorny@symantec.com","username":"bpokorny"},"change_message_id":"8886d722089b7a6037493eda57d1b2fa1b73c1bd","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2012 OpenStack Foundation"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":6,"id":"9aa7fdbe_74bc876d","line":1,"updated":"2014-10-20 15:21:46.000000000","message":"Copyright should be 2014.","commit_id":"08fd825b99444af8ceac089cc1136773ec1179b1"}],"tempest/services/volume/xml/admin/volume_types_client.py":[{"author":{"_account_id":7179,"name":"Brad Pokorny","email":"brad_pokorny@symantec.com","username":"bpokorny"},"change_message_id":"8886d722089b7a6037493eda57d1b2fa1b73c1bd","unresolved":false,"context_lines":[{"line_number":215,"context_line":"class VolumeTypesClientXML(BaseVolumeTypesClientXML):"},{"line_number":216,"context_line":"    \"\"\""},{"line_number":217,"context_line":"    Client class to send CRUD Volume Type API V1 requests to a Cinder endpoint"},{"line_number":218,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":6,"id":"9aa7fdbe_b4126f60","line":218,"updated":"2014-10-20 15:21:46.000000000","message":"Now that there\u0027s a v2 version of this class, would it make sense to set \u0027self.api_version \u003d \"v1\" \u0027 for this class?","commit_id":"08fd825b99444af8ceac089cc1136773ec1179b1"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"13062aa2eba37f1d5ce7a170315509931b89bd40","unresolved":false,"context_lines":[{"line_number":215,"context_line":"class VolumeTypesClientXML(BaseVolumeTypesClientXML):"},{"line_number":216,"context_line":"    \"\"\""},{"line_number":217,"context_line":"    Client class to send CRUD Volume Type API V1 requests to a Cinder endpoint"},{"line_number":218,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":6,"id":"9aa7fdbe_4ced25c3","line":218,"in_reply_to":"9aa7fdbe_b4126f60","updated":"2014-10-21 06:48:57.000000000","message":"Yes, Thanks for pointing out. :;)","commit_id":"08fd825b99444af8ceac089cc1136773ec1179b1"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"447166f4961555ca91a0b3df3066224ecf5dcfaf","unresolved":false,"context_lines":[{"line_number":217,"context_line":"    Client class to send CRUD Volume Type API V1 requests to a Cinder endpoint"},{"line_number":218,"context_line":"    \"\"\""},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"    _api_version \u003d 1"}],"source_content_type":"text/x-python","patch_set":12,"id":"5a890539_1dd87f52","line":220,"updated":"2014-11-13 02:48:52.000000000","message":"why we need _api_version ? for V1, rest_client  is going to use \u0027volume\u0027 endpoints as it is without any alteration.","commit_id":"1010d33cda3827598a5c8c9f5d1cf22f866d6f82"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"ce32cd950a97c8806cf02a5b4a51049d3f3b86e6","unresolved":false,"context_lines":[{"line_number":217,"context_line":"    Client class to send CRUD Volume Type API V1 requests to a Cinder endpoint"},{"line_number":218,"context_line":"    \"\"\""},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"    _api_version \u003d 1"}],"source_content_type":"text/x-python","patch_set":12,"id":"5a890539_1ebf95d1","line":220,"in_reply_to":"5a890539_1dd87f52","updated":"2014-11-13 07:03:17.000000000","message":"Fixing it , Thanks :)","commit_id":"1010d33cda3827598a5c8c9f5d1cf22f866d6f82"}]}