)]}'
{"tempest/cmd/cleanup.py":[{"author":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"change_message_id":"af87cbaedb6b61a887a1157bb7fcbb1769c8ee60","unresolved":false,"context_lines":[{"line_number":9,"context_line":"#"},{"line_number":10,"context_line":"# Unless required by applicable law or agreed to in writing, software"},{"line_number":11,"context_line":"# distributed under the License is distributed on an \"AS IS\" BASIS, WITHOUT"},{"line_number":12,"context_line":"# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.  See the"},{"line_number":13,"context_line":"# License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"# under the License."},{"line_number":15,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"5a890539_baa203ac","line":12,"updated":"2014-11-13 12:23:31.000000000","message":"This commit must not add a white space here.\n1. The other similar comments does not have double space.\n2. Unrelated change.","commit_id":"7bfedde6cdde35e474a4551cee96ca7052992fc3"}],"tempest/cmd/cleanup_service.py":[{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"c054b582a2ec3c14dc38031cad99dc495a4799b9","unresolved":false,"context_lines":[{"line_number":75,"context_line":"    if IS_NEUTRON:"},{"line_number":76,"context_line":"        CONF_PRIV_NETWORK \u003d _get_priv_net_id(CONF.compute.fixed_network_name,"},{"line_number":77,"context_line":"                                             CONF.identity.tenant_name)"},{"line_number":78,"context_line":"        CONF_NETWORKS \u003d [CONF_PUB_NETWORK, CONF_PRIV_NETWORK]"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"def _get_priv_net_id(prv_net_name, tenant_name):"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a890539_986a6aec","line":78,"updated":"2014-11-15 19:40:03.000000000","message":"if not \"IS_NEUTRON\" it\u0027ll be None, see below","commit_id":"0d0b67e2b92073e7ddb3724cb1b4c4040b8e6093"},{"author":{"_account_id":10644,"name":"David Paterson","email":"davpat2112@yahoo.com","username":"dpaterson"},"change_message_id":"e6f986cd5de50a5440c37d877bb51201567c7929","unresolved":false,"context_lines":[{"line_number":75,"context_line":"    if IS_NEUTRON:"},{"line_number":76,"context_line":"        CONF_PRIV_NETWORK \u003d _get_priv_net_id(CONF.compute.fixed_network_name,"},{"line_number":77,"context_line":"                                             CONF.identity.tenant_name)"},{"line_number":78,"context_line":"        CONF_NETWORKS \u003d [CONF_PUB_NETWORK, CONF_PRIV_NETWORK]"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"def _get_priv_net_id(prv_net_name, tenant_name):"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a890539_dd404509","line":78,"in_reply_to":"5a890539_986a6aec","updated":"2014-11-18 20:57:43.000000000","message":"That\u0027s fine because this variable is only used in network cleanup which is in turn only used when IS_NEUTRON is true.  Initializing CONF_NETWORKS to [] for safety\u0027s sake.","commit_id":"0d0b67e2b92073e7ddb3724cb1b4c4040b8e6093"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"c054b582a2ec3c14dc38031cad99dc495a4799b9","unresolved":false,"context_lines":[{"line_number":112,"context_line":"        for item in item_list:"},{"line_number":113,"context_line":"            if item[\u0027tenant_id\u0027] \u003d\u003d self.tenant_id:"},{"line_number":114,"context_line":"                filtered_list.append(item)"},{"line_number":115,"context_line":"        return filtered_list"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"    def list(self):"},{"line_number":118,"context_line":"        pass"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a890539_7865be1c","line":115,"updated":"2014-11-15 19:40:03.000000000","message":"why not comprehension?:\n\n  return [item for item in item_list if item[\u0027tenant_id\u0027] \u003d\u003d self.tenant_id]","commit_id":"0d0b67e2b92073e7ddb3724cb1b4c4040b8e6093"},{"author":{"_account_id":10644,"name":"David Paterson","email":"davpat2112@yahoo.com","username":"dpaterson"},"change_message_id":"e6f986cd5de50a5440c37d877bb51201567c7929","unresolved":false,"context_lines":[{"line_number":112,"context_line":"        for item in item_list:"},{"line_number":113,"context_line":"            if item[\u0027tenant_id\u0027] \u003d\u003d self.tenant_id:"},{"line_number":114,"context_line":"                filtered_list.append(item)"},{"line_number":115,"context_line":"        return filtered_list"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"    def list(self):"},{"line_number":118,"context_line":"        pass"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a890539_59bef6d5","line":115,"in_reply_to":"5a890539_7865be1c","updated":"2014-11-18 20:57:43.000000000","message":"Done","commit_id":"0d0b67e2b92073e7ddb3724cb1b4c4040b8e6093"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"c054b582a2ec3c14dc38031cad99dc495a4799b9","unresolved":false,"context_lines":[{"line_number":351,"context_line":""},{"line_number":352,"context_line":"    def _filter_by_conf_networks(self, item_list):"},{"line_number":353,"context_line":"        if (item_list is None"},{"line_number":354,"context_line":"                or len(item_list) \u003d\u003d 0"},{"line_number":355,"context_line":"                or \u0027network_id\u0027 not in item_list[0]):"},{"line_number":356,"context_line":"            return item_list"},{"line_number":357,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"5a890539_78977eec","line":354,"updated":"2014-11-15 19:40:03.000000000","message":"I think both of these conditions could be combined as \"if not item_list\"","commit_id":"0d0b67e2b92073e7ddb3724cb1b4c4040b8e6093"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"c054b582a2ec3c14dc38031cad99dc495a4799b9","unresolved":false,"context_lines":[{"line_number":352,"context_line":"    def _filter_by_conf_networks(self, item_list):"},{"line_number":353,"context_line":"        if (item_list is None"},{"line_number":354,"context_line":"                or len(item_list) \u003d\u003d 0"},{"line_number":355,"context_line":"                or \u0027network_id\u0027 not in item_list[0]):"},{"line_number":356,"context_line":"            return item_list"},{"line_number":357,"context_line":""},{"line_number":358,"context_line":"        filtered_list \u003d []"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a890539_389176f1","line":355,"updated":"2014-11-15 19:40:03.000000000","message":"Do you expect here lists of something not network related? Maybe it\u0027s better check all:\n\n  all((\u0027network_id\u0027 in i for i in item_list))\n\nAnd in general:\n\n  return item_list if not item_list or not all((\u0027network_id\u0027 in i for i in item_list))","commit_id":"0d0b67e2b92073e7ddb3724cb1b4c4040b8e6093"},{"author":{"_account_id":10644,"name":"David Paterson","email":"davpat2112@yahoo.com","username":"dpaterson"},"change_message_id":"e6f986cd5de50a5440c37d877bb51201567c7929","unresolved":false,"context_lines":[{"line_number":352,"context_line":"    def _filter_by_conf_networks(self, item_list):"},{"line_number":353,"context_line":"        if (item_list is None"},{"line_number":354,"context_line":"                or len(item_list) \u003d\u003d 0"},{"line_number":355,"context_line":"                or \u0027network_id\u0027 not in item_list[0]):"},{"line_number":356,"context_line":"            return item_list"},{"line_number":357,"context_line":""},{"line_number":358,"context_line":"        filtered_list \u003d []"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a890539_2773c6b5","line":355,"in_reply_to":"5a890539_389176f1","updated":"2014-11-18 20:57:43.000000000","message":"Done","commit_id":"0d0b67e2b92073e7ddb3724cb1b4c4040b8e6093"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"c054b582a2ec3c14dc38031cad99dc495a4799b9","unresolved":false,"context_lines":[{"line_number":357,"context_line":""},{"line_number":358,"context_line":"        filtered_list \u003d []"},{"line_number":359,"context_line":"        for item in item_list:"},{"line_number":360,"context_line":"            if item[\u0027network_id\u0027] not in CONF_NETWORKS:"},{"line_number":361,"context_line":"                filtered_list.append(item)"},{"line_number":362,"context_line":"        return filtered_list"},{"line_number":363,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"5a890539_58f72259","line":360,"updated":"2014-11-15 19:40:03.000000000","message":"CONF_NETWORKS is initialized as None, so if not \"IS_NEUTRON\" it\u0027ll raise \u0027NoneType\u0027 is not iterable. Wouldn\u0027t better to initialize it as [] in line 25?","commit_id":"0d0b67e2b92073e7ddb3724cb1b4c4040b8e6093"},{"author":{"_account_id":10644,"name":"David Paterson","email":"davpat2112@yahoo.com","username":"dpaterson"},"change_message_id":"e6f986cd5de50a5440c37d877bb51201567c7929","unresolved":false,"context_lines":[{"line_number":357,"context_line":""},{"line_number":358,"context_line":"        filtered_list \u003d []"},{"line_number":359,"context_line":"        for item in item_list:"},{"line_number":360,"context_line":"            if item[\u0027network_id\u0027] not in CONF_NETWORKS:"},{"line_number":361,"context_line":"                filtered_list.append(item)"},{"line_number":362,"context_line":"        return filtered_list"},{"line_number":363,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"5a890539_fd28a134","line":360,"in_reply_to":"5a890539_58f72259","updated":"2014-11-18 20:57:43.000000000","message":"This doesn\u0027t matter because this service is only called when IS_NEUTRON is true but initialized to [] for future safety.","commit_id":"0d0b67e2b92073e7ddb3724cb1b4c4040b8e6093"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"c054b582a2ec3c14dc38031cad99dc495a4799b9","unresolved":false,"context_lines":[{"line_number":358,"context_line":"        filtered_list \u003d []"},{"line_number":359,"context_line":"        for item in item_list:"},{"line_number":360,"context_line":"            if item[\u0027network_id\u0027] not in CONF_NETWORKS:"},{"line_number":361,"context_line":"                filtered_list.append(item)"},{"line_number":362,"context_line":"        return filtered_list"},{"line_number":363,"context_line":""},{"line_number":364,"context_line":"    def list(self):"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a890539_f8b1ae8f","line":361,"updated":"2014-11-15 19:40:03.000000000","message":"why not comprehension?\n\n  return [item for item in items_list if item[\u0027network_id\u0027] not in CONF_NETWORKS]","commit_id":"0d0b67e2b92073e7ddb3724cb1b4c4040b8e6093"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"4c8fad7404f1cf312015f2381058aa6240299c18","unresolved":false,"context_lines":[{"line_number":358,"context_line":"        filtered_list \u003d []"},{"line_number":359,"context_line":"        for item in item_list:"},{"line_number":360,"context_line":"            if item[\u0027network_id\u0027] not in CONF_NETWORKS:"},{"line_number":361,"context_line":"                filtered_list.append(item)"},{"line_number":362,"context_line":"        return filtered_list"},{"line_number":363,"context_line":""},{"line_number":364,"context_line":"    def list(self):"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a890539_bfedd627","line":361,"in_reply_to":"5a890539_d620f5b2","updated":"2014-11-19 18:16:58.000000000","message":"Agree, so it\u0027s completely unreadable,  you can split it to 2 lines or leave only 1 comprehension.","commit_id":"0d0b67e2b92073e7ddb3724cb1b4c4040b8e6093"},{"author":{"_account_id":10644,"name":"David Paterson","email":"davpat2112@yahoo.com","username":"dpaterson"},"change_message_id":"e6f986cd5de50a5440c37d877bb51201567c7929","unresolved":false,"context_lines":[{"line_number":358,"context_line":"        filtered_list \u003d []"},{"line_number":359,"context_line":"        for item in item_list:"},{"line_number":360,"context_line":"            if item[\u0027network_id\u0027] not in CONF_NETWORKS:"},{"line_number":361,"context_line":"                filtered_list.append(item)"},{"line_number":362,"context_line":"        return filtered_list"},{"line_number":363,"context_line":""},{"line_number":364,"context_line":"    def list(self):"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a890539_d620f5b2","line":361,"in_reply_to":"5a890539_f8b1ae8f","updated":"2014-11-18 20:57:43.000000000","message":"Using both of those changes what I\u0027d end up with is:\ndef _filter_by_conf_networks(self, item_list):\n        return item_list if not item_list or\n    not all((\u0027network_id\u0027 in i for i in item_list))\n    else [item for item in items_list if item[\u0027network_id\u0027]\n          not in CONF_NETWORKS]\n\nWhich is difficult to follow.  I will make it somewhere in the middle.","commit_id":"0d0b67e2b92073e7ddb3724cb1b4c4040b8e6093"}]}