)]}'
{"tox.ini":[{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"12d8e64f6c90c870d16bd8a1f060e9aef8d7e83c","unresolved":false,"context_lines":[{"line_number":91,"context_line":"[testenv:venv]"},{"line_number":92,"context_line":"sitepackages \u003d {[tempestenv]sitepackages}"},{"line_number":93,"context_line":"setenv \u003d {[tempestenv]setenv}"},{"line_number":94,"context_line":"deps \u003d {[tempestenv]deps}"},{"line_number":95,"context_line":"commands \u003d {posargs}"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"[testenv:docs]"}],"source_content_type":"text/x-properties","patch_set":2,"id":"baa201ad_584f1c34","line":94,"updated":"2014-10-16 13:26:02.000000000","message":"This is incorrect, the venv definition here is used for unit testing and other local testing of tempest, not running it.\n\nYou won\u0027t be able to land this change because it is used for the docs job in the gate, and by making venv a tempest job you\u0027re breaking the reqs for building the docs.\n\nIf you want to use a venv tox job with tempest I think the correct path would be to add another definition for testenv:tempest-venv and do what needs to be done there, but that shouldn\u0027t be needed. Because you could just pass your filter and concurrency args into the tenenv:all job and it should work the way you want. That is really the reason that job exists.","commit_id":"7857a22473136559198397c9425c73306bba1525"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"e7e13f87cb4765bc70f2c5d351c11702f592f95a","unresolved":false,"context_lines":[{"line_number":91,"context_line":"[testenv:venv]"},{"line_number":92,"context_line":"sitepackages \u003d {[tempestenv]sitepackages}"},{"line_number":93,"context_line":"setenv \u003d {[tempestenv]setenv}"},{"line_number":94,"context_line":"deps \u003d {[tempestenv]deps}"},{"line_number":95,"context_line":"commands \u003d {posargs}"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"[testenv:docs]"}],"source_content_type":"text/x-properties","patch_set":2,"id":"baa201ad_be1389ff","line":94,"in_reply_to":"baa201ad_2bbbe40f","updated":"2014-10-16 17:40:41.000000000","message":"Ok, will use \"all\" tox job. thanks.","commit_id":"7857a22473136559198397c9425c73306bba1525"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"a59a991e2f67d4da09b4fc67b6cd05aa2c57ed19","unresolved":false,"context_lines":[{"line_number":91,"context_line":"[testenv:venv]"},{"line_number":92,"context_line":"sitepackages \u003d {[tempestenv]sitepackages}"},{"line_number":93,"context_line":"setenv \u003d {[tempestenv]setenv}"},{"line_number":94,"context_line":"deps \u003d {[tempestenv]deps}"},{"line_number":95,"context_line":"commands \u003d {posargs}"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"[testenv:docs]"}],"source_content_type":"text/x-properties","patch_set":2,"id":"baa201ad_2bbbe40f","line":94,"in_reply_to":"baa201ad_38a7b851","updated":"2014-10-16 13:50:34.000000000","message":"Everything inherits from testenv because that\u0027s where both the common pieces (setup command, etc.) go and it also includes unit test specific pieces. It is a requirement for all jobs here, both tempest and not. By adding the 3 overloaded variables in the job definition is how you specify whether a job definition is intended to run tempest or not.\n\nUnfortunately, tox doesn\u0027t allow having 2 real base sections which would make this a bit clear. This is the best compromise it currently allows. the other alternative was a separate tox.ini which I feel would be far more confusing.","commit_id":"7857a22473136559198397c9425c73306bba1525"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"8f1ec81f031e9520599a0888401d44ec3c9b70f3","unresolved":false,"context_lines":[{"line_number":91,"context_line":"[testenv:venv]"},{"line_number":92,"context_line":"sitepackages \u003d {[tempestenv]sitepackages}"},{"line_number":93,"context_line":"setenv \u003d {[tempestenv]setenv}"},{"line_number":94,"context_line":"deps \u003d {[tempestenv]deps}"},{"line_number":95,"context_line":"commands \u003d {posargs}"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"[testenv:docs]"}],"source_content_type":"text/x-properties","patch_set":2,"id":"baa201ad_38a7b851","line":94,"in_reply_to":"baa201ad_584f1c34","updated":"2014-10-16 13:40:07.000000000","message":"Thanks for clarification. But it is really confusing, \"all\" is related to \"testenv\" too as well as \"venv\". And only one of them can be used for running tempest itself.\n\nIn that case we should not use \"all\" for tempest run too.","commit_id":"7857a22473136559198397c9425c73306bba1525"}]}