)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10090,"name":"Amit Ugol","email":"augol@redhat.com","username":"cmyster"},"change_message_id":"5c5d7e477026df2e59770ca7030892973a35e238","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"cinder multibackend - attach detach volume from an instance"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In this test each cinder backend volume attached to an instance and detached"},{"line_number":10,"context_line":"At the end of the test the instance deleted."},{"line_number":11,"context_line":"test steps :"},{"line_number":12,"context_line":"1. create shared instance"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9aa7fdbe_5beee623","line":9,"updated":"2014-10-19 08:22:46.000000000","message":"Please consider reviewing this text","commit_id":"908fd5831f48cd2ddccbbb145199bafd92569c0a"},{"author":{"_account_id":7227,"name":"Timur Nurlygayanov","email":"tnurlygayanov@mirantis.com","username":"tnurlygayanov"},"change_message_id":"5260bf8dbba53da84a8e87491d4b11430b5bf0b9","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Each cinder backend volume is attached and detached from shared"},{"line_number":10,"context_line":"instance."},{"line_number":11,"context_line":"At the end of the test the instance is deleted."},{"line_number":12,"context_line":"test steps :"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: Ic220c0e0c62efdeeb0b67c2cb7ab261e505f535e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"5a890539_ba35fa47","line":12,"updated":"2014-11-10 16:59:34.000000000","message":"looks like mistake with \u0027:\u0027 here.","commit_id":"7607998197ea78670dae0f499c0b9e7ee4483a10"}],"tempest/api/volume/admin/test_multi_backend.py":[{"author":{"_account_id":8576,"name":"Yair Fried","email":"yfried@redhat.com","username":"yfried"},"change_message_id":"897933261065d179697b523694fcdc5431948e6f","unresolved":false,"context_lines":[{"line_number":128,"context_line":"    @test.attr(type\u003d\u0027gate\u0027)"},{"line_number":129,"context_line":"    def test_backend_attach_detach_volume_to_instance(self):"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"        # This test creates a shared instance. each volume backend attached and"},{"line_number":132,"context_line":"        # detached from the instance. the instance deleted at the end of"},{"line_number":133,"context_line":"        # this test."},{"line_number":134,"context_line":"        srv_name \u003d data_utils.rand_name(\u0027-Instance-\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9aa7fdbe_9bf84ee7","line":131,"updated":"2014-10-19 08:27:00.000000000","message":"by convention, docstring should use \"\"\" instead of #","commit_id":"908fd5831f48cd2ddccbbb145199bafd92569c0a"},{"author":{"_account_id":10090,"name":"Amit Ugol","email":"augol@redhat.com","username":"cmyster"},"change_message_id":"5c5d7e477026df2e59770ca7030892973a35e238","unresolved":false,"context_lines":[{"line_number":130,"context_line":""},{"line_number":131,"context_line":"        # This test creates a shared instance. each volume backend attached and"},{"line_number":132,"context_line":"        # detached from the instance. the instance deleted at the end of"},{"line_number":133,"context_line":"        # this test."},{"line_number":134,"context_line":"        srv_name \u003d data_utils.rand_name(\u0027-Instance-\u0027)"},{"line_number":135,"context_line":"        resp, server \u003d self.servers_client.create_server(srv_name,"},{"line_number":136,"context_line":"                                                         self.image_ref,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9aa7fdbe_1b8d3e7c","line":133,"updated":"2014-10-19 08:22:46.000000000","message":"Please consider reviewing this text","commit_id":"908fd5831f48cd2ddccbbb145199bafd92569c0a"},{"author":{"_account_id":10090,"name":"Amit Ugol","email":"augol@redhat.com","username":"cmyster"},"change_message_id":"5c5d7e477026df2e59770ca7030892973a35e238","unresolved":false,"context_lines":[{"line_number":132,"context_line":"        # detached from the instance. the instance deleted at the end of"},{"line_number":133,"context_line":"        # this test."},{"line_number":134,"context_line":"        srv_name \u003d data_utils.rand_name(\u0027-Instance-\u0027)"},{"line_number":135,"context_line":"        resp, server \u003d self.servers_client.create_server(srv_name,"},{"line_number":136,"context_line":"                                                         self.image_ref,"},{"line_number":137,"context_line":"                                                         self.flavor_ref)"},{"line_number":138,"context_line":"        self.servers_client.wait_for_server_status(server[\u0027id\u0027], \u0027ACTIVE\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9aa7fdbe_db92d69e","line":135,"updated":"2014-10-19 08:22:46.000000000","message":"If you are not using resp, please consider renaming it \u0027_\u0027","commit_id":"908fd5831f48cd2ddccbbb145199bafd92569c0a"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"3d5bacd4f001a3a417a662f01bed11e698e95f4e","unresolved":false,"context_lines":[{"line_number":132,"context_line":"        Each volume is attached and detached from the instance"},{"line_number":133,"context_line":"        The instance is deleted at the end of test"},{"line_number":134,"context_line":"        \"\"\""},{"line_number":135,"context_line":"        srv_name \u003d data_utils.rand_name(\u0027-Instance-\u0027)"},{"line_number":136,"context_line":"        _, server \u003d self.servers_client.create_server(srv_name,"},{"line_number":137,"context_line":"                                                      self.image_ref,"},{"line_number":138,"context_line":"                                                      self.flavor_ref)"}],"source_content_type":"text/x-python","patch_set":5,"id":"9aa7fdbe_d635fbdb","line":135,"updated":"2014-10-22 08:11:27.000000000","message":"Useless leading and trailing \u0027-\u0027. Seee the definition of \u0027rand_name\u0027.","commit_id":"e3c87b57cd79dcbbcb4e545ea636589862151e2c"},{"author":{"_account_id":11075,"name":"Benny Kopilov","email":"bkopilov@redhat.com","username":"bkopilov"},"change_message_id":"de1482491af5b63a00ffca982b02574b5d8e8c66","unresolved":false,"context_lines":[{"line_number":132,"context_line":"        Each volume is attached and detached from the instance"},{"line_number":133,"context_line":"        The instance is deleted at the end of test"},{"line_number":134,"context_line":"        \"\"\""},{"line_number":135,"context_line":"        srv_name \u003d data_utils.rand_name(\u0027-Instance-\u0027)"},{"line_number":136,"context_line":"        _, server \u003d self.servers_client.create_server(srv_name,"},{"line_number":137,"context_line":"                                                      self.image_ref,"},{"line_number":138,"context_line":"                                                      self.flavor_ref)"}],"source_content_type":"text/x-python","patch_set":5,"id":"9aa7fdbe_f6559fc6","line":135,"in_reply_to":"9aa7fdbe_d635fbdb","updated":"2014-10-22 08:20:17.000000000","message":"sure , i will fix it \nThanks","commit_id":"e3c87b57cd79dcbbcb4e545ea636589862151e2c"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"3d5bacd4f001a3a417a662f01bed11e698e95f4e","unresolved":false,"context_lines":[{"line_number":140,"context_line":"        # attach and detach to the instance each volume backend created"},{"line_number":141,"context_line":"        for volume_id in self.volume_id_list_without_prefix\\"},{"line_number":142,"context_line":"                + self.volume_id_list_with_prefix:"},{"line_number":143,"context_line":"            mountpoint \u003d \u0027/dev/vdc\u0027"},{"line_number":144,"context_line":"            _, body \u003d self.volume_client.attach_volume(volume_id,"},{"line_number":145,"context_line":"                                                       server[\u0027id\u0027],"},{"line_number":146,"context_line":"                                                       mountpoint)"}],"source_content_type":"text/x-python","patch_set":5,"id":"9aa7fdbe_56782b8f","line":143,"updated":"2014-10-22 08:11:27.000000000","message":"You should not hardcode the mountpoint. I believe \u0027auto\u0027 is a valid value.","commit_id":"e3c87b57cd79dcbbcb4e545ea636589862151e2c"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"5e80cecac44aaa6d44b1796315272e5e4b144785","unresolved":false,"context_lines":[{"line_number":140,"context_line":"        # attach and detach to the instance each volume backend created"},{"line_number":141,"context_line":"        for volume_id in self.volume_id_list_without_prefix\\"},{"line_number":142,"context_line":"                + self.volume_id_list_with_prefix:"},{"line_number":143,"context_line":"            mountpoint \u003d \u0027/dev/vdc\u0027"},{"line_number":144,"context_line":"            _, body \u003d self.volume_client.attach_volume(volume_id,"},{"line_number":145,"context_line":"                                                       server[\u0027id\u0027],"},{"line_number":146,"context_line":"                                                       mountpoint)"}],"source_content_type":"text/x-python","patch_set":5,"id":"9aa7fdbe_519f55b4","line":143,"in_reply_to":"9aa7fdbe_56782b8f","updated":"2014-10-22 08:50:43.000000000","message":"@Benny, please use mountpoint\u003d\"AUTO\".","commit_id":"e3c87b57cd79dcbbcb4e545ea636589862151e2c"},{"author":{"_account_id":11075,"name":"Benny Kopilov","email":"bkopilov@redhat.com","username":"bkopilov"},"change_message_id":"de1482491af5b63a00ffca982b02574b5d8e8c66","unresolved":false,"context_lines":[{"line_number":140,"context_line":"        # attach and detach to the instance each volume backend created"},{"line_number":141,"context_line":"        for volume_id in self.volume_id_list_without_prefix\\"},{"line_number":142,"context_line":"                + self.volume_id_list_with_prefix:"},{"line_number":143,"context_line":"            mountpoint \u003d \u0027/dev/vdc\u0027"},{"line_number":144,"context_line":"            _, body \u003d self.volume_client.attach_volume(volume_id,"},{"line_number":145,"context_line":"                                                       server[\u0027id\u0027],"},{"line_number":146,"context_line":"                                                       mountpoint)"}],"source_content_type":"text/x-python","patch_set":5,"id":"9aa7fdbe_f603dfb5","line":143,"in_reply_to":"9aa7fdbe_56782b8f","updated":"2014-10-22 08:20:17.000000000","message":"I dont know if its valid , the instance run mount to this device .\nThere is a similar test in API with device name","commit_id":"e3c87b57cd79dcbbcb4e545ea636589862151e2c"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"9e61d0c7840a9a5d6157f08927ef393f9e60e976","unresolved":false,"context_lines":[{"line_number":140,"context_line":"        # attach and detach to the instance each volume backend created"},{"line_number":141,"context_line":"        for volume_id in self.volume_id_list_without_prefix\\"},{"line_number":142,"context_line":"                + self.volume_id_list_with_prefix:"},{"line_number":143,"context_line":"            mountpoint \u003d \u0027/dev/vdc\u0027"},{"line_number":144,"context_line":"            _, body \u003d self.volume_client.attach_volume(volume_id,"},{"line_number":145,"context_line":"                                                       server[\u0027id\u0027],"},{"line_number":146,"context_line":"                                                       mountpoint)"}],"source_content_type":"text/x-python","patch_set":5,"id":"9aa7fdbe_915b7d2d","line":143,"in_reply_to":"9aa7fdbe_f603dfb5","updated":"2014-10-22 08:48:55.000000000","message":"\"auto\" is a valid value.\n\nDevice name is ignored by KVM and \"/dev/vdc\" doesn\u0027t make sense to Xen so I think \"auto\" is the correct value.","commit_id":"e3c87b57cd79dcbbcb4e545ea636589862151e2c"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"3d5bacd4f001a3a417a662f01bed11e698e95f4e","unresolved":false,"context_lines":[{"line_number":149,"context_line":"            self.volume_client.wait_for_volume_status(volume_id, \u0027available\u0027)"},{"line_number":150,"context_line":"        # delete instance"},{"line_number":151,"context_line":"        self.servers_client.delete_server(server[\u0027id\u0027])"},{"line_number":152,"context_line":"        self.servers_client.wait_for_server_termination("},{"line_number":153,"context_line":"            server[\u0027id\u0027])"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"    def _test_backend_name_reporting_by_volume_id(self, volume_id):"}],"source_content_type":"text/x-python","patch_set":5,"id":"9aa7fdbe_766fefc5","line":152,"updated":"2014-10-22 08:11:27.000000000","message":"Why do you need to wait for server termination ?","commit_id":"e3c87b57cd79dcbbcb4e545ea636589862151e2c"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"9e61d0c7840a9a5d6157f08927ef393f9e60e976","unresolved":false,"context_lines":[{"line_number":149,"context_line":"            self.volume_client.wait_for_volume_status(volume_id, \u0027available\u0027)"},{"line_number":150,"context_line":"        # delete instance"},{"line_number":151,"context_line":"        self.servers_client.delete_server(server[\u0027id\u0027])"},{"line_number":152,"context_line":"        self.servers_client.wait_for_server_termination("},{"line_number":153,"context_line":"            server[\u0027id\u0027])"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"    def _test_backend_name_reporting_by_volume_id(self, volume_id):"}],"source_content_type":"text/x-python","patch_set":5,"id":"9aa7fdbe_91245db0","line":152,"in_reply_to":"9aa7fdbe_16686386","updated":"2014-10-22 08:48:55.000000000","message":"Being able to delete an instance after a successful detach is not specific to cinder multi_backend feature, so it should not be on this test, imo.\n\nMy point is : waiting where it\u0027s not necessary slows down the Gate.","commit_id":"e3c87b57cd79dcbbcb4e545ea636589862151e2c"},{"author":{"_account_id":11075,"name":"Benny Kopilov","email":"bkopilov@redhat.com","username":"bkopilov"},"change_message_id":"de1482491af5b63a00ffca982b02574b5d8e8c66","unresolved":false,"context_lines":[{"line_number":149,"context_line":"            self.volume_client.wait_for_volume_status(volume_id, \u0027available\u0027)"},{"line_number":150,"context_line":"        # delete instance"},{"line_number":151,"context_line":"        self.servers_client.delete_server(server[\u0027id\u0027])"},{"line_number":152,"context_line":"        self.servers_client.wait_for_server_termination("},{"line_number":153,"context_line":"            server[\u0027id\u0027])"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"    def _test_backend_name_reporting_by_volume_id(self, volume_id):"}],"source_content_type":"text/x-python","patch_set":5,"id":"9aa7fdbe_16686386","line":152,"in_reply_to":"9aa7fdbe_766fefc5","updated":"2014-10-22 08:20:17.000000000","message":"It is part of the test , to be able to delete the instance after detach .\nBenny","commit_id":"e3c87b57cd79dcbbcb4e545ea636589862151e2c"},{"author":{"_account_id":7227,"name":"Timur Nurlygayanov","email":"tnurlygayanov@mirantis.com","username":"tnurlygayanov"},"change_message_id":"5260bf8dbba53da84a8e87491d4b11430b5bf0b9","unresolved":false,"context_lines":[{"line_number":128,"context_line":"    @test.attr(type\u003d\u0027gate\u0027)"},{"line_number":129,"context_line":"    def test_backend_attach_detach_volume_to_instance(self):"},{"line_number":130,"context_line":"        \"\"\""},{"line_number":131,"context_line":"        The test creates a shared instance."},{"line_number":132,"context_line":"        Each volume is attached and detached from the instance"},{"line_number":133,"context_line":"        The instance is deleted at the end of test"},{"line_number":134,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":6,"id":"5a890539_5aefb6b0","line":131,"updated":"2014-11-10 16:59:34.000000000","message":"Let\u0027s fix docstring here.\n\nMore info:\nhttp://docs.openstack.org/developer/hacking/#docstrings","commit_id":"7607998197ea78670dae0f499c0b9e7ee4483a10"},{"author":{"_account_id":7227,"name":"Timur Nurlygayanov","email":"tnurlygayanov@mirantis.com","username":"tnurlygayanov"},"change_message_id":"d453e5f41dff5d6fe7b5d8c90fe32f138075985f","unresolved":false,"context_lines":[{"line_number":140,"context_line":"        # attach and detach to the instance each volume backend created"},{"line_number":141,"context_line":"        for volume_id in self.volume_id_list_without_prefix\\"},{"line_number":142,"context_line":"                + self.volume_id_list_with_prefix:"},{"line_number":143,"context_line":"            mountpoint \u003d \u0027AUTO\u0027"},{"line_number":144,"context_line":"            _, body \u003d self.volume_client.attach_volume(volume_id,"},{"line_number":145,"context_line":"                                                       server[\u0027id\u0027],"},{"line_number":146,"context_line":"                                                       mountpoint)"}],"source_content_type":"text/x-python","patch_set":7,"id":"5a890539_ce14c4f7","line":143,"updated":"2014-11-10 19:32:23.000000000","message":"do we really need this variable? in for loop? can we just use \u0027AUTO\u0027 instead of this variable?","commit_id":"fdab524c7d3acae39a83a4b343c1095dfc50ea65"},{"author":{"_account_id":11075,"name":"Benny Kopilov","email":"bkopilov@redhat.com","username":"bkopilov"},"change_message_id":"472b9c45daac7b78f1e16e329e81aa24c61efa16","unresolved":false,"context_lines":[{"line_number":140,"context_line":"        # attach and detach to the instance each volume backend created"},{"line_number":141,"context_line":"        for volume_id in self.volume_id_list_without_prefix\\"},{"line_number":142,"context_line":"                + self.volume_id_list_with_prefix:"},{"line_number":143,"context_line":"            mountpoint \u003d \u0027AUTO\u0027"},{"line_number":144,"context_line":"            _, body \u003d self.volume_client.attach_volume(volume_id,"},{"line_number":145,"context_line":"                                                       server[\u0027id\u0027],"},{"line_number":146,"context_line":"                                                       mountpoint)"}],"source_content_type":"text/x-python","patch_set":7,"id":"5a890539_80ad248b","line":143,"in_reply_to":"5a890539_ce14c4f7","updated":"2014-11-11 05:31:22.000000000","message":"I agree  ,\nfixing it .","commit_id":"fdab524c7d3acae39a83a4b343c1095dfc50ea65"},{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"66220bb82711fab1d4a74ccfc6d4c6316785c5ee","unresolved":false,"context_lines":[{"line_number":127,"context_line":""},{"line_number":128,"context_line":"    @test.attr(type\u003d\u0027gate\u0027)"},{"line_number":129,"context_line":"    def test_backend_attach_detach_volume_to_instance(self):"},{"line_number":130,"context_line":"        \"\"\"The test creates a shared instance."},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"        Each volume is attached and detached from the instance"},{"line_number":133,"context_line":"        The instance is deleted at the end of test"}],"source_content_type":"text/x-python","patch_set":8,"id":"5a890539_3297064a","line":130,"updated":"2014-11-13 21:41:48.000000000","message":"What\u0027s a \"shared instance\"?  Looks like it\u0027s just an Instance to me, am I missing something?","commit_id":"21875af879afea7b875df41d5803b29a00b197db"},{"author":{"_account_id":11075,"name":"Benny Kopilov","email":"bkopilov@redhat.com","username":"bkopilov"},"change_message_id":"727506e014f711dd8f2a2a35f53a79472a96c30e","unresolved":false,"context_lines":[{"line_number":127,"context_line":""},{"line_number":128,"context_line":"    @test.attr(type\u003d\u0027gate\u0027)"},{"line_number":129,"context_line":"    def test_backend_attach_detach_volume_to_instance(self):"},{"line_number":130,"context_line":"        \"\"\"The test creates a shared instance."},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"        Each volume is attached and detached from the instance"},{"line_number":133,"context_line":"        The instance is deleted at the end of test"}],"source_content_type":"text/x-python","patch_set":8,"id":"5a890539_769e6109","line":130,"in_reply_to":"5a890539_3297064a","updated":"2014-11-18 20:42:47.000000000","message":"yes you are right its an instance , we use this instance to attach /detach volumes .\nI will fix it .\nBenny","commit_id":"21875af879afea7b875df41d5803b29a00b197db"},{"author":{"_account_id":6890,"name":"Martin Pavlásek","email":"mpavlase@redhat.com","username":"mpavlase"},"change_message_id":"1caade02539511c9ece67fe99a89ae25594c1447","unresolved":false,"context_lines":[{"line_number":147,"context_line":"            _, body \u003d self.volume_client.detach_volume(volume_id)"},{"line_number":148,"context_line":"            self.volume_client.wait_for_volume_status(volume_id, \u0027available\u0027)"},{"line_number":149,"context_line":"        # delete instance"},{"line_number":150,"context_line":"        self.servers_client.delete_server(server[\u0027id\u0027])"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"    def _test_backend_name_reporting_by_volume_id(self, volume_id):"},{"line_number":153,"context_line":"        # this test checks if os-vol-attr:host is populated correctly after"}],"source_content_type":"text/x-python","patch_set":9,"id":"5a890539_17f02966","line":150,"updated":"2014-11-23 17:41:35.000000000","message":"I think would be better/cleaner to use cleanup method. It\u0027s usual to call it near by allocate/create resource.","commit_id":"80942a5d3bc4f5e9cdcf4db3590c8ef6c9769093"}]}