)]}'
{"tempest/common/rest_client.py":[{"author":{"_account_id":8576,"name":"Yair Fried","email":"yfried@redhat.com","username":"yfried"},"change_message_id":"11136a789fcc351092a28e7ab185304c2ed8f66d","unresolved":false,"context_lines":[{"line_number":66,"context_line":"    return wrapper"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"class ResponseBody(dict):"},{"line_number":70,"context_line":"    \"\"\""},{"line_number":71,"context_line":"    Class that wraps an http response and body into a single value."},{"line_number":72,"context_line":"    Callers that receive this object will normally use it as a dict but"}],"source_content_type":"text/x-python","patch_set":3,"id":"9aa7fdbe_1bed3ef0","line":69,"updated":"2014-10-29 08:48:58.000000000","message":"I\u0027ve posted my concern in the spec page, but I\u0027m adding it here also:\n\nI\u0027d rather we go for composition instead for inheriting dict, and blocking us from using methods like \"update\" properly down the road.\n\nFor example, consider scenario test were resources aren\u0027t only created but later updated and even wait for status change.\n\nhaving _data_dict as an object would allow us to choose which dict properties/methods we want to expose and which we don\u0027t.","commit_id":"248419b78798a3799057bfc561b0ac7240cb9561"},{"author":{"_account_id":8576,"name":"Yair Fried","email":"yfried@redhat.com","username":"yfried"},"change_message_id":"d99e083f3af546c2ece9d5bfa46082bb576c5abf","unresolved":false,"context_lines":[{"line_number":66,"context_line":"    return wrapper"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"class ResponseBody(dict):"},{"line_number":70,"context_line":"    \"\"\""},{"line_number":71,"context_line":"    Class that wraps an http response and body into a single value."},{"line_number":72,"context_line":"    Callers that receive this object will normally use it as a dict but"}],"source_content_type":"text/x-python","patch_set":3,"id":"9aa7fdbe_3b2a02e8","line":69,"in_reply_to":"9aa7fdbe_1bed3ef0","updated":"2014-10-29 08:50:23.000000000","message":"Alternatively, please add the reason to not do that do the docstring","commit_id":"248419b78798a3799057bfc561b0ac7240cb9561"},{"author":{"_account_id":7227,"name":"Timur Nurlygayanov","email":"tnurlygayanov@mirantis.com","username":"tnurlygayanov"},"change_message_id":"d1b778c81dae9fa38614495a418c708fc8e105c6","unresolved":false,"context_lines":[{"line_number":68,"context_line":""},{"line_number":69,"context_line":"class ResponseBody(dict):"},{"line_number":70,"context_line":"    \"\"\""},{"line_number":71,"context_line":"    Class that wraps an http response and body into a single value."},{"line_number":72,"context_line":"    Callers that receive this object will normally use it as a dict but"},{"line_number":73,"context_line":"    can extract the response if needed."},{"line_number":74,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":4,"id":"5a890539_e0643fe7","line":71,"updated":"2014-11-10 16:57:22.000000000","message":"Let\u0027s use common patterns for docstrings:\n\n\"\"\"Class that wraps an http response and body into a single value.\n\nCallers that receive this object will normally use it as a dict but\t\n\ncan extract the response if needed.\n\n\"\"\"\n\nMore info:\nhttp://docs.openstack.org/developer/hacking/#docstrings","commit_id":"ffc6a7a5923d6be3b34febd7908eda78ebf90ef8"},{"author":{"_account_id":7227,"name":"Timur Nurlygayanov","email":"tnurlygayanov@mirantis.com","username":"tnurlygayanov"},"change_message_id":"0d682c0f0d46e88f58df804d25b15524fedd7dda","unresolved":false,"context_lines":[{"line_number":15,"context_line":"#    under the License."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"import collections"},{"line_number":18,"context_line":"import functools"},{"line_number":19,"context_line":"import json"},{"line_number":20,"context_line":"import logging as real_logging"},{"line_number":21,"context_line":"import re"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a890539_0e924c57","line":18,"updated":"2014-11-10 19:40:03.000000000","message":"pep8 error:\n\nF401 \u0027functools\u0027 imported but unused","commit_id":"2ff2963b593a4523689a2f65e8b0c81a228d3e4d"},{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"cbcc05f73460d2d13bda52afc3358722d6de46b6","unresolved":false,"context_lines":[{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    def __str__(self):"},{"line_number":68,"context_line":"        body \u003d super.__str__(self)"},{"line_number":69,"context_line":"        return \"request: %s\\nBody: %s\" % (self.response, body)"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"class RestClient(object):"}],"source_content_type":"text/x-python","patch_set":7,"id":"5a890539_15df81d7","line":69,"updated":"2014-12-01 15:36:56.000000000","message":"This should be \"response: %s...\" instead.","commit_id":"70f137cbddd5335ba0c854518efcefd3c85af401"},{"author":{"_account_id":1192,"name":"David Kranz","email":"dkranz@redhat.com","username":"david-kranz"},"change_message_id":"1104151a09edd797348ac121cc092915992e8274","unresolved":false,"context_lines":[{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    def __str__(self):"},{"line_number":68,"context_line":"        body \u003d super.__str__(self)"},{"line_number":69,"context_line":"        return \"request: %s\\nBody: %s\" % (self.response, body)"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"class RestClient(object):"}],"source_content_type":"text/x-python","patch_set":7,"id":"5a890539_a61e810b","line":69,"in_reply_to":"5a890539_15df81d7","updated":"2014-12-01 16:34:43.000000000","message":"Oops, thanks. Fixed in https://review.openstack.org/138118","commit_id":"70f137cbddd5335ba0c854518efcefd3c85af401"}]}