)]}'
{"tempest/api/messaging/test_queues.py":[{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"8e9a4018cef439076808c65d54ca2a872775a7e8","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        self.addCleanup(self.client.delete_queue, queue_name)"},{"line_number":39,"context_line":"        # NOTE(gmann): create_queue returns response status code as 201"},{"line_number":40,"context_line":"        # so specifically checking the expected empty response body as"},{"line_number":41,"context_line":"        # this is not going to be checked in response_checker()."},{"line_number":42,"context_line":"        self.assertEqual(\u0027\u0027, body)"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"        self.delete_queue(queue_name)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9aa7fdbe_f0f630f8","line":41,"updated":"2014-10-24 19:00:54.000000000","message":"So not being familiar with marconi API this I really can\u0027t contradict this it just feels a bit odd to me. It is a bit different from the traditional openstack response which is a 200 for all synchronous creates. It\u0027s not wrong 201 is CREATED, but if I remember the HTTP spec correctly a 201 needs to come with the location and properties of the resources, which would imply a body, although I guess it could be done all with headers.(but then the resp object shouldn\u0027t be ignored) Also, how are we supposed to know any information about the queue that was created if the body is empty and there aren\u0027t any headers? I\u0027m assuming it has properties besides a name.\n\nThat being said it\u0027s also not like we could change it in marconi at this point so I guess it\u0027s fine even if a bit inconsistent from the other projects.","commit_id":"a2016377bc548ef0f1e25533cc6625b5539af229"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"754d005ecf065992b726945e198f612b796b5491","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        self.addCleanup(self.client.delete_queue, queue_name)"},{"line_number":39,"context_line":"        # NOTE(gmann): create_queue returns response status code as 201"},{"line_number":40,"context_line":"        # so specifically checking the expected empty response body as"},{"line_number":41,"context_line":"        # this is not going to be checked in response_checker()."},{"line_number":42,"context_line":"        self.assertEqual(\u0027\u0027, body)"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"        self.delete_queue(queue_name)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9aa7fdbe_ba8d55d5","line":41,"in_reply_to":"9aa7fdbe_f0f630f8","updated":"2014-10-27 01:55:26.000000000","message":"Same i had in my mind about empty resp body for 201. It should be consistent in openstack projects which can be discussed in API working group. I proposed some consistency about success code in API guidelines (https://review.openstack.org/#/c/130690/) and I will discuss this too so that at least for new API that can be consistent.","commit_id":"a2016377bc548ef0f1e25533cc6625b5539af229"}]}