)]}'
{"tempest/scenario/manager.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"ff61372d9e6e57ebb6c1da410977979830cde65a","unresolved":false,"context_lines":[{"line_number":1201,"context_line":"        if not CONF.service_available.heat:"},{"line_number":1202,"context_line":"            raise cls.skipException(\"Heat support is required\")"},{"line_number":1203,"context_line":"        super(OrchestrationScenarioTest, cls).resource_setup()"},{"line_number":1204,"context_line":"        cls.load_clients(manager\u003dcls.admin_manager)"},{"line_number":1205,"context_line":""},{"line_number":1206,"context_line":"    @classmethod"},{"line_number":1207,"context_line":"    def load_clients(cls, manager\u003dNone):"}],"source_content_type":"text/x-python","patch_set":11,"id":"5a890539_da456618","line":1204,"updated":"2014-11-19 09:08:49.000000000","message":"Apart from below comment, this is anyways extra call.","commit_id":"ca3881d3dda7c87c7a610f0ac3f55878ad391c4b"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"ff61372d9e6e57ebb6c1da410977979830cde65a","unresolved":false,"context_lines":[{"line_number":1209,"context_line":"        creds \u003d auth.get_default_credentials(\u0027user\u0027)"},{"line_number":1210,"context_line":"        admin_creds.tenant_name \u003d creds.tenant_name"},{"line_number":1211,"context_line":"        manager \u003d clients.Manager(credentials\u003dadmin_creds)"},{"line_number":1212,"context_line":"        super(OrchestrationScenarioTest, cls).load_clients(manager)"},{"line_number":1213,"context_line":""},{"line_number":1214,"context_line":"    def _load_template(self, base_file, file_name):"},{"line_number":1215,"context_line":"        filepath \u003d os.path.join(os.path.dirname(os.path.realpath(base_file)),"}],"source_content_type":"text/x-python","patch_set":11,"id":"5a890539_7acf12b4","line":1212,"updated":"2014-11-19 09:08:49.000000000","message":"I am not getting what extra benefit we are getting by re factoring this.\n\nIn original code, specific class override the credentials() method to set cred according to need, now more code they need to override.\n\nMinimal part varies between classes is cred (primary or admin) which was overridden correctly as in original code.  \n\nIMO, we can leave this class as it is just remove alt_credentials(cls). Other class changes looks reasonable.","commit_id":"ca3881d3dda7c87c7a610f0ac3f55878ad391c4b"}]}