)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8576,"name":"Yair Fried","email":"yfried@redhat.com","username":"yfried"},"change_message_id":"04c5745616b50c12d6081cde12ec05bc21f4033e","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fixes volume client in volume tests"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Volumes_client i coming from cls.os and volume_client is coming"},{"line_number":10,"context_line":"from cls.os_adm. Here it creates a naming disaster for the volume"},{"line_number":11,"context_line":"client. Adding admin_volume_client at the place of volume_client"},{"line_number":12,"context_line":"fixes the client for admin user."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9aa7fdbe_6436a6b6","line":9,"updated":"2014-10-29 13:28:34.000000000","message":"I think you have a typo here s/i/is","commit_id":"b4b097317ffb70e6ca277f50dca1e179052d074f"}],"tempest/api/volume/admin/test_multi_backend.py":[{"author":{"_account_id":11075,"name":"Benny Kopilov","email":"bkopilov@redhat.com","username":"bkopilov"},"change_message_id":"93ea9f344bdb0d945e2ac58a07fb5780dc5e4a32","unresolved":false,"context_lines":[{"line_number":50,"context_line":"            cls._create_type_and_volume(cls.backend2_name, True)"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    @classmethod"},{"line_number":53,"context_line":"    def _create_type_and_volume(self, backend_name_key, with_prefix):"},{"line_number":54,"context_line":"        # Volume/Type creation"},{"line_number":55,"context_line":"        type_name \u003d data_utils.rand_name(\u0027Type\u0027)"},{"line_number":56,"context_line":"        vol_name \u003d data_utils.rand_name(\u0027Volume\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a8c0949_06614039","line":53,"updated":"2014-10-31 19:12:41.000000000","message":"Well , this is a class method , so why it accpets self  ? \nis it by purpose ?","commit_id":"8e6f588e4be1d80f16ee4f73c3bdc6905171f48c"},{"author":{"_account_id":11075,"name":"Benny Kopilov","email":"bkopilov@redhat.com","username":"bkopilov"},"change_message_id":"4ea1527ac1578770b7cf04053899abee6d06bcdc","unresolved":false,"context_lines":[{"line_number":50,"context_line":"            cls._create_type_and_volume(cls.backend2_name, True)"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    @classmethod"},{"line_number":53,"context_line":"    def _create_type_and_volume(self, backend_name_key, with_prefix):"},{"line_number":54,"context_line":"        # Volume/Type creation"},{"line_number":55,"context_line":"        type_name \u003d data_utils.rand_name(\u0027Type\u0027)"},{"line_number":56,"context_line":"        vol_name \u003d data_utils.rand_name(\u0027Volume\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a8c0949_6a20024a","line":53,"in_reply_to":"7a8c0949_06614039","updated":"2014-11-02 08:08:33.000000000","message":"Is it ok use classmethod with self inside  ?  is it acceptable  ?","commit_id":"8e6f588e4be1d80f16ee4f73c3bdc6905171f48c"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"199c86a9689fc5bf77519ba4d266ca1fcda9c1b0","unresolved":false,"context_lines":[{"line_number":50,"context_line":"            cls._create_type_and_volume(cls.backend2_name, True)"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    @classmethod"},{"line_number":53,"context_line":"    def _create_type_and_volume(self, backend_name_key, with_prefix):"},{"line_number":54,"context_line":"        # Volume/Type creation"},{"line_number":55,"context_line":"        type_name \u003d data_utils.rand_name(\u0027Type\u0027)"},{"line_number":56,"context_line":"        vol_name \u003d data_utils.rand_name(\u0027Volume\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a8c0949_3d1566f1","line":53,"in_reply_to":"7a8c0949_6a20024a","updated":"2014-11-02 14:27:52.000000000","message":"Yes, It is acceptable.","commit_id":"8e6f588e4be1d80f16ee4f73c3bdc6905171f48c"},{"author":{"_account_id":11075,"name":"Benny Kopilov","email":"bkopilov@redhat.com","username":"bkopilov"},"change_message_id":"93ea9f344bdb0d945e2ac58a07fb5780dc5e4a32","unresolved":false,"context_lines":[{"line_number":67,"context_line":"        params \u003d {self.name_field: vol_name, \u0027volume_type\u0027: type_name}"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"        _, self.volume \u003d self.admin_volume_client.create_volume(size\u003d1,"},{"line_number":70,"context_line":"                                                                **params)"},{"line_number":71,"context_line":"        if with_prefix:"},{"line_number":72,"context_line":"            self.volume_id_list_with_prefix.append(self.volume[\u0027id\u0027])"},{"line_number":73,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a8c0949_26c2bce9","line":70,"updated":"2014-10-31 19:12:41.000000000","message":"You call here self.admin_volume  , but why you are not fixing the names under BaseVolumeAdminTest: ? \nDid you test your code ?\n\nBenny","commit_id":"8e6f588e4be1d80f16ee4f73c3bdc6905171f48c"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"60526067f3b906fb5c233355600a53e14e21ae99","unresolved":false,"context_lines":[{"line_number":67,"context_line":"        params \u003d {self.name_field: vol_name, \u0027volume_type\u0027: type_name}"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"        _, self.volume \u003d self.admin_volume_client.create_volume(size\u003d1,"},{"line_number":70,"context_line":"                                                                **params)"},{"line_number":71,"context_line":"        if with_prefix:"},{"line_number":72,"context_line":"            self.volume_id_list_with_prefix.append(self.volume[\u0027id\u0027])"},{"line_number":73,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a8c0949_7df60ed9","line":70,"in_reply_to":"7a8c0949_1d10aa00","updated":"2014-11-02 14:28:57.000000000","message":"Sorry, Other clients are changed when i will send the patches for this blueprint https://blueprints.launchpad.net/tempest/+spec/cinder-v2-api-tests","commit_id":"8e6f588e4be1d80f16ee4f73c3bdc6905171f48c"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"113ef3b6ad1157eeecbc19bf12b285f900c16134","unresolved":false,"context_lines":[{"line_number":67,"context_line":"        params \u003d {self.name_field: vol_name, \u0027volume_type\u0027: type_name}"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"        _, self.volume \u003d self.admin_volume_client.create_volume(size\u003d1,"},{"line_number":70,"context_line":"                                                                **params)"},{"line_number":71,"context_line":"        if with_prefix:"},{"line_number":72,"context_line":"            self.volume_id_list_with_prefix.append(self.volume[\u0027id\u0027])"},{"line_number":73,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a8c0949_fad3e735","line":70,"in_reply_to":"7a8c0949_26c2bce9","updated":"2014-11-01 05:04:04.000000000","message":"@Benny, It is fixed inside the  BaseVolumeAdminTest. in base.py.https://review.openstack.org/#/c/131693/2/tempest/api/volume/base.py at line no: 184 Yes, i have tested the code.","commit_id":"8e6f588e4be1d80f16ee4f73c3bdc6905171f48c"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"199c86a9689fc5bf77519ba4d266ca1fcda9c1b0","unresolved":false,"context_lines":[{"line_number":67,"context_line":"        params \u003d {self.name_field: vol_name, \u0027volume_type\u0027: type_name}"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"        _, self.volume \u003d self.admin_volume_client.create_volume(size\u003d1,"},{"line_number":70,"context_line":"                                                                **params)"},{"line_number":71,"context_line":"        if with_prefix:"},{"line_number":72,"context_line":"            self.volume_id_list_with_prefix.append(self.volume[\u0027id\u0027])"},{"line_number":73,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a8c0949_1d10aa00","line":70,"in_reply_to":"7a8c0949_4a2c2648","updated":"2014-11-02 14:27:52.000000000","message":"I have proposed this patch to fix the naming mismatch of volume_client in https://review.openstack.org/#/c/126213/ .\n \nOther clients are changed when i will send the patches for this blueprint https://review.openstack.org/#/c/126213/","commit_id":"8e6f588e4be1d80f16ee4f73c3bdc6905171f48c"},{"author":{"_account_id":11075,"name":"Benny Kopilov","email":"bkopilov@redhat.com","username":"bkopilov"},"change_message_id":"4ea1527ac1578770b7cf04053899abee6d06bcdc","unresolved":false,"context_lines":[{"line_number":67,"context_line":"        params \u003d {self.name_field: vol_name, \u0027volume_type\u0027: type_name}"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"        _, self.volume \u003d self.admin_volume_client.create_volume(size\u003d1,"},{"line_number":70,"context_line":"                                                                **params)"},{"line_number":71,"context_line":"        if with_prefix:"},{"line_number":72,"context_line":"            self.volume_id_list_with_prefix.append(self.volume[\u0027id\u0027])"},{"line_number":73,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a8c0949_4a2c2648","line":70,"in_reply_to":"7a8c0949_fad3e735","updated":"2014-11-02 08:08:33.000000000","message":"Hi , \nThanks , i missed this fix.\nWhy do we fix only a volume_client ?  \nUnder base.py ,  we have additional naming issues as far as i know :\ncls.volume_qos_client \u003d cls.os_adm.volume_qos_client\ncls.volume_types_client \u003d cls.os_adm.volume_types_client \ncls.hosts_client \u003d cls.os_adm.volume_hosts_client\ncls.quotas_client \u003d cls.os_adm.volume_quotas_client\n\nIn case we want to change all naming issue , we must do it for all .\n\nAm i missing something here ?\n\nBenny","commit_id":"8e6f588e4be1d80f16ee4f73c3bdc6905171f48c"}],"tempest/api/volume/admin/test_volume_types.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"cdcc6b508b96feb2da85cc1abddc3283fdc06d20","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    _interface \u003d \"json\""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    def _delete_volume(self, volume_id):"},{"line_number":28,"context_line":"        self.admin_volume_client.delete_volume(volume_id)"},{"line_number":29,"context_line":"        self.admin_volume_client.wait_for_resource_deletion(volume_id)"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    def _delete_volume_type(self, volume_type_id):"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a890539_cfd774be","line":28,"updated":"2014-11-10 05:50:44.000000000","message":"why these changes? I think only volume type creation needs admin cred. volume type can be visible and used among non-admin tenant also.","commit_id":"8e6f588e4be1d80f16ee4f73c3bdc6905171f48c"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"1a6c2c84178603ba90aba3c127b4a01b9750a326","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    _interface \u003d \"json\""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    def _delete_volume(self, volume_id):"},{"line_number":28,"context_line":"        self.admin_volume_client.delete_volume(volume_id)"},{"line_number":29,"context_line":"        self.admin_volume_client.wait_for_resource_deletion(volume_id)"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    def _delete_volume_type(self, volume_type_id):"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a890539_6a3cae94","line":28,"in_reply_to":"5a890539_cfd774be","updated":"2014-11-10 06:53:59.000000000","message":"Yes, you are right. I am fixing it and sending a new patchset.","commit_id":"8e6f588e4be1d80f16ee4f73c3bdc6905171f48c"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"72dc9f2d5bc9d4ea4c50fc064171324844e21f76","unresolved":false,"context_lines":[{"line_number":67,"context_line":"                        \"Field volume id is empty or not found.\")"},{"line_number":68,"context_line":"        self.volumes_client.wait_for_volume_status(volume[\u0027id\u0027],"},{"line_number":69,"context_line":"                                                   \u0027available\u0027)"},{"line_number":70,"context_line":"        _, fetched_volume \u003d self.volumes_client.get_volume("},{"line_number":71,"context_line":"            volume[\u0027id\u0027])"},{"line_number":72,"context_line":"        self.assertEqual(vol_name, fetched_volume[\u0027display_name\u0027],"},{"line_number":73,"context_line":"                         \u0027The fetched Volume is different \u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a890539_00421410","line":70,"updated":"2014-11-11 05:05:50.000000000","message":"this is not necessary.","commit_id":"3ae5db43564a92fc2e063d7724f473df56a82873"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"19e1256b75cc4c950a36827dc97a7fc48f5d1658","unresolved":false,"context_lines":[{"line_number":67,"context_line":"                        \"Field volume id is empty or not found.\")"},{"line_number":68,"context_line":"        self.volumes_client.wait_for_volume_status(volume[\u0027id\u0027],"},{"line_number":69,"context_line":"                                                   \u0027available\u0027)"},{"line_number":70,"context_line":"        self.assertEqual(vol_name, volume[\u0027display_name\u0027],"},{"line_number":71,"context_line":"                         \u0027The fetched Volume is different \u0027"},{"line_number":72,"context_line":"                         \u0027from the created Volume\u0027)"},{"line_number":73,"context_line":"        self.assertEqual(volume[\u0027id\u0027], volume[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a890539_2b3b713b","line":70,"updated":"2014-11-11 07:28:54.000000000","message":"Sorry for confusion. Actually i mean to undo the changes for this file not to remove the line.","commit_id":"3cec1f9375e157bfab5dee0077ecbcd371faa03b"}],"tempest/api/volume/admin/test_volume_types_negative.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"cdcc6b508b96feb2da85cc1abddc3283fdc06d20","unresolved":false,"context_lines":[{"line_number":27,"context_line":"    def test_create_with_nonexistent_volume_type(self):"},{"line_number":28,"context_line":"        # Should not be able to create volume with nonexistent volume_type."},{"line_number":29,"context_line":"        self.assertRaises(exceptions.NotFound,"},{"line_number":30,"context_line":"                          self.admin_volume_client.create_volume, size\u003d1,"},{"line_number":31,"context_line":"                          display_name\u003dstr(uuid.uuid4()),"},{"line_number":32,"context_line":"                          volume_type\u003dstr(uuid.uuid4()))"},{"line_number":33,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5a890539_0fe25c9f","line":30,"updated":"2014-11-10 05:50:44.000000000","message":"ditto","commit_id":"8e6f588e4be1d80f16ee4f73c3bdc6905171f48c"}]}