)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"016106b6dc05e478b39b17189a513587a467eb31","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add test to create a floating ip by admin  for non-admin tenant"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"  -Create a Floating IP as an admin by passing external network_id, tenant_id and port_id as  parameter"},{"line_number":12,"context_line":"  -Verify the port_id, floating_network_id and fixed_ip_address"},{"line_number":13,"context_line":"  -Delete the Floating IP by non-admin"},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5a890539_5b60a535","line":11,"updated":"2014-11-10 10:53:51.000000000","message":"Line too long.","commit_id":"59ff04ff18c6cd222f5e864c7d43046f2092075b"}],"tempest/api/network/admin/test_floating_ips_admin_actions.py":[{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"d5f4c3cc6f301b39db0675876ea082327e2d65ed","unresolved":false,"context_lines":[{"line_number":75,"context_line":"        self.assertNotIn(floating_ip_alt[\u0027id\u0027], floating_ip_ids)"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":78,"context_line":"    def test_create_list_show_delete_floating_ip_by_admin(self):"},{"line_number":79,"context_line":"        # Creates a floating IP"},{"line_number":80,"context_line":"        _, body \u003d self.admin_client.create_floatingip("},{"line_number":81,"context_line":"            floating_network_id\u003dself.ext_net_id,"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a890539_a17ed467","line":78,"updated":"2014-11-18 13:09:34.000000000","message":"I this this test should have a different name. As it now it seem to duplicate the previous one. test_create_list_show_floating_ip_with_port_by_admin or something like this.","commit_id":"7e4b17a19f0e1d7396d9c71e59a7ab7e43aa1275"},{"author":{"_account_id":13342,"name":"Abhishek G M","email":"abhishek.gm@hpe.com","username":"abhishek60014726"},"change_message_id":"b18284ff88b2d953a9c99444a4deb0b893e65191","unresolved":false,"context_lines":[{"line_number":75,"context_line":"        self.assertNotIn(floating_ip_alt[\u0027id\u0027], floating_ip_ids)"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":78,"context_line":"    def test_create_list_show_delete_floating_ip_by_admin(self):"},{"line_number":79,"context_line":"        # Creates a floating IP"},{"line_number":80,"context_line":"        _, body \u003d self.admin_client.create_floatingip("},{"line_number":81,"context_line":"            floating_network_id\u003dself.ext_net_id,"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a890539_8ab39109","line":78,"in_reply_to":"5a890539_a17ed467","updated":"2014-11-21 09:52:29.000000000","message":"ok will make changes","commit_id":"7e4b17a19f0e1d7396d9c71e59a7ab7e43aa1275"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"e65f1168eabd95f7c791427822e75a7a6ce7869c","unresolved":false,"context_lines":[{"line_number":109,"context_line":"        _, floating_ips \u003d self.admin_client.list_floatingips()"},{"line_number":110,"context_line":"        floatingip_id_list \u003d list()"},{"line_number":111,"context_line":"        for f in floating_ips[\u0027floatingips\u0027]:"},{"line_number":112,"context_line":"            floatingip_id_list.append(f[\u0027id\u0027])"},{"line_number":113,"context_line":"        self.assertIn(created_floating_ip[\u0027id\u0027], floatingip_id_list)"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5a890539_664ba259","line":112,"updated":"2014-11-21 11:01:02.000000000","message":"Three lines above could be replaced with \n\n     floatingip_id_list \u003d [f[\u0027id\u0027] for f in floating_ips[\u0027floatingips\u0027]]","commit_id":"a8080538a43ece2637307a670a48749132d99c08"},{"author":{"_account_id":13342,"name":"Abhishek G M","email":"abhishek.gm@hpe.com","username":"abhishek60014726"},"change_message_id":"b33d93f0b8b757b6050bbf7a6e1660e0ebe64370","unresolved":false,"context_lines":[{"line_number":109,"context_line":"        _, floating_ips \u003d self.admin_client.list_floatingips()"},{"line_number":110,"context_line":"        floatingip_id_list \u003d list()"},{"line_number":111,"context_line":"        for f in floating_ips[\u0027floatingips\u0027]:"},{"line_number":112,"context_line":"            floatingip_id_list.append(f[\u0027id\u0027])"},{"line_number":113,"context_line":"        self.assertIn(created_floating_ip[\u0027id\u0027], floatingip_id_list)"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5a890539_4d064787","line":112,"in_reply_to":"5a890539_664ba259","updated":"2014-11-26 09:11:25.000000000","message":"yes i made changes","commit_id":"a8080538a43ece2637307a670a48749132d99c08"},{"author":{"_account_id":5174,"name":"Mauro Sergio Martins Rodrigues","email":"maurosr@linux.vnet.ibm.com","username":"maurosr"},"change_message_id":"4adf522d563a73791483666ae66537da02e1733f","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        cls.router \u003d cls.create_router(data_utils.rand_name(\u0027router-\u0027),"},{"line_number":39,"context_line":"                                       external_network_id\u003dcls.ext_net_id)"},{"line_number":40,"context_line":"        cls.create_router_interface(cls.router[\u0027id\u0027], cls.subnet[\u0027id\u0027])"},{"line_number":41,"context_line":"        cls.port \u003d list()"},{"line_number":42,"context_line":"        # Create two ports one each for Creation and Updating of floatingIP"},{"line_number":43,"context_line":"        for i in range(2):"},{"line_number":44,"context_line":"            cls.create_port(cls.network)"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a890539_f07b3ebc","line":41,"updated":"2014-11-27 12:58:09.000000000","message":"cls.port is not used anywhere, you use self.ports (in plural), I guess it doesn\u0027t break cause you\u0027re using self.ports from NetworkBaseTest class which might cause trouble if eventually we add another test in this class that create other ports and only cleans when the whole class\u0027s test is done.","commit_id":"c94263d578fd199747b0aff2e68cbcb1be552b12"},{"author":{"_account_id":13342,"name":"Abhishek G M","email":"abhishek.gm@hpe.com","username":"abhishek60014726"},"change_message_id":"6d10011bbf57aeaf767762c26b61f4c552fc0aa7","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        cls.router \u003d cls.create_router(data_utils.rand_name(\u0027router-\u0027),"},{"line_number":39,"context_line":"                                       external_network_id\u003dcls.ext_net_id)"},{"line_number":40,"context_line":"        cls.create_router_interface(cls.router[\u0027id\u0027], cls.subnet[\u0027id\u0027])"},{"line_number":41,"context_line":"        cls.port \u003d list()"},{"line_number":42,"context_line":"        # Create two ports one each for Creation and Updating of floatingIP"},{"line_number":43,"context_line":"        for i in range(2):"},{"line_number":44,"context_line":"            cls.create_port(cls.network)"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a890539_d9fa9d42","line":41,"in_reply_to":"5a890539_f07b3ebc","updated":"2014-12-01 10:20:15.000000000","message":"yes i made changes","commit_id":"c94263d578fd199747b0aff2e68cbcb1be552b12"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"05b35f82cccb0072d5d8ae496a405751ac411541","unresolved":false,"context_lines":[{"line_number":91,"context_line":"        self.assertEqual(created_floating_ip[\u0027floating_network_id\u0027],"},{"line_number":92,"context_line":"                         self.ext_net_id)"},{"line_number":93,"context_line":"        self.assertIn(created_floating_ip[\u0027fixed_ip_address\u0027],"},{"line_number":94,"context_line":"                      [ip[\u0027ip_address\u0027] for ip in self.ports[0][\u0027fixed_ips\u0027]])"},{"line_number":95,"context_line":"        # Verifies the details of a floating_ip"},{"line_number":96,"context_line":"        _, floating_ip \u003d self.admin_client.show_floatingip("},{"line_number":97,"context_line":"            created_floating_ip[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a890539_10e5010a","line":94,"updated":"2014-11-27 22:20:46.000000000","message":"I think it\u0027s better to create dictionary and compare with matcher, than so many asserts here.","commit_id":"c94263d578fd199747b0aff2e68cbcb1be552b12"},{"author":{"_account_id":13342,"name":"Abhishek G M","email":"abhishek.gm@hpe.com","username":"abhishek60014726"},"change_message_id":"6d10011bbf57aeaf767762c26b61f4c552fc0aa7","unresolved":false,"context_lines":[{"line_number":91,"context_line":"        self.assertEqual(created_floating_ip[\u0027floating_network_id\u0027],"},{"line_number":92,"context_line":"                         self.ext_net_id)"},{"line_number":93,"context_line":"        self.assertIn(created_floating_ip[\u0027fixed_ip_address\u0027],"},{"line_number":94,"context_line":"                      [ip[\u0027ip_address\u0027] for ip in self.ports[0][\u0027fixed_ips\u0027]])"},{"line_number":95,"context_line":"        # Verifies the details of a floating_ip"},{"line_number":96,"context_line":"        _, floating_ip \u003d self.admin_client.show_floatingip("},{"line_number":97,"context_line":"            created_floating_ip[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a890539_59e78dac","line":94,"in_reply_to":"5a890539_10e5010a","updated":"2014-12-01 10:20:15.000000000","message":"I did changes, what u told.","commit_id":"c94263d578fd199747b0aff2e68cbcb1be552b12"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"05b35f82cccb0072d5d8ae496a405751ac411541","unresolved":false,"context_lines":[{"line_number":103,"context_line":"                         self.network[\u0027tenant_id\u0027])"},{"line_number":104,"context_line":"        self.assertEqual(shown_floating_ip[\u0027floating_ip_address\u0027],"},{"line_number":105,"context_line":"                         created_floating_ip[\u0027floating_ip_address\u0027])"},{"line_number":106,"context_line":"        self.assertEqual(shown_floating_ip[\u0027port_id\u0027], self.ports[0][\u0027id\u0027])"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"        # Verify the floating ip exists in the list of all floating_ips"},{"line_number":109,"context_line":"        _, floating_ips \u003d self.admin_client.list_floatingips()"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a890539_30e2fd01","line":106,"updated":"2014-11-27 22:20:46.000000000","message":"and again, 2 dictionaries will save you.","commit_id":"c94263d578fd199747b0aff2e68cbcb1be552b12"},{"author":{"_account_id":13342,"name":"Abhishek G M","email":"abhishek.gm@hpe.com","username":"abhishek60014726"},"change_message_id":"6d10011bbf57aeaf767762c26b61f4c552fc0aa7","unresolved":false,"context_lines":[{"line_number":103,"context_line":"                         self.network[\u0027tenant_id\u0027])"},{"line_number":104,"context_line":"        self.assertEqual(shown_floating_ip[\u0027floating_ip_address\u0027],"},{"line_number":105,"context_line":"                         created_floating_ip[\u0027floating_ip_address\u0027])"},{"line_number":106,"context_line":"        self.assertEqual(shown_floating_ip[\u0027port_id\u0027], self.ports[0][\u0027id\u0027])"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"        # Verify the floating ip exists in the list of all floating_ips"},{"line_number":109,"context_line":"        _, floating_ips \u003d self.admin_client.list_floatingips()"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a890539_99001537","line":106,"in_reply_to":"5a890539_30e2fd01","updated":"2014-12-01 10:20:15.000000000","message":"I did changes, what u told.","commit_id":"c94263d578fd199747b0aff2e68cbcb1be552b12"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"611f4cf04945d9f1c8713fbd5884f22c62580132","unresolved":false,"context_lines":[{"line_number":84,"context_line":"        self.addCleanup(self.client.delete_floatingip,"},{"line_number":85,"context_line":"                        created_floating_ip[\u0027id\u0027])"},{"line_number":86,"context_line":"        self.assertIsNotNone(created_floating_ip[\u0027id\u0027])"},{"line_number":87,"context_line":"        self.assertIsNotNone(created_floating_ip[\u0027tenant_id\u0027])"},{"line_number":88,"context_line":"        self.assertIsNotNone(created_floating_ip[\u0027floating_ip_address\u0027])"},{"line_number":89,"context_line":"        dict1 \u003d {\u0027port_id\u0027: created_floating_ip[\u0027port_id\u0027],"},{"line_number":90,"context_line":"                 \u0027net_id\u0027: created_floating_ip[\u0027floating_network_id\u0027]}"}],"source_content_type":"text/x-python","patch_set":7,"id":"3a961159_b46d0b07","line":87,"updated":"2014-12-08 14:41:43.000000000","message":"You should use assertEqual here. You have the exact value you are looking for (self.network[\u0027tenant_id\u0027])","commit_id":"bedad60bea374ae615ee80c9572d194f6bef2b84"},{"author":{"_account_id":13342,"name":"Abhishek G M","email":"abhishek.gm@hpe.com","username":"abhishek60014726"},"change_message_id":"3ff01f30e9b9d3f783f968559cb440043dc8f3ea","unresolved":false,"context_lines":[{"line_number":84,"context_line":"        self.addCleanup(self.client.delete_floatingip,"},{"line_number":85,"context_line":"                        created_floating_ip[\u0027id\u0027])"},{"line_number":86,"context_line":"        self.assertIsNotNone(created_floating_ip[\u0027id\u0027])"},{"line_number":87,"context_line":"        self.assertIsNotNone(created_floating_ip[\u0027tenant_id\u0027])"},{"line_number":88,"context_line":"        self.assertIsNotNone(created_floating_ip[\u0027floating_ip_address\u0027])"},{"line_number":89,"context_line":"        dict1 \u003d {\u0027port_id\u0027: created_floating_ip[\u0027port_id\u0027],"},{"line_number":90,"context_line":"                 \u0027net_id\u0027: created_floating_ip[\u0027floating_network_id\u0027]}"}],"source_content_type":"text/x-python","patch_set":7,"id":"3a961159_7789ccc9","line":87,"in_reply_to":"3a961159_b46d0b07","updated":"2014-12-09 05:10:02.000000000","message":"I got a comment from Sergey Shnaidman in patch 4 to use dictionary instead of assertEqual.","commit_id":"bedad60bea374ae615ee80c9572d194f6bef2b84"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"611f4cf04945d9f1c8713fbd5884f22c62580132","unresolved":false,"context_lines":[{"line_number":89,"context_line":"        dict1 \u003d {\u0027port_id\u0027: created_floating_ip[\u0027port_id\u0027],"},{"line_number":90,"context_line":"                 \u0027net_id\u0027: created_floating_ip[\u0027floating_network_id\u0027]}"},{"line_number":91,"context_line":"        dict2 \u003d {\u0027port_id\u0027: self.ports[0][\u0027id\u0027], \u0027net_id\u0027: self.ext_net_id}"},{"line_number":92,"context_line":"        cmp(dict1, dict2)"},{"line_number":93,"context_line":"        self.assertIn(created_floating_ip[\u0027fixed_ip_address\u0027],"},{"line_number":94,"context_line":"                      [ip[\u0027ip_address\u0027] for ip in self.ports[0][\u0027fixed_ips\u0027]])"},{"line_number":95,"context_line":"        # Verifies the details of a floating_ip"}],"source_content_type":"text/x-python","patch_set":7,"id":"3a961159_d4a45759","line":92,"updated":"2014-12-08 14:41:43.000000000","message":"What are you doing with the result of this comparison ? You should assertSomething() maybe ?","commit_id":"bedad60bea374ae615ee80c9572d194f6bef2b84"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"611f4cf04945d9f1c8713fbd5884f22c62580132","unresolved":false,"context_lines":[{"line_number":106,"context_line":"                 \u0027tenant_id\u0027: self.network[\u0027tenant_id\u0027],"},{"line_number":107,"context_line":"                 \u0027floating_ip\u0027: created_floating_ip[\u0027floating_ip_address\u0027],"},{"line_number":108,"context_line":"                 \u0027port_id\u0027: self.ports[0][\u0027id\u0027]}"},{"line_number":109,"context_line":"        cmp(dict3, dict4)"},{"line_number":110,"context_line":"        # Verify the floating ip exists in the list of all floating_ips"},{"line_number":111,"context_line":"        _, floating_ips \u003d self.admin_client.list_floatingips()"},{"line_number":112,"context_line":"        floatingip_id_list \u003d [f[\u0027id\u0027] for f in floating_ips[\u0027floatingips\u0027]]"}],"source_content_type":"text/x-python","patch_set":7,"id":"3a961159_f48873c8","line":109,"updated":"2014-12-08 14:41:43.000000000","message":"What are you doing with the result of this comparison ?","commit_id":"bedad60bea374ae615ee80c9572d194f6bef2b84"},{"author":{"_account_id":5174,"name":"Mauro Sergio Martins Rodrigues","email":"maurosr@linux.vnet.ibm.com","username":"maurosr"},"change_message_id":"478000c728c460cbe279ae2eb746571b8d39c881","unresolved":false,"context_lines":[{"line_number":89,"context_line":"        dict1 \u003d {\u0027port_id\u0027: created_floating_ip[\u0027port_id\u0027],"},{"line_number":90,"context_line":"                 \u0027net_id\u0027: created_floating_ip[\u0027floating_network_id\u0027]}"},{"line_number":91,"context_line":"        dict2 \u003d {\u0027port_id\u0027: self.ports[0][\u0027id\u0027], \u0027net_id\u0027: self.ext_net_id}"},{"line_number":92,"context_line":"        cmp(dict1, dict2)"},{"line_number":93,"context_line":"        self.assertIn(created_floating_ip[\u0027fixed_ip_address\u0027],"},{"line_number":94,"context_line":"                      [ip[\u0027ip_address\u0027] for ip in self.ports[0][\u0027fixed_ips\u0027]])"},{"line_number":95,"context_line":"        # Verifies the details of a floating_ip"}],"source_content_type":"text/x-python","patch_set":8,"id":"3a961159_93455e72","line":92,"updated":"2014-12-09 14:00:53.000000000","message":"I don\u0027t think that is exactly what Sergey meant to suggest here.\nit does compare the dictionaries successfully but you\u0027re not asserting the result of such compare, at very least you should use: self.assertEqual(cmp(dict1,dict2), 0)\n\nAlso, It\u0027s worthy to mention that cmp doesn\u0027t exist in python3\n\nI guess you can try with self.assertDictEqual instead","commit_id":"a987c3e3ca5f663ffeeb46a3c7e50d5ec24a7b5c"},{"author":{"_account_id":13342,"name":"Abhishek G M","email":"abhishek.gm@hpe.com","username":"abhishek60014726"},"change_message_id":"13f5bebf7da1e773641a826a48d301df0949973d","unresolved":false,"context_lines":[{"line_number":89,"context_line":"        dict1 \u003d {\u0027port_id\u0027: created_floating_ip[\u0027port_id\u0027],"},{"line_number":90,"context_line":"                 \u0027net_id\u0027: created_floating_ip[\u0027floating_network_id\u0027]}"},{"line_number":91,"context_line":"        dict2 \u003d {\u0027port_id\u0027: self.ports[0][\u0027id\u0027], \u0027net_id\u0027: self.ext_net_id}"},{"line_number":92,"context_line":"        cmp(dict1, dict2)"},{"line_number":93,"context_line":"        self.assertIn(created_floating_ip[\u0027fixed_ip_address\u0027],"},{"line_number":94,"context_line":"                      [ip[\u0027ip_address\u0027] for ip in self.ports[0][\u0027fixed_ips\u0027]])"},{"line_number":95,"context_line":"        # Verifies the details of a floating_ip"}],"source_content_type":"text/x-python","patch_set":8,"id":"3a961159_cea9e37c","line":92,"in_reply_to":"3a961159_93455e72","updated":"2014-12-10 06:23:11.000000000","message":"Yes i made changes by using self.assertDictEqual.","commit_id":"a987c3e3ca5f663ffeeb46a3c7e50d5ec24a7b5c"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"aa0b16ab74eb87e8b701ddf8b8ce7652448a52a8","unresolved":false,"context_lines":[{"line_number":85,"context_line":"                        created_floating_ip[\u0027id\u0027])"},{"line_number":86,"context_line":"        self.assertIsNotNone(created_floating_ip[\u0027id\u0027])"},{"line_number":87,"context_line":"        self.assertIsNotNone(created_floating_ip[\u0027tenant_id\u0027])"},{"line_number":88,"context_line":"        self.assertIsNotNone(created_floating_ip[\u0027floating_ip_address\u0027])"},{"line_number":89,"context_line":"        dict1 \u003d {\u0027port_id\u0027: created_floating_ip[\u0027port_id\u0027],"},{"line_number":90,"context_line":"                 \u0027net_id\u0027: created_floating_ip[\u0027floating_network_id\u0027]}"},{"line_number":91,"context_line":"        dict2 \u003d {\u0027port_id\u0027: self.ports[0][\u0027id\u0027], \u0027net_id\u0027: self.ext_net_id}"}],"source_content_type":"text/x-python","patch_set":9,"id":"3a961159_fac90e5b","line":88,"updated":"2014-12-17 15:59:30.000000000","message":"I think it\u0027s already covered by other tests, does it make sense to check it here?","commit_id":"d7bc360ba1ea223e0779eabc03eae7f98adb3f8b"},{"author":{"_account_id":13342,"name":"Abhishek G M","email":"abhishek.gm@hpe.com","username":"abhishek60014726"},"change_message_id":"2c6489ec2aae94d30ba804db0f755ea4ae100e14","unresolved":false,"context_lines":[{"line_number":85,"context_line":"                        created_floating_ip[\u0027id\u0027])"},{"line_number":86,"context_line":"        self.assertIsNotNone(created_floating_ip[\u0027id\u0027])"},{"line_number":87,"context_line":"        self.assertIsNotNone(created_floating_ip[\u0027tenant_id\u0027])"},{"line_number":88,"context_line":"        self.assertIsNotNone(created_floating_ip[\u0027floating_ip_address\u0027])"},{"line_number":89,"context_line":"        dict1 \u003d {\u0027port_id\u0027: created_floating_ip[\u0027port_id\u0027],"},{"line_number":90,"context_line":"                 \u0027net_id\u0027: created_floating_ip[\u0027floating_network_id\u0027]}"},{"line_number":91,"context_line":"        dict2 \u003d {\u0027port_id\u0027: self.ports[0][\u0027id\u0027], \u0027net_id\u0027: self.ext_net_id}"}],"source_content_type":"text/x-python","patch_set":9,"id":"3a961159_456869ba","line":88,"in_reply_to":"3a961159_fac90e5b","updated":"2014-12-18 10:07:43.000000000","message":"i am doing this in admin directory","commit_id":"d7bc360ba1ea223e0779eabc03eae7f98adb3f8b"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"aa0b16ab74eb87e8b701ddf8b8ce7652448a52a8","unresolved":false,"context_lines":[{"line_number":89,"context_line":"        dict1 \u003d {\u0027port_id\u0027: created_floating_ip[\u0027port_id\u0027],"},{"line_number":90,"context_line":"                 \u0027net_id\u0027: created_floating_ip[\u0027floating_network_id\u0027]}"},{"line_number":91,"context_line":"        dict2 \u003d {\u0027port_id\u0027: self.ports[0][\u0027id\u0027], \u0027net_id\u0027: self.ext_net_id}"},{"line_number":92,"context_line":"        self.assertDictEqual(dict1, dict2)"},{"line_number":93,"context_line":"        self.assertIn(created_floating_ip[\u0027fixed_ip_address\u0027],"},{"line_number":94,"context_line":"                      [ip[\u0027ip_address\u0027] for ip in self.ports[0][\u0027fixed_ips\u0027]])"},{"line_number":95,"context_line":"        # Verifies the details of a floating_ip"}],"source_content_type":"text/x-python","patch_set":9,"id":"3a961159_5ad6a2f2","line":92,"updated":"2014-12-17 15:59:30.000000000","message":"you can just compare 4 values, why to create dicts that you don\u0027t use anymore?","commit_id":"d7bc360ba1ea223e0779eabc03eae7f98adb3f8b"},{"author":{"_account_id":13342,"name":"Abhishek G M","email":"abhishek.gm@hpe.com","username":"abhishek60014726"},"change_message_id":"2c6489ec2aae94d30ba804db0f755ea4ae100e14","unresolved":false,"context_lines":[{"line_number":89,"context_line":"        dict1 \u003d {\u0027port_id\u0027: created_floating_ip[\u0027port_id\u0027],"},{"line_number":90,"context_line":"                 \u0027net_id\u0027: created_floating_ip[\u0027floating_network_id\u0027]}"},{"line_number":91,"context_line":"        dict2 \u003d {\u0027port_id\u0027: self.ports[0][\u0027id\u0027], \u0027net_id\u0027: self.ext_net_id}"},{"line_number":92,"context_line":"        self.assertDictEqual(dict1, dict2)"},{"line_number":93,"context_line":"        self.assertIn(created_floating_ip[\u0027fixed_ip_address\u0027],"},{"line_number":94,"context_line":"                      [ip[\u0027ip_address\u0027] for ip in self.ports[0][\u0027fixed_ips\u0027]])"},{"line_number":95,"context_line":"        # Verifies the details of a floating_ip"}],"source_content_type":"text/x-python","patch_set":9,"id":"3a961159_6563a5dd","line":92,"in_reply_to":"3a961159_5ad6a2f2","updated":"2014-12-18 10:07:43.000000000","message":"I patch 4 u only suggested me to use dictionaries.","commit_id":"d7bc360ba1ea223e0779eabc03eae7f98adb3f8b"},{"author":{"_account_id":13342,"name":"Abhishek G M","email":"abhishek.gm@hpe.com","username":"abhishek60014726"},"change_message_id":"9e1b7f5a2076220d2d6c701308d6ce340d31edd3","unresolved":false,"context_lines":[{"line_number":89,"context_line":"        dict1 \u003d {\u0027port_id\u0027: created_floating_ip[\u0027port_id\u0027],"},{"line_number":90,"context_line":"                 \u0027net_id\u0027: created_floating_ip[\u0027floating_network_id\u0027]}"},{"line_number":91,"context_line":"        dict2 \u003d {\u0027port_id\u0027: self.ports[0][\u0027id\u0027], \u0027net_id\u0027: self.ext_net_id}"},{"line_number":92,"context_line":"        self.assertDictEqual(dict1, dict2)"},{"line_number":93,"context_line":"        self.assertIn(created_floating_ip[\u0027fixed_ip_address\u0027],"},{"line_number":94,"context_line":"                      [ip[\u0027ip_address\u0027] for ip in self.ports[0][\u0027fixed_ips\u0027]])"},{"line_number":95,"context_line":"        # Verifies the details of a floating_ip"}],"source_content_type":"text/x-python","patch_set":9,"id":"3a961159_68b0b18b","line":92,"in_reply_to":"3a961159_6563a5dd","updated":"2015-01-06 08:36:37.000000000","message":"In patch 4 u only suggested me to use dictionaries","commit_id":"d7bc360ba1ea223e0779eabc03eae7f98adb3f8b"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"aa0b16ab74eb87e8b701ddf8b8ce7652448a52a8","unresolved":false,"context_lines":[{"line_number":106,"context_line":"                 \u0027tenant_id\u0027: self.network[\u0027tenant_id\u0027],"},{"line_number":107,"context_line":"                 \u0027floating_ip\u0027: created_floating_ip[\u0027floating_ip_address\u0027],"},{"line_number":108,"context_line":"                 \u0027port_id\u0027: self.ports[0][\u0027id\u0027]}"},{"line_number":109,"context_line":"        self.assertDictEqual(dict3, dict4)"},{"line_number":110,"context_line":"        # Verify the floating ip exists in the list of all floating_ips"},{"line_number":111,"context_line":"        _, floating_ips \u003d self.admin_client.list_floatingips()"},{"line_number":112,"context_line":"        floatingip_id_list \u003d [f[\u0027id\u0027] for f in floating_ips[\u0027floatingips\u0027]]"}],"source_content_type":"text/x-python","patch_set":9,"id":"3a961159_3aad5689","line":109,"updated":"2014-12-17 15:59:30.000000000","message":"If you want only to compare value by value, all these keys don\u0027t make sense:\n\n  self.assertEqual(created_floating_ip[\u0027id\u0027], shown_floating_ip[\u0027id\u0027], \"Id is different\")\n  self.assertEqual(self.ext_net_id, shown_floating_ip[\u0027floating_network_id\u0027], \"net ID is different\")\n\nand so on","commit_id":"d7bc360ba1ea223e0779eabc03eae7f98adb3f8b"},{"author":{"_account_id":13342,"name":"Abhishek G M","email":"abhishek.gm@hpe.com","username":"abhishek60014726"},"change_message_id":"2c6489ec2aae94d30ba804db0f755ea4ae100e14","unresolved":false,"context_lines":[{"line_number":106,"context_line":"                 \u0027tenant_id\u0027: self.network[\u0027tenant_id\u0027],"},{"line_number":107,"context_line":"                 \u0027floating_ip\u0027: created_floating_ip[\u0027floating_ip_address\u0027],"},{"line_number":108,"context_line":"                 \u0027port_id\u0027: self.ports[0][\u0027id\u0027]}"},{"line_number":109,"context_line":"        self.assertDictEqual(dict3, dict4)"},{"line_number":110,"context_line":"        # Verify the floating ip exists in the list of all floating_ips"},{"line_number":111,"context_line":"        _, floating_ips \u003d self.admin_client.list_floatingips()"},{"line_number":112,"context_line":"        floatingip_id_list \u003d [f[\u0027id\u0027] for f in floating_ips[\u0027floatingips\u0027]]"}],"source_content_type":"text/x-python","patch_set":9,"id":"3a961159_c59b79c7","line":109,"in_reply_to":"3a961159_3aad5689","updated":"2014-12-18 10:07:43.000000000","message":"I patch 4 u only suggested me to use dictionaries","commit_id":"d7bc360ba1ea223e0779eabc03eae7f98adb3f8b"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"441b2d385dc2b6c949e8dcc0931d53d6b2da26fb","unresolved":false,"context_lines":[{"line_number":43,"context_line":"            cls.create_port(cls.network)"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":46,"context_line":"    def test_list_floating_ips_from_admin_and_nonadmin(self):"},{"line_number":47,"context_line":"        # Create floating ip from admin user"},{"line_number":48,"context_line":"        _, floating_ip_admin \u003d self.admin_client.create_floatingip("},{"line_number":49,"context_line":"            floating_network_id\u003dself.ext_net_id)"}],"source_content_type":"text/x-python","patch_set":10,"id":"da86d52c_72ace08c","line":46,"updated":"2015-02-05 16:03:29.000000000","message":"Why do you need two ports here ? It seems you are only using ports[0]","commit_id":"ab13c606534fd44180e67f78db10d47253805a77"},{"author":{"_account_id":13342,"name":"Abhishek G M","email":"abhishek.gm@hpe.com","username":"abhishek60014726"},"change_message_id":"a954c1672bebc0401fbe243f2ba3056097415e01","unresolved":false,"context_lines":[{"line_number":43,"context_line":"            cls.create_port(cls.network)"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":46,"context_line":"    def test_list_floating_ips_from_admin_and_nonadmin(self):"},{"line_number":47,"context_line":"        # Create floating ip from admin user"},{"line_number":48,"context_line":"        _, floating_ip_admin \u003d self.admin_client.create_floatingip("},{"line_number":49,"context_line":"            floating_network_id\u003dself.ext_net_id)"}],"source_content_type":"text/x-python","patch_set":10,"id":"da86d52c_5545eb40","line":46,"in_reply_to":"da86d52c_72ace08c","updated":"2015-02-06 07:11:58.000000000","message":"yes i made changes","commit_id":"ab13c606534fd44180e67f78db10d47253805a77"},{"author":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"change_message_id":"6537e7b66701fa072e26ea606526b1bf6930c157","unresolved":false,"context_lines":[{"line_number":97,"context_line":"            created_floating_ip[\u0027id\u0027])"},{"line_number":98,"context_line":"        shown_floating_ip \u003d floating_ip[\u0027floatingip\u0027]"},{"line_number":99,"context_line":"        dict3 \u003d {\u0027id\u0027: shown_floating_ip[\u0027id\u0027],"},{"line_number":100,"context_line":"                 \u0027net_id\u0027: shown_floating_ip[\u0027floating_network_id\u0027],"},{"line_number":101,"context_line":"                 \u0027tenant_id\u0027: shown_floating_ip[\u0027tenant_id\u0027],"},{"line_number":102,"context_line":"                 \u0027floating_ip\u0027: shown_floating_ip[\u0027floating_ip_address\u0027],"},{"line_number":103,"context_line":"                 \u0027port_id\u0027: shown_floating_ip[\u0027port_id\u0027]}"}],"source_content_type":"text/x-python","patch_set":10,"id":"da86d52c_8af879c4","line":100,"updated":"2015-02-04 09:28:51.000000000","message":"I have no idea why these dicts created instead of just using many assertEquals.","commit_id":"ab13c606534fd44180e67f78db10d47253805a77"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"441b2d385dc2b6c949e8dcc0931d53d6b2da26fb","unresolved":false,"context_lines":[{"line_number":97,"context_line":"            created_floating_ip[\u0027id\u0027])"},{"line_number":98,"context_line":"        shown_floating_ip \u003d floating_ip[\u0027floatingip\u0027]"},{"line_number":99,"context_line":"        dict3 \u003d {\u0027id\u0027: shown_floating_ip[\u0027id\u0027],"},{"line_number":100,"context_line":"                 \u0027net_id\u0027: shown_floating_ip[\u0027floating_network_id\u0027],"},{"line_number":101,"context_line":"                 \u0027tenant_id\u0027: shown_floating_ip[\u0027tenant_id\u0027],"},{"line_number":102,"context_line":"                 \u0027floating_ip\u0027: shown_floating_ip[\u0027floating_ip_address\u0027],"},{"line_number":103,"context_line":"                 \u0027port_id\u0027: shown_floating_ip[\u0027port_id\u0027]}"}],"source_content_type":"text/x-python","patch_set":10,"id":"da86d52c_9271540e","line":100,"in_reply_to":"da86d52c_8af879c4","updated":"2015-02-05 16:03:29.000000000","message":"Yeah, please don\u0027t do that.\n\nIf a new property to a floating IP is added, it will be returned by show_floatingip() and this test will fail.","commit_id":"ab13c606534fd44180e67f78db10d47253805a77"},{"author":{"_account_id":13342,"name":"Abhishek G M","email":"abhishek.gm@hpe.com","username":"abhishek60014726"},"change_message_id":"a954c1672bebc0401fbe243f2ba3056097415e01","unresolved":false,"context_lines":[{"line_number":97,"context_line":"            created_floating_ip[\u0027id\u0027])"},{"line_number":98,"context_line":"        shown_floating_ip \u003d floating_ip[\u0027floatingip\u0027]"},{"line_number":99,"context_line":"        dict3 \u003d {\u0027id\u0027: shown_floating_ip[\u0027id\u0027],"},{"line_number":100,"context_line":"                 \u0027net_id\u0027: shown_floating_ip[\u0027floating_network_id\u0027],"},{"line_number":101,"context_line":"                 \u0027tenant_id\u0027: shown_floating_ip[\u0027tenant_id\u0027],"},{"line_number":102,"context_line":"                 \u0027floating_ip\u0027: shown_floating_ip[\u0027floating_ip_address\u0027],"},{"line_number":103,"context_line":"                 \u0027port_id\u0027: shown_floating_ip[\u0027port_id\u0027]}"}],"source_content_type":"text/x-python","patch_set":10,"id":"da86d52c_75774fa0","line":100,"in_reply_to":"da86d52c_8af879c4","updated":"2015-02-06 07:11:58.000000000","message":"yes i made changes","commit_id":"ab13c606534fd44180e67f78db10d47253805a77"},{"author":{"_account_id":13342,"name":"Abhishek G M","email":"abhishek.gm@hpe.com","username":"abhishek60014726"},"change_message_id":"a954c1672bebc0401fbe243f2ba3056097415e01","unresolved":false,"context_lines":[{"line_number":97,"context_line":"            created_floating_ip[\u0027id\u0027])"},{"line_number":98,"context_line":"        shown_floating_ip \u003d floating_ip[\u0027floatingip\u0027]"},{"line_number":99,"context_line":"        dict3 \u003d {\u0027id\u0027: shown_floating_ip[\u0027id\u0027],"},{"line_number":100,"context_line":"                 \u0027net_id\u0027: shown_floating_ip[\u0027floating_network_id\u0027],"},{"line_number":101,"context_line":"                 \u0027tenant_id\u0027: shown_floating_ip[\u0027tenant_id\u0027],"},{"line_number":102,"context_line":"                 \u0027floating_ip\u0027: shown_floating_ip[\u0027floating_ip_address\u0027],"},{"line_number":103,"context_line":"                 \u0027port_id\u0027: shown_floating_ip[\u0027port_id\u0027]}"}],"source_content_type":"text/x-python","patch_set":10,"id":"da86d52c_957a0386","line":100,"in_reply_to":"da86d52c_9271540e","updated":"2015-02-06 07:11:58.000000000","message":"yes i made changes","commit_id":"ab13c606534fd44180e67f78db10d47253805a77"}],"tempest/api/network/test_floating_ips.py":[{"author":{"_account_id":8623,"name":"Kaitlin Farr","email":"kaitlin.farr@jhuapl.edu","username":"kaitlin.farr"},"change_message_id":"e11eaa1b3492586e33d9428a8068ebfb544ff42b","unresolved":false,"context_lines":[{"line_number":65,"context_line":"            cls.create_port(cls.network)"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":68,"context_line":"    def test_create_list_show_delete_floating_ip_by_admin(self):"},{"line_number":69,"context_line":"        # Creates a floating IP"},{"line_number":70,"context_line":"        _, body \u003d self.admin_client.create_floatingip("},{"line_number":71,"context_line":"            floating_network_id\u003dself.ext_net_id,"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a8c0949_3263bddd","line":68,"updated":"2014-11-04 17:52:20.000000000","message":"I don\u0027t think having \"delete\" in the name of this test accurately describes what this test is doing.\n\nProbably something like:\ntest_create_list_show_floating_ip_by_admin\n\nUnless I am misunderstanding, no?","commit_id":"59ff04ff18c6cd222f5e864c7d43046f2092075b"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"d5f4c3cc6f301b39db0675876ea082327e2d65ed","unresolved":false,"context_lines":[{"line_number":23,"context_line":"CONF \u003d config.CONF"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"class FloatingIPTestJSON(base.BaseAdminNetworkTest):"},{"line_number":27,"context_line":"    _interface \u003d \u0027json\u0027"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"5a890539_21b82410","line":26,"updated":"2014-11-18 13:09:34.000000000","message":"Unnecessary change.","commit_id":"7e4b17a19f0e1d7396d9c71e59a7ab7e43aa1275"},{"author":{"_account_id":13342,"name":"Abhishek G M","email":"abhishek.gm@hpe.com","username":"abhishek60014726"},"change_message_id":"b18284ff88b2d953a9c99444a4deb0b893e65191","unresolved":false,"context_lines":[{"line_number":23,"context_line":"CONF \u003d config.CONF"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"class FloatingIPTestJSON(base.BaseAdminNetworkTest):"},{"line_number":27,"context_line":"    _interface \u003d \u0027json\u0027"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"5a890539_9da54149","line":26,"in_reply_to":"5a890539_21b82410","updated":"2014-11-21 09:52:29.000000000","message":"i removed those changes","commit_id":"7e4b17a19f0e1d7396d9c71e59a7ab7e43aa1275"}]}