)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"e2a656f4d3fb117ee5fa6eacc2f3a2838e778945","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This is the new standard for tests that use the api client."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"See also: https://review.openstack.org/#/c/115971/"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I309084ab0d13fa3bf3a84dcbe4ddee5b24284b66"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"5a890539_ab7ff7a9","line":11,"updated":"2014-11-14 04:14:38.000000000","message":"We use Change-Id instead of URL for the patch link usually. So I think this should be \n See also: I07316db1f51d0562919ed2a50f002011944bfdb1","commit_id":"731ad3abc5d70d79e070ed32ac1ac7d8eb76e788"}],"tempest/api/object_storage/test_container_services.py":[{"author":{"_account_id":8859,"name":"Daisuke Morita","email":"morita.daisuke@ntti3.com","username":"morrisson"},"change_message_id":"d330c67c28985f9f7c958fe66131fca5b24989bf","unresolved":false,"context_lines":[{"line_number":149,"context_line":"        # delete container"},{"line_number":150,"context_line":"        resp, _ \u003d self.container_client.delete_container(container_name)"},{"line_number":151,"context_line":"        self.assertIn(int(resp[\u0027status\u0027]), test.HTTP_SUCCESS)"},{"line_number":152,"context_line":"        self.assertHeaders(resp, \u0027Container\u0027, \u0027DELETE\u0027)"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"        self.containers.remove(container_name)"},{"line_number":155,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5a890539_056ea601","side":"PARENT","line":152,"updated":"2014-11-11 04:06:52.000000000","message":"You must remain unmodified this header checker.","commit_id":"f306a23a8b688a2c0cecb89dee938f72aa4c8f0d"},{"author":{"_account_id":8576,"name":"Yair Fried","email":"yfried@redhat.com","username":"yfried"},"change_message_id":"439f048f6b45e5977c68120d24888f311364fd2c","unresolved":false,"context_lines":[{"line_number":149,"context_line":"        # delete container"},{"line_number":150,"context_line":"        resp, _ \u003d self.container_client.delete_container(container_name)"},{"line_number":151,"context_line":"        self.assertIn(int(resp[\u0027status\u0027]), test.HTTP_SUCCESS)"},{"line_number":152,"context_line":"        self.assertHeaders(resp, \u0027Container\u0027, \u0027DELETE\u0027)"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"        self.containers.remove(container_name)"},{"line_number":155,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5a890539_6bc1f97f","side":"PARENT","line":152,"in_reply_to":"5a890539_056ea601","updated":"2014-11-11 07:01:49.000000000","message":"well, if this checker is necessary, shouldn\u0027t it go in the client?","commit_id":"f306a23a8b688a2c0cecb89dee938f72aa4c8f0d"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"68ccf675bcc763bb9b33459052d4182f59bc79c9","unresolved":false,"context_lines":[{"line_number":149,"context_line":"        # delete container"},{"line_number":150,"context_line":"        resp, _ \u003d self.container_client.delete_container(container_name)"},{"line_number":151,"context_line":"        self.assertIn(int(resp[\u0027status\u0027]), test.HTTP_SUCCESS)"},{"line_number":152,"context_line":"        self.assertHeaders(resp, \u0027Container\u0027, \u0027DELETE\u0027)"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"        self.containers.remove(container_name)"},{"line_number":155,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5a890539_ab202ef8","side":"PARENT","line":152,"in_reply_to":"5a890539_0b5b1588","updated":"2014-11-11 19:18:06.000000000","message":"I\u0027ve had a look around at some of the other clients that are already using expected_success and from what I can see that is the only assertion that is being done in the client. There are no tests for header validation.\n\nI would be uncomfortable moving addition assertions into that domain, so fo r now I will have the client return the usual data and leave the assertHeaders assertion.","commit_id":"f306a23a8b688a2c0cecb89dee938f72aa4c8f0d"},{"author":{"_account_id":8859,"name":"Daisuke Morita","email":"morita.daisuke@ntti3.com","username":"morrisson"},"change_message_id":"7d5b5a0316dd786fc4f15e7e4491ab78b5344173","unresolved":false,"context_lines":[{"line_number":149,"context_line":"        # delete container"},{"line_number":150,"context_line":"        resp, _ \u003d self.container_client.delete_container(container_name)"},{"line_number":151,"context_line":"        self.assertIn(int(resp[\u0027status\u0027]), test.HTTP_SUCCESS)"},{"line_number":152,"context_line":"        self.assertHeaders(resp, \u0027Container\u0027, \u0027DELETE\u0027)"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"        self.containers.remove(container_name)"},{"line_number":155,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5a890539_0b5b1588","side":"PARENT","line":152,"in_reply_to":"5a890539_6bc1f97f","updated":"2014-11-11 07:38:16.000000000","message":"This checker is necessary. It seems OK for me to migrate this code into the client, but, you should do that change in another commit for all test cases. So, in this commit, you must leave this sentence unmodified.","commit_id":"f306a23a8b688a2c0cecb89dee938f72aa4c8f0d"}]}