)]}'
{"tempest/api/network/base.py":[{"author":{"_account_id":8576,"name":"Yair Fried","email":"yfried@redhat.com","username":"yfried"},"change_message_id":"7106966e64ebabfd369d1bd9cb7399be6e1b0d3d","unresolved":false,"context_lines":[{"line_number":275,"context_line":"    @classmethod"},{"line_number":276,"context_line":"    def create_member(cls, protocol_port, pool, ip_version\u003dNone):"},{"line_number":277,"context_line":"        \"\"\"Wrapper utility that returns a test member.\"\"\""},{"line_number":278,"context_line":"        ip_version \u003d ip_version if ip_version is not None else cls._ip_version"},{"line_number":279,"context_line":"        member_address \u003d \"fd00::abcd\" if ip_version \u003d\u003d 6 else \"10.0.9.46\""},{"line_number":280,"context_line":"        resp, body \u003d cls.client.create_member(address\u003dmember_address,"},{"line_number":281,"context_line":"                                              protocol_port\u003dprotocol_port,"}],"source_content_type":"text/x-python","patch_set":7,"id":"5a890539_f0ad0c32","line":278,"updated":"2014-11-18 12:15:08.000000000","message":"unless we are considering ip_version\u003d0 as a valid input:\nip_version \u003d ip_version or cls._ip_version","commit_id":"97e6a0f0efb0a0e4e6c6dc170b03e49c4e1cb7e2"}],"tempest/api/network/test_allowed_address_pair.py":[{"author":{"_account_id":12632,"name":"Kirill Shileev","email":"kshileev@cisco.com","username":"kshileev"},"change_message_id":"796467c97aac97121c5888f6976c4591c015ea0b","unresolved":false,"context_lines":[{"line_number":101,"context_line":"    _ip_version \u003d 6"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"    @classmethod"},{"line_number":104,"context_line":"    def resource_setup(cls):"},{"line_number":105,"context_line":"        if not CONF.network_feature_enabled.ipv6:"},{"line_number":106,"context_line":"            skip_msg \u003d \"IPv6 Tests are disabled.\""},{"line_number":107,"context_line":"            raise cls.skipException(skip_msg)"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a890539_20115e5d","line":104,"updated":"2014-11-14 10:10:35.000000000","message":"the same code is repeated in all your tests. better to put it in BaseNetworkTest. This way all your tests will be 2 liners:\nclass XXX(base.YYYY):\n    _ip_version \u003d 6","commit_id":"c76a715e86af9c35bc504b7d766eecb648874007"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"6fd700705529827f4e37944accb6be2536a1b7d2","unresolved":false,"context_lines":[{"line_number":101,"context_line":"    _ip_version \u003d 6"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"    @classmethod"},{"line_number":104,"context_line":"    def resource_setup(cls):"},{"line_number":105,"context_line":"        if not CONF.network_feature_enabled.ipv6:"},{"line_number":106,"context_line":"            skip_msg \u003d \"IPv6 Tests are disabled.\""},{"line_number":107,"context_line":"            raise cls.skipException(skip_msg)"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a890539_4daa1e86","line":104,"in_reply_to":"5a890539_20115e5d","updated":"2014-11-14 11:47:04.000000000","message":"Done","commit_id":"c76a715e86af9c35bc504b7d766eecb648874007"}],"tempest/api/network/test_extra_dhcp_options.py":[{"author":{"_account_id":8576,"name":"Yair Fried","email":"yfried@redhat.com","username":"yfried"},"change_message_id":"7106966e64ebabfd369d1bd9cb7399be6e1b0d3d","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        cls.subnet \u003d cls.create_subnet(cls.network)"},{"line_number":46,"context_line":"        cls.port \u003d cls.create_port(cls.network)"},{"line_number":47,"context_line":"        cls.ip_tftp \u003d (\u0027123.123.123.123\u0027 if cls._ip_version \u003d\u003d 4"},{"line_number":48,"context_line":"                       else \u00272015::dead\u0027)"},{"line_number":49,"context_line":"        cls.ip_server \u003d (\u0027123.123.123.45\u0027 if cls._ip_version \u003d\u003d 4"},{"line_number":50,"context_line":"                         else \u00272015::badd\u0027)"},{"line_number":51,"context_line":"        cls.extra_dhcp_opts \u003d ["}],"source_content_type":"text/x-python","patch_set":7,"id":"5a890539_b06f04fb","line":48,"updated":"2014-11-18 12:15:08.000000000","message":"nice hexa nums :)","commit_id":"97e6a0f0efb0a0e4e6c6dc170b03e49c4e1cb7e2"},{"author":{"_account_id":8576,"name":"Yair Fried","email":"yfried@redhat.com","username":"yfried"},"change_message_id":"7106966e64ebabfd369d1bd9cb7399be6e1b0d3d","unresolved":false,"context_lines":[{"line_number":47,"context_line":"        cls.ip_tftp \u003d (\u0027123.123.123.123\u0027 if cls._ip_version \u003d\u003d 4"},{"line_number":48,"context_line":"                       else \u00272015::dead\u0027)"},{"line_number":49,"context_line":"        cls.ip_server \u003d (\u0027123.123.123.45\u0027 if cls._ip_version \u003d\u003d 4"},{"line_number":50,"context_line":"                         else \u00272015::badd\u0027)"},{"line_number":51,"context_line":"        cls.extra_dhcp_opts \u003d ["},{"line_number":52,"context_line":"            {\u0027opt_value\u0027: \u0027pxelinux.0\u0027, \u0027opt_name\u0027: \u0027bootfile-name\u0027},"},{"line_number":53,"context_line":"            {\u0027opt_value\u0027: cls.ip_tftp, \u0027opt_name\u0027: \u0027tftp-server\u0027},"}],"source_content_type":"text/x-python","patch_set":7,"id":"5a890539_d079f0c8","line":50,"updated":"2014-11-18 12:15:08.000000000","message":"same here :)","commit_id":"97e6a0f0efb0a0e4e6c6dc170b03e49c4e1cb7e2"}],"tempest/api/network/test_metering_extensions.py":[{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"36dbb4302ce961406c7060eb0ec8f5cfa60cac4c","unresolved":false,"context_lines":[{"line_number":19,"context_line":"from tempest.openstack.common import log as logging"},{"line_number":20,"context_line":"from tempest import test"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"5a890539_1b9da766","side":"PARENT","line":22,"updated":"2014-11-14 16:31:59.000000000","message":"unrelated change.","commit_id":"1e6d39ebff98647e650cea9d6ac6c84f5b8e972c"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"4e3df7187251bb805af75a373f4a54d0639ad0a1","unresolved":false,"context_lines":[{"line_number":19,"context_line":"from tempest.openstack.common import log as logging"},{"line_number":20,"context_line":"from tempest import test"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"5a890539_fbf61b8e","side":"PARENT","line":22,"in_reply_to":"5a890539_1b9da766","updated":"2014-11-14 16:35:47.000000000","message":"Done","commit_id":"1e6d39ebff98647e650cea9d6ac6c84f5b8e972c"},{"author":{"_account_id":8576,"name":"Yair Fried","email":"yfried@redhat.com","username":"yfried"},"change_message_id":"7106966e64ebabfd369d1bd9cb7399be6e1b0d3d","unresolved":false,"context_lines":[{"line_number":43,"context_line":"        description \u003d \"metering label created by tempest\""},{"line_number":44,"context_line":"        name \u003d data_utils.rand_name(\"metering-label\")"},{"line_number":45,"context_line":"        cls.metering_label \u003d cls.create_metering_label(name, description)"},{"line_number":46,"context_line":"        remote_ip_prefix \u003d (\"10.0.0.0/24\" if cls._ip_version \u003d\u003d 4"},{"line_number":47,"context_line":"                            else \"fd02::/64\")"},{"line_number":48,"context_line":"        direction \u003d \"ingress\""},{"line_number":49,"context_line":"        cls.metering_label_rule \u003d cls.create_metering_label_rule("}],"source_content_type":"text/x-python","patch_set":7,"id":"5a890539_1b455942","line":46,"updated":"2014-11-18 12:15:08.000000000","message":"make this into cls.remote_ip_prefix to be used later","commit_id":"97e6a0f0efb0a0e4e6c6dc170b03e49c4e1cb7e2"},{"author":{"_account_id":12632,"name":"Kirill Shileev","email":"kshileev@cisco.com","username":"kshileev"},"change_message_id":"97520036d1ae63605b791de6db6775ab18ee76a3","unresolved":false,"context_lines":[{"line_number":43,"context_line":"        description \u003d \"metering label created by tempest\""},{"line_number":44,"context_line":"        name \u003d data_utils.rand_name(\"metering-label\")"},{"line_number":45,"context_line":"        cls.metering_label \u003d cls.create_metering_label(name, description)"},{"line_number":46,"context_line":"        remote_ip_prefix \u003d (\"10.0.0.0/24\" if cls._ip_version \u003d\u003d 4"},{"line_number":47,"context_line":"                            else \"fd02::/64\")"},{"line_number":48,"context_line":"        direction \u003d \"ingress\""},{"line_number":49,"context_line":"        cls.metering_label_rule \u003d cls.create_metering_label_rule("}],"source_content_type":"text/x-python","patch_set":7,"id":"5a890539_c1b12048","line":46,"in_reply_to":"5a890539_1b455942","updated":"2014-11-18 13:07:45.000000000","message":"Why? the only inheritor is MeteringXML which is deprecated.","commit_id":"97e6a0f0efb0a0e4e6c6dc170b03e49c4e1cb7e2"},{"author":{"_account_id":8576,"name":"Yair Fried","email":"yfried@redhat.com","username":"yfried"},"change_message_id":"7106966e64ebabfd369d1bd9cb7399be6e1b0d3d","unresolved":false,"context_lines":[{"line_number":113,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":114,"context_line":"    def test_create_delete_metering_label_rule_with_filters(self):"},{"line_number":115,"context_line":"        # Creates a rule"},{"line_number":116,"context_line":"        remote_ip_prefix \u003d (\"10.0.1.0/24\" if self._ip_version \u003d\u003d 4"},{"line_number":117,"context_line":"                            else \"fd03::/64\")"},{"line_number":118,"context_line":"        _, body \u003d (self.admin_client.create_metering_label_rule("},{"line_number":119,"context_line":"                   remote_ip_prefix\u003dremote_ip_prefix,"}],"source_content_type":"text/x-python","patch_set":7,"id":"5a890539_7b6d7dcb","line":116,"updated":"2014-11-18 12:15:08.000000000","message":"see above","commit_id":"97e6a0f0efb0a0e4e6c6dc170b03e49c4e1cb7e2"}]}
