)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"568de6b1a258c0243dc6a05d082c3b336b6d4bcc","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Test case to create ipsec-site-connection-API"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Delete ipsec-site-connection"},{"line_number":10,"context_line":"Create ipsec-site-connection"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ic866b685431d157cafc31e7588e30f7e990e71da"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5a890539_bb6c80d1","line":10,"updated":"2014-11-15 20:37:44.000000000","message":"It\u0027s better to write what is checked in test than just actions.","commit_id":"6f5dd6a8bf72a2d42d2866a57fb5e93042240145"}],"tempest/api/network/base.py":[{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"568de6b1a258c0243dc6a05d082c3b336b6d4bcc","unresolved":false,"context_lines":[{"line_number":145,"context_line":"            # Clean up ipsec-site-connection"},{"line_number":146,"context_line":"            for ipsec_site_connection in cls.ipsec_site_connections:"},{"line_number":147,"context_line":"                cls.client.delete_ipsec_site_connection("},{"line_number":148,"context_line":"                    ipsec_site_connection[\u0027id\u0027])"},{"line_number":149,"context_line":"            cls.clear_isolated_creds()"},{"line_number":150,"context_line":"        super(BaseNetworkTest, cls).resource_cleanup()"},{"line_number":151,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5a890539_7b7698a5","line":148,"updated":"2014-11-15 20:37:44.000000000","message":"I suspect that ipsec connections should be deleted before routers, ports and subnets that participate in it","commit_id":"6f5dd6a8bf72a2d42d2866a57fb5e93042240145"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"3d3fa567e4b036659567d40ebe09b8c23e1a65a8","unresolved":false,"context_lines":[{"line_number":94,"context_line":"        if CONF.service_available.neutron:"},{"line_number":95,"context_line":"            # Clean up ipsec-site-connection"},{"line_number":96,"context_line":"            for ipsec_site_connection in cls.ipsec_site_connections:"},{"line_number":97,"context_line":"                cls._try_delete_resource(client.delete_ipsec_site_connection,"},{"line_number":98,"context_line":"                                         ipsec_site_connection[\u0027id\u0027])"},{"line_number":99,"context_line":"            # Clean up ipsec policies"},{"line_number":100,"context_line":"            for ipsecpolicy in cls.ipsecpolicies:"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a890539_23f987c8","line":97,"updated":"2014-11-21 13:32:53.000000000","message":"client -\u003e cls.client, see pep-8 complains in failed job","commit_id":"02f72536970059e547a1555f418bd2f2bdfa13f6"}],"tempest/api/network/test_vpnaas_extensions.py":[{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"3d3fa567e4b036659567d40ebe09b8c23e1a65a8","unresolved":false,"context_lines":[{"line_number":319,"context_line":"    def test_create_ipsec_site_connection(self):"},{"line_number":320,"context_line":"        # Verifies the creation of ipsec-site-connection"},{"line_number":321,"context_line":"        name \u003d data_utils.rand_name(\u0027ipsec-site-connection-\u0027)"},{"line_number":322,"context_line":"        cidr \u003d str(netaddr.IPNetwork(CONF.network.tenant_network_cidr))"},{"line_number":323,"context_line":"        seq \u003d (cidr.split(\"/\")[0]).split(\u0027.\u0027)"},{"line_number":324,"context_line":"        ip_address \u003d (seq[0], seq[1], seq[2], \"4\")"},{"line_number":325,"context_line":"        ip_address \u003d \".\".join(ip_address)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a890539_c3a443bb","line":322,"updated":"2014-11-21 13:32:53.000000000","message":"what if it\u0027s IPv6 network? I\u0027d suggest to extract cidr to resource setup:\n\n  if cls._ip_version \u003d\u003d 4:\n      cidr \u003d CONF.network.tenant_network_cidr\n  else:\n      cidr \u003d CONF.network.tenant_network_v6_cidr","commit_id":"02f72536970059e547a1555f418bd2f2bdfa13f6"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"3d3fa567e4b036659567d40ebe09b8c23e1a65a8","unresolved":false,"context_lines":[{"line_number":320,"context_line":"        # Verifies the creation of ipsec-site-connection"},{"line_number":321,"context_line":"        name \u003d data_utils.rand_name(\u0027ipsec-site-connection-\u0027)"},{"line_number":322,"context_line":"        cidr \u003d str(netaddr.IPNetwork(CONF.network.tenant_network_cidr))"},{"line_number":323,"context_line":"        seq \u003d (cidr.split(\"/\")[0]).split(\u0027.\u0027)"},{"line_number":324,"context_line":"        ip_address \u003d (seq[0], seq[1], seq[2], \"4\")"},{"line_number":325,"context_line":"        ip_address \u003d \".\".join(ip_address)"},{"line_number":326,"context_line":"        psk \u003d \"secret\""}],"source_content_type":"text/x-python","patch_set":2,"id":"5a890539_4390534e","line":323,"updated":"2014-11-21 13:32:53.000000000","message":"See above and use netaddr, please.","commit_id":"02f72536970059e547a1555f418bd2f2bdfa13f6"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"3d3fa567e4b036659567d40ebe09b8c23e1a65a8","unresolved":false,"context_lines":[{"line_number":322,"context_line":"        cidr \u003d str(netaddr.IPNetwork(CONF.network.tenant_network_cidr))"},{"line_number":323,"context_line":"        seq \u003d (cidr.split(\"/\")[0]).split(\u0027.\u0027)"},{"line_number":324,"context_line":"        ip_address \u003d (seq[0], seq[1], seq[2], \"4\")"},{"line_number":325,"context_line":"        ip_address \u003d \".\".join(ip_address)"},{"line_number":326,"context_line":"        psk \u003d \"secret\""},{"line_number":327,"context_line":"        _, body \u003d self.client.create_ipsec_site_connection("},{"line_number":328,"context_line":"            name\u003dname, vpnservice_id\u003dself.vpnservice[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a890539_43ccd361","line":325,"updated":"2014-11-21 13:32:53.000000000","message":"with netaddr it\u0027s better: \n  ip_address \u003d str(netaddr.IPNetwork(cidr).ip + 4)\n\nif you need exactly \"4\" (why, btw?)","commit_id":"02f72536970059e547a1555f418bd2f2bdfa13f6"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"3d3fa567e4b036659567d40ebe09b8c23e1a65a8","unresolved":false,"context_lines":[{"line_number":339,"context_line":"        self.assertEqual(self.vpnservice[\u0027id\u0027],"},{"line_number":340,"context_line":"                         body[\u0027ipsec_site_connection\u0027][\u0027vpnservice_id\u0027])"},{"line_number":341,"context_line":"        self.assertEqual(ip_address,"},{"line_number":342,"context_line":"                         body[\u0027ipsec_site_connection\u0027][\u0027peer_address\u0027])"},{"line_number":343,"context_line":"        self.client.delete_ipsec_site_connection("},{"line_number":344,"context_line":"            body[\u0027ipsec_site_connection\u0027][\u0027id\u0027])"},{"line_number":345,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5a890539_03100ba7","line":342,"updated":"2014-11-21 13:32:53.000000000","message":"all these asserts could be simplified because you already have all these arguments and dictionary in body. I\u0027d suggest to compare it in one line together","commit_id":"02f72536970059e547a1555f418bd2f2bdfa13f6"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"3d3fa567e4b036659567d40ebe09b8c23e1a65a8","unresolved":false,"context_lines":[{"line_number":341,"context_line":"        self.assertEqual(ip_address,"},{"line_number":342,"context_line":"                         body[\u0027ipsec_site_connection\u0027][\u0027peer_address\u0027])"},{"line_number":343,"context_line":"        self.client.delete_ipsec_site_connection("},{"line_number":344,"context_line":"            body[\u0027ipsec_site_connection\u0027][\u0027id\u0027])"},{"line_number":345,"context_line":""},{"line_number":346,"context_line":""},{"line_number":347,"context_line":"class VPNaaSTestXML(VPNaaSTestJSON):"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a890539_c37c43ee","line":344,"updated":"2014-11-21 13:32:53.000000000","message":"If you want to check delete, you should check if it\u0027s present in site connections. If you don\u0027t want to check, you don\u0027t need this line - you have a resource cleanup.","commit_id":"02f72536970059e547a1555f418bd2f2bdfa13f6"}],"tempest/services/network/network_client_base.py":[{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"3d3fa567e4b036659567d40ebe09b8c23e1a65a8","unresolved":false,"context_lines":[{"line_number":37,"context_line":"    \u0027metering_label_rules\u0027: \u0027metering\u0027,"},{"line_number":38,"context_line":"    \u0027firewall_rules\u0027: \u0027fw\u0027,"},{"line_number":39,"context_line":"    \u0027firewall_policies\u0027: \u0027fw\u0027,"},{"line_number":40,"context_line":"    \u0027firewalls\u0027: \u0027fw\u0027,"},{"line_number":41,"context_line":"    \u0027ipsec_site_connections\u0027: \u0027vpn\u0027"},{"line_number":42,"context_line":"}"},{"line_number":43,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5a890539_a3c73711","line":40,"updated":"2014-11-21 13:32:53.000000000","message":"could you explain please why do you need \"firewall\" here? I didn\u0027t see anything with fw yet, thanks.","commit_id":"02f72536970059e547a1555f418bd2f2bdfa13f6"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"3d3fa567e4b036659567d40ebe09b8c23e1a65a8","unresolved":false,"context_lines":[{"line_number":54,"context_line":"    \u0027ikepolicy\u0027: \u0027ikepolicies\u0027,"},{"line_number":55,"context_line":"    \u0027ipsecpolicy\u0027: \u0027ipsecpolicies\u0027,"},{"line_number":56,"context_line":"    \u0027quotas\u0027: \u0027quotas\u0027,"},{"line_number":57,"context_line":"    \u0027firewall_policy\u0027: \u0027firewall_policies\u0027,"},{"line_number":58,"context_line":"    \u0027ipsec_site_connection\u0027: \u0027ipsec_site_connections\u0027"},{"line_number":59,"context_line":"}"},{"line_number":60,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5a890539_23db47ee","line":57,"updated":"2014-11-21 13:32:53.000000000","message":"the same question about firewall, please","commit_id":"02f72536970059e547a1555f418bd2f2bdfa13f6"}]}