)]}'
{"tempest/scenario/manager.py":[{"author":{"_account_id":12378,"name":"Richard Winters","email":"riwinter@cisco.com","username":"riwinter"},"change_message_id":"7adc63b5f99b4c161688f97f37d3aa5a80f46b4e","unresolved":false,"context_lines":[{"line_number":318,"context_line":"            raise"},{"line_number":319,"context_line":"        except Exception:"},{"line_number":320,"context_line":"            LOG.exception(\u0027Initializing SSH connection failed\u0027)"},{"line_number":321,"context_line":"            self._log_console_output()"},{"line_number":322,"context_line":"            raise"},{"line_number":323,"context_line":""},{"line_number":324,"context_line":"        return linux_client"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a890539_a8cc1e8a","line":321,"updated":"2014-11-17 13:36:00.000000000","message":"The test_volume_boot_pattern exception handler adds servers\u003d[server] self._log_console_output(servers\u003d[server]) - this change will remove that.  I\u0027d rather add it to all then remove it for one.","commit_id":"7a6015722520e67e41aa8e82867e42299e6b29c1"},{"author":{"_account_id":12378,"name":"Richard Winters","email":"riwinter@cisco.com","username":"riwinter"},"change_message_id":"83f43ba36f52ca86576449024fdb1ebd6ef3f638","unresolved":false,"context_lines":[{"line_number":318,"context_line":"            raise"},{"line_number":319,"context_line":"        except Exception:"},{"line_number":320,"context_line":"            LOG.exception(\u0027Initializing SSH connection failed\u0027)"},{"line_number":321,"context_line":"            self._log_console_output()"},{"line_number":322,"context_line":"            raise"},{"line_number":323,"context_line":""},{"line_number":324,"context_line":"        return linux_client"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a890539_46dbaa7b","line":321,"in_reply_to":"5a890539_2370500a","updated":"2014-11-17 14:47:23.000000000","message":"Ah yes - I see, thanks","commit_id":"7a6015722520e67e41aa8e82867e42299e6b29c1"},{"author":{"_account_id":8576,"name":"Yair Fried","email":"yfried@redhat.com","username":"yfried"},"change_message_id":"ab8ebf885492b246337c96053b49f51e763a8424","unresolved":false,"context_lines":[{"line_number":318,"context_line":"            raise"},{"line_number":319,"context_line":"        except Exception:"},{"line_number":320,"context_line":"            LOG.exception(\u0027Initializing SSH connection failed\u0027)"},{"line_number":321,"context_line":"            self._log_console_output()"},{"line_number":322,"context_line":"            raise"},{"line_number":323,"context_line":""},{"line_number":324,"context_line":"        return linux_client"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a890539_f0e42c0e","line":321,"in_reply_to":"5a890539_46dbaa7b","updated":"2014-11-18 11:59:17.000000000","message":"I suggest adding server\u003dNone to the methods kwargs so user/test can pass down a list of servers to debug","commit_id":"7a6015722520e67e41aa8e82867e42299e6b29c1"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"3c7adfb4a0257096517b15552a5e96ef96f7bda3","unresolved":false,"context_lines":[{"line_number":318,"context_line":"            raise"},{"line_number":319,"context_line":"        except Exception:"},{"line_number":320,"context_line":"            LOG.exception(\u0027Initializing SSH connection failed\u0027)"},{"line_number":321,"context_line":"            self._log_console_output()"},{"line_number":322,"context_line":"            raise"},{"line_number":323,"context_line":""},{"line_number":324,"context_line":"        return linux_client"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a890539_2370500a","line":321,"in_reply_to":"5a890539_a8cc1e8a","updated":"2014-11-17 14:37:09.000000000","message":"If you take a look at the definition of _log_console_output(), you\u0027ll see that if the \"servers\" parameter is not set, then the console of every found servers will be logged. So, just to be safe, we should not set \"servers\u003d[server]\" here because it will be a subset of what was logged before this patch and we would loose some info.\n\nDo you agree ?","commit_id":"7a6015722520e67e41aa8e82867e42299e6b29c1"},{"author":{"_account_id":8576,"name":"Yair Fried","email":"yfried@redhat.com","username":"yfried"},"change_message_id":"a11385fb05c05ab9621bb32ce6e4f3c9f9e2b89a","unresolved":false,"context_lines":[{"line_number":298,"context_line":"        return secgroup"},{"line_number":299,"context_line":""},{"line_number":300,"context_line":"    def get_remote_client(self, server_or_ip, username\u003dNone, private_key\u003dNone,"},{"line_number":301,"context_line":"                          log_console_of_servers\u003dNone):"},{"line_number":302,"context_line":"        if isinstance(server_or_ip, six.string_types):"},{"line_number":303,"context_line":"            ip \u003d server_or_ip"},{"line_number":304,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a890539_5b1e0171","line":301,"updated":"2014-11-18 12:39:05.000000000","message":"this is becoming non-trivial. please add docstring for the method\u0027s arguments and exceptions","commit_id":"f0d72c9a5a85707ea4a5f919e6ea92aa2d97bcde"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"4cb9c97a53cd2063ceb365808e506de2dd8d60c9","unresolved":false,"context_lines":[{"line_number":324,"context_line":"            # See the definition of _log_console_output()"},{"line_number":325,"context_line":"            self._log_console_output(log_console_of_servers)"},{"line_number":326,"context_line":"            raise"},{"line_number":327,"context_line":""},{"line_number":328,"context_line":"        return linux_client"},{"line_number":329,"context_line":""},{"line_number":330,"context_line":"    def _image_create(self, name, fmt, path, properties\u003dNone):"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a890539_15a69310","line":327,"updated":"2014-11-21 02:21:21.000000000","message":"w.r.t. my comments in next files, can we do something like-\n\ndef get_remote_client(self, server_or_ip, username\u003dNone, private_key\u003dNone,\t\n                          log_console_of_servers\u003dNone, network_debug_log\u003dfalse):\n\nreplace L326 - 326 with \n\n    except Exception as e:\n            LOG.exception(\u0027Initializing SSH connection failed\u0027)\n            # If we don\u0027t explicitely set for which servers we want to \t\n            # log the console output then all the servers will be logged. \t\n            # See the definition of _log_console_output() \t\n            self._log_console_output(log_console_of_servers)\n\n            if isinstance(e, test.exceptions.SSHTimeout) or network_debug_log:\n                LOG.exception(\u0027ssh connection to %s failed\u0027 % ip)   \n                debug.log_net_debug() \t\n            raise\n\nThis will going to handle all original case.","commit_id":"f0d72c9a5a85707ea4a5f919e6ea92aa2d97bcde"},{"author":{"_account_id":8576,"name":"Yair Fried","email":"yfried@redhat.com","username":"yfried"},"change_message_id":"76b38232e465cfd9c11d855be3a1bf0f79891527","unresolved":false,"context_lines":[{"line_number":298,"context_line":"        return secgroup"},{"line_number":299,"context_line":""},{"line_number":300,"context_line":"    def get_remote_client(self, server_or_ip, username\u003dNone, private_key\u003dNone,"},{"line_number":301,"context_line":"                          log_console_of_servers\u003dNone):"},{"line_number":302,"context_line":"        if isinstance(server_or_ip, six.string_types):"},{"line_number":303,"context_line":"            ip \u003d server_or_ip"},{"line_number":304,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a890539_3f75b3f9","line":301,"updated":"2014-11-25 20:41:25.000000000","message":"I\u0027d still like to see a docstring for this method","commit_id":"db96ec2d8b0bd97e829b9da7af160e8acecf175b"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"93ff1d81df2785c57aca89bc58df8517805717fa","unresolved":false,"context_lines":[{"line_number":298,"context_line":"        return secgroup"},{"line_number":299,"context_line":""},{"line_number":300,"context_line":"    def get_remote_client(self, server_or_ip, username\u003dNone, private_key\u003dNone,"},{"line_number":301,"context_line":"                          log_console_of_servers\u003dNone):"},{"line_number":302,"context_line":"        if isinstance(server_or_ip, six.string_types):"},{"line_number":303,"context_line":"            ip \u003d server_or_ip"},{"line_number":304,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a890539_aa5951fe","line":301,"in_reply_to":"5a890539_3f75b3f9","updated":"2014-11-26 08:29:31.000000000","message":"I agree with Yair. it will be good if you can add doc string.","commit_id":"db96ec2d8b0bd97e829b9da7af160e8acecf175b"}],"tempest/scenario/orchestration/test_server_cfn_init.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"4cb9c97a53cd2063ceb365808e506de2dd8d60c9","unresolved":false,"context_lines":[{"line_number":120,"context_line":"            # Check that the user can authenticate with the generated"},{"line_number":121,"context_line":"            # keypair"},{"line_number":122,"context_line":"            self.get_remote_client(server_ip, username\u003d\u0027ec2-user\u0027,"},{"line_number":123,"context_line":"                                   log_console_of_servers\u003d[server])"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"    @test.attr(type\u003d\u0027slow\u0027)"},{"line_number":126,"context_line":"    @test.services(\u0027orchestration\u0027, \u0027compute\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a890539_753c37c0","line":123,"updated":"2014-11-21 02:21:21.000000000","message":"In original code, console output was logged for exceptions.SSHTimeout too. But now it will not.","commit_id":"f0d72c9a5a85707ea4a5f919e6ea92aa2d97bcde"}],"tempest/scenario/test_minimum_basic.py":[{"author":{"_account_id":8576,"name":"Yair Fried","email":"yfried@redhat.com","username":"yfried"},"change_message_id":"ab8ebf885492b246337c96053b49f51e763a8424","unresolved":false,"context_lines":[{"line_number":98,"context_line":"        self.floating_ips_client.associate_floating_ip_to_server("},{"line_number":99,"context_line":"            self.floating_ip[\u0027ip\u0027], self.server[\u0027id\u0027])"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"    def ssh_to_server(self):"},{"line_number":102,"context_line":"        self.linux_client \u003d self.get_remote_client(self.floating_ip[\u0027ip\u0027])"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"    def check_partitions(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a890539_905768c9","line":101,"updated":"2014-11-18 11:59:17.000000000","message":"please remove methods if they degenerate to one-liners","commit_id":"7a6015722520e67e41aa8e82867e42299e6b29c1"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"4cb9c97a53cd2063ceb365808e506de2dd8d60c9","unresolved":false,"context_lines":[{"line_number":147,"context_line":"        self.nova_floating_ip_add()"},{"line_number":148,"context_line":"        self.create_and_add_security_group()"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"        self.linux_client \u003d self.get_remote_client(self.floating_ip[\u0027ip\u0027])"},{"line_number":151,"context_line":"        self.nova_reboot()"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"        self.linux_client \u003d self.get_remote_client(self.floating_ip[\u0027ip\u0027])"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a890539_b52f7f87","line":150,"updated":"2014-11-21 02:21:21.000000000","message":"In original code, for non exceptions.SSHTimeout also network debugging was called. are you sure we do not want that now?","commit_id":"f0d72c9a5a85707ea4a5f919e6ea92aa2d97bcde"},{"author":{"_account_id":8576,"name":"Yair Fried","email":"yfried@redhat.com","username":"yfried"},"change_message_id":"a11385fb05c05ab9621bb32ce6e4f3c9f9e2b89a","unresolved":false,"context_lines":[{"line_number":147,"context_line":"        self.nova_floating_ip_add()"},{"line_number":148,"context_line":"        self.create_and_add_security_group()"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"        self.linux_client \u003d self.get_remote_client(self.floating_ip[\u0027ip\u0027])"},{"line_number":151,"context_line":"        self.nova_reboot()"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"        self.linux_client \u003d self.get_remote_client(self.floating_ip[\u0027ip\u0027])"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a890539_960be022","line":150,"updated":"2014-11-18 12:39:05.000000000","message":"tnx","commit_id":"f0d72c9a5a85707ea4a5f919e6ea92aa2d97bcde"}],"tempest/scenario/test_server_basic_ops.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"4cb9c97a53cd2063ceb365808e506de2dd8d60c9","unresolved":false,"context_lines":[{"line_number":91,"context_line":"            self.get_remote_client("},{"line_number":92,"context_line":"                server_or_ip\u003dfloating_ip[\u0027ip\u0027],"},{"line_number":93,"context_line":"                username\u003dself.image_utils.ssh_user(self.image_ref),"},{"line_number":94,"context_line":"                private_key\u003dself.keypair[\u0027private_key\u0027])"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"    @test.services(\u0027compute\u0027, \u0027network\u0027)"},{"line_number":97,"context_line":"    def test_server_basicops(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a890539_b515bfe6","line":94,"updated":"2014-11-21 02:21:21.000000000","message":"now in case of SSHTimeout, it will not going to log console output","commit_id":"f0d72c9a5a85707ea4a5f919e6ea92aa2d97bcde"}],"tempest/scenario/test_snapshot_pattern.py":[{"author":{"_account_id":8576,"name":"Yair Fried","email":"yfried@redhat.com","username":"yfried"},"change_message_id":"ab8ebf885492b246337c96053b49f51e763a8424","unresolved":false,"context_lines":[{"line_number":48,"context_line":"        self.keypair \u003d self.create_keypair()"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    def _ssh_to_server(self, server_or_ip):"},{"line_number":51,"context_line":"        return self.get_remote_client(server_or_ip)"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    def _write_timestamp(self, server_or_ip):"},{"line_number":54,"context_line":"        ssh_client \u003d self._ssh_to_server(server_or_ip)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a890539_700bdcd5","line":51,"updated":"2014-11-18 11:59:17.000000000","message":"same here","commit_id":"7a6015722520e67e41aa8e82867e42299e6b29c1"}]}