)]}'
{"tempest/api/compute/servers/test_create_server.py":[{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"83ef3372abe0fb98e9b42bdd6a0deb18f45f4da5","unresolved":false,"context_lines":[{"line_number":202,"context_line":""},{"line_number":203,"context_line":"        def cleanup_server():"},{"line_number":204,"context_line":"            self.client.delete_server(server[\u0027id\u0027])"},{"line_number":205,"context_line":"            self.client.wait_for_server_termination(server[\u0027id\u0027])"},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"        self.addCleanup(cleanup_server)"},{"line_number":208,"context_line":"        params \u003d {\u0027name\u0027: name}"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a890539_566b4f1d","line":205,"updated":"2014-11-17 21:13:47.000000000","message":"Why do you need to wait here ? You are not reusing the server","commit_id":"f353da5df240c6df2edee42d67375f3cd0ab9748"},{"author":{"_account_id":10016,"name":"Joseph Lanoux","email":"joseph.lanoux@hpe.com","username":"lanoux"},"change_message_id":"93d1da801eb691113ffcf1b5b4caa35085eab904","unresolved":false,"context_lines":[{"line_number":202,"context_line":""},{"line_number":203,"context_line":"        def cleanup_server():"},{"line_number":204,"context_line":"            self.client.delete_server(server[\u0027id\u0027])"},{"line_number":205,"context_line":"            self.client.wait_for_server_termination(server[\u0027id\u0027])"},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"        self.addCleanup(cleanup_server)"},{"line_number":208,"context_line":"        params \u003d {\u0027name\u0027: name}"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a890539_3605d513","line":205,"in_reply_to":"5a890539_566b4f1d","updated":"2014-11-18 08:56:57.000000000","message":"The server needs to be deleted in order for the volume to be deleted. Otherwise, the request for the volume deletion occurs when the volume is still in use.","commit_id":"f353da5df240c6df2edee42d67375f3cd0ab9748"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"4e6aeae2b6de1974d0723b15ea73ecf80a56eb09","unresolved":false,"context_lines":[{"line_number":188,"context_line":"        # Create a server and attach a volume with block device mapping v2"},{"line_number":189,"context_line":"        _, extensions \u003d self.extensions_client.list_extensions()"},{"line_number":190,"context_line":"        if \u0027os-block-device-mapping-v2-boot\u0027in map(lambda x: x[\u0027alias\u0027],"},{"line_number":191,"context_line":"                                                   extensions):"},{"line_number":192,"context_line":"            _, self.volume \u003d self.volumes_client.create_volume(1)"},{"line_number":193,"context_line":"            self.addCleanup(self.volumes_client.delete_volume,"},{"line_number":194,"context_line":"                            self.volume[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a890539_ecdd6c71","line":191,"updated":"2014-11-24 23:42:05.000000000","message":"wouldn\u0027t comprehension be better? [x[\u0027alias\u0027] for x in extensions] or something like this.","commit_id":"068a6e002e4b17af1eb8ecab2b69dad8afc0b794"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"4e6aeae2b6de1974d0723b15ea73ecf80a56eb09","unresolved":false,"context_lines":[{"line_number":204,"context_line":"                                                block_device_mapping_v2\u003dbdms,"},{"line_number":205,"context_line":"                                                wait_until\u003d\u0027ACTIVE\u0027)"},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"        def cleanup_server():"},{"line_number":208,"context_line":"            self.client.delete_server(server[\u0027id\u0027])"},{"line_number":209,"context_line":"            self.client.wait_for_server_termination(server[\u0027id\u0027])"},{"line_number":210,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5a890539_8cd6a84d","line":207,"updated":"2014-11-24 23:42:05.000000000","message":"AFAIK functions should be in top. It\u0027s not so common to include function in test.","commit_id":"068a6e002e4b17af1eb8ecab2b69dad8afc0b794"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"4e6aeae2b6de1974d0723b15ea73ecf80a56eb09","unresolved":false,"context_lines":[{"line_number":205,"context_line":"                                                wait_until\u003d\u0027ACTIVE\u0027)"},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"        def cleanup_server():"},{"line_number":208,"context_line":"            self.client.delete_server(server[\u0027id\u0027])"},{"line_number":209,"context_line":"            self.client.wait_for_server_termination(server[\u0027id\u0027])"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"        self.addCleanup(cleanup_server)"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a890539_ac3e0489","line":208,"updated":"2014-11-24 23:42:05.000000000","message":"where do you take \"server\"? you have no arguments","commit_id":"068a6e002e4b17af1eb8ecab2b69dad8afc0b794"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"4e6aeae2b6de1974d0723b15ea73ecf80a56eb09","unresolved":false,"context_lines":[{"line_number":208,"context_line":"            self.client.delete_server(server[\u0027id\u0027])"},{"line_number":209,"context_line":"            self.client.wait_for_server_termination(server[\u0027id\u0027])"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"        self.addCleanup(cleanup_server)"},{"line_number":212,"context_line":"        params \u003d {\u0027name\u0027: name}"},{"line_number":213,"context_line":"        _, body \u003d self.client.list_servers_with_detail(params)"},{"line_number":214,"context_line":"        vol \u003d body[\u0027servers\u0027][0][\u0027os-extended-volumes:volumes_attached\u0027]"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a890539_4cb84011","line":211,"updated":"2014-11-24 23:42:05.000000000","message":"I think you need also server id.","commit_id":"068a6e002e4b17af1eb8ecab2b69dad8afc0b794"}]}