)]}'
{"tempest/api/compute/admin/test_servers.py":[{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"2521ecd27d836aa8a515532f49e9117b528594f6","unresolved":false,"context_lines":[{"line_number":193,"context_line":"        params \u003d {\u0027all_tenants\u0027: \u0027\u0027, \u0027status\u0027: \u0027deleted\u0027, \u0027name\u0027: name}"},{"line_number":194,"context_line":"        _, body \u003d self.client.list_servers_with_detail(params)"},{"line_number":195,"context_line":"        self.assertIsNotNone(body[\u0027servers\u0027][0][\u0027OS-SRV-USG:launched_at\u0027])"},{"line_number":196,"context_line":"        self.assertIsNotNone(body[\u0027servers\u0027][0][\u0027OS-SRV-USG:terminated_at\u0027])"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"class ServersAdminTestXML(ServersAdminTestJSON):"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a890539_00e774e5","line":196,"updated":"2014-11-19 14:31:56.000000000","message":"assertIsNotNone is too broad. It should be a date so you should be able to test that it looks like a date, maybe parse the thing.","commit_id":"0f141a3167484c0ceafd6c1c6e97b069d5da631d"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"9d53aa4d20050e22ef534cf9004738b49db9f4fc","unresolved":false,"context_lines":[{"line_number":195,"context_line":"        params \u003d {\u0027all_tenants\u0027: \u0027\u0027, \u0027status\u0027: \u0027deleted\u0027, \u0027name\u0027: name}"},{"line_number":196,"context_line":"        _, body \u003d self.client.list_servers_with_detail(params)"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"        if self._interface \u003d\u003d \u0027xml\u0027:"},{"line_number":199,"context_line":"            self.assertTrue(time.strptime("},{"line_number":200,"context_line":"                            body[\u0027servers\u0027][0][\u0027OS-SRV-USG:launched_at\u0027],"},{"line_number":201,"context_line":"                            \u0027%Y-%m-%d %H:%M:%S\u0027))"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a890539_d0b29905","line":198,"updated":"2014-11-27 22:31:02.000000000","message":"I think we don\u0027t have xml anymore.","commit_id":"87bfde96712fb10f0e59d3dc346f3ce06c556b4e"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"9d53aa4d20050e22ef534cf9004738b49db9f4fc","unresolved":false,"context_lines":[{"line_number":208,"context_line":"                            \u0027%Y-%m-%dT%H:%M:%S.%f\u0027))"},{"line_number":209,"context_line":"            self.assertTrue(time.strptime("},{"line_number":210,"context_line":"                            body[\u0027servers\u0027][0][\u0027OS-SRV-USG:terminated_at\u0027],"},{"line_number":211,"context_line":"                            \u0027%Y-%m-%dT%H:%M:%S.%f\u0027))"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a890539_30c91d7a","line":211,"updated":"2014-11-27 22:31:02.000000000","message":"the difference only in time, so it\u0027s better to extract time and then assert it.","commit_id":"87bfde96712fb10f0e59d3dc346f3ce06c556b4e"}],"tempest/api/compute/v3/admin/test_servers.py":[{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"9d53aa4d20050e22ef534cf9004738b49db9f4fc","unresolved":false,"context_lines":[{"line_number":187,"context_line":""},{"line_number":188,"context_line":"        self.assertTrue(time.strptime("},{"line_number":189,"context_line":"                        body[\u0027servers\u0027][0][\u0027os-server-usage:launched_at\u0027],"},{"line_number":190,"context_line":"                        \u0027%Y-%m-%dT%H:%M:%S.%f\u0027))"},{"line_number":191,"context_line":"        self.assertTrue(time.strptime("},{"line_number":192,"context_line":"                        body[\u0027servers\u0027][0][\u0027os-server-usage:terminated_at\u0027],"},{"line_number":193,"context_line":"                        \u0027%Y-%m-%dT%H:%M:%S.%f\u0027))"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a890539_90865115","line":190,"updated":"2014-11-27 22:31:02.000000000","message":"it will be ValueError exception when data will not be time-like, so assertTrue is not enough here IMHO, you can improve it, i.e:\n\n  try:\n    self.assertTrue(....)\n  except ValueError as e:\n    self.fail(\"No time in launched_at...\")","commit_id":"87bfde96712fb10f0e59d3dc346f3ce06c556b4e"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"8aceb2bd01d1e9b5c48f531592579b84a3cbfb8e","unresolved":false,"context_lines":[{"line_number":176,"context_line":"        self.assertEqual(202, resp.status)"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"    @test.attr(type\u003d\u0027gate\u0027)"},{"line_number":179,"context_line":"    def test_list_servers_usage(self):"},{"line_number":180,"context_line":"        # check the presence of the launched_at and terminated_at parameters"},{"line_number":181,"context_line":"        name \u003d data_utils.rand_name(self.__class__.__name__)"},{"line_number":182,"context_line":"        _, server \u003d self.create_test_server(name\u003dname, wait_until\u003d\u0027ACTIVE\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a890539_a5fdc43d","line":179,"updated":"2014-11-28 10:36:42.000000000","message":"Nova v3 API has been removed from Nova side, and we have a plan v3 API tests from Tempest also.\nSo we don\u0027t need to add v3 API tests now.","commit_id":"5a51cccdfee38a6ff6543addd16d677029473693"}]}