)]}'
{"tempest/api/volume/admin/test_volume_services.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"b5def3079e7c940000a2a8e7ee83584121c3c382","unresolved":false,"context_lines":[{"line_number":27,"context_line":"    @classmethod"},{"line_number":28,"context_line":"    def resource_setup(cls):"},{"line_number":29,"context_line":"        super(VolumesServicesV2TestJSON, cls).resource_setup()"},{"line_number":30,"context_line":"        _, cls.services \u003d cls.volume_services_client.list_services()"},{"line_number":31,"context_line":"        cls.host_name \u003d cls.services[0][\u0027host\u0027]"},{"line_number":32,"context_line":"        cls.binary_name \u003d cls.services[0][\u0027binary\u0027]"},{"line_number":33,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5a890539_7f66f72a","line":30,"updated":"2014-11-20 10:35:35.000000000","message":"ahh you missed this.","commit_id":"d54a1f48be9d7d623b42687ed6458ece924f3377"},{"author":{"_account_id":7930,"name":"jun xie","email":"easonxie160@163.com","username":"jeffreycoho"},"change_message_id":"b764459984b9b76304bd76f5941aab2114f760fa","unresolved":false,"context_lines":[{"line_number":27,"context_line":"    @classmethod"},{"line_number":28,"context_line":"    def resource_setup(cls):"},{"line_number":29,"context_line":"        super(VolumesServicesV2TestJSON, cls).resource_setup()"},{"line_number":30,"context_line":"        _, cls.services \u003d cls.volume_services_client.list_services()"},{"line_number":31,"context_line":"        cls.host_name \u003d cls.services[0][\u0027host\u0027]"},{"line_number":32,"context_line":"        cls.binary_name \u003d cls.services[0][\u0027binary\u0027]"},{"line_number":33,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5a890539_71c70b13","line":30,"in_reply_to":"5a890539_7f66f72a","updated":"2014-11-20 11:55:22.000000000","message":"thank you/","commit_id":"d54a1f48be9d7d623b42687ed6458ece924f3377"}],"tempest/api/volume/base.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"dee795c768164709829d155bc63cf92b6b84842a","unresolved":false,"context_lines":[{"line_number":172,"context_line":"                msg \u003d \"Volume API v1 is disabled\""},{"line_number":173,"context_line":"                raise cls.skipException(msg)"},{"line_number":174,"context_line":"            cls.volume_qos_client \u003d cls.os_adm.volume_qos_client"},{"line_number":175,"context_line":"            cls.volume_services_client \u003d cls.os_adm.volume_services_client"},{"line_number":176,"context_line":"            cls.volume_types_client \u003d cls.os_adm.volume_types_client"},{"line_number":177,"context_line":"            cls.admin_volume_client \u003d cls.os_adm.volumes_client"},{"line_number":178,"context_line":"            cls.hosts_client \u003d cls.os_adm.volume_hosts_client"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a890539_94ab8a88","line":175,"updated":"2014-11-20 09:44:33.000000000","message":"suggestion - please change cls.volume_services_client to cls.admin_volume_services_client as non admin base class also has same name which can create confusion.","commit_id":"7b972096b6962c27f718eaa5a0ff78c277861d02"},{"author":{"_account_id":7930,"name":"jun xie","email":"easonxie160@163.com","username":"jeffreycoho"},"change_message_id":"2d9948256c49fc2abd4fb1194c41a8354569e83f","unresolved":false,"context_lines":[{"line_number":172,"context_line":"                msg \u003d \"Volume API v1 is disabled\""},{"line_number":173,"context_line":"                raise cls.skipException(msg)"},{"line_number":174,"context_line":"            cls.volume_qos_client \u003d cls.os_adm.volume_qos_client"},{"line_number":175,"context_line":"            cls.volume_services_client \u003d cls.os_adm.volume_services_client"},{"line_number":176,"context_line":"            cls.volume_types_client \u003d cls.os_adm.volume_types_client"},{"line_number":177,"context_line":"            cls.admin_volume_client \u003d cls.os_adm.volumes_client"},{"line_number":178,"context_line":"            cls.hosts_client \u003d cls.os_adm.volume_hosts_client"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a890539_f483eea6","line":175,"in_reply_to":"5a890539_94ab8a88","updated":"2014-11-20 10:03:09.000000000","message":"Done, good point","commit_id":"7b972096b6962c27f718eaa5a0ff78c277861d02"}],"tempest/clients.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"dee795c768164709829d155bc63cf92b6b84842a","unresolved":false,"context_lines":[{"line_number":440,"context_line":"        self.volume_services_client \u003d VolumesServicesClientJSON("},{"line_number":441,"context_line":"            self.auth_provider)"},{"line_number":442,"context_line":"        self.volume_services_v2_client \u003d VolumesServicesV2ClientJSON("},{"line_number":443,"context_line":"            self.auth_provider)"},{"line_number":444,"context_line":"        self.volume_hosts_client \u003d VolumeHostsClientJSON(self.auth_provider)"},{"line_number":445,"context_line":"        self.volume_hosts_v2_client \u003d VolumeHostsV2ClientJSON("},{"line_number":446,"context_line":"            self.auth_provider)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a890539_54ba02e2","line":443,"updated":"2014-11-20 09:44:33.000000000","message":"Please move this to L411 as there is no xml client for this","commit_id":"7b972096b6962c27f718eaa5a0ff78c277861d02"},{"author":{"_account_id":7930,"name":"jun xie","email":"easonxie160@163.com","username":"jeffreycoho"},"change_message_id":"2d9948256c49fc2abd4fb1194c41a8354569e83f","unresolved":false,"context_lines":[{"line_number":440,"context_line":"        self.volume_services_client \u003d VolumesServicesClientJSON("},{"line_number":441,"context_line":"            self.auth_provider)"},{"line_number":442,"context_line":"        self.volume_services_v2_client \u003d VolumesServicesV2ClientJSON("},{"line_number":443,"context_line":"            self.auth_provider)"},{"line_number":444,"context_line":"        self.volume_hosts_client \u003d VolumeHostsClientJSON(self.auth_provider)"},{"line_number":445,"context_line":"        self.volume_hosts_v2_client \u003d VolumeHostsV2ClientJSON("},{"line_number":446,"context_line":"            self.auth_provider)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a890539_54bcc26c","line":443,"in_reply_to":"5a890539_54ba02e2","updated":"2014-11-20 10:03:09.000000000","message":"Done","commit_id":"7b972096b6962c27f718eaa5a0ff78c277861d02"}],"tempest/services/volume/v2/json/admin/volume_services_client.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"dee795c768164709829d155bc63cf92b6b84842a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2014 NEC Corporation"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a890539_f4c84e77","line":1,"updated":"2014-11-20 09:44:33.000000000","message":"may be you want to change company name.","commit_id":"7b972096b6962c27f718eaa5a0ff78c277861d02"},{"author":{"_account_id":7930,"name":"jun xie","email":"easonxie160@163.com","username":"jeffreycoho"},"change_message_id":"2d9948256c49fc2abd4fb1194c41a8354569e83f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2014 NEC Corporation"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a890539_943b8aea","line":1,"in_reply_to":"5a890539_f4c84e77","updated":"2014-11-20 10:03:09.000000000","message":"Done","commit_id":"7b972096b6962c27f718eaa5a0ff78c277861d02"}],"tempest/services/volume/xml/admin/volume_services_client.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"d7e4225fe54f0ee6b5861f121b5c158618a92f72","unresolved":false,"context_lines":[{"line_number":41,"context_line":"        body \u003d [xml_utils.xml_to_json(x) for x in node.getchildren()]"},{"line_number":42,"context_line":"        self.expected_success(200, resp.status)"},{"line_number":43,"context_line":"        return resp, body"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"class VolumesServicesClientXML(BaseVolumesServicesClientXML):"},{"line_number":47,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":4,"id":"5a890539_55dd24df","line":44,"updated":"2014-11-25 04:09:49.000000000","message":"I think we should leave this class as it is. This is going to be removed in https://review.openstack.org/#/c/136821/","commit_id":"01114f8c9c6b667a60cc693187adef8a495d70b8"},{"author":{"_account_id":7930,"name":"jun xie","email":"easonxie160@163.com","username":"jeffreycoho"},"change_message_id":"3caddf7ffd6b26976472b7cd41655c289562e229","unresolved":false,"context_lines":[{"line_number":41,"context_line":"        body \u003d [xml_utils.xml_to_json(x) for x in node.getchildren()]"},{"line_number":42,"context_line":"        self.expected_success(200, resp.status)"},{"line_number":43,"context_line":"        return resp, body"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"class VolumesServicesClientXML(BaseVolumesServicesClientXML):"},{"line_number":47,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":4,"id":"5a890539_e1fc89b7","line":44,"in_reply_to":"5a890539_55dd24df","updated":"2014-11-25 10:31:53.000000000","message":"thanks Done.","commit_id":"01114f8c9c6b667a60cc693187adef8a495d70b8"}]}