)]}'
{"tempest/api/network/test_ports.py":[{"author":{"_account_id":8576,"name":"Yair Fried","email":"yfried@redhat.com","username":"yfried"},"change_message_id":"b23831f43979e6b28834e60db2747120d3d29451","unresolved":false,"context_lines":[{"line_number":188,"context_line":""},{"line_number":189,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":190,"context_line":"    def test_create_show_delete_port_user_defined_mac(self):"},{"line_number":191,"context_line":"        # Create a port for a dynamic mac"},{"line_number":192,"context_line":"        _, body \u003d self.client.create_port(network_id\u003dself.network[\u0027id\u0027])"},{"line_number":193,"context_line":"        port \u003d body[\u0027port\u0027]"},{"line_number":194,"context_line":"        self.client.delete_port(port[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a890539_e60b127b","line":191,"updated":"2014-12-02 07:36:28.000000000","message":"s/dynamic/legal","commit_id":"f48a97acf90ae4ae7599f6344f2861849fec314d"},{"author":{"_account_id":11671,"name":"Ashish Kumar Gupta","email":"guptaas@vmware.com","username":"ashish-kumar-gupta"},"change_message_id":"2db35b3d25829cf8493a30a11ac2ada09661f1c2","unresolved":false,"context_lines":[{"line_number":188,"context_line":""},{"line_number":189,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":190,"context_line":"    def test_create_show_delete_port_user_defined_mac(self):"},{"line_number":191,"context_line":"        # Create a port for a dynamic mac"},{"line_number":192,"context_line":"        _, body \u003d self.client.create_port(network_id\u003dself.network[\u0027id\u0027])"},{"line_number":193,"context_line":"        port \u003d body[\u0027port\u0027]"},{"line_number":194,"context_line":"        self.client.delete_port(port[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a890539_96b51bd2","line":191,"in_reply_to":"5a890539_e60b127b","updated":"2014-12-02 10:20:44.000000000","message":"Thanks for the review . Edited the name.","commit_id":"f48a97acf90ae4ae7599f6344f2861849fec314d"},{"author":{"_account_id":8576,"name":"Yair Fried","email":"yfried@redhat.com","username":"yfried"},"change_message_id":"b23831f43979e6b28834e60db2747120d3d29451","unresolved":false,"context_lines":[{"line_number":191,"context_line":"        # Create a port for a dynamic mac"},{"line_number":192,"context_line":"        _, body \u003d self.client.create_port(network_id\u003dself.network[\u0027id\u0027])"},{"line_number":193,"context_line":"        port \u003d body[\u0027port\u0027]"},{"line_number":194,"context_line":"        self.client.delete_port(port[\u0027id\u0027])"},{"line_number":195,"context_line":"        # Create a new port with user defined mac"},{"line_number":196,"context_line":"        post_body \u003d {\"network_id\": self.network[\u0027id\u0027],"},{"line_number":197,"context_line":"                     \"mac_address\": port[\u0027mac_address\u0027]}"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a890539_06865edb","line":194,"updated":"2014-12-02 07:36:28.000000000","message":"since port is deleted here, please same \"mac_address\" in a different variable, for clearer code","commit_id":"f48a97acf90ae4ae7599f6344f2861849fec314d"},{"author":{"_account_id":11671,"name":"Ashish Kumar Gupta","email":"guptaas@vmware.com","username":"ashish-kumar-gupta"},"change_message_id":"2db35b3d25829cf8493a30a11ac2ada09661f1c2","unresolved":false,"context_lines":[{"line_number":191,"context_line":"        # Create a port for a dynamic mac"},{"line_number":192,"context_line":"        _, body \u003d self.client.create_port(network_id\u003dself.network[\u0027id\u0027])"},{"line_number":193,"context_line":"        port \u003d body[\u0027port\u0027]"},{"line_number":194,"context_line":"        self.client.delete_port(port[\u0027id\u0027])"},{"line_number":195,"context_line":"        # Create a new port with user defined mac"},{"line_number":196,"context_line":"        post_body \u003d {\"network_id\": self.network[\u0027id\u0027],"},{"line_number":197,"context_line":"                     \"mac_address\": port[\u0027mac_address\u0027]}"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a890539_f6b2dfe3","line":194,"in_reply_to":"5a890539_06865edb","updated":"2014-12-02 10:20:44.000000000","message":"Used different name to store the deleted port mac address","commit_id":"f48a97acf90ae4ae7599f6344f2861849fec314d"},{"author":{"_account_id":8576,"name":"Yair Fried","email":"yfried@redhat.com","username":"yfried"},"change_message_id":"b23831f43979e6b28834e60db2747120d3d29451","unresolved":false,"context_lines":[{"line_number":193,"context_line":"        port \u003d body[\u0027port\u0027]"},{"line_number":194,"context_line":"        self.client.delete_port(port[\u0027id\u0027])"},{"line_number":195,"context_line":"        # Create a new port with user defined mac"},{"line_number":196,"context_line":"        post_body \u003d {\"network_id\": self.network[\u0027id\u0027],"},{"line_number":197,"context_line":"                     \"mac_address\": port[\u0027mac_address\u0027]}"},{"line_number":198,"context_line":"        _, body \u003d self.client.create_port(**post_body)"},{"line_number":199,"context_line":"        self.addCleanup(self.client.delete_port, body[\u0027port\u0027][\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a890539_86488eb4","line":196,"updated":"2014-12-02 07:36:28.000000000","message":"this dict is not really needed. you could send the arguments directly in L198","commit_id":"f48a97acf90ae4ae7599f6344f2861849fec314d"},{"author":{"_account_id":11671,"name":"Ashish Kumar Gupta","email":"guptaas@vmware.com","username":"ashish-kumar-gupta"},"change_message_id":"2db35b3d25829cf8493a30a11ac2ada09661f1c2","unresolved":false,"context_lines":[{"line_number":193,"context_line":"        port \u003d body[\u0027port\u0027]"},{"line_number":194,"context_line":"        self.client.delete_port(port[\u0027id\u0027])"},{"line_number":195,"context_line":"        # Create a new port with user defined mac"},{"line_number":196,"context_line":"        post_body \u003d {\"network_id\": self.network[\u0027id\u0027],"},{"line_number":197,"context_line":"                     \"mac_address\": port[\u0027mac_address\u0027]}"},{"line_number":198,"context_line":"        _, body \u003d self.client.create_port(**post_body)"},{"line_number":199,"context_line":"        self.addCleanup(self.client.delete_port, body[\u0027port\u0027][\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a890539_56c3b337","line":196,"in_reply_to":"5a890539_86488eb4","updated":"2014-12-02 10:20:44.000000000","message":"Used directly as the argument in L198","commit_id":"f48a97acf90ae4ae7599f6344f2861849fec314d"},{"author":{"_account_id":8576,"name":"Yair Fried","email":"yfried@redhat.com","username":"yfried"},"change_message_id":"b23831f43979e6b28834e60db2747120d3d29451","unresolved":false,"context_lines":[{"line_number":194,"context_line":"        self.client.delete_port(port[\u0027id\u0027])"},{"line_number":195,"context_line":"        # Create a new port with user defined mac"},{"line_number":196,"context_line":"        post_body \u003d {\"network_id\": self.network[\u0027id\u0027],"},{"line_number":197,"context_line":"                     \"mac_address\": port[\u0027mac_address\u0027]}"},{"line_number":198,"context_line":"        _, body \u003d self.client.create_port(**post_body)"},{"line_number":199,"context_line":"        self.addCleanup(self.client.delete_port, body[\u0027port\u0027][\u0027id\u0027])"},{"line_number":200,"context_line":"        port \u003d body[\u0027port\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a890539_66764208","line":197,"updated":"2014-12-02 07:36:28.000000000","message":"see above.\nreferring to the deleted port is confusing. you are only interested in the mac address","commit_id":"f48a97acf90ae4ae7599f6344f2861849fec314d"},{"author":{"_account_id":11671,"name":"Ashish Kumar Gupta","email":"guptaas@vmware.com","username":"ashish-kumar-gupta"},"change_message_id":"2db35b3d25829cf8493a30a11ac2ada09661f1c2","unresolved":false,"context_lines":[{"line_number":194,"context_line":"        self.client.delete_port(port[\u0027id\u0027])"},{"line_number":195,"context_line":"        # Create a new port with user defined mac"},{"line_number":196,"context_line":"        post_body \u003d {\"network_id\": self.network[\u0027id\u0027],"},{"line_number":197,"context_line":"                     \"mac_address\": port[\u0027mac_address\u0027]}"},{"line_number":198,"context_line":"        _, body \u003d self.client.create_port(**post_body)"},{"line_number":199,"context_line":"        self.addCleanup(self.client.delete_port, body[\u0027port\u0027][\u0027id\u0027])"},{"line_number":200,"context_line":"        port \u003d body[\u0027port\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a890539_76beefaf","line":197,"in_reply_to":"5a890539_66764208","updated":"2014-12-02 10:20:44.000000000","message":"Done","commit_id":"f48a97acf90ae4ae7599f6344f2861849fec314d"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"7459aab5058f185945f9b0a22ef6ac007f8532ee","unresolved":false,"context_lines":[{"line_number":201,"context_line":"        _, body \u003d self.client.show_port(port[\u0027id\u0027])"},{"line_number":202,"context_line":"        show_port \u003d body[\u0027port\u0027]"},{"line_number":203,"context_line":"        self.assertEqual(port[\u0027mac_address\u0027],"},{"line_number":204,"context_line":"                         show_port[\u0027mac_address\u0027])"},{"line_number":205,"context_line":""},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"class PortsAdminExtendedAttrsTestJSON(base.BaseAdminNetworkTest):"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a890539_b4d5af1c","line":204,"updated":"2014-12-02 11:22:58.000000000","message":"I guess this check is for validating show_port[\u0027mac_address\u0027] should be the same as the specified mac address at create_port() because this test creates port with old mac address.\n\nHowever, port is overwritten at line 200. so now this doesn\u0027t check it.\n\nSo maybe we need to define the other name variable at line 193 like old_port or something, and we need to pass it at line 203 instead.","commit_id":"6e0495fcc83636b0468ff77d720343f09780a2c2"},{"author":{"_account_id":11671,"name":"Ashish Kumar Gupta","email":"guptaas@vmware.com","username":"ashish-kumar-gupta"},"change_message_id":"e01d70066270f7a257d8c330524c19c5b343beef","unresolved":false,"context_lines":[{"line_number":201,"context_line":"        _, body \u003d self.client.show_port(port[\u0027id\u0027])"},{"line_number":202,"context_line":"        show_port \u003d body[\u0027port\u0027]"},{"line_number":203,"context_line":"        self.assertEqual(port[\u0027mac_address\u0027],"},{"line_number":204,"context_line":"                         show_port[\u0027mac_address\u0027])"},{"line_number":205,"context_line":""},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"class PortsAdminExtendedAttrsTestJSON(base.BaseAdminNetworkTest):"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a890539_0a401834","line":204,"in_reply_to":"5a890539_b4d5af1c","updated":"2014-12-02 12:20:46.000000000","message":"Done","commit_id":"6e0495fcc83636b0468ff77d720343f09780a2c2"}]}