)]}'
{"tempest/api/network/test_networks.py":[{"author":{"_account_id":6685,"name":"Baodong (Robert) Li","email":"baoli@cisco.com","username":"baoli"},"change_message_id":"b159c73b7e5e80a1fdea99fd42e643678366aeae","unresolved":false,"context_lines":[{"line_number":572,"context_line":""},{"line_number":573,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":574,"context_line":"    def test_delete_subnet_with_slaac_ports(self):"},{"line_number":575,"context_line":"        \"\"\"Create subnet with SLAAC DHCP, create ports in network"},{"line_number":576,"context_line":"        and then you shall be able to delete subnet without port"},{"line_number":577,"context_line":"        deletion. But you still can not delete the network."},{"line_number":578,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":6,"id":"5a890539_b09eedb6","line":575,"updated":"2014-11-27 21:58:00.000000000","message":"remove DHCP.","commit_id":"aedbaacb3dc39faa5690af5f7f1f5c4a7500db93"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"1ccfb45b8b32ecb20feec145d82ecbf425e3e338","unresolved":false,"context_lines":[{"line_number":572,"context_line":""},{"line_number":573,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":574,"context_line":"    def test_delete_subnet_with_slaac_ports(self):"},{"line_number":575,"context_line":"        \"\"\"Create subnet with SLAAC DHCP, create ports in network"},{"line_number":576,"context_line":"        and then you shall be able to delete subnet without port"},{"line_number":577,"context_line":"        deletion. But you still can not delete the network."},{"line_number":578,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":6,"id":"3a961159_cb71eea9","line":575,"in_reply_to":"5a890539_b09eedb6","updated":"2014-12-17 13:06:30.000000000","message":"Done","commit_id":"aedbaacb3dc39faa5690af5f7f1f5c4a7500db93"},{"author":{"_account_id":6685,"name":"Baodong (Robert) Li","email":"baoli@cisco.com","username":"baoli"},"change_message_id":"b159c73b7e5e80a1fdea99fd42e643678366aeae","unresolved":false,"context_lines":[{"line_number":581,"context_line":"                                          **{\u0027ipv6_ra_mode\u0027: \"slaac\","},{"line_number":582,"context_line":"                                             \u0027ipv6_address_mode\u0027: \"slaac\"})"},{"line_number":583,"context_line":"        port \u003d self.create_port(slaac_network)"},{"line_number":584,"context_line":"        self.assertIsNotNone(port[\u0027fixed_ips\u0027][0][\u0027ip_address\u0027])"},{"line_number":585,"context_line":"        self.client.delete_subnet(subnet_slaac[\u0027id\u0027])"},{"line_number":586,"context_line":"        self.subnets.pop()"},{"line_number":587,"context_line":"        subnets \u003d self.client.list_subnets()"}],"source_content_type":"text/x-python","patch_set":6,"id":"5a890539_d0a379fe","line":584,"updated":"2014-11-27 21:58:00.000000000","message":"Should the address be verified as belonging to the subnet?","commit_id":"aedbaacb3dc39faa5690af5f7f1f5c4a7500db93"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"1ccfb45b8b32ecb20feec145d82ecbf425e3e338","unresolved":false,"context_lines":[{"line_number":581,"context_line":"                                          **{\u0027ipv6_ra_mode\u0027: \"slaac\","},{"line_number":582,"context_line":"                                             \u0027ipv6_address_mode\u0027: \"slaac\"})"},{"line_number":583,"context_line":"        port \u003d self.create_port(slaac_network)"},{"line_number":584,"context_line":"        self.assertIsNotNone(port[\u0027fixed_ips\u0027][0][\u0027ip_address\u0027])"},{"line_number":585,"context_line":"        self.client.delete_subnet(subnet_slaac[\u0027id\u0027])"},{"line_number":586,"context_line":"        self.subnets.pop()"},{"line_number":587,"context_line":"        subnets \u003d self.client.list_subnets()"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a961159_cba80ede","line":584,"in_reply_to":"5a890539_d0a379fe","updated":"2014-12-17 13:06:30.000000000","message":"Not necessary, it\u0027s checked in patch of DHCPv6","commit_id":"aedbaacb3dc39faa5690af5f7f1f5c4a7500db93"},{"author":{"_account_id":6695,"name":"Dane LeBlanc","email":"leblancd@cisco.com","username":"leblancd"},"change_message_id":"baaa33352c2c06b87ad450e81b8e05de94b2233a","unresolved":false,"context_lines":[{"line_number":572,"context_line":""},{"line_number":573,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":574,"context_line":"    def test_delete_subnet_with_slaac_ports(self):"},{"line_number":575,"context_line":"        \"\"\"Create subnet with SLAAC, create ports in network"},{"line_number":576,"context_line":"        and then you shall be able to delete subnet without port"},{"line_number":577,"context_line":"        deletion. But you still can not delete the network."},{"line_number":578,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":7,"id":"3a961159_014f55bf","line":575,"updated":"2014-12-17 14:28:56.000000000","message":"Nit: multi-line docstring should start with one-line summary. (http://docs.openstack.org/developer/hacking/)","commit_id":"22c379896cff1a7619667c2db0ec54fcacea2b04"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"5f39ebffc04ee413175cd7b30d97ecc47767d749","unresolved":false,"context_lines":[{"line_number":572,"context_line":""},{"line_number":573,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":574,"context_line":"    def test_delete_subnet_with_slaac_ports(self):"},{"line_number":575,"context_line":"        \"\"\"Create subnet with SLAAC, create ports in network"},{"line_number":576,"context_line":"        and then you shall be able to delete subnet without port"},{"line_number":577,"context_line":"        deletion. But you still can not delete the network."},{"line_number":578,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":7,"id":"3a961159_44440bb7","line":575,"in_reply_to":"3a961159_014f55bf","updated":"2014-12-17 14:54:31.000000000","message":"Done","commit_id":"22c379896cff1a7619667c2db0ec54fcacea2b04"},{"author":{"_account_id":6695,"name":"Dane LeBlanc","email":"leblancd@cisco.com","username":"leblancd"},"change_message_id":"baaa33352c2c06b87ad450e81b8e05de94b2233a","unresolved":false,"context_lines":[{"line_number":577,"context_line":"        deletion. But you still can not delete the network."},{"line_number":578,"context_line":"        \"\"\""},{"line_number":579,"context_line":"        slaac_network \u003d self.create_network()"},{"line_number":580,"context_line":"        subnet_slaac \u003d self.create_subnet(slaac_network,"},{"line_number":581,"context_line":"                                          **{\u0027ipv6_ra_mode\u0027: \"slaac\","},{"line_number":582,"context_line":"                                             \u0027ipv6_address_mode\u0027: \"slaac\"})"},{"line_number":583,"context_line":"        port \u003d self.create_port(slaac_network)"}],"source_content_type":"text/x-python","patch_set":7,"id":"3a961159_81a425ba","line":580,"updated":"2014-12-17 14:28:56.000000000","message":"For completeness, it would be good to also test with ipv6_ra_mode and ipv6_address_mode set to \"dhcpv6-stateless\". Behavior should be the same.","commit_id":"22c379896cff1a7619667c2db0ec54fcacea2b04"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"5f39ebffc04ee413175cd7b30d97ecc47767d749","unresolved":false,"context_lines":[{"line_number":577,"context_line":"        deletion. But you still can not delete the network."},{"line_number":578,"context_line":"        \"\"\""},{"line_number":579,"context_line":"        slaac_network \u003d self.create_network()"},{"line_number":580,"context_line":"        subnet_slaac \u003d self.create_subnet(slaac_network,"},{"line_number":581,"context_line":"                                          **{\u0027ipv6_ra_mode\u0027: \"slaac\","},{"line_number":582,"context_line":"                                             \u0027ipv6_address_mode\u0027: \"slaac\"})"},{"line_number":583,"context_line":"        port \u003d self.create_port(slaac_network)"}],"source_content_type":"text/x-python","patch_set":7,"id":"3a961159_6412e7b5","line":580,"in_reply_to":"3a961159_81a425ba","updated":"2014-12-17 14:54:31.000000000","message":"Done","commit_id":"22c379896cff1a7619667c2db0ec54fcacea2b04"},{"author":{"_account_id":6695,"name":"Dane LeBlanc","email":"leblancd@cisco.com","username":"leblancd"},"change_message_id":"cbb5083b7551699ed3a24541a01c6bef34309660","unresolved":false,"context_lines":[{"line_number":571,"context_line":"            ipv6_address_mode\u003d\u0027dhcpv6-stateless\u0027)"},{"line_number":572,"context_line":""},{"line_number":573,"context_line":"    def _test_delete_subnet_with_ports(self, mode):"},{"line_number":574,"context_line":"        \"\"\"Create subnet with required mode and delete it \"\"\""},{"line_number":575,"context_line":"        slaac_network \u003d self.create_network()"},{"line_number":576,"context_line":"        subnet_slaac \u003d self.create_subnet(slaac_network,"},{"line_number":577,"context_line":"                                          **{\u0027ipv6_ra_mode\u0027: mode,"}],"source_content_type":"text/x-python","patch_set":9,"id":"3a961159_ae180585","line":574,"updated":"2014-12-18 15:35:50.000000000","message":"Nit - docstring should mention that subnet is deleted with existing ports.","commit_id":"ccc1bbbad2a0282ca18fc459432cbe8377870ac6"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"8894a21d7d144ee4adb0b077872214338d3125bb","unresolved":false,"context_lines":[{"line_number":571,"context_line":"            ipv6_address_mode\u003d\u0027dhcpv6-stateless\u0027)"},{"line_number":572,"context_line":""},{"line_number":573,"context_line":"    def _test_delete_subnet_with_ports(self, mode):"},{"line_number":574,"context_line":"        \"\"\"Create subnet with required mode and delete it \"\"\""},{"line_number":575,"context_line":"        slaac_network \u003d self.create_network()"},{"line_number":576,"context_line":"        subnet_slaac \u003d self.create_subnet(slaac_network,"},{"line_number":577,"context_line":"                                          **{\u0027ipv6_ra_mode\u0027: mode,"}],"source_content_type":"text/x-python","patch_set":9,"id":"3a961159_a9955fe5","line":574,"in_reply_to":"3a961159_ae180585","updated":"2014-12-18 15:48:02.000000000","message":"Done","commit_id":"ccc1bbbad2a0282ca18fc459432cbe8377870ac6"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"a9c52a53ffe9468dd298e494db1c93c40d96cb7a","unresolved":false,"context_lines":[{"line_number":581,"context_line":"        self.client.delete_subnet(subnet_slaac[\u0027id\u0027])"},{"line_number":582,"context_line":"        self.subnets.pop()"},{"line_number":583,"context_line":"        subnets \u003d self.client.list_subnets()"},{"line_number":584,"context_line":"        self.assertNotIn(subnet_slaac[\u0027id\u0027], subnets, \"Subnet wasn\u0027t deleted\")"},{"line_number":585,"context_line":"        self.assertRaisesRegexp("},{"line_number":586,"context_line":"            exceptions.Conflict,"},{"line_number":587,"context_line":"            \"There are one or more ports still in use on the network\","}],"source_content_type":"text/x-python","patch_set":9,"id":"3a961159_0ed599b8","line":584,"updated":"2014-12-18 15:25:37.000000000","message":"This is wrong.  subnet_slaac[\u0027id\u0027] is a string. subnets is a dict which keys are not \"subnet IDs\".","commit_id":"ccc1bbbad2a0282ca18fc459432cbe8377870ac6"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"8894a21d7d144ee4adb0b077872214338d3125bb","unresolved":false,"context_lines":[{"line_number":581,"context_line":"        self.client.delete_subnet(subnet_slaac[\u0027id\u0027])"},{"line_number":582,"context_line":"        self.subnets.pop()"},{"line_number":583,"context_line":"        subnets \u003d self.client.list_subnets()"},{"line_number":584,"context_line":"        self.assertNotIn(subnet_slaac[\u0027id\u0027], subnets, \"Subnet wasn\u0027t deleted\")"},{"line_number":585,"context_line":"        self.assertRaisesRegexp("},{"line_number":586,"context_line":"            exceptions.Conflict,"},{"line_number":587,"context_line":"            \"There are one or more ports still in use on the network\","}],"source_content_type":"text/x-python","patch_set":9,"id":"3a961159_49fddb3a","line":584,"in_reply_to":"3a961159_0ed599b8","updated":"2014-12-18 15:48:02.000000000","message":"Thanks! Fixed it.","commit_id":"ccc1bbbad2a0282ca18fc459432cbe8377870ac6"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"cdabecf5e2b059547ff57717a6c8a7609d4deabb","unresolved":false,"context_lines":[{"line_number":580,"context_line":"        self.assertIsNotNone(port[\u0027fixed_ips\u0027][0][\u0027ip_address\u0027])"},{"line_number":581,"context_line":"        self.client.delete_subnet(subnet_slaac[\u0027id\u0027])"},{"line_number":582,"context_line":"        self.subnets.pop()"},{"line_number":583,"context_line":"        _, subnets \u003d self.client.list_subnets()"},{"line_number":584,"context_line":"        subnet_ids \u003d [subnet[\u0027id\u0027] for subnet in subnets[\u0027subnets\u0027]]"},{"line_number":585,"context_line":"        self.assertNotIn(subnet_slaac[\u0027id\u0027], subnet_ids,"},{"line_number":586,"context_line":"                         \"Subnet wasn\u0027t deleted\")"}],"source_content_type":"text/x-python","patch_set":10,"id":"3a961159_b7e00a27","line":583,"updated":"2014-12-22 14:45:36.000000000","message":"I think this need to be rebased.","commit_id":"7c7693b1f0700685606fa121375ad32aab00a67f"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"5b44bd93238ba2e66f775af95e49e13cc1388167","unresolved":false,"context_lines":[{"line_number":580,"context_line":"        self.assertIsNotNone(port[\u0027fixed_ips\u0027][0][\u0027ip_address\u0027])"},{"line_number":581,"context_line":"        self.client.delete_subnet(subnet_slaac[\u0027id\u0027])"},{"line_number":582,"context_line":"        self.subnets.pop()"},{"line_number":583,"context_line":"        _, subnets \u003d self.client.list_subnets()"},{"line_number":584,"context_line":"        subnet_ids \u003d [subnet[\u0027id\u0027] for subnet in subnets[\u0027subnets\u0027]]"},{"line_number":585,"context_line":"        self.assertNotIn(subnet_slaac[\u0027id\u0027], subnet_ids,"},{"line_number":586,"context_line":"                         \"Subnet wasn\u0027t deleted\")"}],"source_content_type":"text/x-python","patch_set":10,"id":"3a961159_7df5a381","line":583,"in_reply_to":"3a961159_b7e00a27","updated":"2014-12-22 15:53:18.000000000","message":"Thanks, great catch!","commit_id":"7c7693b1f0700685606fa121375ad32aab00a67f"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"4184339aacbf528f5628f0a747e063deaf48a770","unresolved":false,"context_lines":[{"line_number":591,"context_line":"            slaac_network[\u0027id\u0027])"},{"line_number":592,"context_line":""},{"line_number":593,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":594,"context_line":"    def test_delete_subnet_with_ports_slaac(self):"},{"line_number":595,"context_line":"        \"\"\"Test deleting subnet with SLAAC ports"},{"line_number":596,"context_line":""},{"line_number":597,"context_line":"        Create subnet with SLAAC, create ports in network"}],"source_content_type":"text/x-python","patch_set":11,"id":"3a961159_06ec0ef3","line":594,"updated":"2014-12-25 09:30:01.000000000","message":"for better readability, may be it can be renamed to something like - test_create_delete_slaac_subnet_with_ports","commit_id":"47149255e1efff9a355ea7fcb9b0e9e31a1d0f40"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"35f67eae72be1744026ce461d6a3b191d02f8337","unresolved":false,"context_lines":[{"line_number":591,"context_line":"            slaac_network[\u0027id\u0027])"},{"line_number":592,"context_line":""},{"line_number":593,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":594,"context_line":"    def test_delete_subnet_with_ports_slaac(self):"},{"line_number":595,"context_line":"        \"\"\"Test deleting subnet with SLAAC ports"},{"line_number":596,"context_line":""},{"line_number":597,"context_line":"        Create subnet with SLAAC, create ports in network"}],"source_content_type":"text/x-python","patch_set":11,"id":"3a961159_c1fcb042","line":594,"in_reply_to":"3a961159_06ec0ef3","updated":"2014-12-25 11:24:05.000000000","message":"Done","commit_id":"47149255e1efff9a355ea7fcb9b0e9e31a1d0f40"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"4184339aacbf528f5628f0a747e063deaf48a770","unresolved":false,"context_lines":[{"line_number":601,"context_line":"        self._test_delete_subnet_with_ports(\"slaac\")"},{"line_number":602,"context_line":""},{"line_number":603,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":604,"context_line":"    def test_delete_subnet_with_ports_stateless(self):"},{"line_number":605,"context_line":"        \"\"\"Test deleting subnet with DHCPv6 stateless ports"},{"line_number":606,"context_line":""},{"line_number":607,"context_line":"        Create subnet with DHCPv6 stateless, create ports in network"}],"source_content_type":"text/x-python","patch_set":11,"id":"3a961159_a6cb3a72","line":604,"updated":"2014-12-25 09:30:01.000000000","message":"ditto","commit_id":"47149255e1efff9a355ea7fcb9b0e9e31a1d0f40"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"35f67eae72be1744026ce461d6a3b191d02f8337","unresolved":false,"context_lines":[{"line_number":601,"context_line":"        self._test_delete_subnet_with_ports(\"slaac\")"},{"line_number":602,"context_line":""},{"line_number":603,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":604,"context_line":"    def test_delete_subnet_with_ports_stateless(self):"},{"line_number":605,"context_line":"        \"\"\"Test deleting subnet with DHCPv6 stateless ports"},{"line_number":606,"context_line":""},{"line_number":607,"context_line":"        Create subnet with DHCPv6 stateless, create ports in network"}],"source_content_type":"text/x-python","patch_set":11,"id":"3a961159_e1f9ac4f","line":604,"in_reply_to":"3a961159_a6cb3a72","updated":"2014-12-25 11:24:05.000000000","message":"Done","commit_id":"47149255e1efff9a355ea7fcb9b0e9e31a1d0f40"}]}