)]}'
{"tempest/services/compute/json/volumes_extensions_client.py":[{"author":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"change_message_id":"d7b91c46335e4d5d9e4a062575e676c5112b67ba","unresolved":false,"context_lines":[{"line_number":72,"context_line":"        display_name: Optional Volume Name."},{"line_number":73,"context_line":"        metadata: A dictionary of values to be used as metadata."},{"line_number":74,"context_line":"        \"\"\""},{"line_number":75,"context_line":"        post_body \u003d {"},{"line_number":76,"context_line":"            \u0027size\u0027: size"},{"line_number":77,"context_line":"        }"},{"line_number":78,"context_line":"        if \u0027display_name\u0027 in kwargs:"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a890539_38faf243","line":75,"updated":"2014-11-27 11:45:18.000000000","message":"Why not just copy the kwargs dict ASIS ?","commit_id":"01fb19d3bf2870ed5072fd9e388c71f3e82f9c98"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"00d76bf7aff4c607566d3d0ccef446f16e500807","unresolved":false,"context_lines":[{"line_number":72,"context_line":"        display_name: Optional Volume Name."},{"line_number":73,"context_line":"        metadata: A dictionary of values to be used as metadata."},{"line_number":74,"context_line":"        \"\"\""},{"line_number":75,"context_line":"        post_body \u003d {"},{"line_number":76,"context_line":"            \u0027size\u0027: size"},{"line_number":77,"context_line":"        }"},{"line_number":78,"context_line":"        if \u0027display_name\u0027 in kwargs:"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a890539_f086b5da","line":75,"in_reply_to":"5a890539_38faf243","updated":"2014-11-27 23:09:33.000000000","message":"@afazekas\n\nNice idea, thanks!\nI will apply it soon.","commit_id":"01fb19d3bf2870ed5072fd9e388c71f3e82f9c98"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"88657b16e627745b62f9848764eb1d401d9e9be8","unresolved":false,"context_lines":[{"line_number":78,"context_line":"        if \u0027display_name\u0027 in kwargs:"},{"line_number":79,"context_line":"            post_body.update({\u0027display_name\u0027: kwargs[\u0027display_name\u0027]})"},{"line_number":80,"context_line":"        if \u0027metadata\u0027 in kwargs:"},{"line_number":81,"context_line":"            post_body.update({\u0027metadata\u0027: kwargs[\u0027metadata\u0027]})"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"        post_body \u003d json.dumps({\u0027volume\u0027: post_body})"},{"line_number":84,"context_line":"        resp, body \u003d self.post(\u0027os-volumes\u0027, post_body)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a890539_b0b98dcd","line":81,"updated":"2014-11-27 22:40:49.000000000","message":"+1 afazekas, one \"update\" will do the job (if you don\u0027t expect a trash in kwargs):\n\n  kwargs.update({\"size\": size})\n  post_body \u003d json.dumps({\u0027volume\u0027: kwargs})\n...\n\nor cycle will save a line\n\n  for key in (\u0027display_name\u0027, \u0027metadata\u0027):\n    if key in kwargs:\n      post_body[key] \u003d kwargs[key]","commit_id":"01fb19d3bf2870ed5072fd9e388c71f3e82f9c98"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"d4218c1c3a8ed11056061256968a7f8177ad2127","unresolved":false,"context_lines":[{"line_number":78,"context_line":"        if \u0027display_name\u0027 in kwargs:"},{"line_number":79,"context_line":"            post_body.update({\u0027display_name\u0027: kwargs[\u0027display_name\u0027]})"},{"line_number":80,"context_line":"        if \u0027metadata\u0027 in kwargs:"},{"line_number":81,"context_line":"            post_body.update({\u0027metadata\u0027: kwargs[\u0027metadata\u0027]})"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"        post_body \u003d json.dumps({\u0027volume\u0027: post_body})"},{"line_number":84,"context_line":"        resp, body \u003d self.post(\u0027os-volumes\u0027, post_body)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a890539_0e715ee0","line":81,"in_reply_to":"5a890539_5075c9f8","updated":"2014-11-28 03:56:47.000000000","message":"yes, that looks good.","commit_id":"01fb19d3bf2870ed5072fd9e388c71f3e82f9c98"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"19c5ad3f13638b96d6ece3e0be9515715175ab2e","unresolved":false,"context_lines":[{"line_number":78,"context_line":"        if \u0027display_name\u0027 in kwargs:"},{"line_number":79,"context_line":"            post_body.update({\u0027display_name\u0027: kwargs[\u0027display_name\u0027]})"},{"line_number":80,"context_line":"        if \u0027metadata\u0027 in kwargs:"},{"line_number":81,"context_line":"            post_body.update({\u0027metadata\u0027: kwargs[\u0027metadata\u0027]})"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"        post_body \u003d json.dumps({\u0027volume\u0027: post_body})"},{"line_number":84,"context_line":"        resp, body \u003d self.post(\u0027os-volumes\u0027, post_body)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a890539_5075c9f8","line":81,"in_reply_to":"5a890539_b0b98dcd","updated":"2014-11-27 23:21:12.000000000","message":"@Sergey\n\nNice suggestion, thanks.\nI prefer the second your idea, because the first one affects caller side.\n\nand\n\n def create_volume(self, size, **kwargs):\n    post_body \u003d {\n        \u0027size\u0027: size\n    }\n    post_body.update(kwargs)\n\n\nwould be nice because we will be able to generate unexpected attributes request in the future for negative tests.","commit_id":"01fb19d3bf2870ed5072fd9e388c71f3e82f9c98"}]}