)]}'
{"tempest/scenario/test_security_groups_basic_ops.py":[{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"dbf57e0a639bf541561ed794c426df1fe5dd50fe","unresolved":false,"context_lines":[{"line_number":470,"context_line":""},{"line_number":471,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":472,"context_line":"    @test.services(\u0027compute\u0027, \u0027network\u0027)"},{"line_number":473,"context_line":"    def _verify_port_vif_host_admin_state(self, tenant):"},{"line_number":474,"context_line":"        \"\"\""},{"line_number":475,"context_line":"        verify that VM (tenant\u0027s access point) port has the attribute listed"},{"line_number":476,"context_line":"        and is not  empty admin_state\u003dTrue,host_id,vif_details\u0027,vif_type"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a961159_dfcd24b9","line":473,"updated":"2014-12-17 15:14:40.000000000","message":"I\u0027m not sure this file is right place to make this test. In class description you have a list of tests, if you think it\u0027s the right place - add it there.","commit_id":"72fcd7b2e291f9f9f4515189d020b15d34c06a57"},{"author":{"_account_id":7293,"name":"Elena Ezhova","email":"ezhovaelena19@gmail.com","username":"elena"},"change_message_id":"a31fe8e7b43b1f89217e7dea561b3d9a694665e2","unresolved":false,"context_lines":[{"line_number":470,"context_line":""},{"line_number":471,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":472,"context_line":"    @test.services(\u0027compute\u0027, \u0027network\u0027)"},{"line_number":473,"context_line":"    def _verify_port_vif_host_admin_state(self, tenant):"},{"line_number":474,"context_line":"        \"\"\""},{"line_number":475,"context_line":"        verify that VM (tenant\u0027s access point) port has the attribute listed"},{"line_number":476,"context_line":"        and is not  empty admin_state\u003dTrue,host_id,vif_details\u0027,vif_type"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a961159_63108f4e","line":473,"in_reply_to":"3a961159_dfcd24b9","updated":"2014-12-23 12:43:54.000000000","message":"Agree with Sergey. Perhaps it should go to test_network_basic_ops.","commit_id":"72fcd7b2e291f9f9f4515189d020b15d34c06a57"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"dbf57e0a639bf541561ed794c426df1fe5dd50fe","unresolved":false,"context_lines":[{"line_number":471,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":472,"context_line":"    @test.services(\u0027compute\u0027, \u0027network\u0027)"},{"line_number":473,"context_line":"    def _verify_port_vif_host_admin_state(self, tenant):"},{"line_number":474,"context_line":"        \"\"\""},{"line_number":475,"context_line":"        verify that VM (tenant\u0027s access point) port has the attribute listed"},{"line_number":476,"context_line":"        and is not  empty admin_state\u003dTrue,host_id,vif_details\u0027,vif_type"},{"line_number":477,"context_line":"        verified image id and device_id are same"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a961159_3fb9c82e","line":474,"updated":"2014-12-17 15:14:40.000000000","message":"docstring starts on the same line with quotes\n\nCan you please also use upper case, commas and other helpful things to help understand your description?","commit_id":"72fcd7b2e291f9f9f4515189d020b15d34c06a57"},{"author":{"_account_id":7293,"name":"Elena Ezhova","email":"ezhovaelena19@gmail.com","username":"elena"},"change_message_id":"a31fe8e7b43b1f89217e7dea561b3d9a694665e2","unresolved":false,"context_lines":[{"line_number":472,"context_line":"    @test.services(\u0027compute\u0027, \u0027network\u0027)"},{"line_number":473,"context_line":"    def _verify_port_vif_host_admin_state(self, tenant):"},{"line_number":474,"context_line":"        \"\"\""},{"line_number":475,"context_line":"        verify that VM (tenant\u0027s access point) port has the attribute listed"},{"line_number":476,"context_line":"        and is not  empty admin_state\u003dTrue,host_id,vif_details\u0027,vif_type"},{"line_number":477,"context_line":"        verified image id and device_id are same"},{"line_number":478,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"3a961159_a32d1791","line":475,"updated":"2014-12-23 12:43:54.000000000","message":"nit: has the listed attributes","commit_id":"72fcd7b2e291f9f9f4515189d020b15d34c06a57"},{"author":{"_account_id":7293,"name":"Elena Ezhova","email":"ezhovaelena19@gmail.com","username":"elena"},"change_message_id":"a31fe8e7b43b1f89217e7dea561b3d9a694665e2","unresolved":false,"context_lines":[{"line_number":473,"context_line":"    def _verify_port_vif_host_admin_state(self, tenant):"},{"line_number":474,"context_line":"        \"\"\""},{"line_number":475,"context_line":"        verify that VM (tenant\u0027s access point) port has the attribute listed"},{"line_number":476,"context_line":"        and is not  empty admin_state\u003dTrue,host_id,vif_details\u0027,vif_type"},{"line_number":477,"context_line":"        verified image id and device_id are same"},{"line_number":478,"context_line":"        \"\"\""},{"line_number":479,"context_line":"        name \u003d data_utils.rand_name(\"tenantvm-\")"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a961159_633ecfb9","line":476,"updated":"2014-12-23 12:43:54.000000000","message":"that admin_state, host_id, vif_details, vif_type are not empty","commit_id":"72fcd7b2e291f9f9f4515189d020b15d34c06a57"},{"author":{"_account_id":7293,"name":"Elena Ezhova","email":"ezhovaelena19@gmail.com","username":"elena"},"change_message_id":"a31fe8e7b43b1f89217e7dea561b3d9a694665e2","unresolved":false,"context_lines":[{"line_number":474,"context_line":"        \"\"\""},{"line_number":475,"context_line":"        verify that VM (tenant\u0027s access point) port has the attribute listed"},{"line_number":476,"context_line":"        and is not  empty admin_state\u003dTrue,host_id,vif_details\u0027,vif_type"},{"line_number":477,"context_line":"        verified image id and device_id are same"},{"line_number":478,"context_line":"        \"\"\""},{"line_number":479,"context_line":"        name \u003d data_utils.rand_name(\"tenantvm-\")"},{"line_number":480,"context_line":"        server \u003d self._create_server(name, tenant)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a961159_c376a3a3","line":477,"updated":"2014-12-23 12:43:54.000000000","message":"and verify that...","commit_id":"72fcd7b2e291f9f9f4515189d020b15d34c06a57"},{"author":{"_account_id":7293,"name":"Elena Ezhova","email":"ezhovaelena19@gmail.com","username":"elena"},"change_message_id":"a31fe8e7b43b1f89217e7dea561b3d9a694665e2","unresolved":false,"context_lines":[{"line_number":481,"context_line":"        vm_id \u003d server[\u0027id\u0027]"},{"line_number":482,"context_line":""},{"line_number":483,"context_line":"        # Get the required details of admin_state,binding:host_id,"},{"line_number":484,"context_line":"        # binding:vif_details,binding:vif_type,fixed_ips fields of all ports."},{"line_number":485,"context_line":"        port \u003d self._list_ports(device_id\u003dvm_id)[0]"},{"line_number":486,"context_line":"        self.assertTrue(port[\u0027admin_state_up\u0027])"},{"line_number":487,"context_line":"        self.assertIsNotNone(port[\u0027binding:host_id\u0027])"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a961159_e3871f5f","line":484,"updated":"2014-12-23 12:43:54.000000000","message":"Don\u0027t think this comment is necessary as it duplicates the information from the doc string.","commit_id":"72fcd7b2e291f9f9f4515189d020b15d34c06a57"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"dbf57e0a639bf541561ed794c426df1fe5dd50fe","unresolved":false,"context_lines":[{"line_number":484,"context_line":"        # binding:vif_details,binding:vif_type,fixed_ips fields of all ports."},{"line_number":485,"context_line":"        port \u003d self._list_ports(device_id\u003dvm_id)[0]"},{"line_number":486,"context_line":"        self.assertTrue(port[\u0027admin_state_up\u0027])"},{"line_number":487,"context_line":"        self.assertIsNotNone(port[\u0027binding:host_id\u0027])"},{"line_number":488,"context_line":"        self.assertIsNotNone(port[\u0027binding:vif_details\u0027])"},{"line_number":489,"context_line":"        self.assertIsNotNone(port[\u0027binding:vif_type\u0027])"},{"line_number":490,"context_line":"        self.assertEqual(vm_id, port[\u0027device_id\u0027])"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a961159_3f90e894","line":487,"updated":"2014-12-17 15:14:40.000000000","message":"I don\u0027t think NotNone is essential here. Could you please provide some more valuable checks? The same about checks below","commit_id":"72fcd7b2e291f9f9f4515189d020b15d34c06a57"},{"author":{"_account_id":7293,"name":"Elena Ezhova","email":"ezhovaelena19@gmail.com","username":"elena"},"change_message_id":"a31fe8e7b43b1f89217e7dea561b3d9a694665e2","unresolved":false,"context_lines":[{"line_number":484,"context_line":"        # binding:vif_details,binding:vif_type,fixed_ips fields of all ports."},{"line_number":485,"context_line":"        port \u003d self._list_ports(device_id\u003dvm_id)[0]"},{"line_number":486,"context_line":"        self.assertTrue(port[\u0027admin_state_up\u0027])"},{"line_number":487,"context_line":"        self.assertIsNotNone(port[\u0027binding:host_id\u0027])"},{"line_number":488,"context_line":"        self.assertIsNotNone(port[\u0027binding:vif_details\u0027])"},{"line_number":489,"context_line":"        self.assertIsNotNone(port[\u0027binding:vif_type\u0027])"},{"line_number":490,"context_line":"        self.assertEqual(vm_id, port[\u0027device_id\u0027])"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a961159_a35b5720","line":487,"in_reply_to":"3a961159_3f90e894","updated":"2014-12-23 12:43:54.000000000","message":"+1","commit_id":"72fcd7b2e291f9f9f4515189d020b15d34c06a57"}]}