)]}'
{"tempest/scenario/test_security_groups_basic_ops.py":[{"author":{"_account_id":8576,"name":"Yair Fried","email":"yfried@redhat.com","username":"yfried"},"change_message_id":"41e425f3f4e666b13babfe6bf016b9da1ce13964","unresolved":false,"context_lines":[{"line_number":230,"context_line":"        self._set_compute_context(tenant)"},{"line_number":231,"context_line":"        if security_groups is None:"},{"line_number":232,"context_line":"            security_groups \u003d [tenant.security_groups[\u0027default\u0027]]"},{"line_number":233,"context_line":"        security_groups_name \u003d []"},{"line_number":234,"context_line":"        for s in security_groups:"},{"line_number":235,"context_line":"            security_groups_name.append({\u0027name\u0027: s[\u0027name\u0027]})"},{"line_number":236,"context_line":"        create_kwargs \u003d {"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a890539_40c84975","line":233,"updated":"2014-12-02 09:19:42.000000000","message":"nit: s/name/names","commit_id":"e46f58dadc7da463b91fc6f4f64aaaa01c04dd3f"},{"author":{"_account_id":8576,"name":"Yair Fried","email":"yfried@redhat.com","username":"yfried"},"change_message_id":"41e425f3f4e666b13babfe6bf016b9da1ce13964","unresolved":false,"context_lines":[{"line_number":232,"context_line":"            security_groups \u003d [tenant.security_groups[\u0027default\u0027]]"},{"line_number":233,"context_line":"        security_groups_name \u003d []"},{"line_number":234,"context_line":"        for s in security_groups:"},{"line_number":235,"context_line":"            security_groups_name.append({\u0027name\u0027: s[\u0027name\u0027]})"},{"line_number":236,"context_line":"        create_kwargs \u003d {"},{"line_number":237,"context_line":"            \u0027networks\u0027: ["},{"line_number":238,"context_line":"                {\u0027uuid\u0027: tenant.network.id},"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a890539_c0bc39de","line":235,"updated":"2014-12-02 09:19:42.000000000","message":"I think this should be:\nsecurity_groups_name \u003d [{\u0027name\u0027: s[\u0027name\u0027]} for s in security_groups]","commit_id":"e46f58dadc7da463b91fc6f4f64aaaa01c04dd3f"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"3ea39768bcf291719a14fe5515dc8335ffc74ef3","unresolved":false,"context_lines":[{"line_number":232,"context_line":"            security_groups \u003d [tenant.security_groups[\u0027default\u0027]]"},{"line_number":233,"context_line":"        security_groups_name \u003d []"},{"line_number":234,"context_line":"        for s in security_groups:"},{"line_number":235,"context_line":"            security_groups_name.append({\u0027name\u0027: s[\u0027name\u0027]})"},{"line_number":236,"context_line":"        create_kwargs \u003d {"},{"line_number":237,"context_line":"            \u0027networks\u0027: ["},{"line_number":238,"context_line":"                {\u0027uuid\u0027: tenant.network.id},"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a890539_b9a3e8af","line":235,"in_reply_to":"5a890539_c0bc39de","updated":"2014-12-02 10:46:40.000000000","message":"Nice idea, thanks!","commit_id":"e46f58dadc7da463b91fc6f4f64aaaa01c04dd3f"}],"tempest/scenario/test_server_basic_ops.py":[{"author":{"_account_id":8576,"name":"Yair Fried","email":"yfried@redhat.com","username":"yfried"},"change_message_id":"b7dfa0acbae369c8059982387cd991b2e214ede7","unresolved":false,"context_lines":[{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    def boot_instance(self):"},{"line_number":70,"context_line":"        # Create server with image and flavor from input scenario"},{"line_number":71,"context_line":"        security_groups \u003d [{\u0027name\u0027: self.security_group[\u0027name\u0027]}]"},{"line_number":72,"context_line":"        create_kwargs \u003d {"},{"line_number":73,"context_line":"            \u0027key_name\u0027: self.keypair[\u0027name\u0027],"},{"line_number":74,"context_line":"            \u0027security_groups\u0027: security_groups"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a890539_a6fe6a03","line":71,"updated":"2014-12-02 06:58:00.000000000","message":"is this really the syntax? the dict format seems a little redundant. I assume this is for backward compatibility, but an explicit comment about that would be helpful.","commit_id":"12834499e53443adb93be6ed1355c526ef953328"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"93a110c0cc55eb190aa4d888b80325499465b3c8","unresolved":false,"context_lines":[{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    def boot_instance(self):"},{"line_number":70,"context_line":"        # Create server with image and flavor from input scenario"},{"line_number":71,"context_line":"        security_groups \u003d [{\u0027name\u0027: self.security_group[\u0027name\u0027]}]"},{"line_number":72,"context_line":"        create_kwargs \u003d {"},{"line_number":73,"context_line":"            \u0027key_name\u0027: self.keypair[\u0027name\u0027],"},{"line_number":74,"context_line":"            \u0027security_groups\u0027: security_groups"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a890539_06b73ef6","line":71,"in_reply_to":"5a890539_a6fe6a03","updated":"2014-12-02 07:36:17.000000000","message":"I think it is fine. Nova expect a list of dict objects containing sec grp name.\nschema is like below-\n{\n    \u0027security_groups\u0027: {\n        \u0027type\u0027: \u0027array\u0027,\n        \u0027items\u0027: {\n            \u0027type\u0027: \u0027object\u0027,\n            \u0027properties\u0027: {\n                \u0027name\u0027: parameter_types.name,\n            },\n            \u0027additionalProperties\u0027: False,\n        }\n    },\n}","commit_id":"12834499e53443adb93be6ed1355c526ef953328"}]}