)]}'
{"tempest/api/baremetal/admin/test_ports.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"b0993746c8011c8a1162d93694fbec4c2c66d957","unresolved":false,"context_lines":[{"line_number":99,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":100,"context_line":"    def test_create_port_with_extra_dict(self):"},{"line_number":101,"context_line":"        extra \u003d {\u0027key\u0027: {\u0027foo\u0027: \u0027bar\u0027}}"},{"line_number":102,"context_line":"        self._test_create_port_with_extra(extra)"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":105,"context_line":"    def test_delete_port(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a890539_5650af5d","line":102,"updated":"2014-12-04 09:18:22.000000000","message":"It will be good to add only 1 tests with all type of extra something\n\ndef test_create_port_with_mix_extra(self)\n    node_id \u003d self.node[\u0027uuid\u0027]\n    address \u003d data_utils.rand_mac_address()\n    extra \u003d { \u0027key\u0027: \u0027value\u0027,  \u0027key\u0027: 123, \u0027key\u0027: 0.123, \u0027key\u0027: True, \u0027key\u0027: [1, 2, 3], \u0027key\u0027: {\u0027foo\u0027:     \n                  \u0027bar\u0027}}\n    _, port \u003d self.create_port(node_id\u003dnode_id, address\u003daddress,\n                                             extra\u003dextra)\n    _, body \u003d self.client.show_port(port[\u0027uuid\u0027])\n    self._assertExpected(port, body)","commit_id":"6438a94270f32e8a12581b38f7fa0d545edf836c"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"5ab954c734241cf4a3523d933a8fbcde61864294","unresolved":false,"context_lines":[{"line_number":99,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":100,"context_line":"    def test_create_port_with_extra_dict(self):"},{"line_number":101,"context_line":"        extra \u003d {\u0027key\u0027: {\u0027foo\u0027: \u0027bar\u0027}}"},{"line_number":102,"context_line":"        self._test_create_port_with_extra(extra)"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":105,"context_line":"    def test_delete_port(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a890539_399cf369","line":102,"in_reply_to":"5a890539_5650af5d","updated":"2014-12-04 10:12:43.000000000","message":"Done","commit_id":"6438a94270f32e8a12581b38f7fa0d545edf836c"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"b0993746c8011c8a1162d93694fbec4c2c66d957","unresolved":false,"context_lines":[{"line_number":100,"context_line":"    def test_create_port_with_extra_dict(self):"},{"line_number":101,"context_line":"        extra \u003d {\u0027key\u0027: {\u0027foo\u0027: \u0027bar\u0027}}"},{"line_number":102,"context_line":"        self._test_create_port_with_extra(extra)"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":105,"context_line":"    def test_delete_port(self):"},{"line_number":106,"context_line":"        node_id \u003d self.node[\u0027uuid\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a890539_16b1c7df","line":103,"updated":"2014-12-04 09:18:22.000000000","message":"do you think we should add some tests for update too. It will be better if we add different \u0027extra/key\u0027 type in test_update_port_mixed_ops instead of new tests.","commit_id":"6438a94270f32e8a12581b38f7fa0d545edf836c"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"5ab954c734241cf4a3523d933a8fbcde61864294","unresolved":false,"context_lines":[{"line_number":100,"context_line":"    def test_create_port_with_extra_dict(self):"},{"line_number":101,"context_line":"        extra \u003d {\u0027key\u0027: {\u0027foo\u0027: \u0027bar\u0027}}"},{"line_number":102,"context_line":"        self._test_create_port_with_extra(extra)"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":105,"context_line":"    def test_delete_port(self):"},{"line_number":106,"context_line":"        node_id \u003d self.node[\u0027uuid\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a890539_b97f0316","line":103,"in_reply_to":"5a890539_16b1c7df","updated":"2014-12-04 10:12:43.000000000","message":"Done","commit_id":"6438a94270f32e8a12581b38f7fa0d545edf836c"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"b0993746c8011c8a1162d93694fbec4c2c66d957","unresolved":false,"context_lines":[{"line_number":101,"context_line":"        extra \u003d {\u0027key\u0027: {\u0027foo\u0027: \u0027bar\u0027}}"},{"line_number":102,"context_line":"        self._test_create_port_with_extra(extra)"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":105,"context_line":"    def test_delete_port(self):"},{"line_number":106,"context_line":"        node_id \u003d self.node[\u0027uuid\u0027]"},{"line_number":107,"context_line":"        address \u003d data_utils.rand_mac_address()"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a890539_16d2a7d0","line":104,"updated":"2014-12-04 09:18:22.000000000","message":"Also for \u0027properties\u0027 \u0026 \u0027driver_info\u0027 some tests with different type.","commit_id":"6438a94270f32e8a12581b38f7fa0d545edf836c"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"5ab954c734241cf4a3523d933a8fbcde61864294","unresolved":false,"context_lines":[{"line_number":101,"context_line":"        extra \u003d {\u0027key\u0027: {\u0027foo\u0027: \u0027bar\u0027}}"},{"line_number":102,"context_line":"        self._test_create_port_with_extra(extra)"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":105,"context_line":"    def test_delete_port(self):"},{"line_number":106,"context_line":"        node_id \u003d self.node[\u0027uuid\u0027]"},{"line_number":107,"context_line":"        address \u003d data_utils.rand_mac_address()"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a890539_1978172a","line":104,"in_reply_to":"5a890539_16d2a7d0","updated":"2014-12-04 10:12:43.000000000","message":"Yup, these fields are part of the nodes, so yeah I could add some","commit_id":"6438a94270f32e8a12581b38f7fa0d545edf836c"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"52889f94f4a977b50a37c648d72e585221c5105a","unresolved":false,"context_lines":[{"line_number":101,"context_line":"        extra \u003d {\u0027key\u0027: {\u0027foo\u0027: \u0027bar\u0027}}"},{"line_number":102,"context_line":"        self._test_create_port_with_extra(extra)"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":105,"context_line":"    def test_delete_port(self):"},{"line_number":106,"context_line":"        node_id \u003d self.node[\u0027uuid\u0027]"},{"line_number":107,"context_line":"        address \u003d data_utils.rand_mac_address()"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a890539_9fc067e1","line":104,"in_reply_to":"5a890539_1978172a","updated":"2014-12-04 11:15:28.000000000","message":"Hi Ghanshyam, \n\nI was trying to add the tests, but before that we should do a some refactor on the create_node() method[1], it\u0027s expecting some very specific values (which was valid for nova baremetal) and ironic is much more flexible, so it doesn\u0027t allow me to create a node with driver_info and then replace the values.\n\nI think it\u0027s a bit outside the scope of this patch to fix that, I will try to find some time to fix that in another patch and then add more tests.\n\n[1] https://github.com/openstack/tempest/blob/master/tempest/api/baremetal/admin/base.py#L105-L123","commit_id":"6438a94270f32e8a12581b38f7fa0d545edf836c"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"71bd2ae3f3cf2e2a1ad9fa7f449969dbb2af596a","unresolved":false,"context_lines":[{"line_number":101,"context_line":"        extra \u003d {\u0027key\u0027: {\u0027foo\u0027: \u0027bar\u0027}}"},{"line_number":102,"context_line":"        self._test_create_port_with_extra(extra)"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":105,"context_line":"    def test_delete_port(self):"},{"line_number":106,"context_line":"        node_id \u003d self.node[\u0027uuid\u0027]"},{"line_number":107,"context_line":"        address \u003d data_utils.rand_mac_address()"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a890539_5f50bf2b","line":104,"in_reply_to":"5a890539_9fc067e1","updated":"2014-12-04 11:19:30.000000000","message":"I see. That sounds fine to have those tests in another patch. Thanks","commit_id":"6438a94270f32e8a12581b38f7fa0d545edf836c"}],"tempest/api/baremetal/admin/test_ports_negative.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"b0993746c8011c8a1162d93694fbec4c2c66d957","unresolved":false,"context_lines":[{"line_number":168,"context_line":"        port_id \u003d port[\u0027uuid\u0027]"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"        self.assertRaises(exc.BadRequest, self.client.update_port, port_id,"},{"line_number":171,"context_line":"                          [{\u0027path\u0027: \u0027/extra/key\u0027, \u0027 op\u0027: \u0027add\u0027,"},{"line_number":172,"context_line":"                            \u0027value\u0027: 0.123}])"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"    @test.attr(type\u003d[\u0027negative\u0027, \u0027smoke\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a890539_56926f9f","side":"PARENT","line":171,"updated":"2014-12-04 09:18:22.000000000","message":"This tests also should be deleted?","commit_id":"2c8c14846935f96fa5523599caeaaafafb8dddd6"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"5ab954c734241cf4a3523d933a8fbcde61864294","unresolved":false,"context_lines":[{"line_number":168,"context_line":"        port_id \u003d port[\u0027uuid\u0027]"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"        self.assertRaises(exc.BadRequest, self.client.update_port, port_id,"},{"line_number":171,"context_line":"                          [{\u0027path\u0027: \u0027/extra/key\u0027, \u0027 op\u0027: \u0027add\u0027,"},{"line_number":172,"context_line":"                            \u0027value\u0027: 0.123}])"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"    @test.attr(type\u003d[\u0027negative\u0027, \u0027smoke\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a890539_79b75bd8","side":"PARENT","line":171,"in_reply_to":"5a890539_56926f9f","updated":"2014-12-04 10:12:43.000000000","message":"Done","commit_id":"2c8c14846935f96fa5523599caeaaafafb8dddd6"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"b0993746c8011c8a1162d93694fbec4c2c66d957","unresolved":false,"context_lines":[{"line_number":181,"context_line":""},{"line_number":182,"context_line":"        self.assertRaises(exc.BadRequest, self.client.update_port, port_id,"},{"line_number":183,"context_line":"                          [{\u0027path\u0027: \u0027/extra\u0027,"},{"line_number":184,"context_line":"                            \u0027op\u0027: \u0027add\u0027,"},{"line_number":185,"context_line":"                            \u0027value\u0027: [1, 2, 3, 4, \u0027a\u0027]}])"},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"    @test.attr(type\u003d[\u0027negative\u0027, \u0027smoke\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a890539_16f467ef","side":"PARENT","line":184,"updated":"2014-12-04 09:18:22.000000000","message":"ditto","commit_id":"2c8c14846935f96fa5523599caeaaafafb8dddd6"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"5ab954c734241cf4a3523d933a8fbcde61864294","unresolved":false,"context_lines":[{"line_number":181,"context_line":""},{"line_number":182,"context_line":"        self.assertRaises(exc.BadRequest, self.client.update_port, port_id,"},{"line_number":183,"context_line":"                          [{\u0027path\u0027: \u0027/extra\u0027,"},{"line_number":184,"context_line":"                            \u0027op\u0027: \u0027add\u0027,"},{"line_number":185,"context_line":"                            \u0027value\u0027: [1, 2, 3, 4, \u0027a\u0027]}])"},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"    @test.attr(type\u003d[\u0027negative\u0027, \u0027smoke\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a890539_99ba47be","side":"PARENT","line":184,"in_reply_to":"5a890539_16f467ef","updated":"2014-12-04 10:12:43.000000000","message":"Done","commit_id":"2c8c14846935f96fa5523599caeaaafafb8dddd6"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"b0993746c8011c8a1162d93694fbec4c2c66d957","unresolved":false,"context_lines":[{"line_number":281,"context_line":"        port_id \u003d port[\u0027uuid\u0027]"},{"line_number":282,"context_line":""},{"line_number":283,"context_line":"        patch \u003d [{\u0027path\u0027: \u0027/extra\u0027,"},{"line_number":284,"context_line":"                  \u0027op\u0027: \u0027replace\u0027,"},{"line_number":285,"context_line":"                  \u0027value\u0027: [1, 2, 3, 4, \u0027a\u0027]}]"},{"line_number":286,"context_line":""},{"line_number":287,"context_line":"        self.assertRaises(exc.BadRequest,"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a890539_f6c7db95","side":"PARENT","line":284,"updated":"2014-12-04 09:18:22.000000000","message":"ditto","commit_id":"2c8c14846935f96fa5523599caeaaafafb8dddd6"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"5ab954c734241cf4a3523d933a8fbcde61864294","unresolved":false,"context_lines":[{"line_number":281,"context_line":"        port_id \u003d port[\u0027uuid\u0027]"},{"line_number":282,"context_line":""},{"line_number":283,"context_line":"        patch \u003d [{\u0027path\u0027: \u0027/extra\u0027,"},{"line_number":284,"context_line":"                  \u0027op\u0027: \u0027replace\u0027,"},{"line_number":285,"context_line":"                  \u0027value\u0027: [1, 2, 3, 4, \u0027a\u0027]}]"},{"line_number":286,"context_line":""},{"line_number":287,"context_line":"        self.assertRaises(exc.BadRequest,"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a890539_b9ad4386","side":"PARENT","line":284,"in_reply_to":"5a890539_f6c7db95","updated":"2014-12-04 10:12:43.000000000","message":"Done","commit_id":"2c8c14846935f96fa5523599caeaaafafb8dddd6"}]}