)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":12632,"name":"Kirill Shileev","email":"kshileev@cisco.com","username":"kshileev"},"change_message_id":"6302946357026302b2ab7919c5a2497079a7a3ef","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add ipsec-site-connections to resource map of a network client"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Lines #35 and #32, #54 and #52 are identical."},{"line_number":10,"context_line":"The removes duplicated lines and it adds ipsec-site-connections"},{"line_number":11,"context_line":"resource"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I606a5c62ba932ac0f7e6d3cf825e9c5440ffa0d8"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3a961159_544d243d","line":10,"updated":"2014-12-22 14:08:14.000000000","message":"s/The//\ns/it//\nplz explain why ipsec-site-connections is added","commit_id":"7cac10be2054a0adc16081e283ef8bcc7cadb922"}],"tempest/services/network/json/network_client.py":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"03cf8cbd3fbfc5b635b499868db7bd702d256562","unresolved":false,"context_lines":[{"line_number":68,"context_line":"            \u0027ipsecpolicies\u0027: \u0027vpn\u0027,"},{"line_number":69,"context_line":"            \u0027vpnservices\u0027: \u0027vpn\u0027,"},{"line_number":70,"context_line":"            \u0027ikepolicies\u0027: \u0027vpn\u0027,"},{"line_number":71,"context_line":"            \u0027ipsec-site-connections\u0027: \u0027vpn\u0027,"},{"line_number":72,"context_line":"            \u0027metering_labels\u0027: \u0027metering\u0027,"},{"line_number":73,"context_line":"            \u0027metering_label_rules\u0027: \u0027metering\u0027,"},{"line_number":74,"context_line":"            \u0027firewall_rules\u0027: \u0027fw\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a930d6b_ff21d99f","line":71,"updated":"2015-01-23 13:47:12.000000000","message":"Why does the name contain hyphens?\n\nNeutron\u0027s neutron/extensions/vpnaas.py is\n\n 144     \u0027ipsec_site_connections\u0027: {\n 145         \u0027id\u0027: {\u0027allow_post\u0027: False, \u0027allow_put\u0027: False,\n 146                \u0027validate\u0027: {\u0027type:uuid\u0027: None},\n 147                \u0027is_visible\u0027: True,\n 148                \u0027primary_key\u0027: True},\n\nand the other names in this dict also contain \"_\" instead of \"-\".\nSo this name seems inconsistent.","commit_id":"e4d52d6447cdcf6116f72f8e93b3cb73d6a4eb18"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"7557f20c31b6851e3eeb1099c2594a236f501373","unresolved":false,"context_lines":[{"line_number":68,"context_line":"            \u0027ipsecpolicies\u0027: \u0027vpn\u0027,"},{"line_number":69,"context_line":"            \u0027vpnservices\u0027: \u0027vpn\u0027,"},{"line_number":70,"context_line":"            \u0027ikepolicies\u0027: \u0027vpn\u0027,"},{"line_number":71,"context_line":"            \u0027ipsec-site-connections\u0027: \u0027vpn\u0027,"},{"line_number":72,"context_line":"            \u0027metering_labels\u0027: \u0027metering\u0027,"},{"line_number":73,"context_line":"            \u0027metering_label_rules\u0027: \u0027metering\u0027,"},{"line_number":74,"context_line":"            \u0027firewall_rules\u0027: \u0027fw\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa81d914_6a9ffeb4","line":71,"in_reply_to":"1a930d6b_9ecfc07e","updated":"2015-01-29 09:24:13.000000000","message":"Thanks for your explanation,\n\nAccording to https://github.com/openstack/python-neutronclient/blob/master/neutronclient/v2_0/client.py#L179 , this change seems right.","commit_id":"e4d52d6447cdcf6116f72f8e93b3cb73d6a4eb18"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"7b2e5f07a685f0c67a8f9f9400aec1538d63312b","unresolved":false,"context_lines":[{"line_number":68,"context_line":"            \u0027ipsecpolicies\u0027: \u0027vpn\u0027,"},{"line_number":69,"context_line":"            \u0027vpnservices\u0027: \u0027vpn\u0027,"},{"line_number":70,"context_line":"            \u0027ikepolicies\u0027: \u0027vpn\u0027,"},{"line_number":71,"context_line":"            \u0027ipsec-site-connections\u0027: \u0027vpn\u0027,"},{"line_number":72,"context_line":"            \u0027metering_labels\u0027: \u0027metering\u0027,"},{"line_number":73,"context_line":"            \u0027metering_label_rules\u0027: \u0027metering\u0027,"},{"line_number":74,"context_line":"            \u0027firewall_rules\u0027: \u0027fw\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a930d6b_fd246a61","line":71,"in_reply_to":"1a930d6b_d5330ca9","updated":"2015-01-24 01:37:13.000000000","message":"Does it mean the other URL is \"/metering/metering_labels\"?\nIf so, current Neutron API\u0027s URLs seems inconsistent interfaces(some URLs include \"-\" but the other ones contain \"_\").","commit_id":"e4d52d6447cdcf6116f72f8e93b3cb73d6a4eb18"},{"author":{"_account_id":8767,"name":"Nikolay Fedotov","email":"nfedotov@cisco.com","username":"nfedotov"},"change_message_id":"83f230e02cdf1150f4d3fe24e52edb0160192516","unresolved":false,"context_lines":[{"line_number":68,"context_line":"            \u0027ipsecpolicies\u0027: \u0027vpn\u0027,"},{"line_number":69,"context_line":"            \u0027vpnservices\u0027: \u0027vpn\u0027,"},{"line_number":70,"context_line":"            \u0027ikepolicies\u0027: \u0027vpn\u0027,"},{"line_number":71,"context_line":"            \u0027ipsec-site-connections\u0027: \u0027vpn\u0027,"},{"line_number":72,"context_line":"            \u0027metering_labels\u0027: \u0027metering\u0027,"},{"line_number":73,"context_line":"            \u0027metering_label_rules\u0027: \u0027metering\u0027,"},{"line_number":74,"context_line":"            \u0027firewall_rules\u0027: \u0027fw\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a930d6b_9ecfc07e","line":71,"in_reply_to":"1a930d6b_fd246a61","updated":"2015-01-26 13:41:33.000000000","message":"Hmm, yes it means the URL should be \"/metering/metering_labels\" but the URL is /v2.0/metering-labels. \nHave you ever run MeteringTestJSON tests? They are skipped in all check-tempest-dsvm-full jobs due to \"SKIPPED: Neutron support is required\". I suppose MeteringTestJSON tests should not work.","commit_id":"e4d52d6447cdcf6116f72f8e93b3cb73d6a4eb18"},{"author":{"_account_id":8767,"name":"Nikolay Fedotov","email":"nfedotov@cisco.com","username":"nfedotov"},"change_message_id":"4da045c55a138346917444de6dfe0552323fca04","unresolved":false,"context_lines":[{"line_number":68,"context_line":"            \u0027ipsecpolicies\u0027: \u0027vpn\u0027,"},{"line_number":69,"context_line":"            \u0027vpnservices\u0027: \u0027vpn\u0027,"},{"line_number":70,"context_line":"            \u0027ikepolicies\u0027: \u0027vpn\u0027,"},{"line_number":71,"context_line":"            \u0027ipsec-site-connections\u0027: \u0027vpn\u0027,"},{"line_number":72,"context_line":"            \u0027metering_labels\u0027: \u0027metering\u0027,"},{"line_number":73,"context_line":"            \u0027metering_label_rules\u0027: \u0027metering\u0027,"},{"line_number":74,"context_line":"            \u0027firewall_rules\u0027: \u0027fw\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a930d6b_d5330ca9","line":71,"in_reply_to":"1a930d6b_ff21d99f","updated":"2015-01-23 22:11:42.000000000","message":"Yes, json data has a key \"ipsec_site_connection\" but URI is \"/vpn/ipsec-site-connections\" (contains \"-\").\n\nThese two dicts help to build correct URI in _deleter, _shower, _creater and _updater methods. So everything is ok here.","commit_id":"e4d52d6447cdcf6116f72f8e93b3cb73d6a4eb18"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"03cf8cbd3fbfc5b635b499868db7bd702d256562","unresolved":false,"context_lines":[{"line_number":96,"context_line":"            \u0027security_group_rules\u0027: \u0027security_group_rules\u0027,"},{"line_number":97,"context_line":"            \u0027ipsecpolicy\u0027: \u0027ipsecpolicies\u0027,"},{"line_number":98,"context_line":"            \u0027ikepolicy\u0027: \u0027ikepolicies\u0027,"},{"line_number":99,"context_line":"            \u0027ipsec_site_connection\u0027: \u0027ipsec-site-connections\u0027,"},{"line_number":100,"context_line":"            \u0027quotas\u0027: \u0027quotas\u0027,"},{"line_number":101,"context_line":"            \u0027firewall_policy\u0027: \u0027firewall_policies\u0027"},{"line_number":102,"context_line":"        }"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a930d6b_3f3b61d2","line":99,"updated":"2015-01-23 13:47:12.000000000","message":"ditto: the second name","commit_id":"e4d52d6447cdcf6116f72f8e93b3cb73d6a4eb18"}]}
