)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"d1e05915e5b5fe33fe51330f18692dc0d78c8706","unresolved":false,"context_lines":[{"line_number":9,"context_line":" -check the vm connectivity fails as there is no icmp rule"},{"line_number":10,"context_line":" -create an icmp security group rule"},{"line_number":11,"context_line":" -attach it to the already existing security group \"def_sg\""},{"line_number":12,"context_line":" -Now acces Vm will consists of two security groups that is acces_sg(with ssh rule) and def_sg(with icmp rule)"},{"line_number":13,"context_line":" -check tenant vm connectivity based on the rule associated.(both ssh and ping)"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I8e806056bc6197a3189e827c0b182b7c4bdbdf41"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3a961159_d7ecb62c","line":12,"updated":"2014-12-12 13:13:46.000000000","message":"Line too long","commit_id":"800e6be39552bb610d04e4f4b2d85ea58fdd1f0f"}],"tempest/scenario/test_security_groups_basic_ops.py":[{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"332bd29ba986ba6f61edfa8ec84f0ec4d496f499","unresolved":false,"context_lines":[{"line_number":473,"context_line":"                                     floating\u003dself.floating_ip_access)"},{"line_number":474,"context_line":"            ssh_login \u003d CONF.compute.image_ssh_user"},{"line_number":475,"context_line":"            private_key \u003d tenant.keypair[\u0027private_key\u0027]"},{"line_number":476,"context_line":"            self.check_vm_connectivity(ip,"},{"line_number":477,"context_line":"                                       username\u003dssh_login,"},{"line_number":478,"context_line":"                                       private_key\u003dprivate_key,"},{"line_number":479,"context_line":"                                       should_connect\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a961159_84d008ca","line":476,"updated":"2014-12-15 14:00:43.000000000","message":"This is misleading. check_vm_connectivity doesn\u0027t try to perform an ssh connection when should_connect \u003d\u003d False. Please remove the \"username\" and \"private_key\" argument.","commit_id":"4d8b81f67a3aef276ed54eecf2da597a38872551"},{"author":{"_account_id":12714,"name":"Preethi Dsilva","email":"preethi.dsilva@hpe.com","username":"prdsilva"},"change_message_id":"54416bd23bdcf821ee6af4f98640aa45b11ee8dd","unresolved":false,"context_lines":[{"line_number":473,"context_line":"                                     floating\u003dself.floating_ip_access)"},{"line_number":474,"context_line":"            ssh_login \u003d CONF.compute.image_ssh_user"},{"line_number":475,"context_line":"            private_key \u003d tenant.keypair[\u0027private_key\u0027]"},{"line_number":476,"context_line":"            self.check_vm_connectivity(ip,"},{"line_number":477,"context_line":"                                       username\u003dssh_login,"},{"line_number":478,"context_line":"                                       private_key\u003dprivate_key,"},{"line_number":479,"context_line":"                                       should_connect\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a961159_27e49aab","line":476,"in_reply_to":"3a961159_84d008ca","updated":"2014-12-18 06:29:37.000000000","message":"Thank you for the comment Jordan.I have removed the username,private_key arguments","commit_id":"4d8b81f67a3aef276ed54eecf2da597a38872551"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"332bd29ba986ba6f61edfa8ec84f0ec4d496f499","unresolved":false,"context_lines":[{"line_number":485,"context_line":"                secgroup\u003dtenant.security_groups[\u0027default\u0027],"},{"line_number":486,"context_line":"                **ruleset"},{"line_number":487,"context_line":"            )"},{"line_number":488,"context_line":"            self.check_vm_connectivity(ip,"},{"line_number":489,"context_line":"                                       username\u003dssh_login,"},{"line_number":490,"context_line":"                                       private_key\u003dprivate_key,"},{"line_number":491,"context_line":"                                       should_connect\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a961159_c4b21093","line":488,"updated":"2014-12-15 14:00:43.000000000","message":"It took me a while to understand why adding a sec rule for ICMP would make the ssh check_vm_connectivity to now pass.\n\nMaybe you could add a comment that says that check_connectivity performs an ICMP ping before attempting an SSH connection. And a note that says the SSH sec rule was added in setUp() method.","commit_id":"4d8b81f67a3aef276ed54eecf2da597a38872551"},{"author":{"_account_id":12714,"name":"Preethi Dsilva","email":"preethi.dsilva@hpe.com","username":"prdsilva"},"change_message_id":"54416bd23bdcf821ee6af4f98640aa45b11ee8dd","unresolved":false,"context_lines":[{"line_number":485,"context_line":"                secgroup\u003dtenant.security_groups[\u0027default\u0027],"},{"line_number":486,"context_line":"                **ruleset"},{"line_number":487,"context_line":"            )"},{"line_number":488,"context_line":"            self.check_vm_connectivity(ip,"},{"line_number":489,"context_line":"                                       username\u003dssh_login,"},{"line_number":490,"context_line":"                                       private_key\u003dprivate_key,"},{"line_number":491,"context_line":"                                       should_connect\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a961159_c7ecb692","line":488,"in_reply_to":"3a961159_c4b21093","updated":"2014-12-18 06:29:37.000000000","message":"I have added the comment section which gives insight into the operation performed.","commit_id":"4d8b81f67a3aef276ed54eecf2da597a38872551"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"332bd29ba986ba6f61edfa8ec84f0ec4d496f499","unresolved":false,"context_lines":[{"line_number":490,"context_line":"                                       private_key\u003dprivate_key,"},{"line_number":491,"context_line":"                                       should_connect\u003dTrue)"},{"line_number":492,"context_line":""},{"line_number":493,"context_line":"        except Exception:"},{"line_number":494,"context_line":"            self._log_console_output(servers\u003dtenant.access_point)"},{"line_number":495,"context_line":"            raise"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a961159_91a12548","line":493,"updated":"2014-12-15 14:00:43.000000000","message":"I am not sure this general try/except helps here. There\u0027s already a call to _log_console_output() in get_remote_client() (called by check_vm_connectivity) if something goes wrong.","commit_id":"4d8b81f67a3aef276ed54eecf2da597a38872551"},{"author":{"_account_id":12714,"name":"Preethi Dsilva","email":"preethi.dsilva@hpe.com","username":"prdsilva"},"change_message_id":"54416bd23bdcf821ee6af4f98640aa45b11ee8dd","unresolved":false,"context_lines":[{"line_number":490,"context_line":"                                       private_key\u003dprivate_key,"},{"line_number":491,"context_line":"                                       should_connect\u003dTrue)"},{"line_number":492,"context_line":""},{"line_number":493,"context_line":"        except Exception:"},{"line_number":494,"context_line":"            self._log_console_output(servers\u003dtenant.access_point)"},{"line_number":495,"context_line":"            raise"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a961159_5ce129fd","line":493,"in_reply_to":"3a961159_91a12548","updated":"2014-12-18 06:29:37.000000000","message":"I have removed the try/except section as exception is taken care already in check_vm_connectivity","commit_id":"4d8b81f67a3aef276ed54eecf2da597a38872551"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"381d0c6f65b360a9a93158add3ac10c2926f22e9","unresolved":false,"context_lines":[{"line_number":483,"context_line":"            **ruleset"},{"line_number":484,"context_line":"        )"},{"line_number":485,"context_line":"        \"\"\""},{"line_number":486,"context_line":"        Vm now consists of 2 security groups one with ssh rule("},{"line_number":487,"context_line":"        already added in setUp setcion),and other with icmp rule"},{"line_number":488,"context_line":"        (added in above step).The check_vm_connectivity tests"},{"line_number":489,"context_line":"        -that vm ping test is successful"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a961159_2510bda7","line":486,"updated":"2014-12-18 10:24:42.000000000","message":"I would replace \"consists of\" with \"has\".","commit_id":"76fc7a73b4f7c8876fa0996355a35bf89f50d49e"},{"author":{"_account_id":12714,"name":"Preethi Dsilva","email":"preethi.dsilva@hpe.com","username":"prdsilva"},"change_message_id":"a19bb53aad67c78729b54021c13cf1c0115e7c86","unresolved":false,"context_lines":[{"line_number":483,"context_line":"            **ruleset"},{"line_number":484,"context_line":"        )"},{"line_number":485,"context_line":"        \"\"\""},{"line_number":486,"context_line":"        Vm now consists of 2 security groups one with ssh rule("},{"line_number":487,"context_line":"        already added in setUp setcion),and other with icmp rule"},{"line_number":488,"context_line":"        (added in above step).The check_vm_connectivity tests"},{"line_number":489,"context_line":"        -that vm ping test is successful"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a961159_080af820","line":486,"in_reply_to":"3a961159_2510bda7","updated":"2014-12-18 10:42:08.000000000","message":"Modified","commit_id":"76fc7a73b4f7c8876fa0996355a35bf89f50d49e"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"381d0c6f65b360a9a93158add3ac10c2926f22e9","unresolved":false,"context_lines":[{"line_number":484,"context_line":"        )"},{"line_number":485,"context_line":"        \"\"\""},{"line_number":486,"context_line":"        Vm now consists of 2 security groups one with ssh rule("},{"line_number":487,"context_line":"        already added in setUp setcion),and other with icmp rule"},{"line_number":488,"context_line":"        (added in above step).The check_vm_connectivity tests"},{"line_number":489,"context_line":"        -that vm ping test is successful"},{"line_number":490,"context_line":"        -ssh to vm is successful"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a961159_055bc187","line":487,"updated":"2014-12-18 10:24:42.000000000","message":"I would replace \"setUp setcion\" (there\u0027s a typo here) by \"setUp() method\".","commit_id":"76fc7a73b4f7c8876fa0996355a35bf89f50d49e"},{"author":{"_account_id":12714,"name":"Preethi Dsilva","email":"preethi.dsilva@hpe.com","username":"prdsilva"},"change_message_id":"a19bb53aad67c78729b54021c13cf1c0115e7c86","unresolved":false,"context_lines":[{"line_number":484,"context_line":"        )"},{"line_number":485,"context_line":"        \"\"\""},{"line_number":486,"context_line":"        Vm now consists of 2 security groups one with ssh rule("},{"line_number":487,"context_line":"        already added in setUp setcion),and other with icmp rule"},{"line_number":488,"context_line":"        (added in above step).The check_vm_connectivity tests"},{"line_number":489,"context_line":"        -that vm ping test is successful"},{"line_number":490,"context_line":"        -ssh to vm is successful"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a961159_2516fd55","line":487,"in_reply_to":"3a961159_055bc187","updated":"2014-12-18 10:42:08.000000000","message":"Modified","commit_id":"76fc7a73b4f7c8876fa0996355a35bf89f50d49e"},{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"76be3b03fec3224dc9ed5643eaec8b36d8054317","unresolved":false,"context_lines":[{"line_number":484,"context_line":"        )"},{"line_number":485,"context_line":"        \"\"\""},{"line_number":486,"context_line":"        Vm now has 2 security groups one with ssh rule("},{"line_number":487,"context_line":"        already added in setUp() method),and other with icmp rule"},{"line_number":488,"context_line":"        (added in the above step).The check_vm_connectivity tests"},{"line_number":489,"context_line":"        -that vm ping test is successful"},{"line_number":490,"context_line":"        -ssh to vm is successful"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a961159_f944b948","line":487,"updated":"2014-12-31 11:50:39.000000000","message":"The rule is added to SG \"default\", there\u0027s no other SG added here, just another rule to the same SG.","commit_id":"5f4e160a1dcf92f6a4e70164e1409323999230fc"},{"author":{"_account_id":12714,"name":"Preethi Dsilva","email":"preethi.dsilva@hpe.com","username":"prdsilva"},"change_message_id":"ac53eda201f22e4dd52c50dbb5b75b1a7ce49f13","unresolved":false,"context_lines":[{"line_number":484,"context_line":"        )"},{"line_number":485,"context_line":"        \"\"\""},{"line_number":486,"context_line":"        Vm now has 2 security groups one with ssh rule("},{"line_number":487,"context_line":"        already added in setUp() method),and other with icmp rule"},{"line_number":488,"context_line":"        (added in the above step).The check_vm_connectivity tests"},{"line_number":489,"context_line":"        -that vm ping test is successful"},{"line_number":490,"context_line":"        -ssh to vm is successful"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a961159_6555d3c0","line":487,"in_reply_to":"3a961159_f944b948","updated":"2015-01-09 09:32:11.000000000","message":"Here vm used is access vm which has 2 SG created with ssh rule added in setUp() method itself ,in the test case I have added icmp rule to one of the SG\u0027s created in setUp method.so we will now have 2 SG\u0027s with each having a rule","commit_id":"5f4e160a1dcf92f6a4e70164e1409323999230fc"},{"author":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"change_message_id":"5c2782dbe410ed6c8847efeaa36e2e4a07a1bcff","unresolved":false,"context_lines":[{"line_number":533,"context_line":"            direction\u003d\u0027ingress\u0027"},{"line_number":534,"context_line":"        )"},{"line_number":535,"context_line":"        self._create_security_group_rule("},{"line_number":536,"context_line":"            secgroup\u003dtenant.security_groups[\u0027default\u0027],"},{"line_number":537,"context_line":"            **ruleset"},{"line_number":538,"context_line":"        )"},{"line_number":539,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":5,"id":"da86d52c_9067cce8","line":536,"updated":"2015-02-04 10:15:39.000000000","message":"The \u0027default\u0027 security group should not be changed. It may cases issues when the \u0027allow_tenant_isolation \u003d false\u0027.\n\nCan you create 3th group ?","commit_id":"8b733ad2c8ea70616bb2e92e8ba763500ee50454"},{"author":{"_account_id":1192,"name":"David Kranz","email":"dkranz@redhat.com","username":"david-kranz"},"change_message_id":"143c51e8947bdb0836c309069430b7fa749431b6","unresolved":false,"context_lines":[{"line_number":533,"context_line":"            direction\u003d\u0027ingress\u0027"},{"line_number":534,"context_line":"        )"},{"line_number":535,"context_line":"        self._create_security_group_rule("},{"line_number":536,"context_line":"            secgroup\u003dtenant.security_groups[\u0027default\u0027],"},{"line_number":537,"context_line":"            **ruleset"},{"line_number":538,"context_line":"        )"},{"line_number":539,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":5,"id":"da86d52c_3f5c8825","line":536,"in_reply_to":"da86d52c_9067cce8","updated":"2015-02-09 15:14:15.000000000","message":"afazekas: This call will do an addCleanup for the new rule. Why is this a problem? Parallel is not allowed with no tenant isolation.","commit_id":"8b733ad2c8ea70616bb2e92e8ba763500ee50454"}]}