)]}'
{"tempest/api/volume/test_volumes_snapshots.py":[{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"5e2c401607f1c2a0572a418368eeac7352a237de","unresolved":false,"context_lines":[{"line_number":82,"context_line":"        self.snapshots_client.wait_for_resource_deletion(snapshot[\u0027id\u0027])"},{"line_number":83,"context_line":"        self.snapshots.remove(snapshot)"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"        # Detach a volume from a test instance"},{"line_number":86,"context_line":"        self.servers_client.detach_volume(server[\u0027id\u0027],"},{"line_number":87,"context_line":"                                          self.volume_origin[\u0027id\u0027])"},{"line_number":88,"context_line":"        self.volumes_client.wait_for_volume_status(self.volume_origin[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a961159_8a7e4e68","line":85,"updated":"2014-12-15 15:00:40.000000000","message":"I would prefer if this continued to be handled via addCleanup. You can for instance define a function in here with the two commands below.","commit_id":"4efab57f97720652b05275cd11c09af1a6a229b6"},{"author":{"_account_id":6983,"name":"YangLei","email":"iamhappg@aliyun.com","username":"YangLei"},"change_message_id":"4122436a87ae0bd13ec543d28af791f801de5c2a","unresolved":false,"context_lines":[{"line_number":70,"context_line":"        self.addCleanup(self.servers_client.delete_server, server[\u0027id\u0027])"},{"line_number":71,"context_line":"        self.servers_client.wait_for_server_status(server[\u0027id\u0027], \u0027ACTIVE\u0027)"},{"line_number":72,"context_line":"        mountpoint \u003d \u0027/dev/%s\u0027 % CONF.compute.volume_device_name"},{"line_number":73,"context_line":"        _, body \u003d self.servers_client.attach_volume("},{"line_number":74,"context_line":"            server[\u0027id\u0027], self.volume_origin[\u0027id\u0027], mountpoint)"},{"line_number":75,"context_line":"        self.volumes_client.wait_for_volume_status(self.volume_origin[\u0027id\u0027],"},{"line_number":76,"context_line":"                                                   \u0027in-use\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a961159_06cb8053","line":73,"updated":"2014-12-22 03:22:33.000000000","message":"Should this test go to tempest/api/compute/volume due to using Nova \"os-volume_attachment\"?","commit_id":"ab667960ef337538cf777bb0f325cb5d0e865d76"},{"author":{"_account_id":6983,"name":"YangLei","email":"iamhappg@aliyun.com","username":"YangLei"},"change_message_id":"9e4c32f52d8e06ff049888f2b3723fe7384090c2","unresolved":false,"context_lines":[{"line_number":70,"context_line":"        self.addCleanup(self.servers_client.delete_server, server[\u0027id\u0027])"},{"line_number":71,"context_line":"        self.servers_client.wait_for_server_status(server[\u0027id\u0027], \u0027ACTIVE\u0027)"},{"line_number":72,"context_line":"        mountpoint \u003d \u0027/dev/%s\u0027 % CONF.compute.volume_device_name"},{"line_number":73,"context_line":"        _, body \u003d self.servers_client.attach_volume("},{"line_number":74,"context_line":"            server[\u0027id\u0027], self.volume_origin[\u0027id\u0027], mountpoint)"},{"line_number":75,"context_line":"        self.volumes_client.wait_for_volume_status(self.volume_origin[\u0027id\u0027],"},{"line_number":76,"context_line":"                                                   \u0027in-use\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a961159_c6fb3879","line":73,"in_reply_to":"3a961159_06cb8053","updated":"2014-12-22 03:26:28.000000000","message":"It looks good here too. Will remove the -1","commit_id":"ab667960ef337538cf777bb0f325cb5d0e865d76"},{"author":{"_account_id":10115,"name":"Mitsuhiro Tanino","email":"mitsuhiro.tanino@lycorp.co.jp","username":"mtanino"},"change_message_id":"e282e1c8b0eb1daee45eb3283ab63ba0b71a754e","unresolved":false,"context_lines":[{"line_number":70,"context_line":"        self.addCleanup(self.servers_client.delete_server, server[\u0027id\u0027])"},{"line_number":71,"context_line":"        self.servers_client.wait_for_server_status(server[\u0027id\u0027], \u0027ACTIVE\u0027)"},{"line_number":72,"context_line":"        mountpoint \u003d \u0027/dev/%s\u0027 % CONF.compute.volume_device_name"},{"line_number":73,"context_line":"        _, body \u003d self.servers_client.attach_volume("},{"line_number":74,"context_line":"            server[\u0027id\u0027], self.volume_origin[\u0027id\u0027], mountpoint)"},{"line_number":75,"context_line":"        self.volumes_client.wait_for_volume_status(self.volume_origin[\u0027id\u0027],"},{"line_number":76,"context_line":"                                                   \u0027in-use\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a961159_a1053612","line":73,"in_reply_to":"3a961159_c6fb3879","updated":"2014-12-22 04:15:32.000000000","message":"Thank you for your review. Yes, we need this test here for Cinder cert test :)","commit_id":"ab667960ef337538cf777bb0f325cb5d0e865d76"}]}