)]}'
{"tempest/api/network/test_routers.py":[{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"bdce9b22309b037ebe4e548c06ad1b513ce040fe","unresolved":false,"context_lines":[{"line_number":301,"context_line":"        self.assertEqual(next_hop,"},{"line_number":302,"context_line":"                         show_body[\u0027router\u0027][\u0027routes\u0027][0][\u0027nexthop\u0027])"},{"line_number":303,"context_line":""},{"line_number":304,"context_line":"    def _delete_extra_routes(self, router_id):"},{"line_number":305,"context_line":"        self.client.delete_extra_routes(router_id)"},{"line_number":306,"context_line":""},{"line_number":307,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"}],"source_content_type":"text/x-python","patch_set":9,"id":"3a961159_1d02940b","line":304,"updated":"2014-12-16 01:38:43.000000000","message":"(No action required) This function should probably be inlined.","commit_id":"c3eb492da590356bb1727731c46663b0ef6a7d56"}],"tempest/cmd/verify_tempest_config.py":[{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"bdce9b22309b037ebe4e548c06ad1b513ce040fe","unresolved":false,"context_lines":[{"line_number":167,"context_line":"    if service \u003d\u003d \u0027neutron\u0027:"},{"line_number":168,"context_line":"        resp \u003d extensions_client.list_extensions()"},{"line_number":169,"context_line":"    else:"},{"line_number":170,"context_line":"        __, resp \u003d extensions_client.list_extensions()"},{"line_number":171,"context_line":"    # For Nova, Cinder and Neutron we use the alias name rather than the"},{"line_number":172,"context_line":"    # \u0027name\u0027 field because the alias is considered to be the canonical"},{"line_number":173,"context_line":"    # name."}],"source_content_type":"text/x-python","patch_set":9,"id":"3a961159_d80e5a32","line":170,"updated":"2014-12-16 01:38:43.000000000","message":"(No action required) Is any another project considering doing something similar?","commit_id":"c3eb492da590356bb1727731c46663b0ef6a7d56"},{"author":{"_account_id":1192,"name":"David Kranz","email":"dkranz@redhat.com","username":"david-kranz"},"change_message_id":"18cfda965d43ee7681a8d826203539077797e079","unresolved":false,"context_lines":[{"line_number":167,"context_line":"    if service \u003d\u003d \u0027neutron\u0027:"},{"line_number":168,"context_line":"        resp \u003d extensions_client.list_extensions()"},{"line_number":169,"context_line":"    else:"},{"line_number":170,"context_line":"        __, resp \u003d extensions_client.list_extensions()"},{"line_number":171,"context_line":"    # For Nova, Cinder and Neutron we use the alias name rather than the"},{"line_number":172,"context_line":"    # \u0027name\u0027 field because the alias is considered to be the canonical"},{"line_number":173,"context_line":"    # name."}],"source_content_type":"text/x-python","patch_set":9,"id":"3a961159_0aab1ad7","line":170,"in_reply_to":"3a961159_d80e5a32","updated":"2014-12-16 13:35:09.000000000","message":"Yes, but this code should not have assumed all clients have the same signature for the extension method. We should change get_extension_client to return a function to call.","commit_id":"c3eb492da590356bb1727731c46663b0ef6a7d56"}],"tempest/services/network/json/network_client.py":[{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"bdce9b22309b037ebe4e548c06ad1b513ce040fe","unresolved":false,"context_lines":[{"line_number":61,"context_line":"        resp, body \u003d self.put(uri, body)"},{"line_number":62,"context_line":"        self.rest_client.expected_success(200, resp.status)"},{"line_number":63,"context_line":"        body \u003d json.loads(body)"},{"line_number":64,"context_line":"        return rest_client.ResponseBody(resp, body[\u0027quota\u0027])"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    def reset_quotas(self, tenant_id):"},{"line_number":67,"context_line":"        uri \u003d \u0027%s/quotas/%s\u0027 % (self.uri_prefix, tenant_id)"}],"source_content_type":"text/x-python","patch_set":9,"id":"3a961159_1830e2e7","line":64,"updated":"2014-12-16 01:38:43.000000000","message":"(No action required) I know this patch isn\u0027t changing the behavior, but it\u0027s strange to see this method returning the meat of the body where all the other methods return the skin, too.","commit_id":"c3eb492da590356bb1727731c46663b0ef6a7d56"},{"author":{"_account_id":1192,"name":"David Kranz","email":"dkranz@redhat.com","username":"david-kranz"},"change_message_id":"18cfda965d43ee7681a8d826203539077797e079","unresolved":false,"context_lines":[{"line_number":61,"context_line":"        resp, body \u003d self.put(uri, body)"},{"line_number":62,"context_line":"        self.rest_client.expected_success(200, resp.status)"},{"line_number":63,"context_line":"        body \u003d json.loads(body)"},{"line_number":64,"context_line":"        return rest_client.ResponseBody(resp, body[\u0027quota\u0027])"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    def reset_quotas(self, tenant_id):"},{"line_number":67,"context_line":"        uri \u003d \u0027%s/quotas/%s\u0027 % (self.uri_prefix, tenant_id)"}],"source_content_type":"text/x-python","patch_set":9,"id":"3a961159_6ae81e17","line":64,"in_reply_to":"3a961159_1830e2e7","updated":"2014-12-16 13:35:09.000000000","message":"Yeah. Once this merges the neutron team should review the methods to see if any other changes should be made before actually moving this code to tempest-lib.","commit_id":"c3eb492da590356bb1727731c46663b0ef6a7d56"}]}