)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"c445763fa5c3b612102f91d616c183375832352e","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Emily Hugenbruch \u003cekhugen@us.ibm.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-02-18 14:12:46 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Split resource_setup for volumes tests"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Split up the resource_setup method for the compute volumes tests,"},{"line_number":10,"context_line":"per the latest spec."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":19,"id":"da86d52c_14a395b2","line":7,"updated":"2015-02-19 10:15:35.000000000","message":"If you re-spin this, please change the title also as this looks same as https://review.openstack.org/#/c/151610/\n\nsomething- Split resource_setup for compute volumes tests","commit_id":"b2a91c731de5b8fb376bdb7e5d0082ee54998dac"}],"tempest/api/compute/volumes/test_attach_volume.py":[{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"27b957cf7c33b0655c7e3ede319a3e3372ea4579","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    @classmethod"},{"line_number":39,"context_line":"    def skip_checks(cls):"},{"line_number":40,"context_line":"        if not CONF.service_available.cinder:"},{"line_number":41,"context_line":"            skip_msg \u003d (\"%s skipped as Cinder is not available\" % cls.__name__)"},{"line_number":42,"context_line":"            raise cls.skipException(skip_msg)"},{"line_number":43,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_23f06390","line":40,"updated":"2014-12-12 12:07:00.000000000","message":"We need to invoke skip_checks from super first, as there may be skip checks defined in BaseV2ComputeTest, which we were running before the split, and we should continue running.\nEven if there is no skip right now in BaseV2ComputeTest, there may be in future.\n\nIn general these new fixtures should always invoke super first, unless they have a very specific reason not do so.\n\nSame applies for skip_checks in the other files.","commit_id":"bb1d200b1eb362e5363f009eaa289b475ef6dd25"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"c445763fa5c3b612102f91d616c183375832352e","unresolved":false,"context_lines":[{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    @classmethod"},{"line_number":40,"context_line":"    def resource_setup(cls):"},{"line_number":41,"context_line":"        cls.prepare_instance_network()"},{"line_number":42,"context_line":"        super(AttachVolumeTestJSON, cls).resource_setup()"},{"line_number":43,"context_line":"        cls.device \u003d CONF.compute.volume_device_name"},{"line_number":44,"context_line":""}],"source_content_type":"text/x-python","patch_set":19,"id":"da86d52c_74de913f","line":41,"updated":"2015-02-19 10:15:35.000000000","message":"This is going to do the network setup so we need to call it setup_credential()","commit_id":"b2a91c731de5b8fb376bdb7e5d0082ee54998dac"}],"tempest/api/compute/volumes/test_volumes_get.py":[{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"27b957cf7c33b0655c7e3ede319a3e3372ea4579","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    @classmethod"},{"line_number":36,"context_line":"    def setup_clients(cls):"},{"line_number":37,"context_line":"        super(VolumesGetTestJSON, cls).resource_setup()"},{"line_number":38,"context_line":"        cls.client \u003d cls.volumes_extensions_client"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_43448fb6","line":37,"updated":"2014-12-12 12:07:00.000000000","message":"This should be:\n\nsuper(VolumesGetTestJSON, cls).setup_clients()","commit_id":"bb1d200b1eb362e5363f009eaa289b475ef6dd25"},{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"b1f758f58b43e481353ef046f55f5ed30880aa40","unresolved":false,"context_lines":[{"line_number":27,"context_line":"class VolumesGetTestJSON(base.BaseV2ComputeTest):"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    @classmethod"},{"line_number":30,"context_line":"    def skip_checks(cls):"},{"line_number":31,"context_line":"        if not CONF.service_available.cinder:"},{"line_number":32,"context_line":"            skip_msg \u003d (\"%s skipped as Cinder is not available\" % cls.__name__)"},{"line_number":33,"context_line":"            raise cls.skipException(skip_msg)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a961159_eed39b5d","line":30,"updated":"2014-12-12 15:32:31.000000000","message":"It seems you\u0027ve missed this one (call to super skip_checks)","commit_id":"de3e41e1a7cff7d72907a47a4ccb734a5aa1e09e"},{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"8b752a84fe7a394831b62417b4070fc97b0603bb","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    @classmethod"},{"line_number":30,"context_line":"    def skip_checks(cls):"},{"line_number":31,"context_line":"        if not CONF.service_available.cinder:"},{"line_number":32,"context_line":"            skip_msg \u003d (\"%s skipped as Cinder is not available\" % cls.__name__)"},{"line_number":33,"context_line":"            raise cls.skipException(skip_msg)"},{"line_number":34,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"3a961159_707d08b2","line":31,"updated":"2015-01-05 21:02:12.000000000","message":"Call to super\u0027s skip_checks is missing","commit_id":"b8fc6dc880060e60d0997e3376bedd0dc51bf4c3"}],"tempest/api/compute/volumes/test_volumes_list.py":[{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"27b957cf7c33b0655c7e3ede319a3e3372ea4579","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    @classmethod"},{"line_number":35,"context_line":"    def resource_setup(cls):"},{"line_number":36,"context_line":"        super(VolumesTestJSON, cls).resource_setup()"},{"line_number":37,"context_line":"        cls.client \u003d cls.volumes_extensions_client"},{"line_number":38,"context_line":"        if not CONF.service_available.cinder:"},{"line_number":39,"context_line":"            skip_msg \u003d (\"%s skipped as Cinder is not available\" % cls.__name__)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_e36e5b2e","side":"PARENT","line":36,"range":{"start_line":36,"start_character":8,"end_line":36,"end_character":52},"updated":"2014-12-12 12:07:00.000000000","message":"This line should not be removed here","commit_id":"919d0e8c8ff5781ee0e6b9f9c527f2eff58779db"},{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"27b957cf7c33b0655c7e3ede319a3e3372ea4579","unresolved":false,"context_lines":[{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    @classmethod"},{"line_number":80,"context_line":"    def setup_clients(cls):"},{"line_number":81,"context_line":"        super(VolumesTestJSON, cls).resource_setup()"},{"line_number":82,"context_line":"        cls.client \u003d cls.volumes_extensions_client"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"    @test.attr(type\u003d\u0027gate\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_c30f9f86","line":81,"updated":"2014-12-12 12:07:00.000000000","message":"This should be:\n\nsuper(VolumesTestJSON, cls).setup_clients()","commit_id":"bb1d200b1eb362e5363f009eaa289b475ef6dd25"}],"tempest/api/compute/volumes/test_volumes_negative.py":[{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"27b957cf7c33b0655c7e3ede319a3e3372ea4579","unresolved":false,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    @classmethod"},{"line_number":37,"context_line":"    def setup_clients(cls):"},{"line_number":38,"context_line":"        super(VolumesNegativeTest, cls).resource_setup()"},{"line_number":39,"context_line":"        cls.client \u003d cls.volumes_extensions_client"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    @test.attr(type\u003d[\u0027negative\u0027, \u0027gate\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_a358d38a","line":38,"updated":"2014-12-12 12:07:00.000000000","message":"This should be:\n\nsuper(VolumesNegativeTest, cls).setup_clients()","commit_id":"bb1d200b1eb362e5363f009eaa289b475ef6dd25"}]}