)]}'
{"tempest/api/network/test_ports.py":[{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"8bfd7cec291f584d388a83ce4dc551b771372d99","unresolved":false,"context_lines":[{"line_number":77,"context_line":"        return dict((key, self._subnet_data[self._ip_version][key])"},{"line_number":78,"context_line":"                    for key in include_keys)"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    def test_to_create_port_in_allowed_allocation_pools(self):"},{"line_number":81,"context_line":"        network \u003d self.create_network()"},{"line_number":82,"context_line":"        net_id \u003d network[\u0027id\u0027]"},{"line_number":83,"context_line":"        self.create_subnet(network,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_ca4acf26","line":80,"updated":"2014-12-17 09:29:04.000000000","message":"just test_create_port_in_allowed_allocation_pools","commit_id":"9cca4d43e44680eef33dd71eddae04073f2c292b"},{"author":{"_account_id":13342,"name":"Abhishek G M","email":"abhishek.gm@hpe.com","username":"abhishek60014726"},"change_message_id":"2d62f62d50f8bd186c428a5d415dfb4bd27c6ccf","unresolved":false,"context_lines":[{"line_number":77,"context_line":"        return dict((key, self._subnet_data[self._ip_version][key])"},{"line_number":78,"context_line":"                    for key in include_keys)"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    def test_to_create_port_in_allowed_allocation_pools(self):"},{"line_number":81,"context_line":"        network \u003d self.create_network()"},{"line_number":82,"context_line":"        net_id \u003d network[\u0027id\u0027]"},{"line_number":83,"context_line":"        self.create_subnet(network,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_19034fb9","line":80,"in_reply_to":"3a961159_ca4acf26","updated":"2014-12-17 12:37:38.000000000","message":"Yes i made changes","commit_id":"9cca4d43e44680eef33dd71eddae04073f2c292b"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"8bfd7cec291f584d388a83ce4dc551b771372d99","unresolved":false,"context_lines":[{"line_number":88,"context_line":"        ip_address \u003d port[\u0027fixed_ips\u0027][0][\u0027ip_address\u0027]"},{"line_number":89,"context_line":"        allocation_pools \u003d self.subnet_dict([\u0027allocation_pools\u0027])"},{"line_number":90,"context_line":"        end_ip_address \u003d allocation_pools[\u0027allocation_pools\u0027][0][\u0027end\u0027]"},{"line_number":91,"context_line":"        self.assertLessEqual(ip_address, end_ip_address)"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"    def _delete_port(self, port_id):"},{"line_number":94,"context_line":"        self.client.delete_port(port_id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_4a5edfea","line":91,"updated":"2014-12-17 09:29:04.000000000","message":"What about also checking that it is bigger then start?","commit_id":"9cca4d43e44680eef33dd71eddae04073f2c292b"},{"author":{"_account_id":13342,"name":"Abhishek G M","email":"abhishek.gm@hpe.com","username":"abhishek60014726"},"change_message_id":"2d62f62d50f8bd186c428a5d415dfb4bd27c6ccf","unresolved":false,"context_lines":[{"line_number":88,"context_line":"        ip_address \u003d port[\u0027fixed_ips\u0027][0][\u0027ip_address\u0027]"},{"line_number":89,"context_line":"        allocation_pools \u003d self.subnet_dict([\u0027allocation_pools\u0027])"},{"line_number":90,"context_line":"        end_ip_address \u003d allocation_pools[\u0027allocation_pools\u0027][0][\u0027end\u0027]"},{"line_number":91,"context_line":"        self.assertLessEqual(ip_address, end_ip_address)"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"    def _delete_port(self, port_id):"},{"line_number":94,"context_line":"        self.client.delete_port(port_id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_792ff33e","line":91,"in_reply_to":"3a961159_4a5edfea","updated":"2014-12-17 12:37:38.000000000","message":"yes i added that verification code","commit_id":"9cca4d43e44680eef33dd71eddae04073f2c292b"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"7da9947d03189835b41d7793c052f7e999830846","unresolved":false,"context_lines":[{"line_number":43,"context_line":"        super(PortsTestJSON, cls).resource_setup()"},{"line_number":44,"context_line":"        cls.network \u003d cls.create_network()"},{"line_number":45,"context_line":"        cls.port \u003d cls.create_port(cls.network)"},{"line_number":46,"context_line":"        cls._subnet_data \u003d {6: {\u0027allocation_pools\u0027:"},{"line_number":47,"context_line":"                                cls._get_allocation_pools_from_gateway(6)},"},{"line_number":48,"context_line":"                            4: {\u0027allocation_pools\u0027:"},{"line_number":49,"context_line":"                                cls._get_allocation_pools_from_gateway(4)}}"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a961159_a444cf74","line":46,"updated":"2014-12-17 15:04:25.000000000","message":"all this is not needed, see as it implemented in PortsTest6 class","commit_id":"1c374c4cfb8e3680e3f9637eb5c2f8911ea87309"},{"author":{"_account_id":13342,"name":"Abhishek G M","email":"abhishek.gm@hpe.com","username":"abhishek60014726"},"change_message_id":"bc39cc2a6eb5446a8ed5f396349789e0b56cbe0c","unresolved":false,"context_lines":[{"line_number":43,"context_line":"        super(PortsTestJSON, cls).resource_setup()"},{"line_number":44,"context_line":"        cls.network \u003d cls.create_network()"},{"line_number":45,"context_line":"        cls.port \u003d cls.create_port(cls.network)"},{"line_number":46,"context_line":"        cls._subnet_data \u003d {6: {\u0027allocation_pools\u0027:"},{"line_number":47,"context_line":"                                cls._get_allocation_pools_from_gateway(6)},"},{"line_number":48,"context_line":"                            4: {\u0027allocation_pools\u0027:"},{"line_number":49,"context_line":"                                cls._get_allocation_pools_from_gateway(4)}}"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a961159_527cad20","line":46,"in_reply_to":"3a961159_a444cf74","updated":"2014-12-18 09:39:47.000000000","message":"yes i deleted those lines","commit_id":"1c374c4cfb8e3680e3f9637eb5c2f8911ea87309"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"7da9947d03189835b41d7793c052f7e999830846","unresolved":false,"context_lines":[{"line_number":44,"context_line":"        cls.network \u003d cls.create_network()"},{"line_number":45,"context_line":"        cls.port \u003d cls.create_port(cls.network)"},{"line_number":46,"context_line":"        cls._subnet_data \u003d {6: {\u0027allocation_pools\u0027:"},{"line_number":47,"context_line":"                                cls._get_allocation_pools_from_gateway(6)},"},{"line_number":48,"context_line":"                            4: {\u0027allocation_pools\u0027:"},{"line_number":49,"context_line":"                                cls._get_allocation_pools_from_gateway(4)}}"},{"line_number":50,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3a961159_2458df55","line":47,"updated":"2014-12-17 15:04:25.000000000","message":"I don\u0027t get how is gateway related to pool, if no gateway, than what is the pool?","commit_id":"1c374c4cfb8e3680e3f9637eb5c2f8911ea87309"},{"author":{"_account_id":13342,"name":"Abhishek G M","email":"abhishek.gm@hpe.com","username":"abhishek60014726"},"change_message_id":"bc39cc2a6eb5446a8ed5f396349789e0b56cbe0c","unresolved":false,"context_lines":[{"line_number":44,"context_line":"        cls.network \u003d cls.create_network()"},{"line_number":45,"context_line":"        cls.port \u003d cls.create_port(cls.network)"},{"line_number":46,"context_line":"        cls._subnet_data \u003d {6: {\u0027allocation_pools\u0027:"},{"line_number":47,"context_line":"                                cls._get_allocation_pools_from_gateway(6)},"},{"line_number":48,"context_line":"                            4: {\u0027allocation_pools\u0027:"},{"line_number":49,"context_line":"                                cls._get_allocation_pools_from_gateway(4)}}"},{"line_number":50,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3a961159_7277e93b","line":47,"in_reply_to":"3a961159_2458df55","updated":"2014-12-18 09:39:47.000000000","message":"yes i made changes","commit_id":"1c374c4cfb8e3680e3f9637eb5c2f8911ea87309"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"7da9947d03189835b41d7793c052f7e999830846","unresolved":false,"context_lines":[{"line_number":57,"context_line":"    @classmethod"},{"line_number":58,"context_line":"    def _get_gateway_from_tempest_conf(cls, ip_version):"},{"line_number":59,"context_line":"        \"\"\"Return first subnet gateway for configured CIDR \"\"\""},{"line_number":60,"context_line":"        if ip_version \u003d\u003d 4:"},{"line_number":61,"context_line":"            cidr \u003d netaddr.IPNetwork(CONF.network.tenant_network_cidr)"},{"line_number":62,"context_line":"            mask_bits \u003d CONF.network.tenant_network_mask_bits"},{"line_number":63,"context_line":"        elif ip_version \u003d\u003d 6:"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a961159_e476d7d7","line":60,"updated":"2014-12-17 15:04:25.000000000","message":"base.BaseNetworkTest has an attribute _ip_version\n\nAnd all this should be in PortTest class in setup, then you just change version in class PortsIpV6TestJSON","commit_id":"1c374c4cfb8e3680e3f9637eb5c2f8911ea87309"},{"author":{"_account_id":13342,"name":"Abhishek G M","email":"abhishek.gm@hpe.com","username":"abhishek60014726"},"change_message_id":"bc39cc2a6eb5446a8ed5f396349789e0b56cbe0c","unresolved":false,"context_lines":[{"line_number":57,"context_line":"    @classmethod"},{"line_number":58,"context_line":"    def _get_gateway_from_tempest_conf(cls, ip_version):"},{"line_number":59,"context_line":"        \"\"\"Return first subnet gateway for configured CIDR \"\"\""},{"line_number":60,"context_line":"        if ip_version \u003d\u003d 4:"},{"line_number":61,"context_line":"            cidr \u003d netaddr.IPNetwork(CONF.network.tenant_network_cidr)"},{"line_number":62,"context_line":"            mask_bits \u003d CONF.network.tenant_network_mask_bits"},{"line_number":63,"context_line":"        elif ip_version \u003d\u003d 6:"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a961159_b2715146","line":60,"in_reply_to":"3a961159_e476d7d7","updated":"2014-12-18 09:39:47.000000000","message":"yes i made changes","commit_id":"1c374c4cfb8e3680e3f9637eb5c2f8911ea87309"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"7da9947d03189835b41d7793c052f7e999830846","unresolved":false,"context_lines":[{"line_number":84,"context_line":"                           **self.subnet_dict([\u0027allocation_pools\u0027]))"},{"line_number":85,"context_line":"        _, body \u003d self.client.create_port(network_id\u003dnet_id)"},{"line_number":86,"context_line":"        port \u003d body[\u0027port\u0027]"},{"line_number":87,"context_line":"        self.addCleanup(self._delete_port, port[\u0027id\u0027])"},{"line_number":88,"context_line":"        ip_address \u003d port[\u0027fixed_ips\u0027][0][\u0027ip_address\u0027]"},{"line_number":89,"context_line":"        allocation_pools \u003d self.subnet_dict([\u0027allocation_pools\u0027])"},{"line_number":90,"context_line":"        start_ip_address \u003d allocation_pools[\u0027allocation_pools\u0027][0][\u0027start\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a961159_e42417c8","line":87,"updated":"2014-12-17 15:04:25.000000000","message":"you have create_port function with build in cleanup, it\u0027s better to use it","commit_id":"1c374c4cfb8e3680e3f9637eb5c2f8911ea87309"},{"author":{"_account_id":13342,"name":"Abhishek G M","email":"abhishek.gm@hpe.com","username":"abhishek60014726"},"change_message_id":"bc39cc2a6eb5446a8ed5f396349789e0b56cbe0c","unresolved":false,"context_lines":[{"line_number":84,"context_line":"                           **self.subnet_dict([\u0027allocation_pools\u0027]))"},{"line_number":85,"context_line":"        _, body \u003d self.client.create_port(network_id\u003dnet_id)"},{"line_number":86,"context_line":"        port \u003d body[\u0027port\u0027]"},{"line_number":87,"context_line":"        self.addCleanup(self._delete_port, port[\u0027id\u0027])"},{"line_number":88,"context_line":"        ip_address \u003d port[\u0027fixed_ips\u0027][0][\u0027ip_address\u0027]"},{"line_number":89,"context_line":"        allocation_pools \u003d self.subnet_dict([\u0027allocation_pools\u0027])"},{"line_number":90,"context_line":"        start_ip_address \u003d allocation_pools[\u0027allocation_pools\u0027][0][\u0027start\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a961159_92c45541","line":87,"in_reply_to":"3a961159_e42417c8","updated":"2014-12-18 09:39:47.000000000","message":"yes i used self.addCleanup(self.client.delete_port, body[\u0027port\u0027][\u0027id\u0027])","commit_id":"1c374c4cfb8e3680e3f9637eb5c2f8911ea87309"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"4e1ef17147da5f94e7c13a0de26340985892f70f","unresolved":false,"context_lines":[{"line_number":106,"context_line":"        network \u003d self.create_network()"},{"line_number":107,"context_line":"        net_id \u003d network[\u0027id\u0027]"},{"line_number":108,"context_line":"        address \u003d self._get_ipaddress_from_tempest_conf()"},{"line_number":109,"context_line":"        allocation_pools \u003d {\u0027allocation_pools\u0027: [{\u0027start\u0027: str(address + 2),"},{"line_number":110,"context_line":"                                                  \u0027end\u0027: str(address + 4)}]}"},{"line_number":111,"context_line":"        self.create_subnet(network, **allocation_pools)"},{"line_number":112,"context_line":"        _, body \u003d self.client.create_port(network_id\u003dnet_id)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a961159_fa527911","line":109,"updated":"2014-12-22 15:13:01.000000000","message":"I think the test would be more relevant if you have :\n\n\u0027start\u0027: str(address + 4)\n\n\u0027end\u0027: str(address + 6)\n\nBecause, I think  \u0027str(address + 2)\u0027 is already the \"default\" if one doesn\u0027t set explicitly the allocation_pools.  (address + 1 is the \"dhcp\" port).","commit_id":"0b67cd3d0703db8b0548125ccb86d494add88df0"},{"author":{"_account_id":13342,"name":"Abhishek G M","email":"abhishek.gm@hpe.com","username":"abhishek60014726"},"change_message_id":"e70879d66ac030ca213deda5d8ee131ea34c1230","unresolved":false,"context_lines":[{"line_number":106,"context_line":"        network \u003d self.create_network()"},{"line_number":107,"context_line":"        net_id \u003d network[\u0027id\u0027]"},{"line_number":108,"context_line":"        address \u003d self._get_ipaddress_from_tempest_conf()"},{"line_number":109,"context_line":"        allocation_pools \u003d {\u0027allocation_pools\u0027: [{\u0027start\u0027: str(address + 2),"},{"line_number":110,"context_line":"                                                  \u0027end\u0027: str(address + 4)}]}"},{"line_number":111,"context_line":"        self.create_subnet(network, **allocation_pools)"},{"line_number":112,"context_line":"        _, body \u003d self.client.create_port(network_id\u003dnet_id)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a961159_a9c63f14","line":109,"in_reply_to":"3a961159_fa527911","updated":"2015-01-05 11:37:35.000000000","message":"Yes i made changes and uploaded a new patch","commit_id":"0b67cd3d0703db8b0548125ccb86d494add88df0"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"98817af2534717420acd25b38798f91b93278c47","unresolved":false,"context_lines":[{"line_number":109,"context_line":"        allocation_pools \u003d {\u0027allocation_pools\u0027: [{\u0027start\u0027: str(address + 2),"},{"line_number":110,"context_line":"                                                  \u0027end\u0027: str(address + 4)}]}"},{"line_number":111,"context_line":"        self.create_subnet(network, **allocation_pools)"},{"line_number":112,"context_line":"        _, body \u003d self.client.create_port(network_id\u003dnet_id)"},{"line_number":113,"context_line":"        self.addCleanup(self.client.delete_port, body[\u0027port\u0027][\u0027id\u0027])"},{"line_number":114,"context_line":"        port \u003d body[\u0027port\u0027]"},{"line_number":115,"context_line":"        ip_address \u003d port[\u0027fixed_ips\u0027][0][\u0027ip_address\u0027]"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a961159_f5cb58a1","line":112,"updated":"2014-12-23 09:07:33.000000000","message":"You need to rebase. If you use self.create_port function, so no need to rebase.","commit_id":"0b67cd3d0703db8b0548125ccb86d494add88df0"},{"author":{"_account_id":13342,"name":"Abhishek G M","email":"abhishek.gm@hpe.com","username":"abhishek60014726"},"change_message_id":"e70879d66ac030ca213deda5d8ee131ea34c1230","unresolved":false,"context_lines":[{"line_number":109,"context_line":"        allocation_pools \u003d {\u0027allocation_pools\u0027: [{\u0027start\u0027: str(address + 2),"},{"line_number":110,"context_line":"                                                  \u0027end\u0027: str(address + 4)}]}"},{"line_number":111,"context_line":"        self.create_subnet(network, **allocation_pools)"},{"line_number":112,"context_line":"        _, body \u003d self.client.create_port(network_id\u003dnet_id)"},{"line_number":113,"context_line":"        self.addCleanup(self.client.delete_port, body[\u0027port\u0027][\u0027id\u0027])"},{"line_number":114,"context_line":"        port \u003d body[\u0027port\u0027]"},{"line_number":115,"context_line":"        ip_address \u003d port[\u0027fixed_ips\u0027][0][\u0027ip_address\u0027]"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a961159_c9c9cb26","line":112,"in_reply_to":"3a961159_f5cb58a1","updated":"2015-01-05 11:37:35.000000000","message":"Yes i made changes and uploaded a new patch","commit_id":"0b67cd3d0703db8b0548125ccb86d494add88df0"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"56527f53a79b3c79298f8d1a5575803e95903fce","unresolved":false,"context_lines":[{"line_number":98,"context_line":"        if mask_bits \u003e\u003d cidr.prefixlen:"},{"line_number":99,"context_line":"            return netaddr.IPAddress(cidr)"},{"line_number":100,"context_line":"        else:"},{"line_number":101,"context_line":"            for subnet in cidr.subnet(mask_bits):"},{"line_number":102,"context_line":"                return netaddr.IPAddress(subnet)"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a961159_f56f31fa","line":101,"updated":"2015-01-05 16:10:19.000000000","message":"Why do you need to iterate over cidr.subnet(mask_bits) since you seem to only need the first element ?","commit_id":"db405e01df3c4880622d9434d0f4e20eba94d1e5"},{"author":{"_account_id":13342,"name":"Abhishek G M","email":"abhishek.gm@hpe.com","username":"abhishek60014726"},"change_message_id":"43d4d44e24371a339413392f494a4db85a3adf3a","unresolved":false,"context_lines":[{"line_number":98,"context_line":"        if mask_bits \u003e\u003d cidr.prefixlen:"},{"line_number":99,"context_line":"            return netaddr.IPAddress(cidr)"},{"line_number":100,"context_line":"        else:"},{"line_number":101,"context_line":"            for subnet in cidr.subnet(mask_bits):"},{"line_number":102,"context_line":"                return netaddr.IPAddress(subnet)"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a961159_140bcad6","line":101,"in_reply_to":"3a961159_f56f31fa","updated":"2015-01-06 05:10:23.000000000","message":"yes, i made changes","commit_id":"db405e01df3c4880622d9434d0f4e20eba94d1e5"},{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"9be46bdcbe2e73fd40a7b820d91aa6b00667eadb","unresolved":false,"context_lines":[{"line_number":109,"context_line":"        ip_address \u003d port[\u0027fixed_ips\u0027][0][\u0027ip_address\u0027]"},{"line_number":110,"context_line":"        start_ip_address \u003d allocation_pools[\u0027allocation_pools\u0027][0][\u0027start\u0027]"},{"line_number":111,"context_line":"        end_ip_address \u003d allocation_pools[\u0027allocation_pools\u0027][0][\u0027end\u0027]"},{"line_number":112,"context_line":"        self.assertGreaterEqual(ip_address, start_ip_address)"},{"line_number":113,"context_line":"        self.assertLessEqual(ip_address, end_ip_address)"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a961159_e25e80e8","line":112,"updated":"2015-01-06 06:25:44.000000000","message":"I think these variables are string type. So I think this assertGreaterEqual() sometimes doesn\u0027t work well.\n\nFor example, when the values are start_ip_address \u003d \u002710.100.0.10\u0027 and ip_address \u003d \u002710.100.0.5\u0027, the assert will be succeeded. But it\u0027s wrong.\n\nDo I miss something?","commit_id":"2df9122ffbc45d869e1f944fb487905cc2e9509d"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"4b9adb6c60e6638c785cf6980c681d95ca168421","unresolved":false,"context_lines":[{"line_number":109,"context_line":"        ip_address \u003d port[\u0027fixed_ips\u0027][0][\u0027ip_address\u0027]"},{"line_number":110,"context_line":"        start_ip_address \u003d allocation_pools[\u0027allocation_pools\u0027][0][\u0027start\u0027]"},{"line_number":111,"context_line":"        end_ip_address \u003d allocation_pools[\u0027allocation_pools\u0027][0][\u0027end\u0027]"},{"line_number":112,"context_line":"        self.assertGreaterEqual(ip_address, start_ip_address)"},{"line_number":113,"context_line":"        self.assertLessEqual(ip_address, end_ip_address)"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a961159_86086281","line":112,"in_reply_to":"3a961159_7da07190","updated":"2015-01-06 16:21:03.000000000","message":"Masayuki is right. The code as is is error-prone.\n\nYou should assert that (for example) :\n\n\u002710.100.0.6\u0027 in netaddr.IPRange(\u002710.100.0.5\u0027, \u002710.100.0.10\u0027)","commit_id":"2df9122ffbc45d869e1f944fb487905cc2e9509d"},{"author":{"_account_id":13342,"name":"Abhishek G M","email":"abhishek.gm@hpe.com","username":"abhishek60014726"},"change_message_id":"af14820585a99dcc72757affd18872bba4207f1a","unresolved":false,"context_lines":[{"line_number":109,"context_line":"        ip_address \u003d port[\u0027fixed_ips\u0027][0][\u0027ip_address\u0027]"},{"line_number":110,"context_line":"        start_ip_address \u003d allocation_pools[\u0027allocation_pools\u0027][0][\u0027start\u0027]"},{"line_number":111,"context_line":"        end_ip_address \u003d allocation_pools[\u0027allocation_pools\u0027][0][\u0027end\u0027]"},{"line_number":112,"context_line":"        self.assertGreaterEqual(ip_address, start_ip_address)"},{"line_number":113,"context_line":"        self.assertLessEqual(ip_address, end_ip_address)"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a961159_f01ddc63","line":112,"in_reply_to":"3a961159_86086281","updated":"2015-01-12 05:59:24.000000000","message":"yes i made changes and uploaded new patch","commit_id":"2df9122ffbc45d869e1f944fb487905cc2e9509d"},{"author":{"_account_id":13342,"name":"Abhishek G M","email":"abhishek.gm@hpe.com","username":"abhishek60014726"},"change_message_id":"4774e25238a36c3885f54b188dfe9dd9dd5ae99d","unresolved":false,"context_lines":[{"line_number":109,"context_line":"        ip_address \u003d port[\u0027fixed_ips\u0027][0][\u0027ip_address\u0027]"},{"line_number":110,"context_line":"        start_ip_address \u003d allocation_pools[\u0027allocation_pools\u0027][0][\u0027start\u0027]"},{"line_number":111,"context_line":"        end_ip_address \u003d allocation_pools[\u0027allocation_pools\u0027][0][\u0027end\u0027]"},{"line_number":112,"context_line":"        self.assertGreaterEqual(ip_address, start_ip_address)"},{"line_number":113,"context_line":"        self.assertLessEqual(ip_address, end_ip_address)"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a961159_7da07190","line":112,"in_reply_to":"3a961159_e25e80e8","updated":"2015-01-06 07:18:51.000000000","message":"When we store values in  ip_address and strat_ip_address variables and using assertGreaterEqual like\nip_address \u003d \u002710.100.0.5\u0027\nstart_ip_address \u003d \u002710.100.0.10\u0027\nself.assertGreaterEqual(ip_address, start_ip_address)\nwill  through error  \u002710.100.0.5\u0027 not greater than or equal to \u002710.100.0.10\u0027\n\nBut if we explicitly specify ip_address like\nself.assertGreaterEqual(\u002710.100.0.5\u0027, \u002710.100.0.10\u0027)\nWill not through an error, it got succeeded\n\nSo in my test case it works fine because i am not explicitly specifying any values.","commit_id":"2df9122ffbc45d869e1f944fb487905cc2e9509d"},{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"9be46bdcbe2e73fd40a7b820d91aa6b00667eadb","unresolved":false,"context_lines":[{"line_number":110,"context_line":"        start_ip_address \u003d allocation_pools[\u0027allocation_pools\u0027][0][\u0027start\u0027]"},{"line_number":111,"context_line":"        end_ip_address \u003d allocation_pools[\u0027allocation_pools\u0027][0][\u0027end\u0027]"},{"line_number":112,"context_line":"        self.assertGreaterEqual(ip_address, start_ip_address)"},{"line_number":113,"context_line":"        self.assertLessEqual(ip_address, end_ip_address)"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":116,"context_line":"    def test_show_port(self):"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a961159_6272907d","line":113,"updated":"2015-01-06 06:25:44.000000000","message":"ditto","commit_id":"2df9122ffbc45d869e1f944fb487905cc2e9509d"},{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"d515c11d793cf29e914545f32811e38600dec109","unresolved":false,"context_lines":[{"line_number":85,"context_line":"        self.assertTrue(port2[\u0027admin_state_up\u0027])"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    @classmethod"},{"line_number":88,"context_line":"    def _get_ipaddress_from_tempest_conf(cls):"},{"line_number":89,"context_line":"        \"\"\"Return first subnet gateway for configured CIDR \"\"\""},{"line_number":90,"context_line":"        if cls._ip_version \u003d\u003d 4:"},{"line_number":91,"context_line":"            cidr \u003d netaddr.IPNetwork(CONF.network.tenant_network_cidr)"}],"source_content_type":"text/x-python","patch_set":7,"id":"3a961159_9218d51f","line":88,"updated":"2015-01-13 22:27:31.000000000","message":"This would be a good candidate for a shared helper function.","commit_id":"de45a5e5c6715c9499f3bdf01ae7fb56e509ca8e"}]}