)]}'
{"tempest/scenario/test_security_groups_basic_ops.py":[{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"23e45da09822b7fd9ea5f00a0e2ec2082dbd69fa","unresolved":false,"context_lines":[{"line_number":73,"context_line":"            * test than revesre traffic is enabled once an appropriate rule has"},{"line_number":74,"context_line":"            been created on source tenant"},{"line_number":75,"context_line":"        7._test_port_update_newsecuritygroup:"},{"line_number":76,"context_line":"           * test that traffic is blocked with default security froup"},{"line_number":77,"context_line":"           * test that traffic is enabled after updating port with new security"},{"line_number":78,"context_line":"           group having appropriate rule"},{"line_number":79,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_7fb6f0dd","line":76,"updated":"2014-12-17 15:26:15.000000000","message":"froup -\u003e group","commit_id":"26629523f0f6ddd278b22d60dd11c69c1d73d04c"},{"author":{"_account_id":12626,"name":"Rajkumar","email":"rajkumart@hp.com","username":"raj15"},"change_message_id":"cf83344872cf067af5f7b36a9c419375b16e459a","unresolved":false,"context_lines":[{"line_number":73,"context_line":"            * test than revesre traffic is enabled once an appropriate rule has"},{"line_number":74,"context_line":"            been created on source tenant"},{"line_number":75,"context_line":"        7._test_port_update_newsecuritygroup:"},{"line_number":76,"context_line":"           * test that traffic is blocked with default security froup"},{"line_number":77,"context_line":"           * test that traffic is enabled after updating port with new security"},{"line_number":78,"context_line":"           group having appropriate rule"},{"line_number":79,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_3da2694b","line":76,"in_reply_to":"3a961159_7fb6f0dd","updated":"2014-12-19 12:57:23.000000000","message":"Done","commit_id":"26629523f0f6ddd278b22d60dd11c69c1d73d04c"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"23e45da09822b7fd9ea5f00a0e2ec2082dbd69fa","unresolved":false,"context_lines":[{"line_number":459,"context_line":"        except Exception:"},{"line_number":460,"context_line":"            for tenant in self.tenants.values():"},{"line_number":461,"context_line":"                self._log_console_output(servers\u003dtenant.servers)"},{"line_number":462,"context_line":"            raise"},{"line_number":463,"context_line":""},{"line_number":464,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":465,"context_line":"    @test.services(\u0027compute\u0027, \u0027network\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_3fdb881c","line":462,"updated":"2014-12-17 15:26:15.000000000","message":"it\u0027s duplicated below","commit_id":"26629523f0f6ddd278b22d60dd11c69c1d73d04c"},{"author":{"_account_id":12626,"name":"Rajkumar","email":"rajkumart@hp.com","username":"raj15"},"change_message_id":"cf83344872cf067af5f7b36a9c419375b16e459a","unresolved":false,"context_lines":[{"line_number":459,"context_line":"        except Exception:"},{"line_number":460,"context_line":"            for tenant in self.tenants.values():"},{"line_number":461,"context_line":"                self._log_console_output(servers\u003dtenant.servers)"},{"line_number":462,"context_line":"            raise"},{"line_number":463,"context_line":""},{"line_number":464,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":465,"context_line":"    @test.services(\u0027compute\u0027, \u0027network\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_3d150949","line":462,"in_reply_to":"3a961159_3fdb881c","updated":"2014-12-19 12:57:23.000000000","message":"It is not duplicated. Since the above 4 lines are same in previous testcase and my testcase, my code is appearing like it is inserted in between and I don\u0027t think it will create any issue.","commit_id":"26629523f0f6ddd278b22d60dd11c69c1d73d04c"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"c4fadbf5f2adfb21ffe1032ed90cdd622271ff29","unresolved":false,"context_lines":[{"line_number":468,"context_line":"        This test verifies the traffic after updating the vm port with new"},{"line_number":469,"context_line":"        security group having appropiate rule."},{"line_number":470,"context_line":"        \"\"\""},{"line_number":471,"context_line":"        try:"},{"line_number":472,"context_line":"            new_tenant \u003d self.primary_tenant"},{"line_number":473,"context_line":"            new_sg \u003d self._create_empty_security_group("},{"line_number":474,"context_line":"                namestart\u003d\u0027secgroup_new-\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a961159_f50bb121","line":471,"updated":"2015-01-05 15:46:49.000000000","message":"This try/except is way too broad.\n\nI get that you want to log console output in case of error. But imo only the call to _check_connectivity() should be inside the try/except block.\n\nMy concern is that letting this code in would set a bad precedent. People would start copy/pasting this construct blindly.","commit_id":"ddf123aeb36dbe3d3ec7085e5de517823513cd9a"},{"author":{"_account_id":12626,"name":"Rajkumar","email":"rajkumart@hp.com","username":"raj15"},"change_message_id":"44fd1e27972ddab584e931dc28f2016e94c06f9b","unresolved":false,"context_lines":[{"line_number":468,"context_line":"        This test verifies the traffic after updating the vm port with new"},{"line_number":469,"context_line":"        security group having appropiate rule."},{"line_number":470,"context_line":"        \"\"\""},{"line_number":471,"context_line":"        try:"},{"line_number":472,"context_line":"            new_tenant \u003d self.primary_tenant"},{"line_number":473,"context_line":"            new_sg \u003d self._create_empty_security_group("},{"line_number":474,"context_line":"                namestart\u003d\u0027secgroup_new-\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a961159_77d94282","line":471,"in_reply_to":"3a961159_f50bb121","updated":"2015-01-07 14:30:47.000000000","message":"Done","commit_id":"ddf123aeb36dbe3d3ec7085e5de517823513cd9a"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"c4fadbf5f2adfb21ffe1032ed90cdd622271ff29","unresolved":false,"context_lines":[{"line_number":470,"context_line":"        \"\"\""},{"line_number":471,"context_line":"        try:"},{"line_number":472,"context_line":"            new_tenant \u003d self.primary_tenant"},{"line_number":473,"context_line":"            new_sg \u003d self._create_empty_security_group("},{"line_number":474,"context_line":"                namestart\u003d\u0027secgroup_new-\u0027,"},{"line_number":475,"context_line":"                tenant_id\u003dnew_tenant.creds.tenant_id,"},{"line_number":476,"context_line":"                client\u003dnew_tenant.manager.network_client)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a961159_75b3414d","line":473,"updated":"2015-01-05 15:46:49.000000000","message":"Please move the security group and rule creation after the first call to _check_connectivity()\n\nThis would make clear that the server created by _create_server() does use the \"default\" security group.","commit_id":"ddf123aeb36dbe3d3ec7085e5de517823513cd9a"},{"author":{"_account_id":12626,"name":"Rajkumar","email":"rajkumart@hp.com","username":"raj15"},"change_message_id":"0474d4d0eccfb8c7fb315d60b77824b42cc865b3","unresolved":false,"context_lines":[{"line_number":470,"context_line":"        \"\"\""},{"line_number":471,"context_line":"        try:"},{"line_number":472,"context_line":"            new_tenant \u003d self.primary_tenant"},{"line_number":473,"context_line":"            new_sg \u003d self._create_empty_security_group("},{"line_number":474,"context_line":"                namestart\u003d\u0027secgroup_new-\u0027,"},{"line_number":475,"context_line":"                tenant_id\u003dnew_tenant.creds.tenant_id,"},{"line_number":476,"context_line":"                client\u003dnew_tenant.manager.network_client)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a961159_ebfc98b7","line":473,"in_reply_to":"3a961159_75b3414d","updated":"2015-01-06 10:51:53.000000000","message":"Hi Jordan,\n                  If I move the security group and rule creation after _check_connectivity(), It will come after  server creation (server \u003d self._create_server(name, new_tenant) (line 490)) which is creating an issue while deleting the security group and server at the end and throws an conflict error below like this\n\nconflict: An object with that identifier already exists\nDetails: {u\u0027message\u0027: u\u0027Security Group 3d39ab67-e033-4ced-8794-0db4b8c6f3f7 in use.\u0027, u\u0027type\u0027: u\u0027SecurityGroupInUse\u0027, u\u0027detail\u0027: u\u0027\u0027}\n\nPlease let me know if there is any alternative to do this without error or we keep the same.","commit_id":"ddf123aeb36dbe3d3ec7085e5de517823513cd9a"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"ec3367978ce3e7321ee52c53bd2993a72fe4a0a7","unresolved":false,"context_lines":[{"line_number":470,"context_line":"        \"\"\""},{"line_number":471,"context_line":"        try:"},{"line_number":472,"context_line":"            new_tenant \u003d self.primary_tenant"},{"line_number":473,"context_line":"            new_sg \u003d self._create_empty_security_group("},{"line_number":474,"context_line":"                namestart\u003d\u0027secgroup_new-\u0027,"},{"line_number":475,"context_line":"                tenant_id\u003dnew_tenant.creds.tenant_id,"},{"line_number":476,"context_line":"                client\u003dnew_tenant.manager.network_client)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a961159_9405e811","line":473,"in_reply_to":"3a961159_ebfc98b7","updated":"2015-01-06 17:11:20.000000000","message":"Okay, I got it. Thanks for the explanation.\n\nI still think the try/except starting L470 is too broad.","commit_id":"ddf123aeb36dbe3d3ec7085e5de517823513cd9a"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"f207fbf58bd5af495bfd09861ee2c296c77082b4","unresolved":false,"context_lines":[{"line_number":72,"context_line":"            * test that reverse traffic is still blocked"},{"line_number":73,"context_line":"            * test than revesre traffic is enabled once an appropriate rule has"},{"line_number":74,"context_line":"            been created on source tenant"},{"line_number":75,"context_line":"        7._test_port_update_newsecuritygroup:"},{"line_number":76,"context_line":"           * test that traffic is blocked with default security group"},{"line_number":77,"context_line":"           * test that traffic is enabled after updating port with new security"},{"line_number":78,"context_line":"           group having appropriate rule"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a961159_3851e930","line":75,"updated":"2015-01-13 02:32:22.000000000","message":"_test_port_update_newsecuritygroup -\u003e _test_port_update_new_security_group","commit_id":"842e4276e304c66c8fcffa99cc624e4ef6ffff0b"},{"author":{"_account_id":12626,"name":"Rajkumar","email":"rajkumart@hp.com","username":"raj15"},"change_message_id":"0b2421ea4026ef32856acc5b65152414b8971988","unresolved":false,"context_lines":[{"line_number":72,"context_line":"            * test that reverse traffic is still blocked"},{"line_number":73,"context_line":"            * test than revesre traffic is enabled once an appropriate rule has"},{"line_number":74,"context_line":"            been created on source tenant"},{"line_number":75,"context_line":"        7._test_port_update_newsecuritygroup:"},{"line_number":76,"context_line":"           * test that traffic is blocked with default security group"},{"line_number":77,"context_line":"           * test that traffic is enabled after updating port with new security"},{"line_number":78,"context_line":"           group having appropriate rule"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a961159_01759532","line":75,"in_reply_to":"3a961159_3851e930","updated":"2015-01-13 07:42:12.000000000","message":"Done","commit_id":"842e4276e304c66c8fcffa99cc624e4ef6ffff0b"}]}