)]}'
{"tempest/api/orchestration/stacks/test_sahara_resources.py":[{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"37b8d82a81e2515f81b7d01ff30243bf89254090","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        if not image_id:"},{"line_number":35,"context_line":"            raise cls.skipException(\"No image available to test\")"},{"line_number":36,"context_line":"        os \u003d clients.Manager()"},{"line_number":37,"context_line":"        if not CONF.service_available.sahara:"},{"line_number":38,"context_line":"            raise cls.skipException(\"Sahara support is required\")"},{"line_number":39,"context_line":"        cls.sahara_basic_template \u003d cls.load_template(\u0027sahara_basic\u0027)"},{"line_number":40,"context_line":"        cls.data_processing_client \u003d os.data_processing_client"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_9206151f","line":37,"updated":"2014-12-18 10:00:33.000000000","message":"I think it would be better to put the check for Sahara service instead of the check for an image.","commit_id":"5f2fb0b35f0664af817bd8a4801774cb051e1cb3"},{"author":{"_account_id":8411,"name":"Andrew Lazarev","email":"alazarev@mirantis.com","username":"alazarev"},"change_message_id":"57a3c91edb218a8af1e2cbf289eac5a33e37e6cb","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        if not image_id:"},{"line_number":35,"context_line":"            raise cls.skipException(\"No image available to test\")"},{"line_number":36,"context_line":"        os \u003d clients.Manager()"},{"line_number":37,"context_line":"        if not CONF.service_available.sahara:"},{"line_number":38,"context_line":"            raise cls.skipException(\"Sahara support is required\")"},{"line_number":39,"context_line":"        cls.sahara_basic_template \u003d cls.load_template(\u0027sahara_basic\u0027)"},{"line_number":40,"context_line":"        cls.data_processing_client \u003d os.data_processing_client"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_b0905044","line":37,"in_reply_to":"3a961159_9206151f","updated":"2014-12-18 22:29:52.000000000","message":"Moved check for sahara to the beginning of the method.","commit_id":"5f2fb0b35f0664af817bd8a4801774cb051e1cb3"},{"author":{"_account_id":8767,"name":"Nikolay Fedotov","email":"nfedotov@cisco.com","username":"nfedotov"},"change_message_id":"6e9ca0194723a82f310161bd36f25d076e059599","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    def resource_setup(cls):"},{"line_number":32,"context_line":"        super(SaharaResourcesTest, cls).resource_setup()"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"        os \u003d clients.Manager()"},{"line_number":35,"context_line":"        if not CONF.service_available.sahara:"},{"line_number":36,"context_line":"            raise cls.skipException(\"Sahara support is required\")"},{"line_number":37,"context_line":"        cls.data_processing_client \u003d os.data_processing_client"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a930d6b_1a85d8cf","line":34,"updated":"2015-01-23 12:47:37.000000000","message":"Duplicate line. It is already defined in parent class BaseOrchestrationTest method resource_setup line #35","commit_id":"3aac40c0128269aca06879e93074ec5cc50c7d48"},{"author":{"_account_id":8411,"name":"Andrew Lazarev","email":"alazarev@mirantis.com","username":"alazarev"},"change_message_id":"2d9565365cd9858cc5ffd9a31d448029eb251e33","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    def resource_setup(cls):"},{"line_number":32,"context_line":"        super(SaharaResourcesTest, cls).resource_setup()"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"        os \u003d clients.Manager()"},{"line_number":35,"context_line":"        if not CONF.service_available.sahara:"},{"line_number":36,"context_line":"            raise cls.skipException(\"Sahara support is required\")"},{"line_number":37,"context_line":"        cls.data_processing_client \u003d os.data_processing_client"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a930d6b_0ecd5085","line":34,"in_reply_to":"1a930d6b_1a85d8cf","updated":"2015-01-26 19:51:30.000000000","message":"Done","commit_id":"3aac40c0128269aca06879e93074ec5cc50c7d48"},{"author":{"_account_id":8767,"name":"Nikolay Fedotov","email":"nfedotov@cisco.com","username":"nfedotov"},"change_message_id":"6e9ca0194723a82f310161bd36f25d076e059599","unresolved":false,"context_lines":[{"line_number":80,"context_line":"        cls.stack_id \u003d cls.stack_identifier.split(\u0027/\u0027)[1]"},{"line_number":81,"context_line":"        try:"},{"line_number":82,"context_line":"            cls.client.wait_for_stack_status(cls.stack_id, \u0027CREATE_COMPLETE\u0027)"},{"line_number":83,"context_line":"            _, resources \u003d cls.client.list_resources(cls.stack_identifier)"},{"line_number":84,"context_line":"        except exceptions.TimeoutException as e:"},{"line_number":85,"context_line":"            if CONF.compute_feature_enabled.console_output:"},{"line_number":86,"context_line":"                # attempt to log the server console to help with debugging"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a930d6b_f5165fa6","line":83,"updated":"2015-01-23 12:47:37.000000000","message":"Are you sure that the \"list_resources\" returns tuple? It seems to me it returns response body only. See: https://github.com/openstack/tempest/blob/master/tempest/services/orchestration/json/orchestration_client.py#L136","commit_id":"3aac40c0128269aca06879e93074ec5cc50c7d48"},{"author":{"_account_id":8411,"name":"Andrew Lazarev","email":"alazarev@mirantis.com","username":"alazarev"},"change_message_id":"2d9565365cd9858cc5ffd9a31d448029eb251e33","unresolved":false,"context_lines":[{"line_number":80,"context_line":"        cls.stack_id \u003d cls.stack_identifier.split(\u0027/\u0027)[1]"},{"line_number":81,"context_line":"        try:"},{"line_number":82,"context_line":"            cls.client.wait_for_stack_status(cls.stack_id, \u0027CREATE_COMPLETE\u0027)"},{"line_number":83,"context_line":"            _, resources \u003d cls.client.list_resources(cls.stack_identifier)"},{"line_number":84,"context_line":"        except exceptions.TimeoutException as e:"},{"line_number":85,"context_line":"            if CONF.compute_feature_enabled.console_output:"},{"line_number":86,"context_line":"                # attempt to log the server console to help with debugging"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a930d6b_4ec3d856","line":83,"in_reply_to":"1a930d6b_f5165fa6","updated":"2015-01-26 19:51:30.000000000","message":"It was changed by https://review.openstack.org/#/c/148008.\nDone.","commit_id":"3aac40c0128269aca06879e93074ec5cc50c7d48"},{"author":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"change_message_id":"bfd2cb1e360b821826f48fcc2d89c2d161f5e468","unresolved":false,"context_lines":[{"line_number":44,"context_line":"        parameters \u003d {"},{"line_number":45,"context_line":"            \u0027key_name\u0027: keypair_name,"},{"line_number":46,"context_line":"            \u0027image_id\u0027: image_id,"},{"line_number":47,"context_line":"            \u0027plugin_name\u0027: \u0027fake\u0027,"},{"line_number":48,"context_line":"            \u0027hadoop_version\u0027: \u00270.1\u0027,"},{"line_number":49,"context_line":"            \u0027node_processes\u0027: [\u0027namenode\u0027, \u0027datanode\u0027, \u0027jobtracker\u0027,"},{"line_number":50,"context_line":"                               \u0027tasktracker\u0027],"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a80dd14_61585afb","line":47,"updated":"2015-03-04 08:51:54.000000000","message":"Is this plugin expected to be available in sahara by default ?","commit_id":"6b01eeb28e4cd08f17dc9d2578bee9aadb229a97"},{"author":{"_account_id":7710,"name":"Sergey Reshetnyak","email":"sreshetniak@mirantis.com","username":"sreshetniak"},"change_message_id":"f0ad4ed8c3c9be53c779000e8eff20bf7ed7acd8","unresolved":false,"context_lines":[{"line_number":44,"context_line":"        parameters \u003d {"},{"line_number":45,"context_line":"            \u0027key_name\u0027: keypair_name,"},{"line_number":46,"context_line":"            \u0027image_id\u0027: image_id,"},{"line_number":47,"context_line":"            \u0027plugin_name\u0027: \u0027fake\u0027,"},{"line_number":48,"context_line":"            \u0027hadoop_version\u0027: \u00270.1\u0027,"},{"line_number":49,"context_line":"            \u0027node_processes\u0027: [\u0027namenode\u0027, \u0027datanode\u0027, \u0027jobtracker\u0027,"},{"line_number":50,"context_line":"                               \u0027tasktracker\u0027],"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a80dd14_9087550f","line":47,"in_reply_to":"9a80dd14_61585afb","updated":"2015-03-04 09:55:13.000000000","message":"This plugin available in devstack by default","commit_id":"6b01eeb28e4cd08f17dc9d2578bee9aadb229a97"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"867a3041e23e8e4cb264d5192c1a38fd4e725502","unresolved":false,"context_lines":[{"line_number":44,"context_line":"        parameters \u003d {"},{"line_number":45,"context_line":"            \u0027key_name\u0027: keypair_name,"},{"line_number":46,"context_line":"            \u0027image_id\u0027: image_id,"},{"line_number":47,"context_line":"            \u0027plugin_name\u0027: \u0027fake\u0027,"},{"line_number":48,"context_line":"            \u0027hadoop_version\u0027: \u00270.1\u0027,"},{"line_number":49,"context_line":"            \u0027node_processes\u0027: [\u0027namenode\u0027, \u0027datanode\u0027, \u0027jobtracker\u0027,"},{"line_number":50,"context_line":"                               \u0027tasktracker\u0027],"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a80dd14_c90f682d","line":47,"in_reply_to":"9a80dd14_9087550f","updated":"2015-03-04 11:01:36.000000000","message":"And what if you run tempest against a generic/production cluster, where the fake plugin is 99.99% disabled?","commit_id":"6b01eeb28e4cd08f17dc9d2578bee9aadb229a97"}]}