)]}'
{"tempest/api/network/test_dhcp_ipv6.py":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"1401b60912b1bdcfdfa5889f21cdbb5a60dedebc","unresolved":false,"context_lines":[{"line_number":60,"context_line":"        resp, body \u003d self.client.list_ports()"},{"line_number":61,"context_line":"        ports \u003d body[\u0027ports\u0027]"},{"line_number":62,"context_line":"        for port in ports:"},{"line_number":63,"context_line":"            if (port[\u0027device_owner\u0027].startswith(\u0027network:router_interface\u0027)"},{"line_number":64,"context_line":"                and port[\u0027device_id\u0027] in [r[\u0027id\u0027] for r in self.routers]):"},{"line_number":65,"context_line":"                self.client.remove_router_interface_with_port_id("},{"line_number":66,"context_line":"                    port[\u0027device_id\u0027], port[\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_4be5c8a6","line":63,"updated":"2014-12-18 19:31:20.000000000","message":"_is_router_port in tempest/scenario/test_security_groups_basic_ops.py\n\ndoes this check for you. Maybe it\u0027s time to make this available as util method to avoid the logic duplication","commit_id":"c0514d53e904418b99934ccde66da0f859b6ddbd"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"2725ffc002dc38066f2aa0d34a7fe9753c948253","unresolved":false,"context_lines":[{"line_number":60,"context_line":"        resp, body \u003d self.client.list_ports()"},{"line_number":61,"context_line":"        ports \u003d body[\u0027ports\u0027]"},{"line_number":62,"context_line":"        for port in ports:"},{"line_number":63,"context_line":"            if (port[\u0027device_owner\u0027].startswith(\u0027network:router_interface\u0027)"},{"line_number":64,"context_line":"                and port[\u0027device_id\u0027] in [r[\u0027id\u0027] for r in self.routers]):"},{"line_number":65,"context_line":"                self.client.remove_router_interface_with_port_id("},{"line_number":66,"context_line":"                    port[\u0027device_id\u0027], port[\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_9c9615ef","line":63,"in_reply_to":"3a961159_4be5c8a6","updated":"2014-12-18 20:32:40.000000000","message":"Yeah I agree we probably want to expand this out into common code since it\u0027s basically the same. Also adding a dvr job to catch this in the future would be nice too.","commit_id":"c0514d53e904418b99934ccde66da0f859b6ddbd"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"a437d126c509f26b5256054ea11f31a162ca5742","unresolved":false,"context_lines":[{"line_number":60,"context_line":"        resp, body \u003d self.client.list_ports()"},{"line_number":61,"context_line":"        ports \u003d body[\u0027ports\u0027]"},{"line_number":62,"context_line":"        for port in ports:"},{"line_number":63,"context_line":"            if (port[\u0027device_owner\u0027].startswith(\u0027network:router_interface\u0027)"},{"line_number":64,"context_line":"                and port[\u0027device_id\u0027] in [r[\u0027id\u0027] for r in self.routers]):"},{"line_number":65,"context_line":"                self.client.remove_router_interface_with_port_id("},{"line_number":66,"context_line":"                    port[\u0027device_id\u0027], port[\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_9f836755","line":63,"in_reply_to":"3a961159_9c9615ef","updated":"2014-12-18 20:43:55.000000000","message":"Matt, you make an excellent point about adding the dvr job. We\u0027ve been looking into this, but unfortunately DVR isn\u0027t quite ready yet.\n\nCurrently the job is on the experimental queue; we could move it to the check queue and make it non-voting, but I feel that even if we did this, we could accidentally end up in the same situation as this one but wasting CI resources in the process ;)\n\nWe need to close the gap on IPv6 between centralized and distributed routers first (we\u0027re almost there, but not quite yet), so that we don\u0027t end stifling innovation that\u0027s going on right now for IPv6 and basi routing.\n\nThe stop-gap action right now if to ramp up our review effort, to make sure we catch these sorts of issues prior the fact.","commit_id":"c0514d53e904418b99934ccde66da0f859b6ddbd"}]}