)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7293,"name":"Elena Ezhova","email":"ezhovaelena19@gmail.com","username":"elena"},"change_message_id":"71a4fd34c5b4132c9ef58df490da93c17fa36157","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2014-12-22 01:11:51 -0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"This test case validates instance with no security group,"},{"line_number":8,"context_line":"There is defect (1399525) in existing code that blocking"},{"line_number":9,"context_line":"Instance traffic after removing security group from the"},{"line_number":10,"context_line":"Instance port."},{"line_number":11,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3a961159_add428e9","line":8,"updated":"2014-12-23 11:42:36.000000000","message":"The bug needs to be referenced in the end the commit message using the \"Closes-Bug\" hint:\n\nCloses-Bug: #1399525","commit_id":"09338ff71bf51eda7432cfa54ec97d13a2913f31"},{"author":{"_account_id":5174,"name":"Mauro Sergio Martins Rodrigues","email":"maurosr@linux.vnet.ibm.com","username":"maurosr"},"change_message_id":"01934baf831a9d7adcba5d2f7f265aae3028a7c8","unresolved":false,"context_lines":[{"line_number":8,"context_line":"There is defect (1399525) in existing code that blocking"},{"line_number":9,"context_line":"Instance traffic after removing security group from the"},{"line_number":10,"context_line":"Instance port."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ifadbfc65074d7b4db54104702c6ae6f88cf69d2e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3a961159_e92d8090","line":11,"updated":"2015-01-06 12:54:19.000000000","message":"Please follow the guidelines for a correct commit message https://wiki.openstack.org/wiki/GitCommitMessages#Summary_of_Git_commit_message_structure","commit_id":"09338ff71bf51eda7432cfa54ec97d13a2913f31"}],"tempest/scenario/manager.py":[{"author":{"_account_id":7293,"name":"Elena Ezhova","email":"ezhovaelena19@gmail.com","username":"elena"},"change_message_id":"71a4fd34c5b4132c9ef58df490da93c17fa36157","unresolved":false,"context_lines":[{"line_number":589,"context_line":"            return resource_list[resource_type]"},{"line_number":590,"context_line":"        return temp"},{"line_number":591,"context_line":""},{"line_number":592,"context_line":"    def _update_security_group(self, port_id, security_groups\u003dNone,"},{"line_number":593,"context_line":"                               client\u003dNone):"},{"line_number":594,"context_line":"        body \u003d client.show_port(port_id)"},{"line_number":595,"context_line":"        port \u003d net_resources.DeletablePort(client\u003dclient, **body[\u0027port\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_6df6c0d8","line":592,"updated":"2014-12-23 11:42:36.000000000","message":"Could you move this method down (i.e. to L843)?","commit_id":"09338ff71bf51eda7432cfa54ec97d13a2913f31"},{"author":{"_account_id":13219,"name":"Thalabathy Venkatesan","email":"thalabathy.venkatesan@hp.com","username":"thalabathy.venkatesanhp.com"},"change_message_id":"f5ddc026628dba680e0f63b2e381540f8029707b","unresolved":false,"context_lines":[{"line_number":589,"context_line":"            return resource_list[resource_type]"},{"line_number":590,"context_line":"        return temp"},{"line_number":591,"context_line":""},{"line_number":592,"context_line":"    def _update_security_group(self, port_id, security_groups\u003dNone,"},{"line_number":593,"context_line":"                               client\u003dNone):"},{"line_number":594,"context_line":"        body \u003d client.show_port(port_id)"},{"line_number":595,"context_line":"        port \u003d net_resources.DeletablePort(client\u003dclient, **body[\u0027port\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_cd1334b6","line":592,"in_reply_to":"3a961159_6df6c0d8","updated":"2015-01-08 06:32:56.000000000","message":"Comments incorporated .","commit_id":"09338ff71bf51eda7432cfa54ec97d13a2913f31"}],"tempest/scenario/test_security_groups_basic_ops.py":[{"author":{"_account_id":7293,"name":"Elena Ezhova","email":"ezhovaelena19@gmail.com","username":"elena"},"change_message_id":"71a4fd34c5b4132c9ef58df490da93c17fa36157","unresolved":false,"context_lines":[{"line_number":74,"context_line":"            been created on source tenant"},{"line_number":75,"context_line":"        7. test_in_tenant_no_securitygroup:"},{"line_number":76,"context_line":"            * test that in-tenant traffic is enabled"},{"line_number":77,"context_line":"          after security goup is removed from server port."},{"line_number":78,"context_line":""},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    assumptions:"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_8d74cc36","line":77,"updated":"2014-12-23 11:42:36.000000000","message":"nit: this line needs to match the indentation of the previous line.","commit_id":"09338ff71bf51eda7432cfa54ec97d13a2913f31"},{"author":{"_account_id":13219,"name":"Thalabathy Venkatesan","email":"thalabathy.venkatesan@hp.com","username":"thalabathy.venkatesanhp.com"},"change_message_id":"f5ddc026628dba680e0f63b2e381540f8029707b","unresolved":false,"context_lines":[{"line_number":74,"context_line":"            been created on source tenant"},{"line_number":75,"context_line":"        7. test_in_tenant_no_securitygroup:"},{"line_number":76,"context_line":"            * test that in-tenant traffic is enabled"},{"line_number":77,"context_line":"          after security goup is removed from server port."},{"line_number":78,"context_line":""},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    assumptions:"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_0d0a9c78","line":77,"in_reply_to":"3a961159_8d74cc36","updated":"2015-01-08 06:32:56.000000000","message":"Comments incorporated","commit_id":"09338ff71bf51eda7432cfa54ec97d13a2913f31"},{"author":{"_account_id":7293,"name":"Elena Ezhova","email":"ezhovaelena19@gmail.com","username":"elena"},"change_message_id":"71a4fd34c5b4132c9ef58df490da93c17fa36157","unresolved":false,"context_lines":[{"line_number":430,"context_line":"        \"\"\""},{"line_number":431,"context_line":"        remove security group from a port"},{"line_number":432,"context_line":"        \"\"\""},{"line_number":433,"context_line":"        sg \u003d []"},{"line_number":434,"context_line":"        port \u003d self._update_security_group("},{"line_number":435,"context_line":"            port_id, security_groups\u003dsg,"},{"line_number":436,"context_line":"            client\u003dtenant.manager.network_client)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_edbb90c1","line":433,"updated":"2014-12-23 11:42:36.000000000","message":"no need to create this  variable, you can just pass security_groups\u003d[]","commit_id":"09338ff71bf51eda7432cfa54ec97d13a2913f31"},{"author":{"_account_id":13219,"name":"Thalabathy Venkatesan","email":"thalabathy.venkatesan@hp.com","username":"thalabathy.venkatesanhp.com"},"change_message_id":"f5ddc026628dba680e0f63b2e381540f8029707b","unresolved":false,"context_lines":[{"line_number":430,"context_line":"        \"\"\""},{"line_number":431,"context_line":"        remove security group from a port"},{"line_number":432,"context_line":"        \"\"\""},{"line_number":433,"context_line":"        sg \u003d []"},{"line_number":434,"context_line":"        port \u003d self._update_security_group("},{"line_number":435,"context_line":"            port_id, security_groups\u003dsg,"},{"line_number":436,"context_line":"            client\u003dtenant.manager.network_client)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_2d0d988f","line":433,"in_reply_to":"3a961159_edbb90c1","updated":"2015-01-08 06:32:56.000000000","message":"Comments incorporated .","commit_id":"09338ff71bf51eda7432cfa54ec97d13a2913f31"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"44f7786759493af3f90d6af34f15cabe77f08a0f","unresolved":false,"context_lines":[{"line_number":475,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":476,"context_line":"    @test.services(\u0027compute\u0027, \u0027network\u0027)"},{"line_number":477,"context_line":"    def test_in_tenant_no_securitygroup(self):"},{"line_number":478,"context_line":"        try:"},{"line_number":479,"context_line":"            tenant1 \u003d self.primary_tenant"},{"line_number":480,"context_line":"            name \u003d \u0027server-{tenant}-no-sg\u0027.format("},{"line_number":481,"context_line":"                   tenant\u003dtenant1.creds.tenant_name)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_4edf4f3a","line":478,"updated":"2014-12-22 17:11:06.000000000","message":"wouldn\u0027t it be better to narrow down this try/except to the block of instructions that you expect it might fail (e.g. connectivity error)?","commit_id":"09338ff71bf51eda7432cfa54ec97d13a2913f31"},{"author":{"_account_id":13219,"name":"Thalabathy Venkatesan","email":"thalabathy.venkatesan@hp.com","username":"thalabathy.venkatesanhp.com"},"change_message_id":"f5ddc026628dba680e0f63b2e381540f8029707b","unresolved":false,"context_lines":[{"line_number":475,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":476,"context_line":"    @test.services(\u0027compute\u0027, \u0027network\u0027)"},{"line_number":477,"context_line":"    def test_in_tenant_no_securitygroup(self):"},{"line_number":478,"context_line":"        try:"},{"line_number":479,"context_line":"            tenant1 \u003d self.primary_tenant"},{"line_number":480,"context_line":"            name \u003d \u0027server-{tenant}-no-sg\u0027.format("},{"line_number":481,"context_line":"                   tenant\u003dtenant1.creds.tenant_name)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_4d274412","line":478,"in_reply_to":"3a961159_4edf4f3a","updated":"2015-01-08 06:32:56.000000000","message":"Comments incorporated.","commit_id":"09338ff71bf51eda7432cfa54ec97d13a2913f31"}],"tempest/services/network/json/network_client.py":[{"author":{"_account_id":5174,"name":"Mauro Sergio Martins Rodrigues","email":"maurosr@linux.vnet.ibm.com","username":"maurosr"},"change_message_id":"01934baf831a9d7adcba5d2f7f265aae3028a7c8","unresolved":false,"context_lines":[{"line_number":71,"context_line":"        resp, body \u003d self.put(uri, body)"},{"line_number":72,"context_line":"        self.rest_client.expected_success(200, resp.status)"},{"line_number":73,"context_line":"        body \u003d json.loads(body)"},{"line_number":74,"context_line":"        return resp, body"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    def reset_quotas(self, tenant_id):"},{"line_number":77,"context_line":"        uri \u003d \u0027%s/quotas/%s\u0027 % (self.uri_prefix, tenant_id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_69ea7075","line":74,"range":{"start_line":74,"start_character":15,"end_line":74,"end_character":19},"updated":"2015-01-06 12:54:19.000000000","message":"can you please wrap the resp and body into the rest_client.ResponseBody like the other methods?","commit_id":"09338ff71bf51eda7432cfa54ec97d13a2913f31"},{"author":{"_account_id":13219,"name":"Thalabathy Venkatesan","email":"thalabathy.venkatesan@hp.com","username":"thalabathy.venkatesanhp.com"},"change_message_id":"f5ddc026628dba680e0f63b2e381540f8029707b","unresolved":false,"context_lines":[{"line_number":71,"context_line":"        resp, body \u003d self.put(uri, body)"},{"line_number":72,"context_line":"        self.rest_client.expected_success(200, resp.status)"},{"line_number":73,"context_line":"        body \u003d json.loads(body)"},{"line_number":74,"context_line":"        return resp, body"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    def reset_quotas(self, tenant_id):"},{"line_number":77,"context_line":"        uri \u003d \u0027%s/quotas/%s\u0027 % (self.uri_prefix, tenant_id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_8d1dacc0","line":74,"in_reply_to":"3a961159_69ea7075","updated":"2015-01-08 06:32:56.000000000","message":"Comments incorporated.","commit_id":"09338ff71bf51eda7432cfa54ec97d13a2913f31"}]}