)]}'
{"tempest/common/rest_client.py":[{"author":{"_account_id":8859,"name":"Daisuke Morita","email":"morita.daisuke@ntti3.com","username":"morrisson"},"change_message_id":"f606b6a16302600c310f907ddd40e8886be073e8","unresolved":false,"context_lines":[{"line_number":78,"context_line":"    def __init__(self, auth_provider, service, region,"},{"line_number":79,"context_line":"                 endpoint_type\u003d\u0027publicURL\u0027,"},{"line_number":80,"context_line":"                 build_interval\u003d1, build_timeout\u003d60,"},{"line_number":81,"context_line":"                 dscv\u003dFalse, ca_certs\u003dNone,"},{"line_number":82,"context_line":"                 trace_requests\u003d\u0027\u0027):"},{"line_number":83,"context_line":"        self.auth_provider \u003d auth_provider"},{"line_number":84,"context_line":"        self.service \u003d service"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a961159_12e7ec47","line":81,"updated":"2014-12-25 01:31:40.000000000","message":"I generally prefer the full name.","commit_id":"7c01c8b2eadb1b74526e5621aba42e70ad600c43"}],"tempest/services/baremetal/base.py":[{"author":{"_account_id":8859,"name":"Daisuke Morita","email":"morita.daisuke@ntti3.com","username":"morrisson"},"change_message_id":"f606b6a16302600c310f907ddd40e8886be073e8","unresolved":false,"context_lines":[{"line_number":54,"context_line":"            CONF.baremetal.catalog_type,"},{"line_number":55,"context_line":"            CONF.identity.region,"},{"line_number":56,"context_line":"            endpoint_type\u003dCONF.baremetal.endpoint_type,"},{"line_number":57,"context_line":"            dscv\u003dCONF.identity.disable_ssl_certificate_validation,"},{"line_number":58,"context_line":"            ca_certs\u003dCONF.identity.ca_certificates_file,"},{"line_number":59,"context_line":"            trace_requests\u003dCONF.debug.trace_requests)"},{"line_number":60,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3a961159_72cd90b7","line":57,"updated":"2014-12-25 01:31:40.000000000","message":"The full name of \u0027dscv\u0027 is very long, therefore **currently** line break will be needed here if dscv is replaced by \u0027disable_ssl_certificate_validation\u0027. However, this modification is tentative and this attribute value will be also replaced by None in the near future. Therefore, I think the full attribute name is better.","commit_id":"7c01c8b2eadb1b74526e5621aba42e70ad600c43"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"ae168529f114145a9388e48828b7aa488e1eae98","unresolved":false,"context_lines":[{"line_number":54,"context_line":"            CONF.baremetal.catalog_type,"},{"line_number":55,"context_line":"            CONF.identity.region,"},{"line_number":56,"context_line":"            endpoint_type\u003dCONF.baremetal.endpoint_type,"},{"line_number":57,"context_line":"            dscv\u003dCONF.identity.disable_ssl_certificate_validation,"},{"line_number":58,"context_line":"            ca_certs\u003dCONF.identity.ca_certificates_file,"},{"line_number":59,"context_line":"            trace_requests\u003dCONF.debug.trace_requests)"},{"line_number":60,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3a961159_40299e88","line":57,"in_reply_to":"3a961159_72cd90b7","updated":"2014-12-25 05:17:03.000000000","message":"Thanks for your review, Morita-san\n\n\nYeah, I also prefer full name. but if full name, a new line is required and that seems unreadable and redundant. so I selected current implementation.\n\nBut now I changed my mind because of your review, maybe full name is on right direction because two developers prefer.\nHowever I don\u0027t like redundant code, so I will add a base class which passes disable_ssl_certificate_validation and ca_certs for all service clients.","commit_id":"7c01c8b2eadb1b74526e5621aba42e70ad600c43"}],"tempest/services/base.py":[{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"8b873bb92a2151aeb6d5282e487211a7c303d23f","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"class ServiceClient(rest_client.RestClient):"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    def __init__(self, auth_provider, service, region, **kwargs):"},{"line_number":24,"context_line":"        params \u003d {"},{"line_number":25,"context_line":"            \u0027disable_ssl_certificate_validation\u0027:"},{"line_number":26,"context_line":"                CONF.identity.disable_ssl_certificate_validation,"}],"source_content_type":"text/x-python","patch_set":9,"id":"3a961159_33dddcdd","line":23,"updated":"2015-01-08 23:38:31.000000000","message":"You\u0027re dropping dscv, ca_certs and trace_requests from __init__, but you\u0027re adding kwargs. What is kwargs for?\nIt the intention is to allow service clients to use dscv, ca_certs or trace_requests they should stay explicit. Else kwargs is not needed.","commit_id":"ce6bce67b4c7a2d10be4a6de1a84ea76ac4f8661"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"379db3651d6c892fb5f20c80aba4a9014085bd84","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"class ServiceClient(rest_client.RestClient):"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    def __init__(self, auth_provider, service, region, **kwargs):"},{"line_number":24,"context_line":"        params \u003d {"},{"line_number":25,"context_line":"            \u0027disable_ssl_certificate_validation\u0027:"},{"line_number":26,"context_line":"                CONF.identity.disable_ssl_certificate_validation,"}],"source_content_type":"text/x-python","patch_set":9,"id":"3a961159_f9a9757c","line":23,"in_reply_to":"3a961159_33dddcdd","updated":"2015-01-09 01:15:35.000000000","message":"This kwargs contains endpoint_type, build_interval and build_timeout. If not using kwargs, the code would be\n\n def __init__(self, auth_provider, service, region,\n                endpoint_type\u003dNone, build_interval\u003dNone, build_timeout\u003dNone):\n     params \u003d {\n         [same]\n     }\n     if endpoint_type is not None:\n         params.update({\u0027endpoint_type\u0027: endpoint_type})\n     if build_interval is not None:\n         params.update({\u0027build_interval\u0027: build_interval})\n     if build_timeout is not None:\n         params.update({\u0027build_timeout\u0027: build_timeout})\n     super(ServiceClient, self).__init__(auth_provider, service, region, **params)\n\nI felt the above code seems redundant, then I used kwargs.\nHowever, I feel now it is important to clarify internal interfaces after your review and the above code is fine.\nHow about the above code?","commit_id":"ce6bce67b4c7a2d10be4a6de1a84ea76ac4f8661"},{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"25c8d24372b0d6137a5fecb9d2ca985e46b8fb07","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"3a961159_242754c8","updated":"2015-01-09 02:53:23.000000000","message":"One suggestion, how about renaming from base.py to service_client.py?\nBecause there is a naming conflict at tempest/services/identity/v3/json/identity_client.py. \nNot so strong opinion, though.","commit_id":"b05063fb2e267e6d70e0b96e166c29e608847771"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"16e2369dc794b7d2fb3178f9824f9f96cabc16ae","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"3a961159_7f09e582","in_reply_to":"3a961159_242754c8","updated":"2015-01-09 03:44:50.000000000","message":"Thanks for your suggestion, I much prefer it.\nI will apply it to the next patch.","commit_id":"b05063fb2e267e6d70e0b96e166c29e608847771"},{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"25c8d24372b0d6137a5fecb9d2ca985e46b8fb07","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2014 NEC Corporation.  All rights reserved."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":10,"id":"3a961159_64c07ce0","line":1,"updated":"2015-01-09 02:53:23.000000000","message":"very nit.\nWe can update this year to 2015 if you have a chance to update this patch :)","commit_id":"b05063fb2e267e6d70e0b96e166c29e608847771"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"16e2369dc794b7d2fb3178f9824f9f96cabc16ae","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2014 NEC Corporation.  All rights reserved."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":10,"id":"3a961159_9f0cd194","line":1,"in_reply_to":"3a961159_64c07ce0","updated":"2015-01-09 03:44:50.000000000","message":"Oops, nice catch.\nwill fix.","commit_id":"b05063fb2e267e6d70e0b96e166c29e608847771"}],"tempest/services/identity/json/identity_client.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"d2fae16e8938cebf5a204cd5f66880e91ce87d3c","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"import json"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"from tempest.common import service_client"},{"line_number":16,"context_line":"from tempest import config"},{"line_number":17,"context_line":"from tempest import exceptions"},{"line_number":18,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"3a961159_aaf4a3f1","line":15,"updated":"2015-01-13 00:39:33.000000000","message":"Need to import rest_client also due to rebase.","commit_id":"ffd6c51b7a65a918388ce0c569049e655f32e17d"}]}