)]}'
{"tempest/services/object_storage/account_client.py":[{"author":{"_account_id":1192,"name":"David Kranz","email":"dkranz@redhat.com","username":"david-kranz"},"change_message_id":"574ecf3ee3114e157aac4b06c20d77df5765cf1b","unresolved":false,"context_lines":[{"line_number":166,"context_line":""},{"line_number":167,"context_line":"class AccountClientCustomizedHeader(base.ObjectStorageClient):"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"    # TODO(andreaf) This class is now redundant, to be removed in next patch"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"    def request(self, method, url, extra_headers\u003dFalse, headers\u003dNone,"},{"line_number":172,"context_line":"                body\u003dNone):"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a961159_4c97c2eb","side":"PARENT","line":169,"updated":"2015-01-02 14:26:10.000000000","message":"I presume this comment meant that the request method was redundant so the comment should also be removed.","commit_id":"0a254b8253fb7d9283ac715320765e89a93b8966"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"b858d2c1a4e85e6b7b280ddc7f301f5792335f0d","unresolved":false,"context_lines":[{"line_number":166,"context_line":""},{"line_number":167,"context_line":"class AccountClientCustomizedHeader(base.ObjectStorageClient):"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"    # TODO(andreaf) This class is now redundant, to be removed in next patch"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"    def request(self, method, url, extra_headers\u003dFalse, headers\u003dNone,"},{"line_number":172,"context_line":"                body\u003dNone):"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a961159_875a63f0","side":"PARENT","line":169,"in_reply_to":"3a961159_4c97c2eb","updated":"2015-01-02 15:18:34.000000000","message":"Thanks for the comment, David.\n\nI felt we could remove this line, but I was not sure that before. So I am sure that now :-)","commit_id":"0a254b8253fb7d9283ac715320765e89a93b8966"},{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"7509b4ae6d77df83af4b826bb3437fb9f2898088","unresolved":false,"context_lines":[{"line_number":168,"context_line":""},{"line_number":169,"context_line":"    # TODO(andreaf) This class is now redundant, to be removed in next patch"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"    def request(self, method, url, extra_headers\u003dFalse, headers\u003dNone,"},{"line_number":172,"context_line":"                body\u003dNone):"},{"line_number":173,"context_line":"        \"\"\"A simple HTTP request interface.\"\"\""},{"line_number":174,"context_line":"        dscv \u003d CONF.identity.disable_ssl_certificate_validation"}],"source_content_type":"text/x-python","patch_set":7,"id":"3a961159_c870fb42","side":"PARENT","line":171,"updated":"2015-01-02 17:52:32.000000000","message":"The only difference in this version request is that if headers is None, it\u0027s set to an empty dict. Since request in rest_client was updated some time ago, the desired behaviour is supported there by supplying headers\u003d{}.\n\nThe only place where headers is left to None is https://git.openstack.org/cgit/openstack/tempest/tree/tempest/api/object_storage/test_container_staticweb.py#n68. Dropping this without setting an empty dict there implies a change, specifically that content-type and accept-type headers are sent on the request linked above - I\u0027m not sure if it\u0027s relevant or not.\n\nIn any case I think this client could be removed completely, and the two list_account_containers method merged into one.","commit_id":"0a254b8253fb7d9283ac715320765e89a93b8966"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"e689e0919f4728f1135ae8943258b534187be1b2","unresolved":false,"context_lines":[{"line_number":168,"context_line":""},{"line_number":169,"context_line":"    # TODO(andreaf) This class is now redundant, to be removed in next patch"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"    def request(self, method, url, extra_headers\u003dFalse, headers\u003dNone,"},{"line_number":172,"context_line":"                body\u003dNone):"},{"line_number":173,"context_line":"        \"\"\"A simple HTTP request interface.\"\"\""},{"line_number":174,"context_line":"        dscv \u003d CONF.identity.disable_ssl_certificate_validation"}],"source_content_type":"text/x-python","patch_set":7,"id":"3a961159_5e259608","side":"PARENT","line":171,"in_reply_to":"3a961159_c870fb42","updated":"2015-01-05 01:16:19.000000000","message":"@Andrea\n\nThanks for your review, they are nice points.\n\n \u003e The only place where headers is left to None is\n \u003e https://git.openstack.org/cgit/openstack/tempest/tree/tempest/api/object_storage/test_container_staticweb.py#n68.\n \u003e Dropping this without setting an empty dict there implies a\n \u003e change, specifically that content-type and accept-type\n \u003e headers are sent on the request linked above\n \u003e - I\u0027m not sure if it\u0027s relevant or not.\n\nNice point, I will change test_container_staticweb.py for passing {} to keep current behavior.\n\n \u003e In any case I think this client could be removed completely,\n \u003e and the two list_account_containers method merged into one.\n\nThis also is a nice point, I will try it.","commit_id":"0a254b8253fb7d9283ac715320765e89a93b8966"}]}