)]}'
{"tempest/api/compute/admin/test_servers.py":[{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"0e42ea15f5f40162be25eaf272eff84d4702f639","unresolved":false,"context_lines":[{"line_number":83,"context_line":"        # In nova v2, tenant_id is ignored unless all_tenants is specified"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"        # List the primary tenant but get nothing due to odd specified behavior"},{"line_number":86,"context_line":"        tenant_id \u003d self.isolated_creds.get_primary_creds().tenant_id"},{"line_number":87,"context_line":"        params \u003d {\u0027tenant_id\u0027: tenant_id}"},{"line_number":88,"context_line":"        resp, body \u003d self.client.list_servers_with_detail(params)"},{"line_number":89,"context_line":"        servers \u003d body[\u0027servers\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a961159_a37d506f","line":86,"updated":"2015-01-06 15:40:28.000000000","message":"This will work only if tenant isolation is enabled.\nYou can get the tenant_id from any client, e.g. self.client.tenant_id or self.non_admin_client.tenant_id","commit_id":"0d6db4af7d42581872bbbea4f880292451641a19"},{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"0e42ea15f5f40162be25eaf272eff84d4702f639","unresolved":false,"context_lines":[{"line_number":90,"context_line":"        self.assertEqual([], servers)"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"        # List the admin tenant which has no servers"},{"line_number":93,"context_line":"        admin_tenant_id \u003d self.isolated_creds.get_admin_creds().tenant_id"},{"line_number":94,"context_line":"        params \u003d {\u0027all_tenants\u0027: \u0027\u0027, \u0027tenant_id\u0027: admin_tenant_id}"},{"line_number":95,"context_line":"        resp, body \u003d self.client.list_servers_with_detail(params)"},{"line_number":96,"context_line":"        servers \u003d body[\u0027servers\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a961159_2389606f","line":93,"updated":"2015-01-06 15:40:28.000000000","message":"Ditto L86","commit_id":"0d6db4af7d42581872bbbea4f880292451641a19"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"48550c48247f443917548f8c3e0146abaeee9e3a","unresolved":false,"context_lines":[{"line_number":87,"context_line":"        params \u003d {\u0027tenant_id\u0027: tenant_id}"},{"line_number":88,"context_line":"        resp, body \u003d self.client.list_servers_with_detail(params)"},{"line_number":89,"context_line":"        servers \u003d body[\u0027servers\u0027]"},{"line_number":90,"context_line":"        self.assertEqual([], servers)"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"        # List the admin tenant which has no servers"},{"line_number":93,"context_line":"        admin_tenant_id \u003d self.client.tenant_id"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a961159_4cff69ab","line":90,"updated":"2015-01-07 07:33:16.000000000","message":"As this is fixed in Nova V2.1 API, it will return servers for non_admin_client.tenant_id.\n\nI think fixing it in Nova V2 also will be good. IMO it will not be backward compatibility (but not sure) as there will not be any change in old behavior(it will still support --tenant_id option with --all_tenants ). But it takes time in nova as it will require spec too.\n\nTill then may be we can have tests with both options \u0027--all_tenants\u0027 \u0026 --tenant_id (just second part of this test) ?","commit_id":"b28b41854655b6dff7f2d5a5bf785826921e2057"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"ec2cb740e89c11533ac3183a758772d3aa42c7ac","unresolved":false,"context_lines":[{"line_number":87,"context_line":"        params \u003d {\u0027tenant_id\u0027: tenant_id}"},{"line_number":88,"context_line":"        resp, body \u003d self.client.list_servers_with_detail(params)"},{"line_number":89,"context_line":"        servers \u003d body[\u0027servers\u0027]"},{"line_number":90,"context_line":"        self.assertEqual([], servers)"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"        # List the admin tenant which has no servers"},{"line_number":93,"context_line":"        admin_tenant_id \u003d self.client.tenant_id"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a961159_8a39a7f4","line":90,"in_reply_to":"3a961159_43980f75","updated":"2015-01-13 01:16:24.000000000","message":"Yes, agree.\nI have posted patch for Nova V2.1 to behave same as V2 (https://review.openstack.org/#/c/145687/). Let\u0027s wait till that patch to pass this on V2.1 experimental job also.","commit_id":"b28b41854655b6dff7f2d5a5bf785826921e2057"},{"author":{"_account_id":1192,"name":"David Kranz","email":"dkranz@redhat.com","username":"david-kranz"},"change_message_id":"fc15403190bdf9e2ec641f51d9f494d4cd8aeb9a","unresolved":false,"context_lines":[{"line_number":87,"context_line":"        params \u003d {\u0027tenant_id\u0027: tenant_id}"},{"line_number":88,"context_line":"        resp, body \u003d self.client.list_servers_with_detail(params)"},{"line_number":89,"context_line":"        servers \u003d body[\u0027servers\u0027]"},{"line_number":90,"context_line":"        self.assertEqual([], servers)"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"        # List the admin tenant which has no servers"},{"line_number":93,"context_line":"        admin_tenant_id \u003d self.client.tenant_id"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a961159_43980f75","line":90,"in_reply_to":"3a961159_4cff69ab","updated":"2015-01-07 13:14:38.000000000","message":"The intent here was to test the current behavior. When we have the mechanism for testing a different microversion with different behavior this test can be updated as will be needed with any other microversion that changes behavior.\n\nThis is definitely a behavior change. Please see https://bugs.launchpad.net/nova/+bug/1185290 and\nhttps://wiki.openstack.org/wiki/APIChangeGuidelines#No.2C_Really._We_Mean_It.21","commit_id":"b28b41854655b6dff7f2d5a5bf785826921e2057"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"48550c48247f443917548f8c3e0146abaeee9e3a","unresolved":false,"context_lines":[{"line_number":90,"context_line":"        self.assertEqual([], servers)"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"        # List the admin tenant which has no servers"},{"line_number":93,"context_line":"        admin_tenant_id \u003d self.client.tenant_id"},{"line_number":94,"context_line":"        params \u003d {\u0027all_tenants\u0027: \u0027\u0027, \u0027tenant_id\u0027: admin_tenant_id}"},{"line_number":95,"context_line":"        resp, body \u003d self.client.list_servers_with_detail(params)"},{"line_number":96,"context_line":"        servers \u003d body[\u0027servers\u0027]"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a961159_8c05d1c3","line":93,"updated":"2015-01-07 07:33:16.000000000","message":"It will be better to search with self.non_admin_client.tenant_id to get the created servers.","commit_id":"b28b41854655b6dff7f2d5a5bf785826921e2057"},{"author":{"_account_id":1192,"name":"David Kranz","email":"dkranz@redhat.com","username":"david-kranz"},"change_message_id":"fc15403190bdf9e2ec641f51d9f494d4cd8aeb9a","unresolved":false,"context_lines":[{"line_number":90,"context_line":"        self.assertEqual([], servers)"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"        # List the admin tenant which has no servers"},{"line_number":93,"context_line":"        admin_tenant_id \u003d self.client.tenant_id"},{"line_number":94,"context_line":"        params \u003d {\u0027all_tenants\u0027: \u0027\u0027, \u0027tenant_id\u0027: admin_tenant_id}"},{"line_number":95,"context_line":"        resp, body \u003d self.client.list_servers_with_detail(params)"},{"line_number":96,"context_line":"        servers \u003d body[\u0027servers\u0027]"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a961159_a3ac5389","line":93,"in_reply_to":"3a961159_8c05d1c3","updated":"2015-01-07 13:14:38.000000000","message":"I did not do that because if tenant_id was not working the returned value might be the same as if it were working. It does not matter which tenant is used other than that.","commit_id":"b28b41854655b6dff7f2d5a5bf785826921e2057"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"ec2cb740e89c11533ac3183a758772d3aa42c7ac","unresolved":false,"context_lines":[{"line_number":90,"context_line":"        self.assertEqual([], servers)"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"        # List the admin tenant which has no servers"},{"line_number":93,"context_line":"        admin_tenant_id \u003d self.client.tenant_id"},{"line_number":94,"context_line":"        params \u003d {\u0027all_tenants\u0027: \u0027\u0027, \u0027tenant_id\u0027: admin_tenant_id}"},{"line_number":95,"context_line":"        resp, body \u003d self.client.list_servers_with_detail(params)"},{"line_number":96,"context_line":"        servers \u003d body[\u0027servers\u0027]"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a961159_cd6589e3","line":93,"in_reply_to":"3a961159_a3ac5389","updated":"2015-01-13 01:16:24.000000000","message":"Actually I was thinking if test can check that search with \u0027tenant_id\u0027 \u0026 \u0027all_tenants\u0027 return some server list against the empty one (which is case of searching with \u0027tenant-id\u0027 alone)","commit_id":"b28b41854655b6dff7f2d5a5bf785826921e2057"}]}