)]}'
{"tempest/api/volume/admin/test_volume_types.py":[{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"9bec3d23cc08a673bbb5f3c7e022d30f1e9b4129","unresolved":false,"context_lines":[{"line_number":40,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":41,"context_line":"    def test_create_update_get_delete_volume_with_volume_type(self):"},{"line_number":42,"context_line":"        # Create/update/get/delete volume with volume_type and extra spec."},{"line_number":43,"context_line":"        volume \u003d {}"},{"line_number":44,"context_line":"        volume_types \u003d list()"},{"line_number":45,"context_line":"        vol_name \u003d data_utils.rand_name(\"volume-\")"},{"line_number":46,"context_line":"        self.name_field \u003d self.special_fields[\u0027name_field\u0027]"}],"source_content_type":"text/x-python","patch_set":5,"id":"da86d52c_56201949","line":43,"updated":"2015-02-10 11:22:51.000000000","message":"I think this variable is not used","commit_id":"d4a924d2c69580639d65c9083644e467f301d824"},{"author":{"_account_id":2222,"name":"meenakshi-m","username":"meenakshi-m"},"change_message_id":"015c678b60cf621dd0b46065b44fc2e165a9bb04","unresolved":false,"context_lines":[{"line_number":40,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":41,"context_line":"    def test_create_update_get_delete_volume_with_volume_type(self):"},{"line_number":42,"context_line":"        # Create/update/get/delete volume with volume_type and extra spec."},{"line_number":43,"context_line":"        volume \u003d {}"},{"line_number":44,"context_line":"        volume_types \u003d list()"},{"line_number":45,"context_line":"        vol_name \u003d data_utils.rand_name(\"volume-\")"},{"line_number":46,"context_line":"        self.name_field \u003d self.special_fields[\u0027name_field\u0027]"}],"source_content_type":"text/x-python","patch_set":5,"id":"da86d52c_74a7710b","line":43,"in_reply_to":"da86d52c_56201949","updated":"2015-02-12 10:59:13.000000000","message":"Done","commit_id":"d4a924d2c69580639d65c9083644e467f301d824"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"9bec3d23cc08a673bbb5f3c7e022d30f1e9b4129","unresolved":false,"context_lines":[{"line_number":58,"context_line":"            self.addCleanup(self._delete_volume_type, vol_type[\u0027id\u0027])"},{"line_number":59,"context_line":"        params \u003d {self.name_field: vol_name,"},{"line_number":60,"context_line":"                  \u0027volume_type\u0027: volume_types[0][\u0027id\u0027]}"},{"line_number":61,"context_line":"        # Create volume"},{"line_number":62,"context_line":"        volume \u003d self.volumes_client.create_volume(size\u003d1, **params)"},{"line_number":63,"context_line":"        self.addCleanup(self._delete_volume, volume[\u0027id\u0027])"},{"line_number":64,"context_line":"        self.assertEqual(volume_types[0][\u0027name\u0027], volume[\"volume_type\"])"}],"source_content_type":"text/x-python","patch_set":5,"id":"da86d52c_b6ecf5f4","line":61,"updated":"2015-02-10 11:22:51.000000000","message":"Add an empty line before this line","commit_id":"d4a924d2c69580639d65c9083644e467f301d824"},{"author":{"_account_id":2222,"name":"meenakshi-m","username":"meenakshi-m"},"change_message_id":"015c678b60cf621dd0b46065b44fc2e165a9bb04","unresolved":false,"context_lines":[{"line_number":58,"context_line":"            self.addCleanup(self._delete_volume_type, vol_type[\u0027id\u0027])"},{"line_number":59,"context_line":"        params \u003d {self.name_field: vol_name,"},{"line_number":60,"context_line":"                  \u0027volume_type\u0027: volume_types[0][\u0027id\u0027]}"},{"line_number":61,"context_line":"        # Create volume"},{"line_number":62,"context_line":"        volume \u003d self.volumes_client.create_volume(size\u003d1, **params)"},{"line_number":63,"context_line":"        self.addCleanup(self._delete_volume, volume[\u0027id\u0027])"},{"line_number":64,"context_line":"        self.assertEqual(volume_types[0][\u0027name\u0027], volume[\"volume_type\"])"}],"source_content_type":"text/x-python","patch_set":5,"id":"da86d52c_b4ac89ee","line":61,"in_reply_to":"da86d52c_b6ecf5f4","updated":"2015-02-12 10:59:13.000000000","message":"Done","commit_id":"d4a924d2c69580639d65c9083644e467f301d824"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"9bec3d23cc08a673bbb5f3c7e022d30f1e9b4129","unresolved":false,"context_lines":[{"line_number":65,"context_line":"        self.assertEqual(volume[self.name_field], vol_name,"},{"line_number":66,"context_line":"                         \"The created volume name is not equal \""},{"line_number":67,"context_line":"                         \"to the requested name\")"},{"line_number":68,"context_line":"        self.assertTrue(volume[\u0027id\u0027] is not None,"},{"line_number":69,"context_line":"                        \"Field volume id is empty or not found.\")"},{"line_number":70,"context_line":"        self.volumes_client.wait_for_volume_status(volume[\u0027id\u0027], \u0027available\u0027)"},{"line_number":71,"context_line":"        # Update volume with new volume_type"}],"source_content_type":"text/x-python","patch_set":5,"id":"da86d52c_16830105","line":68,"updated":"2015-02-10 11:22:51.000000000","message":"While you are at it, maybe change to use assertIsNotNone","commit_id":"d4a924d2c69580639d65c9083644e467f301d824"},{"author":{"_account_id":2222,"name":"meenakshi-m","username":"meenakshi-m"},"change_message_id":"015c678b60cf621dd0b46065b44fc2e165a9bb04","unresolved":false,"context_lines":[{"line_number":65,"context_line":"        self.assertEqual(volume[self.name_field], vol_name,"},{"line_number":66,"context_line":"                         \"The created volume name is not equal \""},{"line_number":67,"context_line":"                         \"to the requested name\")"},{"line_number":68,"context_line":"        self.assertTrue(volume[\u0027id\u0027] is not None,"},{"line_number":69,"context_line":"                        \"Field volume id is empty or not found.\")"},{"line_number":70,"context_line":"        self.volumes_client.wait_for_volume_status(volume[\u0027id\u0027], \u0027available\u0027)"},{"line_number":71,"context_line":"        # Update volume with new volume_type"}],"source_content_type":"text/x-python","patch_set":5,"id":"da86d52c_d4b73d38","line":68,"in_reply_to":"da86d52c_16830105","updated":"2015-02-12 10:59:13.000000000","message":"Done","commit_id":"d4a924d2c69580639d65c9083644e467f301d824"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"9bec3d23cc08a673bbb5f3c7e022d30f1e9b4129","unresolved":false,"context_lines":[{"line_number":68,"context_line":"        self.assertTrue(volume[\u0027id\u0027] is not None,"},{"line_number":69,"context_line":"                        \"Field volume id is empty or not found.\")"},{"line_number":70,"context_line":"        self.volumes_client.wait_for_volume_status(volume[\u0027id\u0027], \u0027available\u0027)"},{"line_number":71,"context_line":"        # Update volume with new volume_type"},{"line_number":72,"context_line":"        self.volumes_client.retype_volume(volume[\u0027id\u0027],"},{"line_number":73,"context_line":"                                          volume_type\u003dvolume_types[1][\u0027id\u0027])"},{"line_number":74,"context_line":"        self.volumes_client.wait_for_volume_status(volume[\u0027id\u0027], \u0027available\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"da86d52c_16b5c1ed","line":71,"updated":"2015-02-10 11:22:51.000000000","message":"Add an empty line before this line","commit_id":"d4a924d2c69580639d65c9083644e467f301d824"},{"author":{"_account_id":2222,"name":"meenakshi-m","username":"meenakshi-m"},"change_message_id":"015c678b60cf621dd0b46065b44fc2e165a9bb04","unresolved":false,"context_lines":[{"line_number":68,"context_line":"        self.assertTrue(volume[\u0027id\u0027] is not None,"},{"line_number":69,"context_line":"                        \"Field volume id is empty or not found.\")"},{"line_number":70,"context_line":"        self.volumes_client.wait_for_volume_status(volume[\u0027id\u0027], \u0027available\u0027)"},{"line_number":71,"context_line":"        # Update volume with new volume_type"},{"line_number":72,"context_line":"        self.volumes_client.retype_volume(volume[\u0027id\u0027],"},{"line_number":73,"context_line":"                                          volume_type\u003dvolume_types[1][\u0027id\u0027])"},{"line_number":74,"context_line":"        self.volumes_client.wait_for_volume_status(volume[\u0027id\u0027], \u0027available\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"da86d52c_14855559","line":71,"in_reply_to":"da86d52c_16b5c1ed","updated":"2015-02-12 10:59:13.000000000","message":"Done","commit_id":"d4a924d2c69580639d65c9083644e467f301d824"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"9bec3d23cc08a673bbb5f3c7e022d30f1e9b4129","unresolved":false,"context_lines":[{"line_number":72,"context_line":"        self.volumes_client.retype_volume(volume[\u0027id\u0027],"},{"line_number":73,"context_line":"                                          volume_type\u003dvolume_types[1][\u0027id\u0027])"},{"line_number":74,"context_line":"        self.volumes_client.wait_for_volume_status(volume[\u0027id\u0027], \u0027available\u0027)"},{"line_number":75,"context_line":"        # Get volume details and Verify"},{"line_number":76,"context_line":"        fetched_volume \u003d self.volumes_client.get_volume(volume[\u0027id\u0027])"},{"line_number":77,"context_line":"        self.assertEqual(volume_types[1][\u0027name\u0027],"},{"line_number":78,"context_line":"                         fetched_volume[\u0027volume_type\u0027],"}],"source_content_type":"text/x-python","patch_set":5,"id":"da86d52c_56ce5984","line":75,"updated":"2015-02-10 11:22:51.000000000","message":"Add an empty line before this line","commit_id":"d4a924d2c69580639d65c9083644e467f301d824"},{"author":{"_account_id":2222,"name":"meenakshi-m","username":"meenakshi-m"},"change_message_id":"015c678b60cf621dd0b46065b44fc2e165a9bb04","unresolved":false,"context_lines":[{"line_number":72,"context_line":"        self.volumes_client.retype_volume(volume[\u0027id\u0027],"},{"line_number":73,"context_line":"                                          volume_type\u003dvolume_types[1][\u0027id\u0027])"},{"line_number":74,"context_line":"        self.volumes_client.wait_for_volume_status(volume[\u0027id\u0027], \u0027available\u0027)"},{"line_number":75,"context_line":"        # Get volume details and Verify"},{"line_number":76,"context_line":"        fetched_volume \u003d self.volumes_client.get_volume(volume[\u0027id\u0027])"},{"line_number":77,"context_line":"        self.assertEqual(volume_types[1][\u0027name\u0027],"},{"line_number":78,"context_line":"                         fetched_volume[\u0027volume_type\u0027],"}],"source_content_type":"text/x-python","patch_set":5,"id":"da86d52c_747e916b","line":75,"in_reply_to":"da86d52c_56ce5984","updated":"2015-02-12 10:59:13.000000000","message":"Done","commit_id":"d4a924d2c69580639d65c9083644e467f301d824"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"388a612c3077ce5152cf84e150a244bc8886002d","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        self.assertIsInstance(body, list)"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":41,"context_line":"    def test_create_update_get_delete_volume_with_volume_type(self):"},{"line_number":42,"context_line":"        # Create/update/get/delete volume with volume_type and extra spec."},{"line_number":43,"context_line":"        volume_types \u003d list()"},{"line_number":44,"context_line":"        vol_name \u003d data_utils.rand_name(\"volume-\")"}],"source_content_type":"text/x-python","patch_set":6,"id":"da86d52c_cd6fd090","line":41,"updated":"2015-02-11 17:37:36.000000000","message":"Why did you remove the \"_and_extra_specs\" from the name ?\n\nThis is going to break IBM Cinder CI, because they exclude some tests based on their name. This test is excluded. (http://dal05.objectstorage.softlayer.net/v1/AUTH_58396f85-2c60-47b9-aaf8-e03bc24a1a6f/IBMStorwizeCI/65/152565/2/check/storwize-cinder-ci/8e471d4/console.html   look for DEVSTACK_GATE_TEMPEST_REGEX)","commit_id":"17960138d4b9f1e1058156f4d6f526b5e70f0900"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"aaa481dc09ff1d03e6be1abb72d13841f2ef80ac","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        self.assertIsInstance(body, list)"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":41,"context_line":"    def test_create_update_get_delete_volume_with_volume_type(self):"},{"line_number":42,"context_line":"        # Create/update/get/delete volume with volume_type and extra spec."},{"line_number":43,"context_line":"        volume_types \u003d list()"},{"line_number":44,"context_line":"        vol_name \u003d data_utils.rand_name(\"volume-\")"}],"source_content_type":"text/x-python","patch_set":6,"id":"da86d52c_43bb63c3","line":41,"updated":"2015-02-13 06:54:45.000000000","message":"Yes Jordon is right.\nHows about \u0027test_volume_crud_with_volume_type_and_extra_specs\u0027","commit_id":"17960138d4b9f1e1058156f4d6f526b5e70f0900"}],"tempest/api/volume/admin/test_volumes_actions.py":[{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"932d6eb944ca1c753192ab06b64fb5c88cfa5860","unresolved":false,"context_lines":[{"line_number":101,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":102,"context_line":"    def test_update_volume_type(self):"},{"line_number":103,"context_line":"        # Create/get/retype/delete volume with volume_type."},{"line_number":104,"context_line":"        vol_name \u003d utils.rand_name(\"volume-\")"},{"line_number":105,"context_line":"        vol_type_name1 \u003d utils.rand_name(\"volume-type1-\")"},{"line_number":106,"context_line":"        vol_type_name2 \u003d utils.rand_name(\"volume-type2-\")"},{"line_number":107,"context_line":"        self.name_field \u003d self.special_fields[\u0027name_field\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_d61a6a6e","line":104,"updated":"2015-01-13 10:54:35.000000000","message":"Declare the variable \"vol_name\" right before you first use it. Line 122.","commit_id":"2cefa555618c5a4b3f9cd099d21a60a0055147fc"},{"author":{"_account_id":2222,"name":"meenakshi-m","username":"meenakshi-m"},"change_message_id":"52ff14cb731f893404538c4d586729bcc863c485","unresolved":false,"context_lines":[{"line_number":101,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":102,"context_line":"    def test_update_volume_type(self):"},{"line_number":103,"context_line":"        # Create/get/retype/delete volume with volume_type."},{"line_number":104,"context_line":"        vol_name \u003d utils.rand_name(\"volume-\")"},{"line_number":105,"context_line":"        vol_type_name1 \u003d utils.rand_name(\"volume-type1-\")"},{"line_number":106,"context_line":"        vol_type_name2 \u003d utils.rand_name(\"volume-type2-\")"},{"line_number":107,"context_line":"        self.name_field \u003d self.special_fields[\u0027name_field\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_21526368","line":104,"in_reply_to":"3a961159_d61a6a6e","updated":"2015-01-14 09:51:35.000000000","message":"Done","commit_id":"2cefa555618c5a4b3f9cd099d21a60a0055147fc"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"932d6eb944ca1c753192ab06b64fb5c88cfa5860","unresolved":false,"context_lines":[{"line_number":105,"context_line":"        vol_type_name1 \u003d utils.rand_name(\"volume-type1-\")"},{"line_number":106,"context_line":"        vol_type_name2 \u003d utils.rand_name(\"volume-type2-\")"},{"line_number":107,"context_line":"        self.name_field \u003d self.special_fields[\u0027name_field\u0027]"},{"line_number":108,"context_line":"        # Create volume_type1"},{"line_number":109,"context_line":"        _, vol_type1 \u003d self.volume_types_client.create_volume_type("},{"line_number":110,"context_line":"            vol_type_name1)"},{"line_number":111,"context_line":"        self.assertIn(\u0027id\u0027, vol_type1)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_d0135163","line":108,"updated":"2015-01-13 10:54:35.000000000","message":"You have duplicated code. You should use a loop to : \n\n1) Create a volume type\n2) assert\n3) addcleanup\n\non the 2 volume types","commit_id":"2cefa555618c5a4b3f9cd099d21a60a0055147fc"},{"author":{"_account_id":2222,"name":"meenakshi-m","username":"meenakshi-m"},"change_message_id":"52ff14cb731f893404538c4d586729bcc863c485","unresolved":false,"context_lines":[{"line_number":105,"context_line":"        vol_type_name1 \u003d utils.rand_name(\"volume-type1-\")"},{"line_number":106,"context_line":"        vol_type_name2 \u003d utils.rand_name(\"volume-type2-\")"},{"line_number":107,"context_line":"        self.name_field \u003d self.special_fields[\u0027name_field\u0027]"},{"line_number":108,"context_line":"        # Create volume_type1"},{"line_number":109,"context_line":"        _, vol_type1 \u003d self.volume_types_client.create_volume_type("},{"line_number":110,"context_line":"            vol_type_name1)"},{"line_number":111,"context_line":"        self.assertIn(\u0027id\u0027, vol_type1)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_614c6bc9","line":108,"in_reply_to":"3a961159_d0135163","updated":"2015-01-14 09:51:35.000000000","message":"Done","commit_id":"2cefa555618c5a4b3f9cd099d21a60a0055147fc"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"932d6eb944ca1c753192ab06b64fb5c88cfa5860","unresolved":false,"context_lines":[{"line_number":129,"context_line":"        self.assertEqual(volume[self.name_field], vol_name,"},{"line_number":130,"context_line":"                         \"The created volume name is not equal \""},{"line_number":131,"context_line":"                         \"to the requested name\")"},{"line_number":132,"context_line":"        self.assertTrue(volume[\u0027id\u0027] is not None,"},{"line_number":133,"context_line":"                        \"Field volume id is empty or not found.\")"},{"line_number":134,"context_line":"        self.volumes_client.wait_for_volume_status(volume[\u0027id\u0027], \u0027available\u0027)"},{"line_number":135,"context_line":"        # Update volume with new volime_type"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_167232b0","line":132,"updated":"2015-01-13 10:54:35.000000000","message":"Use assertIsNone()","commit_id":"2cefa555618c5a4b3f9cd099d21a60a0055147fc"},{"author":{"_account_id":2222,"name":"meenakshi-m","username":"meenakshi-m"},"change_message_id":"52ff14cb731f893404538c4d586729bcc863c485","unresolved":false,"context_lines":[{"line_number":129,"context_line":"        self.assertEqual(volume[self.name_field], vol_name,"},{"line_number":130,"context_line":"                         \"The created volume name is not equal \""},{"line_number":131,"context_line":"                         \"to the requested name\")"},{"line_number":132,"context_line":"        self.assertTrue(volume[\u0027id\u0027] is not None,"},{"line_number":133,"context_line":"                        \"Field volume id is empty or not found.\")"},{"line_number":134,"context_line":"        self.volumes_client.wait_for_volume_status(volume[\u0027id\u0027], \u0027available\u0027)"},{"line_number":135,"context_line":"        # Update volume with new volime_type"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_e1e69baf","line":132,"in_reply_to":"3a961159_167232b0","updated":"2015-01-14 09:51:35.000000000","message":"Hi Jordan,\n\nModified the assert statement to assertIsNotNone, as we have used \"volume[\u0027id\u0027] is not None\" in the test case.\n\nRegards,\nMeenakshi","commit_id":"2cefa555618c5a4b3f9cd099d21a60a0055147fc"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"932d6eb944ca1c753192ab06b64fb5c88cfa5860","unresolved":false,"context_lines":[{"line_number":132,"context_line":"        self.assertTrue(volume[\u0027id\u0027] is not None,"},{"line_number":133,"context_line":"                        \"Field volume id is empty or not found.\")"},{"line_number":134,"context_line":"        self.volumes_client.wait_for_volume_status(volume[\u0027id\u0027], \u0027available\u0027)"},{"line_number":135,"context_line":"        # Update volume with new volime_type"},{"line_number":136,"context_line":"        self.volumes_client.retype_volume(volume[\u0027id\u0027],"},{"line_number":137,"context_line":"                                          volume_type\u003dvol_type2[\u0027id\u0027])"},{"line_number":138,"context_line":"        self.volumes_client.wait_for_volume_status(volume[\u0027id\u0027], \u0027available\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_966542e4","line":135,"updated":"2015-01-13 10:54:35.000000000","message":"s/volime/volume/","commit_id":"2cefa555618c5a4b3f9cd099d21a60a0055147fc"},{"author":{"_account_id":2222,"name":"meenakshi-m","username":"meenakshi-m"},"change_message_id":"52ff14cb731f893404538c4d586729bcc863c485","unresolved":false,"context_lines":[{"line_number":132,"context_line":"        self.assertTrue(volume[\u0027id\u0027] is not None,"},{"line_number":133,"context_line":"                        \"Field volume id is empty or not found.\")"},{"line_number":134,"context_line":"        self.volumes_client.wait_for_volume_status(volume[\u0027id\u0027], \u0027available\u0027)"},{"line_number":135,"context_line":"        # Update volume with new volime_type"},{"line_number":136,"context_line":"        self.volumes_client.retype_volume(volume[\u0027id\u0027],"},{"line_number":137,"context_line":"                                          volume_type\u003dvol_type2[\u0027id\u0027])"},{"line_number":138,"context_line":"        self.volumes_client.wait_for_volume_status(volume[\u0027id\u0027], \u0027available\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_2100a334","line":135,"in_reply_to":"3a961159_966542e4","updated":"2015-01-14 09:51:35.000000000","message":"Done","commit_id":"2cefa555618c5a4b3f9cd099d21a60a0055147fc"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"932d6eb944ca1c753192ab06b64fb5c88cfa5860","unresolved":false,"context_lines":[{"line_number":136,"context_line":"        self.volumes_client.retype_volume(volume[\u0027id\u0027],"},{"line_number":137,"context_line":"                                          volume_type\u003dvol_type2[\u0027id\u0027])"},{"line_number":138,"context_line":"        self.volumes_client.wait_for_volume_status(volume[\u0027id\u0027], \u0027available\u0027)"},{"line_number":139,"context_line":"        # Verify volume-type updation"},{"line_number":140,"context_line":"        _, get_volume \u003d self.volumes_client.get_volume(volume[\u0027id\u0027])"},{"line_number":141,"context_line":"        self.assertEqual(vol_type_name2, get_volume[\u0027volume_type\u0027],"},{"line_number":142,"context_line":"                         \u0027The fetched Volume type is different \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_f65a061d","line":139,"updated":"2015-01-13 10:54:35.000000000","message":"s/updation/update/","commit_id":"2cefa555618c5a4b3f9cd099d21a60a0055147fc"},{"author":{"_account_id":2222,"name":"meenakshi-m","username":"meenakshi-m"},"change_message_id":"52ff14cb731f893404538c4d586729bcc863c485","unresolved":false,"context_lines":[{"line_number":136,"context_line":"        self.volumes_client.retype_volume(volume[\u0027id\u0027],"},{"line_number":137,"context_line":"                                          volume_type\u003dvol_type2[\u0027id\u0027])"},{"line_number":138,"context_line":"        self.volumes_client.wait_for_volume_status(volume[\u0027id\u0027], \u0027available\u0027)"},{"line_number":139,"context_line":"        # Verify volume-type updation"},{"line_number":140,"context_line":"        _, get_volume \u003d self.volumes_client.get_volume(volume[\u0027id\u0027])"},{"line_number":141,"context_line":"        self.assertEqual(vol_type_name2, get_volume[\u0027volume_type\u0027],"},{"line_number":142,"context_line":"                         \u0027The fetched Volume type is different \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_41fbef47","line":139,"in_reply_to":"3a961159_f65a061d","updated":"2015-01-14 09:51:35.000000000","message":"Done","commit_id":"2cefa555618c5a4b3f9cd099d21a60a0055147fc"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"31fd78904034ce8a4c0e7e49d36b340f63d432bf","unresolved":false,"context_lines":[{"line_number":115,"context_line":"                vol_type_name,"},{"line_number":116,"context_line":"                extra_specs\u003dextra_specs)"},{"line_number":117,"context_line":"            volume_types.append(vol_type)"},{"line_number":118,"context_line":"            self.assertIn(\u0027id\u0027, vol_type)"},{"line_number":119,"context_line":"            self.addCleanup(self.volume_types_client.delete_volume_type,"},{"line_number":120,"context_line":"                            vol_type[\u0027id\u0027])"},{"line_number":121,"context_line":"            self.assertIn(\u0027name\u0027, vol_type)"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a930d6b_e4907745","line":118,"updated":"2015-01-23 11:10:03.000000000","message":"This assert is already tested in \"admin/test_volume_types.py\"","commit_id":"fd1cbd5d0fa99d17f79076869ec08f18ae9c8b4e"},{"author":{"_account_id":2222,"name":"meenakshi-m","username":"meenakshi-m"},"change_message_id":"d0e3a446b5a0b8ee849198bc9a2891197306b936","unresolved":false,"context_lines":[{"line_number":115,"context_line":"                vol_type_name,"},{"line_number":116,"context_line":"                extra_specs\u003dextra_specs)"},{"line_number":117,"context_line":"            volume_types.append(vol_type)"},{"line_number":118,"context_line":"            self.assertIn(\u0027id\u0027, vol_type)"},{"line_number":119,"context_line":"            self.addCleanup(self.volume_types_client.delete_volume_type,"},{"line_number":120,"context_line":"                            vol_type[\u0027id\u0027])"},{"line_number":121,"context_line":"            self.assertIn(\u0027name\u0027, vol_type)"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa81d914_1dc40e5e","line":118,"in_reply_to":"1a930d6b_e4907745","updated":"2015-01-29 10:05:16.000000000","message":"Done","commit_id":"fd1cbd5d0fa99d17f79076869ec08f18ae9c8b4e"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"31fd78904034ce8a4c0e7e49d36b340f63d432bf","unresolved":false,"context_lines":[{"line_number":118,"context_line":"            self.assertIn(\u0027id\u0027, vol_type)"},{"line_number":119,"context_line":"            self.addCleanup(self.volume_types_client.delete_volume_type,"},{"line_number":120,"context_line":"                            vol_type[\u0027id\u0027])"},{"line_number":121,"context_line":"            self.assertIn(\u0027name\u0027, vol_type)"},{"line_number":122,"context_line":"        vol_name \u003d utils.rand_name(\"volume-\")"},{"line_number":123,"context_line":"        self.name_field \u003d self.special_fields[\u0027name_field\u0027]"},{"line_number":124,"context_line":"        params \u003d {self.name_field: vol_name,"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a930d6b_249b5f68","line":121,"updated":"2015-01-23 11:10:03.000000000","message":"This assert is already tested in \"admin/test_volume_types.py\"","commit_id":"fd1cbd5d0fa99d17f79076869ec08f18ae9c8b4e"},{"author":{"_account_id":2222,"name":"meenakshi-m","username":"meenakshi-m"},"change_message_id":"d0e3a446b5a0b8ee849198bc9a2891197306b936","unresolved":false,"context_lines":[{"line_number":118,"context_line":"            self.assertIn(\u0027id\u0027, vol_type)"},{"line_number":119,"context_line":"            self.addCleanup(self.volume_types_client.delete_volume_type,"},{"line_number":120,"context_line":"                            vol_type[\u0027id\u0027])"},{"line_number":121,"context_line":"            self.assertIn(\u0027name\u0027, vol_type)"},{"line_number":122,"context_line":"        vol_name \u003d utils.rand_name(\"volume-\")"},{"line_number":123,"context_line":"        self.name_field \u003d self.special_fields[\u0027name_field\u0027]"},{"line_number":124,"context_line":"        params \u003d {self.name_field: vol_name,"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa81d914_3da2b2ae","line":121,"in_reply_to":"1a930d6b_249b5f68","updated":"2015-01-29 10:05:16.000000000","message":"Done","commit_id":"fd1cbd5d0fa99d17f79076869ec08f18ae9c8b4e"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"31fd78904034ce8a4c0e7e49d36b340f63d432bf","unresolved":false,"context_lines":[{"line_number":125,"context_line":"                  \u0027volume_type\u0027: volume_types[0][\u0027id\u0027]}"},{"line_number":126,"context_line":"        # Create volume"},{"line_number":127,"context_line":"        volume \u003d self.volumes_client.create_volume(size\u003d1, **params)"},{"line_number":128,"context_line":"        self.assertIn(\u0027id\u0027, volume)"},{"line_number":129,"context_line":"        self.addCleanup(self._delete_volume, volume[\u0027id\u0027])"},{"line_number":130,"context_line":"        self.assertIn(self.name_field, volume)"},{"line_number":131,"context_line":"        self.assertEqual(volume_types[0][\u0027name\u0027], volume[\"volume_type\"])"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a930d6b_84f5f3cc","line":128,"updated":"2015-01-23 11:10:03.000000000","message":"This \"assert\" is already tested in test_volumes_get.py","commit_id":"fd1cbd5d0fa99d17f79076869ec08f18ae9c8b4e"},{"author":{"_account_id":2222,"name":"meenakshi-m","username":"meenakshi-m"},"change_message_id":"d0e3a446b5a0b8ee849198bc9a2891197306b936","unresolved":false,"context_lines":[{"line_number":125,"context_line":"                  \u0027volume_type\u0027: volume_types[0][\u0027id\u0027]}"},{"line_number":126,"context_line":"        # Create volume"},{"line_number":127,"context_line":"        volume \u003d self.volumes_client.create_volume(size\u003d1, **params)"},{"line_number":128,"context_line":"        self.assertIn(\u0027id\u0027, volume)"},{"line_number":129,"context_line":"        self.addCleanup(self._delete_volume, volume[\u0027id\u0027])"},{"line_number":130,"context_line":"        self.assertIn(self.name_field, volume)"},{"line_number":131,"context_line":"        self.assertEqual(volume_types[0][\u0027name\u0027], volume[\"volume_type\"])"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa81d914_5da5a6b3","line":128,"in_reply_to":"1a930d6b_84f5f3cc","updated":"2015-01-29 10:05:16.000000000","message":"Done","commit_id":"fd1cbd5d0fa99d17f79076869ec08f18ae9c8b4e"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"31fd78904034ce8a4c0e7e49d36b340f63d432bf","unresolved":false,"context_lines":[{"line_number":127,"context_line":"        volume \u003d self.volumes_client.create_volume(size\u003d1, **params)"},{"line_number":128,"context_line":"        self.assertIn(\u0027id\u0027, volume)"},{"line_number":129,"context_line":"        self.addCleanup(self._delete_volume, volume[\u0027id\u0027])"},{"line_number":130,"context_line":"        self.assertIn(self.name_field, volume)"},{"line_number":131,"context_line":"        self.assertEqual(volume_types[0][\u0027name\u0027], volume[\"volume_type\"])"},{"line_number":132,"context_line":"        self.assertEqual(volume[self.name_field], vol_name,"},{"line_number":133,"context_line":"                         \"The created volume name is not equal \""}],"source_content_type":"text/x-python","patch_set":3,"id":"1a930d6b_c4fffba8","line":130,"updated":"2015-01-23 11:10:03.000000000","message":"This \"assert\" is already tested in test_volumes_get.py","commit_id":"fd1cbd5d0fa99d17f79076869ec08f18ae9c8b4e"},{"author":{"_account_id":2222,"name":"meenakshi-m","username":"meenakshi-m"},"change_message_id":"d0e3a446b5a0b8ee849198bc9a2891197306b936","unresolved":false,"context_lines":[{"line_number":127,"context_line":"        volume \u003d self.volumes_client.create_volume(size\u003d1, **params)"},{"line_number":128,"context_line":"        self.assertIn(\u0027id\u0027, volume)"},{"line_number":129,"context_line":"        self.addCleanup(self._delete_volume, volume[\u0027id\u0027])"},{"line_number":130,"context_line":"        self.assertIn(self.name_field, volume)"},{"line_number":131,"context_line":"        self.assertEqual(volume_types[0][\u0027name\u0027], volume[\"volume_type\"])"},{"line_number":132,"context_line":"        self.assertEqual(volume[self.name_field], vol_name,"},{"line_number":133,"context_line":"                         \"The created volume name is not equal \""}],"source_content_type":"text/x-python","patch_set":3,"id":"fa81d914_7dac2aa1","line":130,"in_reply_to":"1a930d6b_c4fffba8","updated":"2015-01-29 10:05:16.000000000","message":"Done","commit_id":"fd1cbd5d0fa99d17f79076869ec08f18ae9c8b4e"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"31fd78904034ce8a4c0e7e49d36b340f63d432bf","unresolved":false,"context_lines":[{"line_number":132,"context_line":"        self.assertEqual(volume[self.name_field], vol_name,"},{"line_number":133,"context_line":"                         \"The created volume name is not equal \""},{"line_number":134,"context_line":"                         \"to the requested name\")"},{"line_number":135,"context_line":"        self.assertIsNotNone(volume[\u0027id\u0027],"},{"line_number":136,"context_line":"                             \"Field volume id is empty or not found.\")"},{"line_number":137,"context_line":"        self.volumes_client.wait_for_volume_status(volume[\u0027id\u0027], \u0027available\u0027)"},{"line_number":138,"context_line":"        # Update volume with new volume_type"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a930d6b_043103a2","line":135,"updated":"2015-01-23 11:10:03.000000000","message":"This \"assert\" is already tested in test_volumes_get.py","commit_id":"fd1cbd5d0fa99d17f79076869ec08f18ae9c8b4e"},{"author":{"_account_id":2222,"name":"meenakshi-m","username":"meenakshi-m"},"change_message_id":"d0e3a446b5a0b8ee849198bc9a2891197306b936","unresolved":false,"context_lines":[{"line_number":132,"context_line":"        self.assertEqual(volume[self.name_field], vol_name,"},{"line_number":133,"context_line":"                         \"The created volume name is not equal \""},{"line_number":134,"context_line":"                         \"to the requested name\")"},{"line_number":135,"context_line":"        self.assertIsNotNone(volume[\u0027id\u0027],"},{"line_number":136,"context_line":"                             \"Field volume id is empty or not found.\")"},{"line_number":137,"context_line":"        self.volumes_client.wait_for_volume_status(volume[\u0027id\u0027], \u0027available\u0027)"},{"line_number":138,"context_line":"        # Update volume with new volume_type"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa81d914_9daf1e94","line":135,"in_reply_to":"1a930d6b_043103a2","updated":"2015-01-29 10:05:16.000000000","message":"Done","commit_id":"fd1cbd5d0fa99d17f79076869ec08f18ae9c8b4e"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"62fe83e092a6adc75b04de1882daf10d78bda6cf","unresolved":false,"context_lines":[{"line_number":101,"context_line":"        self._create_reset_and_force_delete_temp_volume(\u0027error\u0027)"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":104,"context_line":"    def test_update_volume_type(self):"},{"line_number":105,"context_line":"        # Create/get/retype/delete volume with volume_type."},{"line_number":106,"context_line":"        volume_types \u003d list()"},{"line_number":107,"context_line":"        proto \u003d CONF.volume.storage_protocol"}],"source_content_type":"text/x-python","patch_set":4,"id":"da86d52c_9bf7f658","line":104,"updated":"2015-02-04 05:01:36.000000000","message":"This tests is duplicate of tempest.api.volume.admin.test_volume_types -\u003e test_create_get_delete_volume_with_volume_type_and_extra_specs","commit_id":"bfa45513c2c44191d784e0521bb964e67ab6d22f"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"019191ee603ef06c37c2e389ed09d8e14da88bf7","unresolved":false,"context_lines":[{"line_number":101,"context_line":"        self._create_reset_and_force_delete_temp_volume(\u0027error\u0027)"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":104,"context_line":"    def test_update_volume_type(self):"},{"line_number":105,"context_line":"        # Create/get/retype/delete volume with volume_type."},{"line_number":106,"context_line":"        volume_types \u003d list()"},{"line_number":107,"context_line":"        proto \u003d CONF.volume.storage_protocol"}],"source_content_type":"text/x-python","patch_set":4,"id":"da86d52c_fbb47283","line":104,"in_reply_to":"da86d52c_9bf7f658","updated":"2015-02-04 05:06:24.000000000","message":"sorry that is while creating volume not updating type.\n\nBut this tests should go in test_volume_types. and to avoid creating volume again, update type can be merged in test_create_get_delete_volume_with_volume_type_and_extra_specs","commit_id":"bfa45513c2c44191d784e0521bb964e67ab6d22f"},{"author":{"_account_id":2222,"name":"meenakshi-m","username":"meenakshi-m"},"change_message_id":"f9f8617540821e65aa64a37612f511f19488c463","unresolved":false,"context_lines":[{"line_number":101,"context_line":"        self._create_reset_and_force_delete_temp_volume(\u0027error\u0027)"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":104,"context_line":"    def test_update_volume_type(self):"},{"line_number":105,"context_line":"        # Create/get/retype/delete volume with volume_type."},{"line_number":106,"context_line":"        volume_types \u003d list()"},{"line_number":107,"context_line":"        proto \u003d CONF.volume.storage_protocol"}],"source_content_type":"text/x-python","patch_set":4,"id":"da86d52c_f6bd60b8","line":104,"in_reply_to":"da86d52c_fbb47283","updated":"2015-02-04 11:56:45.000000000","message":"Hi Ghanshyam,\n\nAs \"retype\" functionality is a part of volume action  and the call goes to \"volumes/\u003cvolume_id\u003e/action\", so added the testcase under this script.","commit_id":"bfa45513c2c44191d784e0521bb964e67ab6d22f"}]}