)]}'
{"tempest/api/compute/test_tenant_networks.py":[{"author":{"_account_id":5292,"name":"Christopher Yeoh","email":"cbkyeoh@gmail.com","username":"cyeoh-0"},"change_message_id":"8562a0ee50fbebdbcdfabdf2999ac297b6bb04bf","unresolved":false,"context_lines":[{"line_number":26,"context_line":"    @test.attr(type\u003d\u0027gate\u0027)"},{"line_number":27,"context_line":"    def test_list_tenant_networks(self):"},{"line_number":28,"context_line":"        tenant_networks \u003d self.client.list_tenant_networks()"},{"line_number":29,"context_line":"        self.assertNotEmpty(tenant_networks, \"No tenant networks found.\")"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa81d914_44b11f46","line":29,"updated":"2015-01-30 05:50:09.000000000","message":"can we do a more thorough check that the values returned are correct rather than just that are values?","commit_id":"dcafa321a50d9668959eb233ab43d68fb779e960"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"1cc76f46f1809bdfb14b2a47ebc9790d62d424f9","unresolved":false,"context_lines":[{"line_number":26,"context_line":"    @test.attr(type\u003d\u0027gate\u0027)"},{"line_number":27,"context_line":"    def test_list_tenant_networks(self):"},{"line_number":28,"context_line":"        tenant_networks \u003d self.client.list_tenant_networks()"},{"line_number":29,"context_line":"        self.assertNotEmpty(tenant_networks, \"No tenant networks found.\")"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa81d914_7775f7f8","line":29,"in_reply_to":"fa81d914_44b11f46","updated":"2015-01-30 06:48:37.000000000","message":"@Chris,\n\nThat seems difficult.\nThe response body likes\n\n $ curl -i \u0027http://192.168.11.62:8774/v2/fa8c16a7d07b4072a32b2caf658201ee/os-tenant-networks\u0027 -X GET -H \"Accept: application/json\" -H \"X-Auth-Project-Id: demo\" -H \"X-Auth-Token: 81d8cc456def44f3a925bedac37383a6\"\n HTTP/1.1 200 OK\n Content-Type: application/json\n Content-Length: 181\n X-Compute-Request-Id: req-9d8300a7-c9a1-4582-81cd-44b131b0cc64\n Date: Fri, 30 Jan 2015 06:44:37 GMT\n\n {\"networks\": [\n     {\"cidr\": \"None\", \"id\": \"1b64ee34-161c-4889-b8c4-7ebb235647e3\", \"label\": \"private\"},\n     {\"cidr\": \"None\", \"id\": \"b3aca3f0-2b4b-4687-9acc-66ad82397012\", \"label\": \"public\"}\n ]}\n\nand these values depend on each OpenStack environment.\nIf containing some specific values like tenant-id, we could check them.\nbut there are not any values like that.\n\nSo current patch is just checking the format of a response with the jsonschema.","commit_id":"dcafa321a50d9668959eb233ab43d68fb779e960"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"626f88b603fe5568fd7d8cc5b9ce56cd6a0a3ab1","unresolved":false,"context_lines":[{"line_number":26,"context_line":"    @test.attr(type\u003d\u0027gate\u0027)"},{"line_number":27,"context_line":"    def test_list_tenant_networks(self):"},{"line_number":28,"context_line":"        tenant_networks \u003d self.client.list_tenant_networks()"},{"line_number":29,"context_line":"        self.assertNotEmpty(tenant_networks, \"No tenant networks found.\")"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa81d914_774c17c9","line":29,"in_reply_to":"fa81d914_7775f7f8","updated":"2015-01-30 06:49:52.000000000","message":"or we can add a check by the combination of list and get APIs.\n\nI will try it.","commit_id":"dcafa321a50d9668959eb233ab43d68fb779e960"}],"tempest/services/compute/json/tenant_networks_client.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"b5ec099d8691f5c856bbfca403cd5123293f873a","unresolved":false,"context_lines":[{"line_number":24,"context_line":"        resp, body \u003d self.get(\"os-tenant-networks\")"},{"line_number":25,"context_line":"        body \u003d json.loads(body)"},{"line_number":26,"context_line":"        self.validate_response(schema.list_tenant_networks, resp, body)"},{"line_number":27,"context_line":"        return resp, body[\u0027networks\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a961159_80359f46","line":27,"updated":"2015-01-15 12:27:13.000000000","message":"I think it will be better to return ResponseBodyList here (for new service clients.)","commit_id":"f09c140de058b0fd2b013eed643b74a6325a2bb7"}]}