)]}'
{"tempest/clients.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"bf0d96a74d43d50c64411cf322359e51bd6c3bee","unresolved":false,"context_lines":[{"line_number":171,"context_line":"        self.object_client \u003d ObjectClient(self.auth_provider)"},{"line_number":172,"context_line":"        self.orchestration_client \u003d OrchestrationClient("},{"line_number":173,"context_line":"            self.auth_provider,"},{"line_number":174,"context_line":"            CONF.orchestration.catalog_type,"},{"line_number":175,"context_line":"            CONF.orchestration.region or CONF.identity.region,"},{"line_number":176,"context_line":"            endpoint_type\u003dCONF.orchestration.endpoint_type,"},{"line_number":177,"context_line":"            build_interval\u003dCONF.orchestration.build_interval,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_e7f70b58","line":174,"updated":"2015-01-19 03:38:13.000000000","message":"how about other param (\u0027disable_ssl_certificate_validation\u0027, \u0027trace_requests\u0027)?\n\nHow about having a common dict for service client having common param (self.auth_provider, \u0027disable_ssl_certificate_validation\u0027, \u0027trace_requests\u0027) and update others before specific client constructor.","commit_id":"bfdc00261eb088dcd859e2701e77ff6a52eb9578"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"00bf9220fddef68951fd905f80cc454e1b61fadc","unresolved":false,"context_lines":[{"line_number":171,"context_line":"        self.object_client \u003d ObjectClient(self.auth_provider)"},{"line_number":172,"context_line":"        self.orchestration_client \u003d OrchestrationClient("},{"line_number":173,"context_line":"            self.auth_provider,"},{"line_number":174,"context_line":"            CONF.orchestration.catalog_type,"},{"line_number":175,"context_line":"            CONF.orchestration.region or CONF.identity.region,"},{"line_number":176,"context_line":"            endpoint_type\u003dCONF.orchestration.endpoint_type,"},{"line_number":177,"context_line":"            build_interval\u003dCONF.orchestration.build_interval,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_ea727210","line":174,"in_reply_to":"3a961159_4a7c66eb","updated":"2015-01-19 04:49:55.000000000","message":"Oh, nice idea. I will try it soon.\n\nThanks for your suggestion !!","commit_id":"bfdc00261eb088dcd859e2701e77ff6a52eb9578"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"852e7afa57dbac34ba2dde579d39d77826f11cb5","unresolved":false,"context_lines":[{"line_number":171,"context_line":"        self.object_client \u003d ObjectClient(self.auth_provider)"},{"line_number":172,"context_line":"        self.orchestration_client \u003d OrchestrationClient("},{"line_number":173,"context_line":"            self.auth_provider,"},{"line_number":174,"context_line":"            CONF.orchestration.catalog_type,"},{"line_number":175,"context_line":"            CONF.orchestration.region or CONF.identity.region,"},{"line_number":176,"context_line":"            endpoint_type\u003dCONF.orchestration.endpoint_type,"},{"line_number":177,"context_line":"            build_interval\u003dCONF.orchestration.build_interval,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_4a7c66eb","line":174,"in_reply_to":"3a961159_ca0db636","updated":"2015-01-19 04:45:49.000000000","message":"yes, I agree but I am wondering that while changing for general values you need to make changes in client.py for each service client constructor again. \n\nI was thinking to do those also along with other specific values. and to avoid all client file change, how about just having those as default param in ServiceClient? so that just ServiceClient needs to be changed and later https://review.openstack.org/#/c/147163/  just need to remove all conf value from ServiceClient.\n\nBut am ok with your approach too :)","commit_id":"bfdc00261eb088dcd859e2701e77ff6a52eb9578"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"bbe6616da7ba416b274181e69a905e4e0cdc25cd","unresolved":false,"context_lines":[{"line_number":171,"context_line":"        self.object_client \u003d ObjectClient(self.auth_provider)"},{"line_number":172,"context_line":"        self.orchestration_client \u003d OrchestrationClient("},{"line_number":173,"context_line":"            self.auth_provider,"},{"line_number":174,"context_line":"            CONF.orchestration.catalog_type,"},{"line_number":175,"context_line":"            CONF.orchestration.region or CONF.identity.region,"},{"line_number":176,"context_line":"            endpoint_type\u003dCONF.orchestration.endpoint_type,"},{"line_number":177,"context_line":"            build_interval\u003dCONF.orchestration.build_interval,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_ca0db636","line":174,"in_reply_to":"3a961159_e7f70b58","updated":"2015-01-19 03:50:25.000000000","message":"@Ghanshyam\n\nThanks for your review, and that is a nice point.\n\nI tried to do that on https://review.openstack.org/#/c/147163/ , but it was difficult to do it on a single patch because the patch became very big.\nThe change of both disable_ssl_certificate_validation and trace_requests affects all client settings.\n\nIf we will do it as the first patch, the patch will be mix changes of passing service clients-specific values(catalog_type, region, endpint_type, ..) and general values(disable_ssl_certificate_validation). That will be super difficult to be reviewed.\nThen I have created this patch as a small step. after this kind of patch, maybe we can create a patch only for passing general values(disable_ssl_certificate_validation) from client settings as you said.","commit_id":"bfdc00261eb088dcd859e2701e77ff6a52eb9578"}],"tempest/common/service_client.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"c8b8bf39f2ca4248f6a199aa207271dfdd02eac9","unresolved":false,"context_lines":[{"line_number":26,"context_line":"                 trace_requests\u003dNone):"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"        params \u003d {}"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"        if disable_ssl_certificate_validation is not None:"},{"line_number":31,"context_line":"            params.update({\u0027disable_ssl_certificate_validation\u0027:"},{"line_number":32,"context_line":"                           CONF.identity.disable_ssl_certificate_validation})"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a961159_dbb4a637","line":29,"updated":"2015-01-19 08:15:59.000000000","message":"should not this be like below? conf value assignment can be removed later once client.py input their value for all service clients.\n\n\ndisable_ssl_certificate_validation \u003d disable_ssl_certificate_validation or CONF.identity.disable_ssl_certificate_validation\n\nif disable_ssl_certificate_validation is not None:\n    params.update({\u0027disable_ssl_certificate_validation\u0027:\n    disable_ssl_certificate_validation})","commit_id":"bb419d56b6fd08f659ab92ac9079468d131f6675"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"0d66944dfbb888525eeeed10388454750d9aafdb","unresolved":false,"context_lines":[{"line_number":26,"context_line":"                 trace_requests\u003dNone):"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"        params \u003d {}"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"        if disable_ssl_certificate_validation is not None:"},{"line_number":31,"context_line":"            params.update({\u0027disable_ssl_certificate_validation\u0027:"},{"line_number":32,"context_line":"                           CONF.identity.disable_ssl_certificate_validation})"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a961159_bbc43a41","line":29,"in_reply_to":"3a961159_dbb4a637","updated":"2015-01-19 08:41:07.000000000","message":"Nice catch, thanks.","commit_id":"bb419d56b6fd08f659ab92ac9079468d131f6675"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"fe45bf4881c3c372cc0cab8f3005ad8f9996a2f4","unresolved":false,"context_lines":[{"line_number":30,"context_line":"        # free from CONF values."},{"line_number":31,"context_line":"        dscv \u003d (disable_ssl_certificate_validation or"},{"line_number":32,"context_line":"                CONF.identity.disable_ssl_certificate_validation)"},{"line_number":33,"context_line":"        trace_requests \u003d trace_requests or CONF.identity.ca_certificates_file"},{"line_number":34,"context_line":"        params \u003d {"},{"line_number":35,"context_line":"            \u0027disable_ssl_certificate_validation\u0027: dscv,"},{"line_number":36,"context_line":"            \u0027ca_certs\u0027: ca_certs or CONF.identity.ca_certificates_file,"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a961159_b671afdf","line":33,"updated":"2015-01-19 09:44:30.000000000","message":"CONF.identity.ca_certificates_file -\u003e CONF.debug.trace_requests","commit_id":"e0f4185e26087d9a5423b80184e92ea867b814c3"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"5816bf3213066b6ee8b409b811a9531a3e5b6cb2","unresolved":false,"context_lines":[{"line_number":30,"context_line":"        # free from CONF values."},{"line_number":31,"context_line":"        dscv \u003d (disable_ssl_certificate_validation or"},{"line_number":32,"context_line":"                CONF.identity.disable_ssl_certificate_validation)"},{"line_number":33,"context_line":"        trace_requests \u003d trace_requests or CONF.identity.ca_certificates_file"},{"line_number":34,"context_line":"        params \u003d {"},{"line_number":35,"context_line":"            \u0027disable_ssl_certificate_validation\u0027: dscv,"},{"line_number":36,"context_line":"            \u0027ca_certs\u0027: ca_certs or CONF.identity.ca_certificates_file,"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a961159_b33c57c2","line":33,"in_reply_to":"3a961159_b671afdf","updated":"2015-01-19 13:50:11.000000000","message":"Oops, nice catch","commit_id":"e0f4185e26087d9a5423b80184e92ea867b814c3"}]}