)]}'
{"tempest/scenario/test_network_basic_ops.py":[{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"6341a646f46e95334bdd558f5abe586a758f1b79","unresolved":false,"context_lines":[{"line_number":488,"context_line":"                         \"Failed to update subnet\u0027s nameservers\")"},{"line_number":489,"context_line":""},{"line_number":490,"context_line":"        # server needs to renew its dhcp lease in order to get the new dns"},{"line_number":491,"context_line":"        # definitions from subnet"},{"line_number":492,"context_line":"        ssh_client.renew_lease(fixed_ip\u003dfloating_ip[\u0027fixed_ip_address\u0027])"},{"line_number":493,"context_line":""},{"line_number":494,"context_line":"        def check_new_dns_server():"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a961159_812c5e03","line":491,"updated":"2015-01-19 18:33:55.000000000","message":"I would add a delay of about 5 seconds here","commit_id":"769df49c14b8f2bbc3c93d7705c2e2eb9f0c5bcc"},{"author":{"_account_id":8576,"name":"Yair Fried","email":"yfried@redhat.com","username":"yfried"},"change_message_id":"21153d9d0206ffed7a51b9624895471479ef2a88","unresolved":false,"context_lines":[{"line_number":488,"context_line":"                         \"Failed to update subnet\u0027s nameservers\")"},{"line_number":489,"context_line":""},{"line_number":490,"context_line":"        # server needs to renew its dhcp lease in order to get the new dns"},{"line_number":491,"context_line":"        # definitions from subnet"},{"line_number":492,"context_line":"        ssh_client.renew_lease(fixed_ip\u003dfloating_ip[\u0027fixed_ip_address\u0027])"},{"line_number":493,"context_line":""},{"line_number":494,"context_line":"        def check_new_dns_server():"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a961159_87a2aeab","line":491,"in_reply_to":"3a961159_812c5e03","updated":"2015-01-19 19:34:14.000000000","message":"if we move the renewal into \"call_until_true\" we don\u0027t need to add a static wait.\nEven more so, since first try usually works","commit_id":"769df49c14b8f2bbc3c93d7705c2e2eb9f0c5bcc"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"6341a646f46e95334bdd558f5abe586a758f1b79","unresolved":false,"context_lines":[{"line_number":489,"context_line":""},{"line_number":490,"context_line":"        # server needs to renew its dhcp lease in order to get the new dns"},{"line_number":491,"context_line":"        # definitions from subnet"},{"line_number":492,"context_line":"        ssh_client.renew_lease(fixed_ip\u003dfloating_ip[\u0027fixed_ip_address\u0027])"},{"line_number":493,"context_line":""},{"line_number":494,"context_line":"        def check_new_dns_server():"},{"line_number":495,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a961159_41eb56a4","line":492,"updated":"2015-01-19 18:33:55.000000000","message":"if you renew the lease before neutron processes the dns server update you\u0027re always going to fail, no matter how many times you check the dns server (well if you have a timeout so long that the lease expires before the timeout then it will work)","commit_id":"769df49c14b8f2bbc3c93d7705c2e2eb9f0c5bcc"},{"author":{"_account_id":8576,"name":"Yair Fried","email":"yfried@redhat.com","username":"yfried"},"change_message_id":"21153d9d0206ffed7a51b9624895471479ef2a88","unresolved":false,"context_lines":[{"line_number":489,"context_line":""},{"line_number":490,"context_line":"        # server needs to renew its dhcp lease in order to get the new dns"},{"line_number":491,"context_line":"        # definitions from subnet"},{"line_number":492,"context_line":"        ssh_client.renew_lease(fixed_ip\u003dfloating_ip[\u0027fixed_ip_address\u0027])"},{"line_number":493,"context_line":""},{"line_number":494,"context_line":"        def check_new_dns_server():"},{"line_number":495,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a961159_47ea86d9","line":492,"in_reply_to":"3a961159_41eb56a4","updated":"2015-01-19 19:34:14.000000000","message":"You are right. I\u0027ve missed that. sorry","commit_id":"769df49c14b8f2bbc3c93d7705c2e2eb9f0c5bcc"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"6341a646f46e95334bdd558f5abe586a758f1b79","unresolved":false,"context_lines":[{"line_number":501,"context_line":""},{"line_number":502,"context_line":"        test.call_until_true(check_new_dns_server,"},{"line_number":503,"context_line":"                             renew_timeout,"},{"line_number":504,"context_line":"                             renew_delay)"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a961159_c10d8691","line":504,"updated":"2015-01-19 18:33:55.000000000","message":"perhaps in the procedure that you repeat until timeout you should both renew the lease and check the dns server (with a small delay between the two things - say 1 second - just to ensure the DHCP protocol completes)","commit_id":"769df49c14b8f2bbc3c93d7705c2e2eb9f0c5bcc"},{"author":{"_account_id":8576,"name":"Yair Fried","email":"yfried@redhat.com","username":"yfried"},"change_message_id":"21153d9d0206ffed7a51b9624895471479ef2a88","unresolved":false,"context_lines":[{"line_number":501,"context_line":""},{"line_number":502,"context_line":"        test.call_until_true(check_new_dns_server,"},{"line_number":503,"context_line":"                             renew_timeout,"},{"line_number":504,"context_line":"                             renew_delay)"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a961159_c7de763e","line":504,"in_reply_to":"3a961159_c10d8691","updated":"2015-01-19 19:34:14.000000000","message":"No need to wait between renew and validation.\nThe renewal method is synchronous so it returns only once the renewal is done.","commit_id":"769df49c14b8f2bbc3c93d7705c2e2eb9f0c5bcc"},{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"327361cb9b20f9361d6530f0f006323319d03c05","unresolved":false,"context_lines":[{"line_number":489,"context_line":""},{"line_number":490,"context_line":"        def check_new_dns_server():"},{"line_number":491,"context_line":"            # server needs to renew its dhcp lease in order to get the new dns"},{"line_number":492,"context_line":"            # definitions from subnet"},{"line_number":493,"context_line":"            ssh_client.renew_lease(fixed_ip\u003dfloating_ip[\u0027fixed_ip_address\u0027])"},{"line_number":494,"context_line":"            try:"},{"line_number":495,"context_line":"                self._check_dns_server(ssh_client, [alt_dns_server])"}],"source_content_type":"text/x-python","patch_set":7,"id":"1a930d6b_ae3b1737","line":492,"updated":"2015-01-20 20:30:29.000000000","message":"I would probably add a comment explaining why the lease renewal is in the retry loop (Since updating dnsmasq is done asynchronously after the subnet update API call returns).","commit_id":"39858efaa9b45069f968cff76494daa2a5f34197"}]}