)]}'
{"tempest/api/compute/admin/test_baremetal_nodes.py":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"07f3f197963f60c14356b06b600b9f52bb4592f4","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    def resource_setup(cls):"},{"line_number":26,"context_line":"        super(BaremetalNodesAdminTestJSON, cls).resource_setup()"},{"line_number":27,"context_line":"        cls.client \u003d cls.os_adm.baremetal_nodes_client"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    def setUp(self):"},{"line_number":30,"context_line":"        super(BaremetalNodesAdminTestJSON, self).setUp()"},{"line_number":31,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1a930d6b_ed3865a2","line":28,"updated":"2015-01-23 04:50:51.000000000","message":"The following skip is necessary.\n\n        if not CONF.service_available.ironic:\n            skip_msg \u003d (\u0027%s skipped as Ironic is not available\u0027 % cls.__name__)\n            raise cls.skipException(skip_msg)","commit_id":"c7182275019b9bf29e21a842f0b896348fc3e305"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"07f3f197963f60c14356b06b600b9f52bb4592f4","unresolved":false,"context_lines":[{"line_number":27,"context_line":"        cls.client \u003d cls.os_adm.baremetal_nodes_client"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    def setUp(self):"},{"line_number":30,"context_line":"        super(BaremetalNodesAdminTestJSON, self).setUp()"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    @test.attr(type\u003d\u0027gate\u0027)"},{"line_number":33,"context_line":"    def test_list_baremetal_nodes(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a930d6b_6dc5558d","line":30,"updated":"2015-01-23 04:50:51.000000000","message":"This setUp(line 29-30) is not necessary because just calling super(BaremetalNodesAdminTestJSON, self).setUp().","commit_id":"c7182275019b9bf29e21a842f0b896348fc3e305"},{"author":{"_account_id":5292,"name":"Christopher Yeoh","email":"cbkyeoh@gmail.com","username":"cyeoh-0"},"change_message_id":"3f7ec62c34fbf8507bbd0570df6d6c2bf0321e51","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    def test_list_baremetal_nodes(self):"},{"line_number":37,"context_line":"        # List all baremetal nodes."},{"line_number":38,"context_line":"        baremetal_nodes \u003d self.client.list_baremetal_nodes()"},{"line_number":39,"context_line":"        self.assertNotEmpty(baremetal_nodes, \"No baremetal nodes found.\")"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa81d914_2410aba7","line":39,"updated":"2015-01-30 06:08:31.000000000","message":"Can we check that the values returned are correct as well?","commit_id":"ab95c9ffb1b368bb22da9c1bc04054af610f5136"},{"author":{"_account_id":7882,"name":"Yuiko Takada Mori","email":"yuiko-mori@nec.com","username":"YuikoTakada"},"change_message_id":"4e8b98de4e9440ad83962036b4e9dc6d47270df7","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    def test_list_baremetal_nodes(self):"},{"line_number":37,"context_line":"        # List all baremetal nodes."},{"line_number":38,"context_line":"        baremetal_nodes \u003d self.client.list_baremetal_nodes()"},{"line_number":39,"context_line":"        self.assertNotEmpty(baremetal_nodes, \"No baremetal nodes found.\")"}],"source_content_type":"text/x-python","patch_set":3,"id":"da86d52c_4e2efea6","line":39,"in_reply_to":"da86d52c_99a9277e","updated":"2015-02-09 08:48:08.000000000","message":"Done","commit_id":"ab95c9ffb1b368bb22da9c1bc04054af610f5136"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"573857e1098b3bcdfd34b0d73eeb8a416ae51908","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    def test_list_baremetal_nodes(self):"},{"line_number":37,"context_line":"        # List all baremetal nodes."},{"line_number":38,"context_line":"        baremetal_nodes \u003d self.client.list_baremetal_nodes()"},{"line_number":39,"context_line":"        self.assertNotEmpty(baremetal_nodes, \"No baremetal nodes found.\")"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa81d914_b515a7e6","line":39,"in_reply_to":"fa81d914_2410aba7","updated":"2015-01-30 08:04:48.000000000","message":"This might depend on https://review.openstack.org/#/c/146761/","commit_id":"ab95c9ffb1b368bb22da9c1bc04054af610f5136"},{"author":{"_account_id":5292,"name":"Christopher Yeoh","email":"cbkyeoh@gmail.com","username":"cyeoh-0"},"change_message_id":"39b0e80bd736d69de2e8f80cd985ec65199740a7","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    def test_list_baremetal_nodes(self):"},{"line_number":37,"context_line":"        # List all baremetal nodes."},{"line_number":38,"context_line":"        baremetal_nodes \u003d self.client.list_baremetal_nodes()"},{"line_number":39,"context_line":"        self.assertNotEmpty(baremetal_nodes, \"No baremetal nodes found.\")"}],"source_content_type":"text/x-python","patch_set":3,"id":"da86d52c_99a9277e","line":39,"in_reply_to":"fa81d914_b515a7e6","updated":"2015-02-09 05:02:15.000000000","message":"I have +2 and +A 146761 and would happy if you do the same sort of thing here","commit_id":"ab95c9ffb1b368bb22da9c1bc04054af610f5136"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"541edccddfa5f432c1e425c1aa706706bd5a6eb1","unresolved":false,"context_lines":[{"line_number":32,"context_line":"            raise cls.skipException(skip_msg)"},{"line_number":33,"context_line":"        cls.client \u003d cls.os_adm.baremetal_nodes_client"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    @test.attr(type\u003d\u0027gate\u0027)"},{"line_number":36,"context_line":"    def test_list_baremetal_nodes(self):"},{"line_number":37,"context_line":"        # List all baremetal nodes."},{"line_number":38,"context_line":"        baremetal_nodes \u003d self.client.list_baremetal_nodes()"}],"source_content_type":"text/x-python","patch_set":6,"id":"da86d52c_20b74a22","line":35,"updated":"2015-02-13 02:47:21.000000000","message":"because of https://github.com/openstack-infra/project-config/blob/master/jenkins/jobs/devstack-gate.yaml#L686 , we need to change this type to \u0027smoke\u0027 for running this test on the gate.","commit_id":"94064f15150e7193b5faa9358dc8c40abc16f68b"},{"author":{"_account_id":7882,"name":"Yuiko Takada Mori","email":"yuiko-mori@nec.com","username":"YuikoTakada"},"change_message_id":"d6b6553162d530845967ec052e0b159bc8f88386","unresolved":false,"context_lines":[{"line_number":32,"context_line":"            raise cls.skipException(skip_msg)"},{"line_number":33,"context_line":"        cls.client \u003d cls.os_adm.baremetal_nodes_client"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    @test.attr(type\u003d\u0027gate\u0027)"},{"line_number":36,"context_line":"    def test_list_baremetal_nodes(self):"},{"line_number":37,"context_line":"        # List all baremetal nodes."},{"line_number":38,"context_line":"        baremetal_nodes \u003d self.client.list_baremetal_nodes()"}],"source_content_type":"text/x-python","patch_set":6,"id":"da86d52c_c0faeebb","line":35,"in_reply_to":"da86d52c_20b74a22","updated":"2015-02-13 02:51:52.000000000","message":"Done","commit_id":"94064f15150e7193b5faa9358dc8c40abc16f68b"}],"tempest/api/compute/base.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"ee9cdb133629c9096b674bfff62dec77995ff2f6","unresolved":false,"context_lines":[{"line_number":87,"context_line":"            cls.migrations_client \u003d cls.os.migrations_client"},{"line_number":88,"context_line":"            cls.security_group_default_rules_client \u003d ("},{"line_number":89,"context_line":"                cls.os.security_group_default_rules_client)"},{"line_number":90,"context_line":"            cls.baremetal_nodes_client \u003d cls.os.baremetal_nodes_client"},{"line_number":91,"context_line":"        else:"},{"line_number":92,"context_line":"            msg \u003d (\"Unexpected API version is specified (%s)\" %"},{"line_number":93,"context_line":"                   cls._api_version)"}],"source_content_type":"text/x-python","patch_set":7,"id":"da86d52c_779d8909","line":90,"updated":"2015-02-13 04:30:11.000000000","message":"This variable is not used as tests get it from admin client manger directly. I think we can remove this from here","commit_id":"e1c36217e6a43b3bd768a04beb14ae78cc079c5f"},{"author":{"_account_id":7882,"name":"Yuiko Takada Mori","email":"yuiko-mori@nec.com","username":"YuikoTakada"},"change_message_id":"03c3f0a7ae36c02ecadcbd9367c8a6e9341b28e5","unresolved":false,"context_lines":[{"line_number":87,"context_line":"            cls.migrations_client \u003d cls.os.migrations_client"},{"line_number":88,"context_line":"            cls.security_group_default_rules_client \u003d ("},{"line_number":89,"context_line":"                cls.os.security_group_default_rules_client)"},{"line_number":90,"context_line":"            cls.baremetal_nodes_client \u003d cls.os.baremetal_nodes_client"},{"line_number":91,"context_line":"        else:"},{"line_number":92,"context_line":"            msg \u003d (\"Unexpected API version is specified (%s)\" %"},{"line_number":93,"context_line":"                   cls._api_version)"}],"source_content_type":"text/x-python","patch_set":7,"id":"da86d52c_77102959","line":90,"in_reply_to":"da86d52c_779d8909","updated":"2015-02-13 04:33:48.000000000","message":"You\u0027re right! It\u0027s my mistake.","commit_id":"e1c36217e6a43b3bd768a04beb14ae78cc079c5f"}],"tempest/api_schema/response/compute/baremetal_nodes.py":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"928dc1fa223468e8e9387a7f26b9e6a6acaff46c","unresolved":false,"context_lines":[{"line_number":56,"context_line":"                    \u0027disk_gb\u0027: {\u0027type\u0027: \u0027integer\u0027},"},{"line_number":57,"context_line":"                },"},{"line_number":58,"context_line":"                \u0027required\u0027: [\u0027id\u0027, \u0027interfaces\u0027, \u0027host\u0027, \u0027task_state\u0027,"},{"line_number":59,"context_line":"                             \u0027cpus\u0027, \u0027memory_mb\u0027, \u0027disk_gb\u0027]"},{"line_number":60,"context_line":"            }"},{"line_number":61,"context_line":"        },"},{"line_number":62,"context_line":"        \u0027required\u0027: [\u0027node\u0027]"}],"source_content_type":"text/x-python","patch_set":4,"id":"da86d52c_b19fdfb3","line":59,"updated":"2015-02-09 08:52:03.000000000","message":"line 48-59 is the same as line 23-34.\nSo how about defining\n\n node \u003d {\n  \u0027type\u0027: \u0027object\u0027,\n  \u0027properties\u0027: {\n       [..]\n   },\n   \u0027required\u0027: [\u0027id\u0027, \u0027interfaces\u0027, \u0027host\u0027, \u0027task_state\u0027,\n                \u0027cpus\u0027, \u0027memory_mb\u0027, \u0027disk_gb\u0027]\n }\n\nand reusing it in list_baremetal_nodes and get_baremetal_node ?","commit_id":"e8d32b5a8129f8ade3b4f8a3681daf0402ee6eea"},{"author":{"_account_id":7882,"name":"Yuiko Takada Mori","email":"yuiko-mori@nec.com","username":"YuikoTakada"},"change_message_id":"a352fc507eb32a9778fd631d523b7a5f212c970e","unresolved":false,"context_lines":[{"line_number":56,"context_line":"                    \u0027disk_gb\u0027: {\u0027type\u0027: \u0027integer\u0027},"},{"line_number":57,"context_line":"                },"},{"line_number":58,"context_line":"                \u0027required\u0027: [\u0027id\u0027, \u0027interfaces\u0027, \u0027host\u0027, \u0027task_state\u0027,"},{"line_number":59,"context_line":"                             \u0027cpus\u0027, \u0027memory_mb\u0027, \u0027disk_gb\u0027]"},{"line_number":60,"context_line":"            }"},{"line_number":61,"context_line":"        },"},{"line_number":62,"context_line":"        \u0027required\u0027: [\u0027node\u0027]"}],"source_content_type":"text/x-python","patch_set":4,"id":"da86d52c_b1ed1f28","line":59,"in_reply_to":"da86d52c_b19fdfb3","updated":"2015-02-09 09:00:05.000000000","message":"Done","commit_id":"e8d32b5a8129f8ade3b4f8a3681daf0402ee6eea"},{"author":{"_account_id":5292,"name":"Christopher Yeoh","email":"cbkyeoh@gmail.com","username":"cyeoh-0"},"change_message_id":"4593ed87e86914c690242ae9218878481392dab7","unresolved":false,"context_lines":[{"line_number":21,"context_line":"        \u0027task_state\u0027: {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027]},"},{"line_number":22,"context_line":"        \u0027cpus\u0027: {\u0027type\u0027: \u0027integer\u0027},"},{"line_number":23,"context_line":"        \u0027memory_mb\u0027: {\u0027type\u0027: \u0027integer\u0027},"},{"line_number":24,"context_line":"        \u0027disk_gb\u0027: {\u0027type\u0027: \u0027integer\u0027},"},{"line_number":25,"context_line":"    },"},{"line_number":26,"context_line":"    \u0027required\u0027: [\u0027id\u0027, \u0027interfaces\u0027, \u0027host\u0027, \u0027task_state\u0027, \u0027cpus\u0027, \u0027memory_mb\u0027,"},{"line_number":27,"context_line":"                 \u0027disk_gb\u0027]"}],"source_content_type":"text/x-python","patch_set":5,"id":"da86d52c_3e370ab2","line":24,"updated":"2015-02-10 03:37:41.000000000","message":"Looking at the v2 and v2.1 baremetal code it should also have instance_uuid as a field as well when the node is displayed via show (but not list). The API samples are looking a bit wrong I think because it looks like they were handwritten - there is not api sample tests AFAICT. \n\nSo I think this needs to get updated - but I\u0027ll fix the api samples on the Nova side in the meantime.","commit_id":"7e0954fdca29677005f76c137bd5a8d4228b6536"}]}