)]}'
{"tempest/api/network/admin/test_floating_ips_admin_actions.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"42ebc39175b4968f55e1e2aa2a761a82c7704a00","unresolved":false,"context_lines":[{"line_number":29,"context_line":"    @classmethod"},{"line_number":30,"context_line":"    def setup_clients(cls):"},{"line_number":31,"context_line":"        super(FloatingIPAdminTestJSON, cls).setup_clients()"},{"line_number":32,"context_line":"        cls.alt_manager \u003d clients.Manager(cls.isolated_creds.get_alt_creds())"},{"line_number":33,"context_line":"        cls.alt_client \u003d cls.alt_manager.network_client"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":7,"id":"1a6ced46_225a77f3","line":32,"updated":"2015-03-25 00:49:37.000000000","message":"this should go in setup credential method","commit_id":"3bd2f6adc208481beba4645649ddb8f5f49ea446"},{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"0c5557ff4bc1431f08763a65eddcbe80c01a831f","unresolved":false,"context_lines":[{"line_number":29,"context_line":"    @classmethod"},{"line_number":30,"context_line":"    def setup_clients(cls):"},{"line_number":31,"context_line":"        super(FloatingIPAdminTestJSON, cls).setup_clients()"},{"line_number":32,"context_line":"        cls.alt_manager \u003d clients.Manager(cls.isolated_creds.get_alt_creds())"},{"line_number":33,"context_line":"        cls.alt_client \u003d cls.alt_manager.network_client"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa963961_31551a1d","line":32,"in_reply_to":"1a6ced46_225a77f3","updated":"2015-03-26 15:28:51.000000000","message":"Done","commit_id":"3bd2f6adc208481beba4645649ddb8f5f49ea446"},{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"d645dda35c8125a70749a54854589d65a3045478","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        cls.ext_net_id \u003d CONF.network.public_network_id"},{"line_number":39,"context_line":"        cls.floating_ip \u003d cls.create_floatingip(cls.ext_net_id)"},{"line_number":40,"context_line":"        cls.alt_manager \u003d clients.Manager(cls.isolated_creds.get_alt_creds())"},{"line_number":41,"context_line":"        cls.alt_client \u003d cls.alt_manager.network_client"},{"line_number":42,"context_line":"        cls.network \u003d cls.create_network()"},{"line_number":43,"context_line":"        cls.subnet \u003d cls.create_subnet(cls.network)"},{"line_number":44,"context_line":"        cls.router \u003d cls.create_router(data_utils.rand_name(\u0027router-\u0027),"}],"source_content_type":"text/x-python","patch_set":7,"id":"1a6ced46_36971092","line":41,"updated":"2015-03-25 05:39:16.000000000","message":"Ditto L40","commit_id":"3bd2f6adc208481beba4645649ddb8f5f49ea446"},{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"0c5557ff4bc1431f08763a65eddcbe80c01a831f","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        cls.ext_net_id \u003d CONF.network.public_network_id"},{"line_number":39,"context_line":"        cls.floating_ip \u003d cls.create_floatingip(cls.ext_net_id)"},{"line_number":40,"context_line":"        cls.alt_manager \u003d clients.Manager(cls.isolated_creds.get_alt_creds())"},{"line_number":41,"context_line":"        cls.alt_client \u003d cls.alt_manager.network_client"},{"line_number":42,"context_line":"        cls.network \u003d cls.create_network()"},{"line_number":43,"context_line":"        cls.subnet \u003d cls.create_subnet(cls.network)"},{"line_number":44,"context_line":"        cls.router \u003d cls.create_router(data_utils.rand_name(\u0027router-\u0027),"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa963961_1131f60b","line":41,"in_reply_to":"1a6ced46_36971092","updated":"2015-03-26 15:28:51.000000000","message":"Done","commit_id":"3bd2f6adc208481beba4645649ddb8f5f49ea446"}],"tempest/api/network/admin/test_l3_agent_scheduler.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"f1c5224c7d097ad68d2aa9122989be295e8e8db9","unresolved":false,"context_lines":[{"line_number":39,"context_line":"            raise cls.skipException(msg)"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    @classmethod"},{"line_number":42,"context_line":"    def setup_clients(cls):"},{"line_number":43,"context_line":"        super(L3AgentSchedulerTestJSON, cls).setup_clients()"},{"line_number":44,"context_line":"        body \u003d cls.admin_client.list_agents()"},{"line_number":45,"context_line":"        agents \u003d body[\u0027agents\u0027]"}],"source_content_type":"text/x-python","patch_set":5,"id":"da86d52c_aa750b33","line":42,"updated":"2015-02-05 10:48:56.000000000","message":"this should be resource_setup","commit_id":"506bfd862c5a79bfb2afbbbc1b514964fcb8032d"},{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"d645dda35c8125a70749a54854589d65a3045478","unresolved":false,"context_lines":[{"line_number":50,"context_line":"                break"},{"line_number":51,"context_line":"        else:"},{"line_number":52,"context_line":"            msg \u003d \"L3 Agent not found\""},{"line_number":53,"context_line":"            raise cls.skipException(msg)"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":56,"context_line":"    @test.idempotent_id(\u0027b7ce6e89-e837-4ded-9b78-9ed3c9c6a45a\u0027)"}],"source_content_type":"text/x-python","patch_set":7,"id":"1a6ced46_f67d786f","line":53,"updated":"2015-03-25 05:39:16.000000000","message":"This sounds more like an error (InvalidConfiguration?) than a skip. One should not enable L3 agent scheduler testing if the is not agent. And if one was expected to exists, this skip does not really show the failure. \nTo be fixed in a different patch?","commit_id":"3bd2f6adc208481beba4645649ddb8f5f49ea446"},{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"0c5557ff4bc1431f08763a65eddcbe80c01a831f","unresolved":false,"context_lines":[{"line_number":50,"context_line":"                break"},{"line_number":51,"context_line":"        else:"},{"line_number":52,"context_line":"            msg \u003d \"L3 Agent not found\""},{"line_number":53,"context_line":"            raise cls.skipException(msg)"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":56,"context_line":"    @test.idempotent_id(\u0027b7ce6e89-e837-4ded-9b78-9ed3c9c6a45a\u0027)"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa963961_9c263d15","line":53,"in_reply_to":"1a6ced46_f67d786f","updated":"2015-03-26 15:28:51.000000000","message":"Done","commit_id":"3bd2f6adc208481beba4645649ddb8f5f49ea446"}],"tempest/api/network/admin/test_load_balancer_admin_actions.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"f1c5224c7d097ad68d2aa9122989be295e8e8db9","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    @classmethod"},{"line_number":37,"context_line":"    def setup_clients(cls):"},{"line_number":38,"context_line":"        super(LoadBalancerAdminTestJSON, cls).setup_clients()"},{"line_number":39,"context_line":"        manager \u003d cls.get_client_manager()"},{"line_number":40,"context_line":"        cls.client \u003d manager.network_client"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":5,"id":"da86d52c_8aa12796","line":39,"updated":"2015-02-05 10:48:56.000000000","message":"credential and client manager should be in setup_credentials","commit_id":"506bfd862c5a79bfb2afbbbc1b514964fcb8032d"},{"author":{"_account_id":6124,"name":"Rohan Kanade","email":"openstack@rohankanade.com","username":"kanaderohan"},"change_message_id":"c98065a403b6e5f59de04fb43dd0fb1f9268fc24","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    @classmethod"},{"line_number":37,"context_line":"    def setup_clients(cls):"},{"line_number":38,"context_line":"        super(LoadBalancerAdminTestJSON, cls).setup_clients()"},{"line_number":39,"context_line":"        manager \u003d cls.get_client_manager()"},{"line_number":40,"context_line":"        cls.client \u003d manager.network_client"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":5,"id":"da86d52c_ffc923ad","line":39,"in_reply_to":"da86d52c_8aa12796","updated":"2015-02-09 08:25:58.000000000","message":"Done","commit_id":"506bfd862c5a79bfb2afbbbc1b514964fcb8032d"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"f1c5224c7d097ad68d2aa9122989be295e8e8db9","unresolved":false,"context_lines":[{"line_number":43,"context_line":"    def resource_setup(cls):"},{"line_number":44,"context_line":"        super(LoadBalancerAdminTestJSON, cls).resource_setup()"},{"line_number":45,"context_line":"        cls.force_tenant_isolation \u003d True"},{"line_number":46,"context_line":"        cls.tenant_id \u003d cls.isolated_creds.get_primary_creds().tenant_id"},{"line_number":47,"context_line":"        cls.network \u003d cls.create_network()"},{"line_number":48,"context_line":"        cls.subnet \u003d cls.create_subnet(cls.network)"},{"line_number":49,"context_line":"        cls.pool \u003d cls.create_pool(data_utils.rand_name(\u0027pool-\u0027),"}],"source_content_type":"text/x-python","patch_set":5,"id":"da86d52c_ea15439c","line":46,"updated":"2015-02-05 10:48:56.000000000","message":"cred get should be in setup_credentials and then here you can get tenant id from that.","commit_id":"506bfd862c5a79bfb2afbbbc1b514964fcb8032d"},{"author":{"_account_id":6124,"name":"Rohan Kanade","email":"openstack@rohankanade.com","username":"kanaderohan"},"change_message_id":"c98065a403b6e5f59de04fb43dd0fb1f9268fc24","unresolved":false,"context_lines":[{"line_number":43,"context_line":"    def resource_setup(cls):"},{"line_number":44,"context_line":"        super(LoadBalancerAdminTestJSON, cls).resource_setup()"},{"line_number":45,"context_line":"        cls.force_tenant_isolation \u003d True"},{"line_number":46,"context_line":"        cls.tenant_id \u003d cls.isolated_creds.get_primary_creds().tenant_id"},{"line_number":47,"context_line":"        cls.network \u003d cls.create_network()"},{"line_number":48,"context_line":"        cls.subnet \u003d cls.create_subnet(cls.network)"},{"line_number":49,"context_line":"        cls.pool \u003d cls.create_pool(data_utils.rand_name(\u0027pool-\u0027),"}],"source_content_type":"text/x-python","patch_set":5,"id":"da86d52c_1fcfd7b1","line":46,"in_reply_to":"da86d52c_ea15439c","updated":"2015-02-09 08:25:58.000000000","message":"Done","commit_id":"506bfd862c5a79bfb2afbbbc1b514964fcb8032d"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"42ebc39175b4968f55e1e2aa2a761a82c7704a00","unresolved":false,"context_lines":[{"line_number":44,"context_line":"    def setup_clients(cls):"},{"line_number":45,"context_line":"        super(LoadBalancerAdminTestJSON, cls).setup_clients()"},{"line_number":46,"context_line":"        manager \u003d cls.get_client_manager()"},{"line_number":47,"context_line":"        cls.client \u003d manager.network_client"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    @classmethod"},{"line_number":50,"context_line":"    def resource_setup(cls):"}],"source_content_type":"text/x-python","patch_set":7,"id":"1a6ced46_a26d879a","line":47,"updated":"2015-03-25 00:49:37.000000000","message":"here cls.manager needs to be used instead of getting again.","commit_id":"3bd2f6adc208481beba4645649ddb8f5f49ea446"},{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"0c5557ff4bc1431f08763a65eddcbe80c01a831f","unresolved":false,"context_lines":[{"line_number":44,"context_line":"    def setup_clients(cls):"},{"line_number":45,"context_line":"        super(LoadBalancerAdminTestJSON, cls).setup_clients()"},{"line_number":46,"context_line":"        manager \u003d cls.get_client_manager()"},{"line_number":47,"context_line":"        cls.client \u003d manager.network_client"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    @classmethod"},{"line_number":50,"context_line":"    def resource_setup(cls):"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa963961_dcf28506","line":47,"in_reply_to":"1a6ced46_a26d879a","updated":"2015-03-26 15:28:51.000000000","message":"Done","commit_id":"3bd2f6adc208481beba4645649ddb8f5f49ea446"},{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"d645dda35c8125a70749a54854589d65a3045478","unresolved":false,"context_lines":[{"line_number":50,"context_line":"    def resource_setup(cls):"},{"line_number":51,"context_line":"        super(LoadBalancerAdminTestJSON, cls).resource_setup()"},{"line_number":52,"context_line":"        cls.force_tenant_isolation \u003d True"},{"line_number":53,"context_line":"        cls.tenant_id \u003d cls.primary_creds.tenant_id"},{"line_number":54,"context_line":"        cls.network \u003d cls.create_network()"},{"line_number":55,"context_line":"        cls.subnet \u003d cls.create_subnet(cls.network)"},{"line_number":56,"context_line":"        cls.pool \u003d cls.create_pool(data_utils.rand_name(\u0027pool-\u0027),"}],"source_content_type":"text/x-python","patch_set":7,"id":"1a6ced46_5692cc9f","line":53,"updated":"2015-03-25 05:39:16.000000000","message":"You can get tenant_id from any client. e.g.\n\ncls.tenant_id \u003d cls.client.tenant_id","commit_id":"3bd2f6adc208481beba4645649ddb8f5f49ea446"}],"tempest/api/network/base.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"f1c5224c7d097ad68d2aa9122989be295e8e8db9","unresolved":false,"context_lines":[{"line_number":67,"context_line":"    def setup_credentials(cls):"},{"line_number":68,"context_line":"        super(BaseNetworkTest, cls).setup_credentials()"},{"line_number":69,"context_line":"        cls.os \u003d cls.get_client_manager()"},{"line_number":70,"context_line":"        cls.network_cfg \u003d CONF.network"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    @classmethod"},{"line_number":73,"context_line":"    def setup_clients(cls):"}],"source_content_type":"text/x-python","patch_set":5,"id":"da86d52c_2a5afb82","line":70,"updated":"2015-02-05 10:48:56.000000000","message":"this should be in resource_setup","commit_id":"506bfd862c5a79bfb2afbbbc1b514964fcb8032d"},{"author":{"_account_id":6124,"name":"Rohan Kanade","email":"openstack@rohankanade.com","username":"kanaderohan"},"change_message_id":"c98065a403b6e5f59de04fb43dd0fb1f9268fc24","unresolved":false,"context_lines":[{"line_number":67,"context_line":"    def setup_credentials(cls):"},{"line_number":68,"context_line":"        super(BaseNetworkTest, cls).setup_credentials()"},{"line_number":69,"context_line":"        cls.os \u003d cls.get_client_manager()"},{"line_number":70,"context_line":"        cls.network_cfg \u003d CONF.network"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    @classmethod"},{"line_number":73,"context_line":"    def setup_clients(cls):"}],"source_content_type":"text/x-python","patch_set":5,"id":"da86d52c_dabe2dd4","line":70,"in_reply_to":"da86d52c_2a5afb82","updated":"2015-02-09 08:25:58.000000000","message":"Done","commit_id":"506bfd862c5a79bfb2afbbbc1b514964fcb8032d"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"f1c5224c7d097ad68d2aa9122989be295e8e8db9","unresolved":false,"context_lines":[{"line_number":73,"context_line":"    def setup_clients(cls):"},{"line_number":74,"context_line":"        super(BaseNetworkTest, cls).setup_clients()"},{"line_number":75,"context_line":"        cls.client \u003d cls.os.network_client"},{"line_number":76,"context_line":"        cls.network_cfg \u003d CONF.network"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    @classmethod"},{"line_number":79,"context_line":"    def resource_setup(cls):"}],"source_content_type":"text/x-python","patch_set":5,"id":"da86d52c_6a579358","line":76,"updated":"2015-02-05 10:48:56.000000000","message":"duplicate entry","commit_id":"506bfd862c5a79bfb2afbbbc1b514964fcb8032d"},{"author":{"_account_id":6124,"name":"Rohan Kanade","email":"openstack@rohankanade.com","username":"kanaderohan"},"change_message_id":"c98065a403b6e5f59de04fb43dd0fb1f9268fc24","unresolved":false,"context_lines":[{"line_number":73,"context_line":"    def setup_clients(cls):"},{"line_number":74,"context_line":"        super(BaseNetworkTest, cls).setup_clients()"},{"line_number":75,"context_line":"        cls.client \u003d cls.os.network_client"},{"line_number":76,"context_line":"        cls.network_cfg \u003d CONF.network"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    @classmethod"},{"line_number":79,"context_line":"    def resource_setup(cls):"}],"source_content_type":"text/x-python","patch_set":5,"id":"da86d52c_bab979ee","line":76,"in_reply_to":"da86d52c_6a579358","updated":"2015-02-09 08:25:58.000000000","message":"Done","commit_id":"506bfd862c5a79bfb2afbbbc1b514964fcb8032d"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"f1c5224c7d097ad68d2aa9122989be295e8e8db9","unresolved":false,"context_lines":[{"line_number":436,"context_line":"        except NotImplementedError:"},{"line_number":437,"context_line":"            msg \u003d (\"Missing Administrative Network API credentials \""},{"line_number":438,"context_line":"                   \"in configuration.\")"},{"line_number":439,"context_line":"            raise cls.skipException(msg)"},{"line_number":440,"context_line":"        cls.admin_client \u003d cls.os_adm.network_client"},{"line_number":441,"context_line":""},{"line_number":442,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":5,"id":"da86d52c_8ad927f5","line":439,"updated":"2015-02-05 10:48:56.000000000","message":"credential and client manager should be in setup_credentials","commit_id":"506bfd862c5a79bfb2afbbbc1b514964fcb8032d"},{"author":{"_account_id":6124,"name":"Rohan Kanade","email":"openstack@rohankanade.com","username":"kanaderohan"},"change_message_id":"c98065a403b6e5f59de04fb43dd0fb1f9268fc24","unresolved":false,"context_lines":[{"line_number":436,"context_line":"        except NotImplementedError:"},{"line_number":437,"context_line":"            msg \u003d (\"Missing Administrative Network API credentials \""},{"line_number":438,"context_line":"                   \"in configuration.\")"},{"line_number":439,"context_line":"            raise cls.skipException(msg)"},{"line_number":440,"context_line":"        cls.admin_client \u003d cls.os_adm.network_client"},{"line_number":441,"context_line":""},{"line_number":442,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":5,"id":"da86d52c_fab3f107","line":439,"in_reply_to":"da86d52c_8ad927f5","updated":"2015-02-09 08:25:58.000000000","message":"Done","commit_id":"506bfd862c5a79bfb2afbbbc1b514964fcb8032d"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"a0eb37a8a737da9b1bff11090576b80d74206ba2","unresolved":false,"context_lines":[{"line_number":76,"context_line":"    @classmethod"},{"line_number":77,"context_line":"    def resource_setup(cls):"},{"line_number":78,"context_line":"        # Create no network resources for these test."},{"line_number":79,"context_line":"        cls.set_network_resources()"},{"line_number":80,"context_line":"        super(BaseNetworkTest, cls).resource_setup()"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"        cls.network_cfg \u003d CONF.network"}],"source_content_type":"text/x-python","patch_set":6,"id":"da86d52c_8e78f6f9","line":79,"updated":"2015-02-09 08:38:57.000000000","message":"Actually there is issue here. network resources needs to be set before setting credential. Network resource creation is mixed in credential creation. \n\nAndrea is working on base patch to separate those. After that it will be clean and you can update your patch accordingly. https://review.openstack.org/#/c/153896/","commit_id":"702369904d3f5f9f88dd8497b35538c58f49e2c7"},{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"406267e10a91661f8c8d90a81a23365fd656a50f","unresolved":false,"context_lines":[{"line_number":76,"context_line":"    @classmethod"},{"line_number":77,"context_line":"    def resource_setup(cls):"},{"line_number":78,"context_line":"        # Create no network resources for these test."},{"line_number":79,"context_line":"        cls.set_network_resources()"},{"line_number":80,"context_line":"        super(BaseNetworkTest, cls).resource_setup()"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"        cls.network_cfg \u003d CONF.network"}],"source_content_type":"text/x-python","patch_set":6,"id":"1a6ced46_88a63cc0","line":79,"in_reply_to":"da86d52c_8e78f6f9","updated":"2015-03-23 13:10:17.000000000","message":"At the end we decide to let my patch go last in the bp, so this can be re-spinned with the set_network_resources moved to the top of setup_credentials","commit_id":"702369904d3f5f9f88dd8497b35538c58f49e2c7"},{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"d645dda35c8125a70749a54854589d65a3045478","unresolved":false,"context_lines":[{"line_number":433,"context_line":"        except NotImplementedError:"},{"line_number":434,"context_line":"            msg \u003d (\"Missing Administrative Network API credentials \""},{"line_number":435,"context_line":"                   \"in configuration.\")"},{"line_number":436,"context_line":"            raise cls.skipException(msg)"},{"line_number":437,"context_line":""},{"line_number":438,"context_line":"    @classmethod"},{"line_number":439,"context_line":"    def setup_clients(cls):"}],"source_content_type":"text/x-python","patch_set":7,"id":"1a6ced46_1681344a","line":436,"updated":"2015-03-25 05:39:16.000000000","message":"This should go instead in skip_checks, and use the dedicated credentials.is_admmin_available","commit_id":"3bd2f6adc208481beba4645649ddb8f5f49ea446"},{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"0c5557ff4bc1431f08763a65eddcbe80c01a831f","unresolved":false,"context_lines":[{"line_number":433,"context_line":"        except NotImplementedError:"},{"line_number":434,"context_line":"            msg \u003d (\"Missing Administrative Network API credentials \""},{"line_number":435,"context_line":"                   \"in configuration.\")"},{"line_number":436,"context_line":"            raise cls.skipException(msg)"},{"line_number":437,"context_line":""},{"line_number":438,"context_line":"    @classmethod"},{"line_number":439,"context_line":"    def setup_clients(cls):"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa963961_7c3c992f","line":436,"in_reply_to":"1a6ced46_1681344a","updated":"2015-03-26 15:28:51.000000000","message":"Done","commit_id":"3bd2f6adc208481beba4645649ddb8f5f49ea446"}],"tempest/api/network/test_ports.py":[{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"d645dda35c8125a70749a54854589d65a3045478","unresolved":false,"context_lines":[{"line_number":316,"context_line":"    @classmethod"},{"line_number":317,"context_line":"    def setup_clients(cls):"},{"line_number":318,"context_line":"        super(PortsAdminExtendedAttrsTestJSON, cls).setup_clients()"},{"line_number":319,"context_line":"        cls.identity_client \u003d cls._get_identity_admin_client()"},{"line_number":320,"context_line":""},{"line_number":321,"context_line":"    @classmethod"},{"line_number":322,"context_line":"    def resource_setup(cls):"}],"source_content_type":"text/x-python","patch_set":7,"id":"1a6ced46_968c4481","line":319,"updated":"2015-03-25 05:39:16.000000000","message":"This is redundant as the BaseAdminNetworkTest already creates an admin manager. So it would be enough to say:\n\ncls.identity_manager \u003d cls.os_admin.identity_client","commit_id":"3bd2f6adc208481beba4645649ddb8f5f49ea446"},{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"0c5557ff4bc1431f08763a65eddcbe80c01a831f","unresolved":false,"context_lines":[{"line_number":316,"context_line":"    @classmethod"},{"line_number":317,"context_line":"    def setup_clients(cls):"},{"line_number":318,"context_line":"        super(PortsAdminExtendedAttrsTestJSON, cls).setup_clients()"},{"line_number":319,"context_line":"        cls.identity_client \u003d cls._get_identity_admin_client()"},{"line_number":320,"context_line":""},{"line_number":321,"context_line":"    @classmethod"},{"line_number":322,"context_line":"    def resource_setup(cls):"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa963961_dc5725c9","line":319,"in_reply_to":"1a6ced46_968c4481","updated":"2015-03-26 15:28:51.000000000","message":"Done","commit_id":"3bd2f6adc208481beba4645649ddb8f5f49ea446"}],"tempest/api/network/test_routers.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"f1c5224c7d097ad68d2aa9122989be295e8e8db9","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    @classmethod"},{"line_number":37,"context_line":"    def setup_clients(cls):"},{"line_number":38,"context_line":"        super(RoutersTest, cls).setup_clients()"},{"line_number":39,"context_line":"        admin_manager \u003d clients.AdminManager()"},{"line_number":40,"context_line":"        cls.identity_admin_client \u003d admin_manager.identity_client"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":5,"id":"da86d52c_6a615304","line":39,"updated":"2015-02-05 10:48:56.000000000","message":"client manager should be in setup_credentials","commit_id":"506bfd862c5a79bfb2afbbbc1b514964fcb8032d"},{"author":{"_account_id":6124,"name":"Rohan Kanade","email":"openstack@rohankanade.com","username":"kanaderohan"},"change_message_id":"c98065a403b6e5f59de04fb43dd0fb1f9268fc24","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    @classmethod"},{"line_number":37,"context_line":"    def setup_clients(cls):"},{"line_number":38,"context_line":"        super(RoutersTest, cls).setup_clients()"},{"line_number":39,"context_line":"        admin_manager \u003d clients.AdminManager()"},{"line_number":40,"context_line":"        cls.identity_admin_client \u003d admin_manager.identity_client"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":5,"id":"da86d52c_1aed258c","line":39,"in_reply_to":"da86d52c_6a615304","updated":"2015-02-09 08:25:58.000000000","message":"Done","commit_id":"506bfd862c5a79bfb2afbbbc1b514964fcb8032d"},{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"d645dda35c8125a70749a54854589d65a3045478","unresolved":false,"context_lines":[{"line_number":41,"context_line":"    @classmethod"},{"line_number":42,"context_line":"    def setup_clients(cls):"},{"line_number":43,"context_line":"        super(RoutersTest, cls).setup_clients()"},{"line_number":44,"context_line":"        cls.identity_admin_client \u003d cls.admin_manager.identity_client"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    @classmethod"},{"line_number":47,"context_line":"    def resource_setup(cls):"}],"source_content_type":"text/x-python","patch_set":7,"id":"1a6ced46_76918898","line":44,"updated":"2015-03-25 05:39:16.000000000","message":"... \u003d cls.os_adm.identity_client","commit_id":"3bd2f6adc208481beba4645649ddb8f5f49ea446"},{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"0c5557ff4bc1431f08763a65eddcbe80c01a831f","unresolved":false,"context_lines":[{"line_number":41,"context_line":"    @classmethod"},{"line_number":42,"context_line":"    def setup_clients(cls):"},{"line_number":43,"context_line":"        super(RoutersTest, cls).setup_clients()"},{"line_number":44,"context_line":"        cls.identity_admin_client \u003d cls.admin_manager.identity_client"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    @classmethod"},{"line_number":47,"context_line":"    def resource_setup(cls):"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa963961_fca549b5","line":44,"in_reply_to":"1a6ced46_76918898","updated":"2015-03-26 15:28:51.000000000","message":"Done","commit_id":"3bd2f6adc208481beba4645649ddb8f5f49ea446"},{"author":{"_account_id":14271,"name":"Kallebe Monteiro","email":"kallebe.monteiro@lsbd.ufc.br","username":"kallebe"},"change_message_id":"9d8ab0f96783ab05243261ac2471efe269d528bf","unresolved":false,"context_lines":[{"line_number":17,"context_line":"from tempest_lib.common.utils import data_utils"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from tempest.api.network import base_routers as base"},{"line_number":20,"context_line":"from tempest import clients"},{"line_number":21,"context_line":"from tempest import config"},{"line_number":22,"context_line":"from tempest import test"},{"line_number":23,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"fa963961_bdca184e","line":20,"updated":"2015-03-26 17:15:06.000000000","message":"You can remove this import now.","commit_id":"758bad10230a3070b62eadc2a125832e4a7b437c"}]}