)]}'
{"tempest/api/orchestration/stacks/test_resource_types.py":[{"author":{"_account_id":13372,"name":"Eugene Bagdasaryan","email":"ebagdasaryan@me.com","username":"ebagdasa"},"change_message_id":"4155c4a884011cce589f9358741b8fced7c3d459","unresolved":false,"context_lines":[{"line_number":25,"context_line":"        self.assertIsInstance(resource_types, list)"},{"line_number":26,"context_line":"        type_names \u003d []"},{"line_number":27,"context_line":"        for restype in resource_types:"},{"line_number":28,"context_line":"            if isinstance(restype, six.string_types):"},{"line_number":29,"context_line":"                # for compatibility with old Heat API"},{"line_number":30,"context_line":"                type_names.append(restype)"},{"line_number":31,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa81d914_5a79612e","line":28,"updated":"2015-01-28 12:23:35.000000000","message":"You can put this check in one function and append the resulted value. So it won\u0027t double with line 43","commit_id":"e1d6f749302d19d52f897988563159552319601f"},{"author":{"_account_id":13372,"name":"Eugene Bagdasaryan","email":"ebagdasaryan@me.com","username":"ebagdasa"},"change_message_id":"4155c4a884011cce589f9358741b8fced7c3d459","unresolved":false,"context_lines":[{"line_number":30,"context_line":"                type_names.append(restype)"},{"line_number":31,"context_line":"            else:"},{"line_number":32,"context_line":"                type_names.append(restype[\u0027name\u0027])"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"        self.assertIn(\u0027OS::Nova::Server\u0027, type_names)"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa81d914_cf4f5191","line":33,"updated":"2015-01-28 12:23:35.000000000","message":"Empty line not needed","commit_id":"e1d6f749302d19d52f897988563159552319601f"},{"author":{"_account_id":13372,"name":"Eugene Bagdasaryan","email":"ebagdasaryan@me.com","username":"ebagdasa"},"change_message_id":"4155c4a884011cce589f9358741b8fced7c3d459","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        \"\"\"Verify it is possible to get schema about resource types.\"\"\""},{"line_number":39,"context_line":"        resource_types \u003d self.client.list_resource_types()"},{"line_number":40,"context_line":"        self.assertNotEmpty(resource_types)"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"        for resource_type in resource_types:"},{"line_number":43,"context_line":"            if isinstance(resource_type, six.string_types):"},{"line_number":44,"context_line":"                # old resource type list where each is a string"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa81d914_ba4dfd74","line":41,"updated":"2015-01-28 12:23:35.000000000","message":"Empty line not needed","commit_id":"e1d6f749302d19d52f897988563159552319601f"},{"author":{"_account_id":13372,"name":"Eugene Bagdasaryan","email":"ebagdasaryan@me.com","username":"ebagdasa"},"change_message_id":"4155c4a884011cce589f9358741b8fced7c3d459","unresolved":false,"context_lines":[{"line_number":39,"context_line":"        resource_types \u003d self.client.list_resource_types()"},{"line_number":40,"context_line":"        self.assertNotEmpty(resource_types)"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"        for resource_type in resource_types:"},{"line_number":43,"context_line":"            if isinstance(resource_type, six.string_types):"},{"line_number":44,"context_line":"                # old resource type list where each is a string"},{"line_number":45,"context_line":"                type_name \u003d resource_type"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa81d914_dabb91c2","line":42,"updated":"2015-01-28 12:23:35.000000000","message":"keep names consistent, in line 27 same value is called restype","commit_id":"e1d6f749302d19d52f897988563159552319601f"},{"author":{"_account_id":13372,"name":"Eugene Bagdasaryan","email":"ebagdasaryan@me.com","username":"ebagdasa"},"change_message_id":"4155c4a884011cce589f9358741b8fced7c3d459","unresolved":false,"context_lines":[{"line_number":40,"context_line":"        self.assertNotEmpty(resource_types)"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"        for resource_type in resource_types:"},{"line_number":43,"context_line":"            if isinstance(resource_type, six.string_types):"},{"line_number":44,"context_line":"                # old resource type list where each is a string"},{"line_number":45,"context_line":"                type_name \u003d resource_type"},{"line_number":46,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa81d914_7a762540","line":43,"updated":"2015-01-28 12:23:35.000000000","message":"Put this check into one function.","commit_id":"e1d6f749302d19d52f897988563159552319601f"}]}
