)]}'
{"tempest/api/volume/admin/test_volume_quotas_negative.py":[{"author":{"_account_id":9194,"name":"Emily Hugenbruch","email":"ekhugenbruch@us.ibm.com","username":"ekhugen"},"change_message_id":"5a68aaa6f746d74bea4e49444148164f0f04f91f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"da86d52c_8ba43609","updated":"2015-02-16 19:41:16.000000000","message":"I think this should go into setup_credentials","commit_id":"6bda50b59167499735b98463b7cfb9ac645ed903"}],"tempest/api/volume/admin/test_volume_types.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"77d314184b12d601ba529824625a1426b79774ee","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"class VolumeTypesV2Test(base.BaseVolumeAdminTest):"},{"line_number":25,"context_line":"    _interface \u003d \"json\""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    def _delete_volume(self, volume_id):"},{"line_number":28,"context_line":"        self.volumes_client.delete_volume(volume_id)"}],"source_content_type":"text/x-python","patch_set":3,"id":"da86d52c_640fcc37","side":"PARENT","line":25,"updated":"2015-02-05 10:00:34.000000000","message":"ditto","commit_id":"158efa6208e055a168ce395592c6bd8b0b2c0259"}],"tempest/api/volume/admin/test_volume_types_negative.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"77d314184b12d601ba529824625a1426b79774ee","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"class VolumeTypesNegativeV2Test(base.BaseVolumeAdminTest):"},{"line_number":24,"context_line":"    _interface \u003d \u0027json\u0027"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    @test.attr(type\u003d\u0027gate\u0027)"},{"line_number":27,"context_line":"    def test_create_with_nonexistent_volume_type(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"da86d52c_e41bbc7e","side":"PARENT","line":24,"updated":"2015-02-05 10:00:34.000000000","message":"I think we can keep these changes separately.","commit_id":"158efa6208e055a168ce395592c6bd8b0b2c0259"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"7ab67d395c83eaaee02d57649c03c36801479d67","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"class VolumeTypesNegativeV2Test(base.BaseVolumeAdminTest):"},{"line_number":24,"context_line":"    _interface \u003d \u0027json\u0027"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    @test.attr(type\u003d\u0027gate\u0027)"},{"line_number":27,"context_line":"    def test_create_with_nonexistent_volume_type(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"da86d52c_b561f0d4","side":"PARENT","line":24,"in_reply_to":"da86d52c_e41bbc7e","updated":"2015-02-05 10:50:17.000000000","message":"as it is being removed from all file then m ok.","commit_id":"158efa6208e055a168ce395592c6bd8b0b2c0259"}],"tempest/api/volume/base.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"77d314184b12d601ba529824625a1426b79774ee","unresolved":false,"context_lines":[{"line_number":53,"context_line":"    @classmethod"},{"line_number":54,"context_line":"    def setup_clients(cls):"},{"line_number":55,"context_line":"        super(BaseVolumeTest, cls).setup_clients()"},{"line_number":56,"context_line":"        cls.os \u003d cls.get_client_manager()"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"        cls.servers_client \u003d cls.os.servers_client"},{"line_number":59,"context_line":"        cls.snapshots \u003d []"}],"source_content_type":"text/x-python","patch_set":3,"id":"da86d52c_41471a77","line":56,"updated":"2015-02-05 10:00:34.000000000","message":"this should not go in setup_credentials ?","commit_id":"2508cfb01ac61038bcc41eba12ff283bb19ad79b"},{"author":{"_account_id":6124,"name":"Rohan Kanade","email":"openstack@rohankanade.com","username":"kanaderohan"},"change_message_id":"96a2ca9e55809e2664805a253f38ad5288281ef6","unresolved":false,"context_lines":[{"line_number":53,"context_line":"    @classmethod"},{"line_number":54,"context_line":"    def setup_clients(cls):"},{"line_number":55,"context_line":"        super(BaseVolumeTest, cls).setup_clients()"},{"line_number":56,"context_line":"        cls.os \u003d cls.get_client_manager()"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"        cls.servers_client \u003d cls.os.servers_client"},{"line_number":59,"context_line":"        cls.snapshots \u003d []"}],"source_content_type":"text/x-python","patch_set":3,"id":"da86d52c_4efb5e47","line":56,"in_reply_to":"da86d52c_41471a77","updated":"2015-02-09 09:40:11.000000000","message":"Done","commit_id":"2508cfb01ac61038bcc41eba12ff283bb19ad79b"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"77d314184b12d601ba529824625a1426b79774ee","unresolved":false,"context_lines":[{"line_number":57,"context_line":""},{"line_number":58,"context_line":"        cls.servers_client \u003d cls.os.servers_client"},{"line_number":59,"context_line":"        cls.snapshots \u003d []"},{"line_number":60,"context_line":"        cls.volumes \u003d []"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"        if cls._api_version \u003d\u003d 1:"},{"line_number":63,"context_line":"            cls.snapshots_client \u003d cls.os.snapshots_client"}],"source_content_type":"text/x-python","patch_set":3,"id":"da86d52c_a43384f4","line":60,"updated":"2015-02-05 10:00:34.000000000","message":"cls.snapshots \u0026 cls.volumes should be in resource_setup for better readability.","commit_id":"2508cfb01ac61038bcc41eba12ff283bb19ad79b"},{"author":{"_account_id":6124,"name":"Rohan Kanade","email":"openstack@rohankanade.com","username":"kanaderohan"},"change_message_id":"96a2ca9e55809e2664805a253f38ad5288281ef6","unresolved":false,"context_lines":[{"line_number":57,"context_line":""},{"line_number":58,"context_line":"        cls.servers_client \u003d cls.os.servers_client"},{"line_number":59,"context_line":"        cls.snapshots \u003d []"},{"line_number":60,"context_line":"        cls.volumes \u003d []"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"        if cls._api_version \u003d\u003d 1:"},{"line_number":63,"context_line":"            cls.snapshots_client \u003d cls.os.snapshots_client"}],"source_content_type":"text/x-python","patch_set":3,"id":"da86d52c_0e016639","line":60,"in_reply_to":"da86d52c_a43384f4","updated":"2015-02-09 09:40:11.000000000","message":"Done","commit_id":"2508cfb01ac61038bcc41eba12ff283bb19ad79b"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"77d314184b12d601ba529824625a1426b79774ee","unresolved":false,"context_lines":[{"line_number":68,"context_line":"            cls.availability_zone_client \u003d ("},{"line_number":69,"context_line":"                cls.os.volume_availability_zone_client)"},{"line_number":70,"context_line":"            # Special fields and resp code for cinder v1"},{"line_number":71,"context_line":"            cls.special_fields \u003d {\u0027name_field\u0027: \u0027display_name\u0027,"},{"line_number":72,"context_line":"                                  \u0027descrip_field\u0027: \u0027display_description\u0027}"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        elif cls._api_version \u003d\u003d 2:"}],"source_content_type":"text/x-python","patch_set":3,"id":"da86d52c_24579403","line":71,"updated":"2015-02-05 10:00:34.000000000","message":"cls.special_fields can go in resource_setup","commit_id":"2508cfb01ac61038bcc41eba12ff283bb19ad79b"},{"author":{"_account_id":6124,"name":"Rohan Kanade","email":"openstack@rohankanade.com","username":"kanaderohan"},"change_message_id":"96a2ca9e55809e2664805a253f38ad5288281ef6","unresolved":false,"context_lines":[{"line_number":68,"context_line":"            cls.availability_zone_client \u003d ("},{"line_number":69,"context_line":"                cls.os.volume_availability_zone_client)"},{"line_number":70,"context_line":"            # Special fields and resp code for cinder v1"},{"line_number":71,"context_line":"            cls.special_fields \u003d {\u0027name_field\u0027: \u0027display_name\u0027,"},{"line_number":72,"context_line":"                                  \u0027descrip_field\u0027: \u0027display_description\u0027}"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        elif cls._api_version \u003d\u003d 2:"}],"source_content_type":"text/x-python","patch_set":3,"id":"da86d52c_31692f26","line":71,"in_reply_to":"da86d52c_24579403","updated":"2015-02-09 09:40:11.000000000","message":"Done","commit_id":"2508cfb01ac61038bcc41eba12ff283bb19ad79b"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"77d314184b12d601ba529824625a1426b79774ee","unresolved":false,"context_lines":[{"line_number":78,"context_line":"            cls.availability_zone_client \u003d ("},{"line_number":79,"context_line":"                cls.os.volume_v2_availability_zone_client)"},{"line_number":80,"context_line":"            # Special fields and resp code for cinder v2"},{"line_number":81,"context_line":"            cls.special_fields \u003d {\u0027name_field\u0027: \u0027name\u0027,"},{"line_number":82,"context_line":"                                  \u0027descrip_field\u0027: \u0027description\u0027}"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":3,"id":"da86d52c_247cf471","line":81,"updated":"2015-02-05 10:00:34.000000000","message":"ditto","commit_id":"2508cfb01ac61038bcc41eba12ff283bb19ad79b"},{"author":{"_account_id":6124,"name":"Rohan Kanade","email":"openstack@rohankanade.com","username":"kanaderohan"},"change_message_id":"96a2ca9e55809e2664805a253f38ad5288281ef6","unresolved":false,"context_lines":[{"line_number":78,"context_line":"            cls.availability_zone_client \u003d ("},{"line_number":79,"context_line":"                cls.os.volume_v2_availability_zone_client)"},{"line_number":80,"context_line":"            # Special fields and resp code for cinder v2"},{"line_number":81,"context_line":"            cls.special_fields \u003d {\u0027name_field\u0027: \u0027name\u0027,"},{"line_number":82,"context_line":"                                  \u0027descrip_field\u0027: \u0027description\u0027}"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":3,"id":"da86d52c_116c2b36","line":81,"in_reply_to":"da86d52c_247cf471","updated":"2015-02-09 09:40:11.000000000","message":"Done","commit_id":"2508cfb01ac61038bcc41eba12ff283bb19ad79b"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"77d314184b12d601ba529824625a1426b79774ee","unresolved":false,"context_lines":[{"line_number":81,"context_line":"            cls.special_fields \u003d {\u0027name_field\u0027: \u0027name\u0027,"},{"line_number":82,"context_line":"                                  \u0027descrip_field\u0027: \u0027description\u0027}"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"        else:"},{"line_number":85,"context_line":"            msg \u003d (\"Invalid Cinder API version (%s)\" % cls._api_version)"},{"line_number":86,"context_line":"            raise exceptions.InvalidConfiguration(message\u003dmsg)"},{"line_number":87,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"da86d52c_41155a47","line":84,"updated":"2015-02-05 10:00:34.000000000","message":"this else is already checked in skip_checks so can be removed from here","commit_id":"2508cfb01ac61038bcc41eba12ff283bb19ad79b"},{"author":{"_account_id":6124,"name":"Rohan Kanade","email":"openstack@rohankanade.com","username":"kanaderohan"},"change_message_id":"96a2ca9e55809e2664805a253f38ad5288281ef6","unresolved":false,"context_lines":[{"line_number":81,"context_line":"            cls.special_fields \u003d {\u0027name_field\u0027: \u0027name\u0027,"},{"line_number":82,"context_line":"                                  \u0027descrip_field\u0027: \u0027description\u0027}"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"        else:"},{"line_number":85,"context_line":"            msg \u003d (\"Invalid Cinder API version (%s)\" % cls._api_version)"},{"line_number":86,"context_line":"            raise exceptions.InvalidConfiguration(message\u003dmsg)"},{"line_number":87,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"da86d52c_f18797d5","line":84,"in_reply_to":"da86d52c_41155a47","updated":"2015-02-09 09:40:11.000000000","message":"Done","commit_id":"2508cfb01ac61038bcc41eba12ff283bb19ad79b"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"77d314184b12d601ba529824625a1426b79774ee","unresolved":false,"context_lines":[{"line_number":182,"context_line":"                credentials\u003dcls.adm_creds, interface\u003dcls._interface)"},{"line_number":183,"context_line":"        except NotImplementedError:"},{"line_number":184,"context_line":"            msg \u003d \"Missing Volume Admin API credentials in configuration.\""},{"line_number":185,"context_line":"            raise cls.skipException(msg)"},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"        if cls._api_version \u003d\u003d 1:"},{"line_number":188,"context_line":"            cls.volume_qos_client \u003d cls.os_adm.volume_qos_client"}],"source_content_type":"text/x-python","patch_set":3,"id":"da86d52c_c4b87813","line":185,"updated":"2015-02-05 10:00:34.000000000","message":"credential should be setup in setup_credentials","commit_id":"2508cfb01ac61038bcc41eba12ff283bb19ad79b"},{"author":{"_account_id":6124,"name":"Rohan Kanade","email":"openstack@rohankanade.com","username":"kanaderohan"},"change_message_id":"96a2ca9e55809e2664805a253f38ad5288281ef6","unresolved":false,"context_lines":[{"line_number":182,"context_line":"                credentials\u003dcls.adm_creds, interface\u003dcls._interface)"},{"line_number":183,"context_line":"        except NotImplementedError:"},{"line_number":184,"context_line":"            msg \u003d \"Missing Volume Admin API credentials in configuration.\""},{"line_number":185,"context_line":"            raise cls.skipException(msg)"},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"        if cls._api_version \u003d\u003d 1:"},{"line_number":188,"context_line":"            cls.volume_qos_client \u003d cls.os_adm.volume_qos_client"}],"source_content_type":"text/x-python","patch_set":3,"id":"da86d52c_f1487789","line":185,"in_reply_to":"da86d52c_c4b87813","updated":"2015-02-09 09:40:11.000000000","message":"Done","commit_id":"2508cfb01ac61038bcc41eba12ff283bb19ad79b"},{"author":{"_account_id":9194,"name":"Emily Hugenbruch","email":"ekhugenbruch@us.ibm.com","username":"ekhugen"},"change_message_id":"5a68aaa6f746d74bea4e49444148164f0f04f91f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"da86d52c_0bbda602","updated":"2015-02-16 19:41:16.000000000","message":"Should set_network_resources() go in setup_credentials, as we did in compute/base.py?","commit_id":"6bda50b59167499735b98463b7cfb9ac645ed903"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"a68ca4d5e7749fc819694efd5b256674ec8db917","unresolved":false,"context_lines":[{"line_number":165,"context_line":"    \"\"\"Base test case class for all Volume Admin API tests.\"\"\""},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"    @classmethod"},{"line_number":168,"context_line":"    def skip_checks(cls):"},{"line_number":169,"context_line":"        super(BaseVolumeAdminTest, cls).skip_checks()"},{"line_number":170,"context_line":"        if cls._api_version \u003d\u003d 1:"},{"line_number":171,"context_line":"            if not CONF.volume_feature_enabled.api_v1:"}],"source_content_type":"text/x-python","patch_set":7,"id":"da86d52c_946ea52d","line":168,"updated":"2015-02-19 10:32:39.000000000","message":"we can remove this skip_checks() as all check is present in base class.","commit_id":"4e66ea58344f875eabe33fbc27d0d70438ae6217"}],"tempest/api/volume/test_volume_transfers.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"77d314184b12d601ba529824625a1426b79774ee","unresolved":false,"context_lines":[{"line_number":37,"context_line":"            cls.os_adm \u003d clients.Manager("},{"line_number":38,"context_line":"                credentials\u003dcreds, interface\u003dcls._interface)"},{"line_number":39,"context_line":"        except NotImplementedError:"},{"line_number":40,"context_line":"            msg \u003d \"Missing Volume Admin API credentials in configuration.\""},{"line_number":41,"context_line":"            raise cls.skipException(msg)"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"        cls.client \u003d cls.volumes_client"}],"source_content_type":"text/x-python","patch_set":3,"id":"da86d52c_043370ab","line":40,"updated":"2015-02-05 10:00:34.000000000","message":"credential and client manager setup should go in setup_credentials","commit_id":"2508cfb01ac61038bcc41eba12ff283bb19ad79b"},{"author":{"_account_id":6124,"name":"Rohan Kanade","email":"openstack@rohankanade.com","username":"kanaderohan"},"change_message_id":"96a2ca9e55809e2664805a253f38ad5288281ef6","unresolved":false,"context_lines":[{"line_number":37,"context_line":"            cls.os_adm \u003d clients.Manager("},{"line_number":38,"context_line":"                credentials\u003dcreds, interface\u003dcls._interface)"},{"line_number":39,"context_line":"        except NotImplementedError:"},{"line_number":40,"context_line":"            msg \u003d \"Missing Volume Admin API credentials in configuration.\""},{"line_number":41,"context_line":"            raise cls.skipException(msg)"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"        cls.client \u003d cls.volumes_client"}],"source_content_type":"text/x-python","patch_set":3,"id":"da86d52c_e4cef3b3","line":40,"in_reply_to":"da86d52c_043370ab","updated":"2015-02-09 09:40:11.000000000","message":"Done","commit_id":"2508cfb01ac61038bcc41eba12ff283bb19ad79b"},{"author":{"_account_id":9194,"name":"Emily Hugenbruch","email":"ekhugenbruch@us.ibm.com","username":"ekhugen"},"change_message_id":"5a68aaa6f746d74bea4e49444148164f0f04f91f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"da86d52c_ebf212e2","updated":"2015-02-16 19:41:16.000000000","message":"In https://review.openstack.org/#/c/141424 we\u0027re adding a is_admin_available() method to tempest/common/credentials.py.  You could use that here to pull out the admin creds check from setup_credentials into skip_checks().","commit_id":"6bda50b59167499735b98463b7cfb9ac645ed903"}]}