)]}'
{"tempest/api/network/test_ports.py":[{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"61edba2ab175dfdac66160254c86d58c92eed7b3","unresolved":false,"context_lines":[{"line_number":375,"context_line":"                         show_port[\u0027binding:vif_details\u0027])"},{"line_number":376,"context_line":""},{"line_number":377,"context_line":"    def _create_delete_port_for_mac(self):"},{"line_number":378,"context_line":"        # Create a port for a legal mac"},{"line_number":379,"context_line":"        body \u003d self.client.create_port(network_id\u003dself.network[\u0027id\u0027])"},{"line_number":380,"context_line":"        old_port \u003d body[\u0027port\u0027]"},{"line_number":381,"context_line":"        free_mac_address \u003d old_port[\u0027mac_address\u0027]"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a80dd14_c1d61cc3","line":378,"updated":"2015-03-05 14:34:33.000000000","message":"This could be \"Create then delete a port to get a valid MAC address\".","commit_id":"88033b1f9a64fd019f6f680d5d0209cbe77667aa"},{"author":{"_account_id":9093,"name":"Chuck Carlino","email":"chuckjcarlino@gmail.com","username":"ChuckC"},"change_message_id":"9ca931d208533739d8a2a03a9231a0227208d659","unresolved":false,"context_lines":[{"line_number":375,"context_line":"                         show_port[\u0027binding:vif_details\u0027])"},{"line_number":376,"context_line":""},{"line_number":377,"context_line":"    def _create_delete_port_for_mac(self):"},{"line_number":378,"context_line":"        # Create a port for a legal mac"},{"line_number":379,"context_line":"        body \u003d self.client.create_port(network_id\u003dself.network[\u0027id\u0027])"},{"line_number":380,"context_line":"        old_port \u003d body[\u0027port\u0027]"},{"line_number":381,"context_line":"        free_mac_address \u003d old_port[\u0027mac_address\u0027]"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a80dd14_cebab709","line":378,"in_reply_to":"9a80dd14_c1d61cc3","updated":"2015-03-06 18:19:50.000000000","message":"Done","commit_id":"88033b1f9a64fd019f6f680d5d0209cbe77667aa"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"61edba2ab175dfdac66160254c86d58c92eed7b3","unresolved":false,"context_lines":[{"line_number":382,"context_line":"        self.client.delete_port(old_port[\u0027id\u0027])"},{"line_number":383,"context_line":"        return free_mac_address"},{"line_number":384,"context_line":""},{"line_number":385,"context_line":"    def _check_port_for_mac(self, port_id, expected_mac):"},{"line_number":386,"context_line":"        body \u003d self.client.show_port(port_id)"},{"line_number":387,"context_line":"        show_port \u003d body[\u0027port\u0027]"},{"line_number":388,"context_line":"        self.assertEqual(expected_mac, show_port[\u0027mac_address\u0027])"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a80dd14_613c90e3","line":385,"updated":"2015-03-05 14:34:33.000000000","message":"You don\u0027t have to create a function if the code is only called once.\n\nYou should inline this 3 lines and add a couple of blank/empty lines as separation.","commit_id":"88033b1f9a64fd019f6f680d5d0209cbe77667aa"},{"author":{"_account_id":9093,"name":"Chuck Carlino","email":"chuckjcarlino@gmail.com","username":"ChuckC"},"change_message_id":"9ca931d208533739d8a2a03a9231a0227208d659","unresolved":false,"context_lines":[{"line_number":382,"context_line":"        self.client.delete_port(old_port[\u0027id\u0027])"},{"line_number":383,"context_line":"        return free_mac_address"},{"line_number":384,"context_line":""},{"line_number":385,"context_line":"    def _check_port_for_mac(self, port_id, expected_mac):"},{"line_number":386,"context_line":"        body \u003d self.client.show_port(port_id)"},{"line_number":387,"context_line":"        show_port \u003d body[\u0027port\u0027]"},{"line_number":388,"context_line":"        self.assertEqual(expected_mac, show_port[\u0027mac_address\u0027])"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a80dd14_8e08bf2e","line":385,"in_reply_to":"9a80dd14_613c90e3","updated":"2015-03-06 18:19:50.000000000","message":"Done","commit_id":"88033b1f9a64fd019f6f680d5d0209cbe77667aa"},{"author":{"_account_id":11671,"name":"Ashish Kumar Gupta","email":"guptaas@vmware.com","username":"ashish-kumar-gupta"},"change_message_id":"ba01ab15dd71bbca689f4ecefaf4202507e404d6","unresolved":false,"context_lines":[{"line_number":399,"context_line":""},{"line_number":400,"context_line":"    @test.requires_ext(extension\u003d\u0027allow_port_mac_address_update\u0027,"},{"line_number":401,"context_line":"                       service\u003d\u0027network\u0027)"},{"line_number":402,"context_line":"    def test_update_port_mac_address(self):"},{"line_number":403,"context_line":"        body \u003d self.client.create_port(network_id\u003dself.network[\u0027id\u0027])"},{"line_number":404,"context_line":"        port \u003d body[\u0027port\u0027]"},{"line_number":405,"context_line":"        port_id \u003d port[\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a80dd14_7f012104","line":402,"updated":"2015-03-08 17:36:47.000000000","message":"Why this test in admin class ?\nCan we add this test with already existing test in line 285 with appending the update operation.","commit_id":"7107df07ef8482574e5aff21ec5a8549f32b7fd3"},{"author":{"_account_id":9093,"name":"Chuck Carlino","email":"chuckjcarlino@gmail.com","username":"ChuckC"},"change_message_id":"b45bb350c7ae16c8c9d3ad6f0461b35c97c9962a","unresolved":false,"context_lines":[{"line_number":399,"context_line":""},{"line_number":400,"context_line":"    @test.requires_ext(extension\u003d\u0027allow_port_mac_address_update\u0027,"},{"line_number":401,"context_line":"                       service\u003d\u0027network\u0027)"},{"line_number":402,"context_line":"    def test_update_port_mac_address(self):"},{"line_number":403,"context_line":"        body \u003d self.client.create_port(network_id\u003dself.network[\u0027id\u0027])"},{"line_number":404,"context_line":"        port \u003d body[\u0027port\u0027]"},{"line_number":405,"context_line":"        port_id \u003d port[\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a80dd14_7f6041a5","line":402,"in_reply_to":"9a80dd14_7f012104","updated":"2015-03-08 18:27:03.000000000","message":"It\u0027s in the admin class because mac_address update is by policy limited to admin.","commit_id":"7107df07ef8482574e5aff21ec5a8549f32b7fd3"}]}
