)]}'
{"tempest/scenario/test_network_basic_ops.py":[{"author":{"_account_id":13770,"name":"Adolfo Duarte","email":"adduarte@redhat.com","username":"adolfoduarte"},"change_message_id":"ace765166f66ff5a3d5a4672ce9d6bbb20f5e462","unresolved":false,"context_lines":[{"line_number":416,"context_line":"        self._check_network_external_connectivity()"},{"line_number":417,"context_line":"        self._create_new_network(create_gateway\u003dTrue)"},{"line_number":418,"context_line":"        name \u003d data_utils.rand_name(\u0027server-smoke\u0027)"},{"line_number":419,"context_line":"        self._create_server(name, self.new_net)"},{"line_number":420,"context_line":"        try:"},{"line_number":421,"context_line":"            self._check_network_internal_connectivity(network\u003dself.new_net)"},{"line_number":422,"context_line":"            self.fail(\"Connection between two networks should fail \""}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_b71ca667","line":419,"updated":"2015-02-18 18:59:55.000000000","message":"I understand why you catch the exception. The only problem is that doing it this way hides any other exceptions. i.e. if the exception is thrown for some other reason, this code will hide it and give you a false \"pass\". \nI would strongly suggest writing a function like; \n_check_network_internal_connectivity_not_present(network\u003dsefl.new_net)\nThat specifically checks that there is no connectivity, and all its supporting functions. It probably is neded anyways.\n\nand use something lke: \nself.assertFalse(self._check_remote_connectivity(ssh_source,\n                                                                remote_ip),","commit_id":"a3dd02868e2784e115574c67feee1a35304c60a2"},{"author":{"_account_id":12524,"name":"Zengfa Gao","email":"zengfa.gao@hp.com","username":"zengfagao"},"change_message_id":"30c104b9c7fc6268d2ba8bff3b6c144fd7a9e59e","unresolved":false,"context_lines":[{"line_number":416,"context_line":"        self._check_network_external_connectivity()"},{"line_number":417,"context_line":"        self._create_new_network(create_gateway\u003dTrue)"},{"line_number":418,"context_line":"        name \u003d data_utils.rand_name(\u0027server-smoke\u0027)"},{"line_number":419,"context_line":"        self._create_server(name, self.new_net)"},{"line_number":420,"context_line":"        try:"},{"line_number":421,"context_line":"            self._check_network_internal_connectivity(network\u003dself.new_net)"},{"line_number":422,"context_line":"            self.fail(\"Connection between two networks should fail \""}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_65d0af53","line":419,"in_reply_to":"da86d52c_b71ca667","updated":"2015-02-18 21:42:48.000000000","message":"I thought about this. That will require refractory _check_network_internal_connectivity method. I was little reluctant to do too much refractory at that time.","commit_id":"a3dd02868e2784e115574c67feee1a35304c60a2"},{"author":{"_account_id":13770,"name":"Adolfo Duarte","email":"adduarte@redhat.com","username":"adolfoduarte"},"change_message_id":"901e293d57ec3f159cf5faee97afa9a4bc011ff9","unresolved":false,"context_lines":[{"line_number":328,"context_line":"                msg \u003d \"Timed out waiting for \""},{"line_number":329,"context_line":"                \"%s to become reachable\" % remote_ip"},{"line_number":330,"context_line":"            else:"},{"line_number":331,"context_line":"                msg \u003d \"ip address %s is reachable\" % remote_ip"},{"line_number":332,"context_line":"            try:"},{"line_number":333,"context_line":"                self.assertTrue(self._check_remote_connectivity"},{"line_number":334,"context_line":"                                (ssh_source, remote_ip, should_connect),"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a80dd14_f483ca53","line":331,"updated":"2015-03-05 19:55:41.000000000","message":"may be change message to \"ip address %s is reachable but it should not be\" ... makes it easier to debug tempest output. Otherwise it could be confusing why this is a falure.","commit_id":"05a1c4a6960f8b9a2edc8dafd9976e7b4365c33a"}]}