)]}'
{"tempest/api/compute/admin/test_simple_tenant_usage_negative.py":[{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"154b618550565185d3c945330a9925acb248ea11","unresolved":false,"context_lines":[{"line_number":27,"context_line":"        super(TenantUsagesNegativeTestJSON, cls).setup_clients()"},{"line_number":28,"context_line":"        cls.adm_client \u003d cls.os_adm.tenant_usages_client"},{"line_number":29,"context_line":"        cls.client \u003d cls.os.tenant_usages_client"},{"line_number":30,"context_line":"        cls.identity_client \u003d cls._get_identity_admin_client()"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    @classmethod"},{"line_number":33,"context_line":"    def resource_setup(cls):"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba7be1f8_043ca0e1","line":30,"updated":"2015-03-02 15:56:57.000000000","message":"The call to _get_identity_admin_client() sets up admin credentials and belongs to setup_credentials instead.\n\n_get_identity_admin_client is only called here and in test_ports. I would stop using that method and call the two parts in setup_credentials and setup_clients respectively.\n\nIn fact identity_client is not used at all, so just drop L30 is the best solution.","commit_id":"ba57ca96fee54ab80532b4f128eaecf8d459ad71"},{"author":{"_account_id":6124,"name":"Rohan Kanade","email":"openstack@rohankanade.com","username":"kanaderohan"},"change_message_id":"7e129cda59dce49ec2057d1e720961bda82b883e","unresolved":false,"context_lines":[{"line_number":27,"context_line":"        super(TenantUsagesNegativeTestJSON, cls).setup_clients()"},{"line_number":28,"context_line":"        cls.adm_client \u003d cls.os_adm.tenant_usages_client"},{"line_number":29,"context_line":"        cls.client \u003d cls.os.tenant_usages_client"},{"line_number":30,"context_line":"        cls.identity_client \u003d cls._get_identity_admin_client()"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    @classmethod"},{"line_number":33,"context_line":"    def resource_setup(cls):"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a80dd14_1fdd7b42","line":30,"in_reply_to":"ba7be1f8_043ca0e1","updated":"2015-03-09 09:19:25.000000000","message":"Done","commit_id":"ba57ca96fee54ab80532b4f128eaecf8d459ad71"}],"tempest/api/compute/servers/test_create_server.py":[{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"154b618550565185d3c945330a9925acb248ea11","unresolved":false,"context_lines":[{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    @classmethod"},{"line_number":40,"context_line":"    def resource_setup(cls):"},{"line_number":41,"context_line":"        cls.prepare_instance_network()"},{"line_number":42,"context_line":"        super(ServersTestJSON, cls).resource_setup()"},{"line_number":43,"context_line":"        cls.meta \u003d {\u0027hello\u0027: \u0027world\u0027}"},{"line_number":44,"context_line":"        cls.accessIPv4 \u003d \u00271.1.1.1\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba7be1f8_e7ca2e19","line":41,"range":{"start_line":41,"start_character":9,"end_line":41,"end_character":36},"updated":"2015-03-02 15:56:57.000000000","message":"Having this one here does not work. The result of this call is used by the credentials setup phase (when tenant isolation is enabled). \n\nThis should be in setup_credentials before the call to super().setup_credentials.","commit_id":"ba57ca96fee54ab80532b4f128eaecf8d459ad71"},{"author":{"_account_id":6124,"name":"Rohan Kanade","email":"openstack@rohankanade.com","username":"kanaderohan"},"change_message_id":"7e129cda59dce49ec2057d1e720961bda82b883e","unresolved":false,"context_lines":[{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    @classmethod"},{"line_number":40,"context_line":"    def resource_setup(cls):"},{"line_number":41,"context_line":"        cls.prepare_instance_network()"},{"line_number":42,"context_line":"        super(ServersTestJSON, cls).resource_setup()"},{"line_number":43,"context_line":"        cls.meta \u003d {\u0027hello\u0027: \u0027world\u0027}"},{"line_number":44,"context_line":"        cls.accessIPv4 \u003d \u00271.1.1.1\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a80dd14_dfe043cf","line":41,"in_reply_to":"ba7be1f8_e7ca2e19","updated":"2015-03-09 09:19:25.000000000","message":"Done","commit_id":"ba57ca96fee54ab80532b4f128eaecf8d459ad71"}]}