)]}'
{"tempest/api/compute/floating_ips/test_floating_ips_actions.py":[{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"4a38be76e3ab7176934f3e9f8a161657f0274cf2","unresolved":false,"context_lines":[{"line_number":80,"context_line":"        self.addCleanup(self._try_delete_floating_ip, floating_ip_body[\u0027id\u0027])"},{"line_number":81,"context_line":"        # Storing the details of floating IP before deleting it"},{"line_number":82,"context_line":"        cli_resp \u003d self.client.get_floating_ip_details(floating_ip_body[\u0027id\u0027])"},{"line_number":83,"context_line":"        resp, floating_ip_details \u003d cli_resp"},{"line_number":84,"context_line":"        # Deleting the floating IP from the project"},{"line_number":85,"context_line":"        resp, body \u003d self.client.delete_floating_ip(floating_ip_body[\u0027id\u0027])"},{"line_number":86,"context_line":"        self.assertEqual(202, resp.status)"}],"source_content_type":"text/x-python","patch_set":4,"id":"da86d52c_d7e1bffd","side":"PARENT","line":83,"updated":"2015-02-13 15:01:29.000000000","message":"This is interesting, I wonder why this was here? Was there a check which was removed?","commit_id":"e290f3eec4ad2560d40fc258dc707568572f8f28"},{"author":{"_account_id":1192,"name":"David Kranz","email":"dkranz@redhat.com","username":"david-kranz"},"change_message_id":"0c320c5e8c035f72dc2042312f68f3cc19976ae8","unresolved":false,"context_lines":[{"line_number":80,"context_line":"        self.addCleanup(self._try_delete_floating_ip, floating_ip_body[\u0027id\u0027])"},{"line_number":81,"context_line":"        # Storing the details of floating IP before deleting it"},{"line_number":82,"context_line":"        cli_resp \u003d self.client.get_floating_ip_details(floating_ip_body[\u0027id\u0027])"},{"line_number":83,"context_line":"        resp, floating_ip_details \u003d cli_resp"},{"line_number":84,"context_line":"        # Deleting the floating IP from the project"},{"line_number":85,"context_line":"        resp, body \u003d self.client.delete_floating_ip(floating_ip_body[\u0027id\u0027])"},{"line_number":86,"context_line":"        self.assertEqual(202, resp.status)"}],"source_content_type":"text/x-python","patch_set":4,"id":"da86d52c_d7e45e10","side":"PARENT","line":83,"in_reply_to":"da86d52c_d7e1bffd","updated":"2015-02-13 15:19:51.000000000","message":"I\u0027m not sure but this test does enough for testing deletion.","commit_id":"e290f3eec4ad2560d40fc258dc707568572f8f28"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"4a38be76e3ab7176934f3e9f8a161657f0274cf2","unresolved":false,"context_lines":[{"line_number":130,"context_line":"            self.new_server_id)"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"        self.addCleanup(self.servers_client.delete_server, self.new_server_id)"},{"line_number":133,"context_line":"        if (resp[\u0027status\u0027] is not None):"},{"line_number":134,"context_line":"            self.addCleanup(self.client.disassociate_floating_ip_from_server,"},{"line_number":135,"context_line":"                            self.floating_ip,"},{"line_number":136,"context_line":"                            self.new_server_id)"}],"source_content_type":"text/x-python","patch_set":4,"id":"da86d52c_57922f4c","side":"PARENT","line":133,"updated":"2015-02-13 15:01:29.000000000","message":"That\u0027s a weird check, the status code should never be None","commit_id":"e290f3eec4ad2560d40fc258dc707568572f8f28"},{"author":{"_account_id":1192,"name":"David Kranz","email":"dkranz@redhat.com","username":"david-kranz"},"change_message_id":"0c320c5e8c035f72dc2042312f68f3cc19976ae8","unresolved":false,"context_lines":[{"line_number":130,"context_line":"            self.new_server_id)"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"        self.addCleanup(self.servers_client.delete_server, self.new_server_id)"},{"line_number":133,"context_line":"        if (resp[\u0027status\u0027] is not None):"},{"line_number":134,"context_line":"            self.addCleanup(self.client.disassociate_floating_ip_from_server,"},{"line_number":135,"context_line":"                            self.floating_ip,"},{"line_number":136,"context_line":"                            self.new_server_id)"}],"source_content_type":"text/x-python","patch_set":4,"id":"da86d52c_579f8e65","side":"PARENT","line":133,"in_reply_to":"da86d52c_57922f4c","updated":"2015-02-13 15:19:51.000000000","message":"It can\u0027t be and if it were the client would raise an exception. So I just deleted it.","commit_id":"e290f3eec4ad2560d40fc258dc707568572f8f28"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"4a38be76e3ab7176934f3e9f8a161657f0274cf2","unresolved":false,"context_lines":[{"line_number":109,"context_line":"        # to specific server should change the association of the Floating IP"},{"line_number":110,"context_line":"        # Create server so as to use for Multiple association"},{"line_number":111,"context_line":"        new_name \u003d data_utils.rand_name(\u0027floating_server\u0027)"},{"line_number":112,"context_line":"        resp, body \u003d self.create_test_server(name\u003dnew_name)"},{"line_number":113,"context_line":"        self.servers_client.wait_for_server_status(body[\u0027id\u0027], \u0027ACTIVE\u0027)"},{"line_number":114,"context_line":"        self.new_server_id \u003d body[\u0027id\u0027]"},{"line_number":115,"context_line":"        self.addCleanup(self.servers_client.delete_server, self.new_server_id)"}],"source_content_type":"text/x-python","patch_set":4,"id":"da86d52c_57a4efb8","line":112,"updated":"2015-02-13 15:01:29.000000000","message":"I just approved your patch which changed this, there might be a merge conflict.","commit_id":"e4e3b4100fffbd7827c0426d1ea867d1b84d69d6"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"4a38be76e3ab7176934f3e9f8a161657f0274cf2","unresolved":false,"context_lines":[{"line_number":112,"context_line":"        resp, body \u003d self.create_test_server(name\u003dnew_name)"},{"line_number":113,"context_line":"        self.servers_client.wait_for_server_status(body[\u0027id\u0027], \u0027ACTIVE\u0027)"},{"line_number":114,"context_line":"        self.new_server_id \u003d body[\u0027id\u0027]"},{"line_number":115,"context_line":"        self.addCleanup(self.servers_client.delete_server, self.new_server_id)"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"        # Associating floating IP for the first time"},{"line_number":118,"context_line":"        self.client.associate_floating_ip_to_server("}],"source_content_type":"text/x-python","patch_set":4,"id":"da86d52c_578b0f1e","line":115,"updated":"2015-02-13 15:01:29.000000000","message":"Why is this needed, doesn\u0027t create_test_server take care of the cleanup? Or am I missing something","commit_id":"e4e3b4100fffbd7827c0426d1ea867d1b84d69d6"},{"author":{"_account_id":1192,"name":"David Kranz","email":"dkranz@redhat.com","username":"david-kranz"},"change_message_id":"0c320c5e8c035f72dc2042312f68f3cc19976ae8","unresolved":false,"context_lines":[{"line_number":112,"context_line":"        resp, body \u003d self.create_test_server(name\u003dnew_name)"},{"line_number":113,"context_line":"        self.servers_client.wait_for_server_status(body[\u0027id\u0027], \u0027ACTIVE\u0027)"},{"line_number":114,"context_line":"        self.new_server_id \u003d body[\u0027id\u0027]"},{"line_number":115,"context_line":"        self.addCleanup(self.servers_client.delete_server, self.new_server_id)"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"        # Associating floating IP for the first time"},{"line_number":118,"context_line":"        self.client.associate_floating_ip_to_server("}],"source_content_type":"text/x-python","patch_set":4,"id":"da86d52c_17efd6ea","line":115,"in_reply_to":"da86d52c_578b0f1e","updated":"2015-02-13 15:19:51.000000000","message":"Yes, it does.","commit_id":"e4e3b4100fffbd7827c0426d1ea867d1b84d69d6"}],"tempest/services/compute/json/floating_ips_client.py":[{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"8e48cd9783106fbfb62c49560d5cf5326cde28c2","unresolved":false,"context_lines":[{"line_number":139,"context_line":"        resp, body \u003d self.put(\u0027os-floating-ips-bulk/delete\u0027, post_body)"},{"line_number":140,"context_line":"        body \u003d json.loads(body)"},{"line_number":141,"context_line":"        self.validate_response(schema.delete_floating_ips_bulk, resp, body)"},{"line_number":142,"context_line":"        return resp, body[\u0027floating_ips_bulk_delete\u0027]"}],"source_content_type":"text/x-python","patch_set":3,"id":"da86d52c_5a71e6a6","line":142,"updated":"2015-02-11 13:23:07.000000000","message":"How about adding FIX or NOTE comment the above?\nI think it may help to understand why we leave here.","commit_id":"b4c2b027f4fde49296690c6d84d2ab966f572e36"}]}