)]}'
{"etc/tempest.conf.sample":[{"author":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"change_message_id":"894c5469e36aebd54468d7ebb6a203af2471fece","unresolved":false,"context_lines":[{"line_number":1094,"context_line":"#"},{"line_number":1095,"context_line":""},{"line_number":1096,"context_line":"# Runs Ceilometer event-related tests (boolean value)"},{"line_number":1097,"context_line":"#events \u003d false"},{"line_number":1098,"context_line":""},{"line_number":1099,"context_line":""},{"line_number":1100,"context_line":"[validation]"}],"source_content_type":"application/octet-stream","patch_set":9,"id":"fa32b979_6a061922","line":1097,"updated":"2015-06-14 15:33:23.000000000","message":"Why do you default to False ?\n\nIs there any gate job which sets it to true or it will set it to true ?","commit_id":"ff42e5cd7a85e56399ab6d3d6fb15f3341616b5c"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"df81c86d78d8539459821642f5565838dd216e36","unresolved":false,"context_lines":[{"line_number":1094,"context_line":"#"},{"line_number":1095,"context_line":""},{"line_number":1096,"context_line":"# Runs Ceilometer event-related tests (boolean value)"},{"line_number":1097,"context_line":"#events \u003d false"},{"line_number":1098,"context_line":""},{"line_number":1099,"context_line":""},{"line_number":1100,"context_line":"[validation]"}],"source_content_type":"application/octet-stream","patch_set":9,"id":"fa32b979_5a4e5297","line":1097,"in_reply_to":"fa32b979_6a061922","updated":"2015-06-15 23:18:05.000000000","message":"i believe it\u0027s because tempest is branchless. in liberty (and hopefully kilo) i enabled this value in devstack. if i set this as True, it will test on all branches and it\u0027ll fail in Juno (because it was not implemented yet)\n\nhttps://review.openstack.org/#/c/190945/ (kilo patch), liberty has merged already","commit_id":"ff42e5cd7a85e56399ab6d3d6fb15f3341616b5c"}],"tempest/api/telemetry/base.py":[{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"f25a2802fbc63e2d857a324d32dcbbea4e183928","unresolved":false,"context_lines":[{"line_number":49,"context_line":"        cls.flavors_client \u003d cls.os.flavors_client"},{"line_number":50,"context_line":"        cls.image_client \u003d cls.os.image_client"},{"line_number":51,"context_line":"        cls.image_client_v2 \u003d cls.os.image_client_v2"},{"line_number":52,"context_line":"        cls.telemetry_admin_client \u003d clients.AdminManager().telemetry_client"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    @classmethod"},{"line_number":55,"context_line":"    def resource_setup(cls):"}],"source_content_type":"text/x-python","patch_set":9,"id":"fa32b979_fe7948fd","line":52,"updated":"2015-06-16 09:31:30.000000000","message":"You shouldn\"t add an admin client in this class. You should add a new class BaseTelemetryAdminTest(BaseTelemetryTest).\n\nAre you sure you need to be \"admin\" to perform this test ?","commit_id":"ff42e5cd7a85e56399ab6d3d6fb15f3341616b5c"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"84652992c856f8a27d5115b6eb8d5e764d53c37e","unresolved":false,"context_lines":[{"line_number":49,"context_line":"        cls.flavors_client \u003d cls.os.flavors_client"},{"line_number":50,"context_line":"        cls.image_client \u003d cls.os.image_client"},{"line_number":51,"context_line":"        cls.image_client_v2 \u003d cls.os.image_client_v2"},{"line_number":52,"context_line":"        cls.telemetry_admin_client \u003d clients.AdminManager().telemetry_client"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    @classmethod"},{"line_number":55,"context_line":"    def resource_setup(cls):"}],"source_content_type":"text/x-python","patch_set":9,"id":"fa32b979_4a6f472b","line":52,"in_reply_to":"fa32b979_dfd79b21","updated":"2015-06-16 11:44:28.000000000","message":"hmm... i just tried this but i realised i need to create a new independent test for event generation. i guess one reason i added to existing nova notification test was that i wanted to verify that i could get both event and sample from nova notification -- not each one separately.","commit_id":"ff42e5cd7a85e56399ab6d3d6fb15f3341616b5c"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"51f94005de887313c003a18ac11e1ea00c813785","unresolved":false,"context_lines":[{"line_number":49,"context_line":"        cls.flavors_client \u003d cls.os.flavors_client"},{"line_number":50,"context_line":"        cls.image_client \u003d cls.os.image_client"},{"line_number":51,"context_line":"        cls.image_client_v2 \u003d cls.os.image_client_v2"},{"line_number":52,"context_line":"        cls.telemetry_admin_client \u003d clients.AdminManager().telemetry_client"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    @classmethod"},{"line_number":55,"context_line":"    def resource_setup(cls):"}],"source_content_type":"text/x-python","patch_set":9,"id":"fa32b979_dfd79b21","line":52,"in_reply_to":"fa32b979_fe7948fd","updated":"2015-06-16 11:15:47.000000000","message":"ok. i\u0027ll do that.\n\nyes, admin is required (for right or wrong) https://github.com/openstack/ceilometer/blob/master/ceilometer/api/controllers/v2/events.py#L238","commit_id":"ff42e5cd7a85e56399ab6d3d6fb15f3341616b5c"},{"author":{"_account_id":1192,"name":"David Kranz","email":"dkranz@redhat.com","username":"david-kranz"},"change_message_id":"9ad62b2ad910aac8a662a041e338c260f63da3e5","unresolved":false,"context_lines":[{"line_number":49,"context_line":"        cls.flavors_client \u003d cls.os.flavors_client"},{"line_number":50,"context_line":"        cls.image_client \u003d cls.os.image_client"},{"line_number":51,"context_line":"        cls.image_client_v2 \u003d cls.os.image_client_v2"},{"line_number":52,"context_line":"        cls.telemetry_admin_client \u003d clients.AdminManager().telemetry_client"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    @classmethod"},{"line_number":55,"context_line":"    def resource_setup(cls):"}],"source_content_type":"text/x-python","patch_set":10,"id":"fa32b979_105b62f7","line":52,"updated":"2015-06-17 19:11:13.000000000","message":"This is an old way to get the admin client and will not work with the new test accounts feature. The current way is to just change the credentials var from [\u0027primary\u0027] to [\u0027primary\u0027, \u0027admin\u0027] and then use as the value:\n\ncls.os_adm.telemetry_client\n\nSee BaseComputeAdminTest for example.","commit_id":"be32accdce74d1606c0543ea0167ac1e64a5cadd"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"81398f05f86ec160bb579b7032a6c5d242201d9f","unresolved":false,"context_lines":[{"line_number":49,"context_line":"        cls.flavors_client \u003d cls.os.flavors_client"},{"line_number":50,"context_line":"        cls.image_client \u003d cls.os.image_client"},{"line_number":51,"context_line":"        cls.image_client_v2 \u003d cls.os.image_client_v2"},{"line_number":52,"context_line":"        cls.telemetry_admin_client \u003d clients.AdminManager().telemetry_client"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    @classmethod"},{"line_number":55,"context_line":"    def resource_setup(cls):"}],"source_content_type":"text/x-python","patch_set":10,"id":"fa32b979_f317da42","line":52,"in_reply_to":"fa32b979_105b62f7","updated":"2015-06-18 02:32:28.000000000","message":"done. thanks for the info dkranz!","commit_id":"be32accdce74d1606c0543ea0167ac1e64a5cadd"}],"tempest/api/telemetry/test_telemetry_notification_api.py":[{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"04b927f08dcf7a18f4af5900d93f7a97d3803a00","unresolved":false,"context_lines":[{"line_number":36,"context_line":"        body \u003d self.create_server()"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"        query \u003d (\u0027resource\u0027, \u0027eq\u0027, body[\u0027id\u0027])"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"        for metric in self.nova_notifications:"},{"line_number":41,"context_line":"            self.await_samples(metric, query)"},{"line_number":42,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"ba3cc151_65408057","side":"PARENT","line":39,"updated":"2015-06-29 19:28:46.000000000","message":"tsk tsk, unrelated whitespace change :)","commit_id":"441d2cc917e67e0fa817ba6ab13e4018bbcd6873"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"617198d09700838fbcca22fd4639e2f6a654e3cf","unresolved":false,"context_lines":[{"line_number":36,"context_line":"        body \u003d self.create_server()"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"        query \u003d (\u0027resource\u0027, \u0027eq\u0027, body[\u0027id\u0027])"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"        for metric in self.nova_notifications:"},{"line_number":41,"context_line":"            self.await_samples(metric, query)"},{"line_number":42,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"ba3cc151_19b0f8dc","side":"PARENT","line":39,"in_reply_to":"ba3cc151_65408057","updated":"2015-06-29 20:28:52.000000000","message":"i don\u0027t like whitespace. :)","commit_id":"441d2cc917e67e0fa817ba6ab13e4018bbcd6873"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"04b927f08dcf7a18f4af5900d93f7a97d3803a00","unresolved":false,"context_lines":[{"line_number":82,"context_line":"                                    \"is disabled\")"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"    @test.idempotent_id(\u002729604198-8b45-4fc0-8af8-1cae4f94ebe9\u0027)"},{"line_number":85,"context_line":"    @testtools.skipIf(not CONF.service_available.nova,"},{"line_number":86,"context_line":"                      \"Nova is not available.\")"},{"line_number":87,"context_line":"    def test_check_nova_notification_event_and_meter(self):"},{"line_number":88,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"ba3cc151_c5062c20","line":85,"updated":"2015-06-29 19:28:46.000000000","message":"You should use the services decorator from tempest.test here instead. It will both skip the test if nova isn\u0027t available and also properly tag the test as using nova.","commit_id":"d27141abb960c004f04825a0228f9822ffd93695"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"617198d09700838fbcca22fd4639e2f6a654e3cf","unresolved":false,"context_lines":[{"line_number":82,"context_line":"                                    \"is disabled\")"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"    @test.idempotent_id(\u002729604198-8b45-4fc0-8af8-1cae4f94ebe9\u0027)"},{"line_number":85,"context_line":"    @testtools.skipIf(not CONF.service_available.nova,"},{"line_number":86,"context_line":"                      \"Nova is not available.\")"},{"line_number":87,"context_line":"    def test_check_nova_notification_event_and_meter(self):"},{"line_number":88,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"ba3cc151_f9a0b492","line":85,"in_reply_to":"ba3cc151_c5062c20","updated":"2015-06-29 20:28:52.000000000","message":"Done","commit_id":"d27141abb960c004f04825a0228f9822ffd93695"}],"tempest/services/telemetry/json/telemetry_client.py":[{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"f25a2802fbc63e2d857a324d32dcbbea4e183928","unresolved":false,"context_lines":[{"line_number":137,"context_line":"        body \u003d self.deserialize(body)"},{"line_number":138,"context_line":"        return service_client.ResponseBodyData(resp, body)"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"    def list_events(self, query\u003dNone):"},{"line_number":141,"context_line":"        uri \u003d \u0027%s/events\u0027 % self.uri_prefix"},{"line_number":142,"context_line":"        return self._helper_list(uri, query)"}],"source_content_type":"text/x-python","patch_set":9,"id":"fa32b979_79147243","line":140,"updated":"2015-06-16 09:31:30.000000000","message":"Could you move this around line 80 please ?","commit_id":"ff42e5cd7a85e56399ab6d3d6fb15f3341616b5c"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"51f94005de887313c003a18ac11e1ea00c813785","unresolved":false,"context_lines":[{"line_number":137,"context_line":"        body \u003d self.deserialize(body)"},{"line_number":138,"context_line":"        return service_client.ResponseBodyData(resp, body)"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"    def list_events(self, query\u003dNone):"},{"line_number":141,"context_line":"        uri \u003d \u0027%s/events\u0027 % self.uri_prefix"},{"line_number":142,"context_line":"        return self._helper_list(uri, query)"}],"source_content_type":"text/x-python","patch_set":9,"id":"fa32b979_dfbebbd3","line":140,"in_reply_to":"fa32b979_79147243","updated":"2015-06-16 11:15:47.000000000","message":"yep!","commit_id":"ff42e5cd7a85e56399ab6d3d6fb15f3341616b5c"}]}