)]}'
{"tempest/api/compute/servers/test_server_actions.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"4ea74b11d1fbeab48bb528152e401272f477b287","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"class ServerActionsTestJSON(base.BaseV2ComputeTest,"},{"line_number":37,"context_line":"                            manager.ScenarioTest):"},{"line_number":38,"context_line":"    run_ssh \u003d CONF.compute.run_ssh"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    def setUp(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa963961_2c6355de","line":37,"updated":"2015-03-27 14:55:58.000000000","message":"This shouldn\u0027t be here, scenario tests and API tests shouldn\u0027t be intermingled.\n\nYou could just throw this into scenarios somewhere under an existing test class that does the volume thingies but make it a separate test case.\n\nLike one of these:\n\nhttp://git.openstack.org/cgit/openstack/tempest/tree/tempest/scenario/test_server_advanced_ops.py\n\nhttp://git.openstack.org/cgit/openstack/tempest/tree/tempest/scenario/test_volume_boot_pattern.py","commit_id":"4287f10b65deeb1a4c5cd258b84c11c4f3eb72ad"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"f7eaef3ee4536f1052b4182c45448d7c65b10fa0","unresolved":false,"context_lines":[{"line_number":225,"context_line":"    def test_resize_server_confirm_from_stopped(self):"},{"line_number":226,"context_line":"        self._test_resize_server_confirm(stop\u003dTrue)"},{"line_number":227,"context_line":""},{"line_number":228,"context_line":"    def _create_volume_from_image(self):"},{"line_number":229,"context_line":"        img_uuid \u003d CONF.compute.image_ref"},{"line_number":230,"context_line":"        vol_name \u003d data_utils.rand_name(\u0027volume-origin\u0027)"},{"line_number":231,"context_line":"        return self.create_volume(name\u003dvol_name, imageRef\u003dimg_uuid)"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa963961_2ce8f50f","line":228,"updated":"2015-03-27 14:57:42.000000000","message":"These private helper methods come from this scenario test:\n\nhttp://git.openstack.org/cgit/openstack/tempest/tree/tempest/scenario/test_volume_boot_pattern.py\n\nSo I\u0027d just move the new test case in that test class and re-use the helper methods.","commit_id":"4287f10b65deeb1a4c5cd258b84c11c4f3eb72ad"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"b6f92debf038310e98b0156a71fce4fcb3ed7c4a","unresolved":false,"context_lines":[{"line_number":251,"context_line":"                                  create_kwargs\u003dcreate_kwargs)"},{"line_number":252,"context_line":""},{"line_number":253,"context_line":"    def test_resize_server_booted_from_volume(self):"},{"line_number":254,"context_line":"        keypair \u003d self.create_keypair()"},{"line_number":255,"context_line":"        self.security_group \u003d self._create_security_group()"},{"line_number":256,"context_line":""},{"line_number":257,"context_line":"        # create an instance from volume"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa963961_cc3ce995","line":254,"updated":"2015-03-27 14:58:48.000000000","message":"I don\u0027t think the keypair and security group are needed for the test?  test_volume_boot_pattern needs them because it ssh\u0027s into the instance, you\u0027re not doing that here though so it\u0027s probably overkill.","commit_id":"4287f10b65deeb1a4c5cd258b84c11c4f3eb72ad"},{"author":{"_account_id":13167,"name":"Yogesh","email":"ykshirsa@netapp.com","username":"yogi1"},"change_message_id":"3347da4aab7436ed4c14440e7126025222985596","unresolved":false,"context_lines":[{"line_number":255,"context_line":"        self.security_group \u003d self._create_security_group()"},{"line_number":256,"context_line":""},{"line_number":257,"context_line":"        # create an instance from volume"},{"line_number":258,"context_line":"        volume_origin \u003d self._create_volume_from_image()"},{"line_number":259,"context_line":"        server \u003d self._boot_instance_from_volume(volume_origin[\u0027id\u0027], keypair)"},{"line_number":260,"context_line":"        previous_flavor_ref, new_flavor_ref \u003d ("},{"line_number":261,"context_line":"            self._detect_server_image_flavor(server[\u0027id\u0027]))"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba7be1f8_dbe1939b","line":258,"updated":"2015-02-23 21:27:46.000000000","message":"How are we cleaning up the volume created here after test is completed?","commit_id":"4287f10b65deeb1a4c5cd258b84c11c4f3eb72ad"},{"author":{"_account_id":10300,"name":"Pranali Deore","email":"pranalideore@gmail.com","username":"PranaliDeore"},"change_message_id":"d03ea2a9e2a84d46ff974378bc3bf4cb1b25a272","unresolved":false,"context_lines":[{"line_number":255,"context_line":"        self.security_group \u003d self._create_security_group()"},{"line_number":256,"context_line":""},{"line_number":257,"context_line":"        # create an instance from volume"},{"line_number":258,"context_line":"        volume_origin \u003d self._create_volume_from_image()"},{"line_number":259,"context_line":"        server \u003d self._boot_instance_from_volume(volume_origin[\u0027id\u0027], keypair)"},{"line_number":260,"context_line":"        previous_flavor_ref, new_flavor_ref \u003d ("},{"line_number":261,"context_line":"            self._detect_server_image_flavor(server[\u0027id\u0027]))"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a80dd14_b41a2dc4","line":258,"in_reply_to":"ba7be1f8_dbe1939b","updated":"2015-03-18 13:45:19.000000000","message":"Hi Yogesh,\n\nIn create_volume() method add_cleanup() is called to delete the volume.\nAnd after running this test, the resources are getting cleaned up.","commit_id":"4287f10b65deeb1a4c5cd258b84c11c4f3eb72ad"},{"author":{"_account_id":13167,"name":"Yogesh","email":"ykshirsa@netapp.com","username":"yogi1"},"change_message_id":"3347da4aab7436ed4c14440e7126025222985596","unresolved":false,"context_lines":[{"line_number":256,"context_line":""},{"line_number":257,"context_line":"        # create an instance from volume"},{"line_number":258,"context_line":"        volume_origin \u003d self._create_volume_from_image()"},{"line_number":259,"context_line":"        server \u003d self._boot_instance_from_volume(volume_origin[\u0027id\u0027], keypair)"},{"line_number":260,"context_line":"        previous_flavor_ref, new_flavor_ref \u003d ("},{"line_number":261,"context_line":"            self._detect_server_image_flavor(server[\u0027id\u0027]))"},{"line_number":262,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ba7be1f8_db4a73ab","line":259,"updated":"2015-02-23 21:27:46.000000000","message":"How are we cleaning up the instance once the test is complete?","commit_id":"4287f10b65deeb1a4c5cd258b84c11c4f3eb72ad"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"efeb5466346752158c62f500005c1f2c3a505343","unresolved":false,"context_lines":[{"line_number":260,"context_line":"        previous_flavor_ref, new_flavor_ref \u003d ("},{"line_number":261,"context_line":"            self._detect_server_image_flavor(server[\u0027id\u0027]))"},{"line_number":262,"context_line":""},{"line_number":263,"context_line":"        resp, body \u003d self.client.resize(server[\u0027id\u0027], new_flavor_ref)"},{"line_number":264,"context_line":"        self.assertEqual(202, resp.status)"},{"line_number":265,"context_line":"        self.client.wait_for_server_status(server[\u0027id\u0027], \u0027VERIFY_RESIZE\u0027)"},{"line_number":266,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa963961_6cfa7dbf","line":263,"updated":"2015-03-27 15:01:10.000000000","message":"Are you resizing up or down?  The bug was to fix resizing down with a volume-backed instance.","commit_id":"4287f10b65deeb1a4c5cd258b84c11c4f3eb72ad"}]}