)]}'
{"tempest/scenario/test_network_v6.py":[{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"1875eb31604ce8864a874a53b5d46403942022bd","unresolved":false,"context_lines":[{"line_number":122,"context_line":"        def guest_has_address(ssh, addr):"},{"line_number":123,"context_line":"            return addr in ssh.get_ip_list()"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"        ips_from_ip_1 \u003d ssh1_4.get_ip_list()"},{"line_number":126,"context_line":"        ips_from_ip_2 \u003d ssh2_4.get_ip_list()"},{"line_number":127,"context_line":"        self.assertIn(ips_from_api_1[\u00274\u0027], ips_from_ip_1)"},{"line_number":128,"context_line":"        self.assertIn(ips_from_api_2[\u00274\u0027], ips_from_ip_2)"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a80dd14_a703fd0b","line":125,"updated":"2015-03-05 13:47:41.000000000","message":"I have a hard time understanding what does this variable \"ips_from_ip\" represents. Could you add a code comment ?","commit_id":"b74493179f5ccff19c88f96f28102e92a84056e8"},{"author":{"_account_id":12632,"name":"Kirill Shileev","email":"kshileev@cisco.com","username":"kshileev"},"change_message_id":"04a7e02a044e433ad1ff17e31f0c1002839caf61","unresolved":false,"context_lines":[{"line_number":122,"context_line":"        def guest_has_address(ssh, addr):"},{"line_number":123,"context_line":"            return addr in ssh.get_ip_list()"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"        ips_from_ip_1 \u003d ssh1_4.get_ip_list()"},{"line_number":126,"context_line":"        ips_from_ip_2 \u003d ssh2_4.get_ip_list()"},{"line_number":127,"context_line":"        self.assertIn(ips_from_api_1[\u00274\u0027], ips_from_ip_1)"},{"line_number":128,"context_line":"        self.assertIn(ips_from_api_2[\u00274\u0027], ips_from_ip_2)"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a80dd14_e0fdd13c","line":125,"in_reply_to":"9a80dd14_a703fd0b","updated":"2015-03-05 17:34:03.000000000","message":"Done","commit_id":"b74493179f5ccff19c88f96f28102e92a84056e8"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"1875eb31604ce8864a874a53b5d46403942022bd","unresolved":false,"context_lines":[{"line_number":174,"context_line":"    Boot 2 VMs on this network"},{"line_number":175,"context_line":"    Allocate and assign 2 FIP4"},{"line_number":176,"context_line":"    Check that vNIC of server matches port data from OpenStack DB"},{"line_number":177,"context_line":"    Ping4 tenant IPv4 of one VM from another one"},{"line_number":178,"context_line":"    Will do the same with ping6 when available in VMs"},{"line_number":179,"context_line":"    \"\"\""},{"line_number":180,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"9a80dd14_e7f7b5f3","line":177,"updated":"2015-03-05 13:47:41.000000000","message":"What is \"tenant IPv4\" ? Are you talking about \u0027FIP4\u0027 that you introduced 2 lines above ?","commit_id":"b74493179f5ccff19c88f96f28102e92a84056e8"},{"author":{"_account_id":12632,"name":"Kirill Shileev","email":"kshileev@cisco.com","username":"kshileev"},"change_message_id":"04a7e02a044e433ad1ff17e31f0c1002839caf61","unresolved":false,"context_lines":[{"line_number":174,"context_line":"    Boot 2 VMs on this network"},{"line_number":175,"context_line":"    Allocate and assign 2 FIP4"},{"line_number":176,"context_line":"    Check that vNIC of server matches port data from OpenStack DB"},{"line_number":177,"context_line":"    Ping4 tenant IPv4 of one VM from another one"},{"line_number":178,"context_line":"    Will do the same with ping6 when available in VMs"},{"line_number":179,"context_line":"    \"\"\""},{"line_number":180,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"9a80dd14_a0ecb990","line":177,"in_reply_to":"9a80dd14_e7f7b5f3","updated":"2015-03-05 17:34:03.000000000","message":"it;s internal v4 which is pinged by ssh session via FIP4 of other VM","commit_id":"b74493179f5ccff19c88f96f28102e92a84056e8"},{"author":{"_account_id":13409,"name":"Andrew Boik","email":"drew.boik@gmail.com","username":"dboik"},"change_message_id":"2488160e7b628bdef2b92bc74d95d10b5a48a5ce","unresolved":false,"context_lines":[{"line_number":81,"context_line":"        self.addCleanup(sub4.delete)"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"        for _ in range(n_subnets6):"},{"line_number":84,"context_line":"            sub6 \u003d self._create_subnet(network\u003dself.network,"},{"line_number":85,"context_line":"                                       namestart\u003d\u0027sub6\u0027,"},{"line_number":86,"context_line":"                                       ip_version\u003d6,"},{"line_number":87,"context_line":"                                       ipv6_ra_mode\u003daddress6_mode,"}],"source_content_type":"text/x-python","patch_set":13,"id":"9aa53dc9_0f9ce3be","line":84,"updated":"2015-04-08 03:19:25.000000000","message":"Actually, I was thinking of pinging the gateway_ip of sub6 instead of the router qg interface.","commit_id":"0bb88a54ca80f9e843308d0dc19c623c367b5fa3"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"e1b7f6ef500e9ccde256dfbd11abc680ba520b4a","unresolved":false,"context_lines":[{"line_number":118,"context_line":"                             n_subnets6\u003dn_subnets6)"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"        ssh1_4, ips_from_api_1 \u003d self.prepare_server()"},{"line_number":121,"context_line":"        ssh2_4, ips_from_api_2 \u003d self.prepare_server()"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"        def guest_has_address(ssh, addr):"},{"line_number":124,"context_line":"            return addr in ssh.get_ip_list()"}],"source_content_type":"text/x-python","patch_set":15,"id":"9aa53dc9_5e3db2c2","line":121,"updated":"2015-04-09 15:49:30.000000000","message":"Nit: IMO these would be better named sshv4_1 and sshv4_2.","commit_id":"c463b8a406ac0a59a824b5140b216bee7a18ce56"},{"author":{"_account_id":12632,"name":"Kirill Shileev","email":"kshileev@cisco.com","username":"kshileev"},"change_message_id":"a6af6e1dccd5b23d4a213b25974b623f7da585bf","unresolved":false,"context_lines":[{"line_number":118,"context_line":"                             n_subnets6\u003dn_subnets6)"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"        ssh1_4, ips_from_api_1 \u003d self.prepare_server()"},{"line_number":121,"context_line":"        ssh2_4, ips_from_api_2 \u003d self.prepare_server()"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"        def guest_has_address(ssh, addr):"},{"line_number":124,"context_line":"            return addr in ssh.get_ip_list()"}],"source_content_type":"text/x-python","patch_set":15,"id":"9aa53dc9_f9eca0f4","line":121,"in_reply_to":"9aa53dc9_5e3db2c2","updated":"2015-04-09 16:10:54.000000000","message":"Done","commit_id":"c463b8a406ac0a59a824b5140b216bee7a18ce56"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"bcfcdc475c93a6c0db2bb4e5cf0d579e0b10a20b","unresolved":false,"context_lines":[{"line_number":171,"context_line":"        self._prepare_and_test(address6_mode\u003d\u0027dhcpv6-stateless\u0027)"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"class TestGettingMultipleAddresses(TestGettingAddress):"},{"line_number":175,"context_line":"    \"\"\"Create network with 3 subnets: IPv4 and 2 IPv6 in a given address mode"},{"line_number":176,"context_line":"    Boot 2 VMs on this network"},{"line_number":177,"context_line":"    Allocate and assign 2 FIP4"}],"source_content_type":"text/x-python","patch_set":16,"id":"bab921fb_ea7890c6","line":174,"updated":"2015-04-24 02:29:15.000000000","message":"This is the wrong way to subclass, it\u0027ll end up with all the tests above being run twice for no reason. You either need to split off a separate base class without any tests in it, or just make the helps outside the class scope. (assuming you don\u0027t need these tests to be isolated from the 2 above and can\u0027t just make them all one big class.","commit_id":"8e3ae434c08db416f7ba81406f81697ab0ddc01a"},{"author":{"_account_id":12632,"name":"Kirill Shileev","email":"kshileev@cisco.com","username":"kshileev"},"change_message_id":"2181247bfe05f25b85e46146c21d9de5b3f0adc1","unresolved":false,"context_lines":[{"line_number":171,"context_line":"        self._prepare_and_test(address6_mode\u003d\u0027dhcpv6-stateless\u0027)"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"class TestGettingMultipleAddresses(TestGettingAddress):"},{"line_number":175,"context_line":"    \"\"\"Create network with 3 subnets: IPv4 and 2 IPv6 in a given address mode"},{"line_number":176,"context_line":"    Boot 2 VMs on this network"},{"line_number":177,"context_line":"    Allocate and assign 2 FIP4"}],"source_content_type":"text/x-python","patch_set":16,"id":"bab921fb_39c81622","line":174,"in_reply_to":"bab921fb_ea7890c6","updated":"2015-04-24 08:57:53.000000000","message":"done","commit_id":"8e3ae434c08db416f7ba81406f81697ab0ddc01a"}]}